166783 2017-01-06 16:18:05 -0800 REGRESSION(r210110): Introduced a regression commenting out individual properties (Requested by JoePeck on #webkit). 2017-01-06 16:35:41 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 165831 1 commit-queue commit-queue mattbaker nvasilyev oldest_to_newest 1264559 0 commit-queue 2017-01-06 16:18:05 -0800 http://trac.webkit.org/changeset/210110 broke the build: Introduced a regression commenting out individual properties (Requested by JoePeck on #webkit). This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail. 1264561 1 298234 commit-queue 2017-01-06 16:18:21 -0800 Created attachment 298234 ROLLOUT of r210110 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 1264567 2 298234 commit-queue 2017-01-06 16:35:37 -0800 Comment on attachment 298234 ROLLOUT of r210110 Clearing flags on attachment: 298234 Committed r210460: <http://trac.webkit.org/changeset/210460> 1264568 3 commit-queue 2017-01-06 16:35:41 -0800 All reviewed patches have been landed. Closing bug. 298234 2017-01-06 16:18:21 -0800 2017-01-06 16:35:37 -0800 ROLLOUT of r210110 bug-166783-20170106191651.patch text/plain 3322 commit-queue U3VidmVyc2lvbiBSZXZpc2lvbjogMjEwNDU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA3 ZWVmODA1M2FjYjJmZDE5MDIyMDBjYzNiOTY1ZDQyNDUzMzVmNDdiLi40ZmIwMzYxNWNkODEzY2Vh YTU4OWVjNGVlYTM4YmYzZTJiZGI1Y2IwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxNy0wMS0wNiAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtp dC5vcmc+CisKKyAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjIxMDExMC4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2Njc4MworCisgICAg ICAgIEludHJvZHVjZWQgYSByZWdyZXNzaW9uIGNvbW1lbnRpbmcgb3V0IGluZGl2aWR1YWwgcHJv cGVydGllcworICAgICAgICAoUmVxdWVzdGVkIGJ5IEpvZVBlY2sgb24gI3dlYmtpdCkuCisKKyAg ICAgICAgUmV2ZXJ0ZWQgY2hhbmdlc2V0OgorCisgICAgICAgICJXZWIgSW5zcGVjdG9yOiBTdHls ZXMgc2lkZWJhcjogVW5jb21tZW50aW5nIENTUyBydWxlcyBvZgorICAgICAgICBwc2V1ZG8tZWxl bWVudHMgZG9lc24ndCB3b3JrIgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTY1ODMxCisgICAgICAgIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdl c2V0LzIxMDExMAorCiAyMDE3LTAxLTA1ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBs ZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogUmVtb3ZlIHVudXNlZCBkZWxlZ2F0ZSBm cm9tIFZpc3VhbFN0eWxlU2VsZWN0b3JTZWN0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9DU1NTdHlsZURlY2xhcmF0aW9uVGV4dEVkaXRv ci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NTU1N0eWxl RGVjbGFyYXRpb25UZXh0RWRpdG9yLmpzCmluZGV4IDllZDc2OGJjMGIyNWU3NGI2N2I1N2E0ZmEx YjNmNTI0ZjJhNmU2MzIuLjI1NTg5NGExMWQzOTk4MGIyYmMyNzNjNzg1NDE1YzA0YTFlNDU5MTkg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NT U1N0eWxlRGVjbGFyYXRpb25UZXh0RWRpdG9yLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NTU1N0eWxlRGVjbGFyYXRpb25UZXh0RWRpdG9yLmpzCkBA IC0zMDksMTAgKzMwOSwxMiBAQCBXZWJJbnNwZWN0b3IuQ1NTU3R5bGVEZWNsYXJhdGlvblRleHRF ZGl0b3IgPSBjbGFzcyBDU1NTdHlsZURlY2xhcmF0aW9uVGV4dEVkaXRvcgogICAgICAgICAgICAg aWYgKCFwcm9wZXJ0aWVzLmxlbmd0aCkKICAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAK LSAgICAgICAgICAgIHRoaXMuX3Jlc2V0Q29udGVudCgpOwotCi0gICAgICAgICAgICBmb3IgKGxl dCBwcm9wZXJ0eSBvZiBwcm9wZXJ0aWVzKQotICAgICAgICAgICAgICAgIHRoaXMuX3VuY29tbWVu dFByb3BlcnR5KHByb3BlcnR5KTsKKyAgICAgICAgICAgIGZvciAodmFyIHByb3BlcnR5IG9mIHBy b3BlcnRpZXMpIHsKKyAgICAgICAgICAgICAgICBpZiAocHJvcGVydHkuX2NvbW1lbnRSYW5nZSkg eworICAgICAgICAgICAgICAgICAgICB0aGlzLl91bmNvbW1lbnRSYW5nZShwcm9wZXJ0eS5fY29t bWVudFJhbmdlKTsKKyAgICAgICAgICAgICAgICAgICAgcHJvcGVydHkuX2NvbW1lbnRSYW5nZSA9 IG51bGw7CisgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgfQogCiAgICAgICAgICAgICBy ZXR1cm4gdHJ1ZTsKICAgICAgICAgfQpAQCAtMTI3MCw2ICsxMjcyLDkgQEAgV2ViSW5zcGVjdG9y LkNTU1N0eWxlRGVjbGFyYXRpb25UZXh0RWRpdG9yID0gY2xhc3MgQ1NTU3R5bGVEZWNsYXJhdGlv blRleHRFZGl0b3IKICAgICAgICAgaWYgKCFyYW5nZSkKICAgICAgICAgICAgIHJldHVybjsKIAor ICAgICAgICBwcm9wZXJ0eS5fY29tbWVudFJhbmdlID0gcmFuZ2U7CisgICAgICAgIHByb3BlcnR5 Ll9jb21tZW50UmFuZ2UudG8uY2ggKz0gNjsgLy8gTnVtYmVyIG9mIGNoYXJhY3RlcnMgYWRkZWQg YnkgY29tbWVudHMuCisKICAgICAgICAgdmFyIHRleHQgPSB0aGlzLl9jb2RlTWlycm9yLmdldFJh bmdlKHJhbmdlLmZyb20sIHJhbmdlLnRvKTsKIAogICAgICAgICBmdW5jdGlvbiB1cGRhdGUoKQpA QCAtMTI4NiwxOSArMTI5MSwxNCBAQCBXZWJJbnNwZWN0b3IuQ1NTU3R5bGVEZWNsYXJhdGlvblRl eHRFZGl0b3IgPSBjbGFzcyBDU1NTdHlsZURlY2xhcmF0aW9uVGV4dEVkaXRvcgogCiAgICAgX3By b3BlcnR5Q29tbWVudENoZWNrYm94Q2hhbmdlZChldmVudCkKICAgICB7Ci0gICAgICAgIHRoaXMu X3VuY29tbWVudFByb3BlcnR5KGV2ZW50LnRhcmdldCk7Ci0gICAgfQotCi0gICAgX3VuY29tbWVu dFByb3BlcnR5KHByb3BlcnR5KQotICAgIHsKLSAgICAgICAgbGV0IHRleHRNYXJrZXIgPSBwcm9w ZXJ0eS5fX3Byb3BlcnR5VGV4dE1hcmtlcjsKLSAgICAgICAgY29uc29sZS5hc3NlcnQodGV4dE1h cmtlcik7Ci0gICAgICAgIGlmICghdGV4dE1hcmtlcikKKyAgICAgICAgdmFyIGNvbW1lbnRUZXh0 TWFya2VyID0gZXZlbnQudGFyZ2V0Ll9fY29tbWVudFRleHRNYXJrZXI7CisgICAgICAgIGNvbnNv bGUuYXNzZXJ0KGNvbW1lbnRUZXh0TWFya2VyKTsKKyAgICAgICAgaWYgKCFjb21tZW50VGV4dE1h cmtlcikKICAgICAgICAgICAgIHJldHVybjsKIAotICAgICAgICAvLyBDaGVjayBpZiB0aGUgcHJv cGVydHkgaGFzIGJlZW4gcmVtb3ZlZCBhbHJlYWR5LCBsaWtlIGZyb20gZG91YmxlLWNsaWNraW5n Ci0gICAgICAgIC8vIHRoZSBjaGVja2JveCBhbmQgY2FsbGluZyB0aGlzIGV2ZW50IGxpc3RlbmVy IG11bHRpcGxlIHRpbWVzLgotICAgICAgICBsZXQgcmFuZ2UgPSB0ZXh0TWFya2VyLmZpbmQoKTsK KyAgICAgICAgLy8gQ2hlY2sgaWYgdGhlIGNvbW1lbnQgaGFzIGJlZW4gcmVtb3ZlZCBhbHJlYWR5 LCBsaWtlIGZyb20gZG91YmxlLWNsaWNraW5nCisgICAgICAgIC8vIHRoZSBjaGVja2JveCBhbmQg Y2FsbGluZyBldmVudCBsaXN0ZW5lciBtdWx0aXBsZSB0aW1lcy4KKyAgICAgICAgdmFyIHJhbmdl ID0gY29tbWVudFRleHRNYXJrZXIuZmluZCgpOwogICAgICAgICBpZiAoIXJhbmdlKQogICAgICAg ICAgICAgcmV0dXJuOwogCg==