166744 2017-01-05 14:39:15 -0800 Web Inspector: Remove unused delegate from VisualStyleSelectorSection 2017-01-05 15:43:08 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 joepeck joepeck commit-queue hi inspector-bugzilla-changes oldest_to_newest 1264246 0 joepeck 2017-01-05 14:39:15 -0800 Summary: Remove unused delegate from VisualStyleSelectorSection The constructor sets: this._delegate = delegate || null; But the property is never used. 1264248 1 298138 joepeck 2017-01-05 14:39:43 -0800 Created attachment 298138 [PATCH] Proposed Fix 1264265 2 298138 commit-queue 2017-01-05 15:43:03 -0800 Comment on attachment 298138 [PATCH] Proposed Fix Clearing flags on attachment: 298138 Committed r210379: <http://trac.webkit.org/changeset/210379> 1264266 3 commit-queue 2017-01-05 15:43:08 -0800 All reviewed patches have been landed. Closing bug. 298138 2017-01-05 14:39:43 -0800 2017-01-05 15:43:03 -0800 [PATCH] Proposed Fix delegate-1.patch text/plain 2711 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGI2MWI4MjUuLjY4MGY1NjUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTAxLTA1ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmVtb3Zl IHVudXNlZCBkZWxlZ2F0ZSBmcm9tIFZpc3VhbFN0eWxlU2VsZWN0b3JTZWN0aW9uCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjY3NDQKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2Uv Vmlld3MvVmlzdWFsU3R5bGVEZXRhaWxzUGFuZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3Iu VmlzdWFsU3R5bGVEZXRhaWxzUGFuZWwucHJvdG90eXBlLmluaXRpYWxMYXlvdXQpOgorICAgICAg ICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvVmlzdWFsU3R5bGVTZWxlY3RvclNlY3Rpb24uanM6Cisg ICAgICAgIChXZWJJbnNwZWN0b3IuVmlzdWFsU3R5bGVTZWxlY3RvclNlY3Rpb24pOgorCiAyMDE3 LTAxLTA0ICBOaWtpdGEgVmFzaWx5ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgogCiAgICAgICAg IFdlYiBJbnNwZWN0b3I6IGFwcGxpY2F0aW9uIGNhY2hlIGRldGFpbHMgbm90IHNob3duIGluIFN0 b3JhZ2UgVGFiCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9WaXN1YWxTdHlsZURldGFpbHNQYW5lbC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Zpc3VhbFN0eWxlRGV0YWlsc1BhbmVsLmpzCmluZGV4IGE5 Y2U4MjkuLmExYTI0YjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL1Zpc3VhbFN0eWxlRGV0YWlsc1BhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Zpc3VhbFN0eWxlRGV0YWlsc1BhbmVsLmpz CkBAIC03Myw3ICs3Myw3IEBAIFdlYkluc3BlY3Rvci5WaXN1YWxTdHlsZURldGFpbHNQYW5lbCA9 IGNsYXNzIFZpc3VhbFN0eWxlRGV0YWlsc1BhbmVsIGV4dGVuZHMgV2ViCiAgICAgaW5pdGlhbExh eW91dCgpCiAgICAgewogICAgICAgICAvLyBTZWxlY3RvciBTZWN0aW9uCi0gICAgICAgIHRoaXMu X3NlbGVjdG9yU2VjdGlvbiA9IG5ldyBXZWJJbnNwZWN0b3IuVmlzdWFsU3R5bGVTZWxlY3RvclNl Y3Rpb24odGhpcyk7CisgICAgICAgIHRoaXMuX3NlbGVjdG9yU2VjdGlvbiA9IG5ldyBXZWJJbnNw ZWN0b3IuVmlzdWFsU3R5bGVTZWxlY3RvclNlY3Rpb247CiAgICAgICAgIHRoaXMuX3NlbGVjdG9y U2VjdGlvbi5hZGRFdmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5WaXN1YWxTdHlsZVNlbGVjdG9y U2VjdGlvbi5FdmVudC5TZWxlY3RvckNoYW5nZWQsIHRoaXMuX3VwZGF0ZVNlY3Rpb25zLCB0aGlz KTsKICAgICAgICAgdGhpcy5lbGVtZW50LmFwcGVuZENoaWxkKHRoaXMuX3NlbGVjdG9yU2VjdGlv bi5lbGVtZW50KTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvVmlzdWFsU3R5bGVTZWxlY3RvclNlY3Rpb24uanMgYi9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9WaXN1YWxTdHlsZVNlbGVjdG9yU2VjdGlvbi5q cwppbmRleCA1ZTVhMTE3Li44ODg4NjliNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVmlzdWFsU3R5bGVTZWxlY3RvclNlY3Rpb24uanMKKysr IGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVmlzdWFsU3R5bGVT ZWxlY3RvclNlY3Rpb24uanMKQEAgLTI1LDcgKzI1LDcgQEAKIAogV2ViSW5zcGVjdG9yLlZpc3Vh bFN0eWxlU2VsZWN0b3JTZWN0aW9uID0gY2xhc3MgVmlzdWFsU3R5bGVTZWxlY3RvclNlY3Rpb24g ZXh0ZW5kcyBXZWJJbnNwZWN0b3IuRGV0YWlsc1NlY3Rpb24KIHsKLSAgICBjb25zdHJ1Y3Rvcihk ZWxlZ2F0ZSkKKyAgICBjb25zdHJ1Y3RvcigpCiAgICAgewogICAgICAgICBsZXQgc2VsZWN0b3JT ZWN0aW9uID0ge2VsZW1lbnQ6IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpfTsKICAgICAg ICAgc2VsZWN0b3JTZWN0aW9uLmVsZW1lbnQuY2xhc3NMaXN0LmFkZCgic2VsZWN0b3JzIik7CkBA IC0zNSw3ICszNSw2IEBAIFdlYkluc3BlY3Rvci5WaXN1YWxTdHlsZVNlbGVjdG9yU2VjdGlvbiA9 IGNsYXNzIFZpc3VhbFN0eWxlU2VsZWN0b3JTZWN0aW9uIGV4dGVuCiAKICAgICAgICAgc3VwZXIo InZpc3VhbC1zdHlsZS1zZWxlY3Rvci1zZWN0aW9uIiwgV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJT dHlsZSBSdWxlcyIpLCBbc2VsZWN0b3JTZWN0aW9uXSwgY29udHJvbEVsZW1lbnQpOwogCi0gICAg ICAgIHRoaXMuX2RlbGVnYXRlID0gZGVsZWdhdGUgfHwgbnVsbDsKICAgICAgICAgdGhpcy5fbm9k ZVN0eWxlcyA9IG51bGw7CiAKICAgICAgICAgdGhpcy5fY3VycmVudFNlbGVjdG9yRWxlbWVudCA9 IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpOwo=