16674 2007-12-30 02:23:25 -0800 [GTK] run-launcher sets wrong LD_LIBRARY_PATH 2008-01-02 04:56:52 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Linux RESOLVED FIXED EasyFix, Gtk P3 Trivial --- 1 lethalman88 webkit-unassigned lethalman88 oldest_to_newest 65722 0 lethalman88 2007-12-30 02:23:25 -0800 Hello, the run-launcher uses WebKitBuild/{build} as LD_LIBRARY_PATH instead of WebKitBuild/{build}/lib. Maybe this issue is only for GtkLauncher and other ports don't need /lib? 65723 1 18185 lethalman88 2007-12-30 02:27:25 -0800 Created attachment 18185 use /lib Very simple patch. 65751 2 ddkilzer 2007-12-30 08:28:53 -0800 This needs to be reviewed by a Qt developer to make sure this doesn't break launching QtLauncher. It may also be wise to start using the catdir() function from the File::Spec Perl module to concatenate paths. 65771 3 18195 lethalman88 2007-12-30 11:30:08 -0800 Created attachment 18195 use catdir I'm not able to run Qt if LD_LIBRARY_PATH is not set to /lib currently, but i don't use Qt at all. 65876 4 18195 darin 2008-01-01 01:18:08 -0800 Comment on attachment 18195 use catdir Even though I'm no expert on the details here, this looks fine to me. r=me 66017 5 alp 2008-01-02 04:56:52 -0800 Landed in r29081. 18185 2007-12-30 02:27:25 -0800 2007-12-30 11:30:08 -0800 use /lib launcherldpath.patch text/plain 999 lethalman88 SW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvcnVuLWxhdW5jaGVyCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YktpdFRvb2xzL1NjcmlwdHMvcnVuLWxhdW5jaGVyCShyZXZpc2lvbiAyOTAzNikKKysrIFdlYktp dFRvb2xzL1NjcmlwdHMvcnVuLWxhdW5jaGVyCSh3b3JraW5nIGNvcHkpCkBAIC0zNywxNiArMzcs MTcgQEAKIAogc2V0Q29uZmlndXJhdGlvbigpOwogbXkgJHByb2R1Y3REaXIgPSBwcm9kdWN0RGly KCk7CitteSAkbGliRGlyID0gcHJvZHVjdERpcigpLicvbGliJzsKIG15ICRsYXVuY2hlclBhdGgg PSBwcm9kdWN0RGlyKCk7CiAKICMgQ2hlY2sgdG8gc2VlIHRoYXQgYWxsIHRoZSBmcmFtZXdvcmtz IGFyZSBidWlsdC4KIGNoZWNrRnJhbWV3b3JrcygpOwogCiAjIFNldCB1cCBMRF9MSUJSQVJZX1BB VEggdG8gcG9pbnQgdG8gdGhlIHByb2R1Y3QgZGlyZWN0b3J5LgotcHJpbnQgIlN0YXJ0aW5nIHdl YmtpdCBsYXVuY2hlciB3aXRoIExEX0xJQlJBUllfUEFUSCBzZXQgdG8gcG9pbnQgdG8gYnVpbHQg V2ViS2l0IGluICRwcm9kdWN0RGlyLlxuIjsKK3ByaW50ICJTdGFydGluZyB3ZWJraXQgbGF1bmNo ZXIgd2l0aCBMRF9MSUJSQVJZX1BBVEggc2V0IHRvIHBvaW50IHRvIGJ1aWx0IFdlYktpdCBpbiAk bGliRGlyLlxuIjsKIAogbXkgQGFyZ3MgPSBAQVJHVjsKLSRFTlZ7TERfTElCUkFSWV9QQVRIfSA9 ICRFTlZ7TERfTElCUkFSWV9QQVRIfSA/ICIkcHJvZHVjdERpcjokRU5We0xEX0xJQlJBUllfUEFU SH0iIDogJHByb2R1Y3REaXI7CiskRU5We0xEX0xJQlJBUllfUEFUSH0gPSAkRU5We0xEX0xJQlJB UllfUEFUSH0gPyAiJGxpYkRpcjokRU5We0xEX0xJQlJBUllfUEFUSH0iIDogJGxpYkRpcjsKIAog aWYgKGlzR3RrKCkpIHsKICAgJGxhdW5jaGVyUGF0aCA9ICIkbGF1bmNoZXJQYXRoL1dlYktpdFRv b2xzL0d0a0xhdW5jaGVyL0d0a0xhdW5jaGVyIjsK 18195 2007-12-30 11:30:08 -0800 2008-01-01 01:18:08 -0800 use catdir launcherldpath.patch text/plain 1714 lethalman88 SW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvcnVuLWxhdW5jaGVyCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YktpdFRvb2xzL1NjcmlwdHMvcnVuLWxhdW5jaGVyCShyZXZpc2lvbiAyOTAzNykKKysrIFdlYktp dFRvb2xzL1NjcmlwdHMvcnVuLWxhdW5jaGVyCSh3b3JraW5nIGNvcHkpCkBAIC0zMCw2ICszMCw3 IEBACiAjIFNpbXBsaWZpZWQgInJ1biIgc2NyaXB0IGZvciBXZWIgS2l0IE9wZW4gU291cmNlIFBy b2plY3QuCiAKIHVzZSBzdHJpY3Q7Cit1c2UgRmlsZTo6U3BlYzo6RnVuY3Rpb25zIHF3L2NhdGRp ci87CiB1c2UgRmlsZTo6VGVtcCBxdy90ZW1wZmlsZS87CiB1c2UgRmluZEJpbjsKIHVzZSBsaWIg JEZpbmRCaW46OkJpbjsKQEAgLTM3LDI3ICszOCwyOCBAQAogCiBzZXRDb25maWd1cmF0aW9uKCk7 CiBteSAkcHJvZHVjdERpciA9IHByb2R1Y3REaXIoKTsKK215ICRsaWJEaXIgPSBjYXRkaXIocHJv ZHVjdERpcigpLCAnbGliJyk7CiBteSAkbGF1bmNoZXJQYXRoID0gcHJvZHVjdERpcigpOworbXkg QGFyZ3MgPSBAQVJHVjsKIAogIyBDaGVjayB0byBzZWUgdGhhdCBhbGwgdGhlIGZyYW1ld29ya3Mg YXJlIGJ1aWx0LgogY2hlY2tGcmFtZXdvcmtzKCk7CiAKLSMgU2V0IHVwIExEX0xJQlJBUllfUEFU SCB0byBwb2ludCB0byB0aGUgcHJvZHVjdCBkaXJlY3RvcnkuCi1wcmludCAiU3RhcnRpbmcgd2Vi a2l0IGxhdW5jaGVyIHdpdGggTERfTElCUkFSWV9QQVRIIHNldCB0byBwb2ludCB0byBidWlsdCBX ZWJLaXQgaW4gJHByb2R1Y3REaXIuXG4iOwotCi1teSBAYXJncyA9IEBBUkdWOwotJEVOVntMRF9M SUJSQVJZX1BBVEh9ID0gJEVOVntMRF9MSUJSQVJZX1BBVEh9ID8gIiRwcm9kdWN0RGlyOiRFTlZ7 TERfTElCUkFSWV9QQVRIfSIgOiAkcHJvZHVjdERpcjsKLQogaWYgKGlzR3RrKCkpIHsKLSAgJGxh dW5jaGVyUGF0aCA9ICIkbGF1bmNoZXJQYXRoL1dlYktpdFRvb2xzL0d0a0xhdW5jaGVyL0d0a0xh dW5jaGVyIjsKKyAgJGxhdW5jaGVyUGF0aCA9IGNhdGRpcigkbGF1bmNoZXJQYXRoLCAiV2ViS2l0 VG9vbHMiLCAiR3RrTGF1bmNoZXIiLCAiR3RrTGF1bmNoZXIiKTsKICAgIyBTdHJpcCAtLWd0ayBm cm9tIHRoZSBhcmctbGlzdCwgc2luY2Ugb3RoZXJ3aXNlIEd0a0xhdW5jaGVyIHdpbGwgdHJ5IHRv CiAgICMgaW50ZXJwcmV0IGl0IGFzIGEgVVJMLgogICBAYXJncyA9IGdyZXAoIS9eKC0tZ3RrKSQv LCBAYXJncyk7CiB9IGVsc2lmIChpc1F0KCkpIHsKLSAgJGxhdW5jaGVyUGF0aCA9ICIkbGF1bmNo ZXJQYXRoL2Jpbi9RdExhdW5jaGVyIjsKKyAgJGxhdW5jaGVyUGF0aCA9IGNhdGRpcigkbGF1bmNo ZXJQYXRoLCAiYmluIiwgIlF0TGF1bmNoZXIiKTsKIH0gZWxzZSB7CiAgIGRpZTsKIH0KIAorIyBT ZXQgdXAgTERfTElCUkFSWV9QQVRIIHRvIHBvaW50IHRvIHRoZSBwcm9kdWN0IGRpcmVjdG9yeS4K K3ByaW50ICJTdGFydGluZyB3ZWJraXQgbGF1bmNoZXIgd2l0aCBMRF9MSUJSQVJZX1BBVEggc2V0 IHRvIHBvaW50IHRvIGJ1aWx0IFdlYktpdCBpbiAkbGliRGlyLlxuIjsKKworJEVOVntMRF9MSUJS QVJZX1BBVEh9ID0gJEVOVntMRF9MSUJSQVJZX1BBVEh9ID8gIiRsaWJEaXI6JEVOVntMRF9MSUJS QVJZX1BBVEh9IiA6ICRsaWJEaXI7CisKIGV4ZWMgJGxhdW5jaGVyUGF0aCwgQGFyZ3Mgb3IgZGll OwogCg==