166725 2017-01-05 05:44:30 -0800 prepare-ChangeLog: Correct help string for --style option 2017-01-09 09:42:31 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mcrha webkit-unassigned ap commit-queue lforschler tpopela oldest_to_newest 1264095 0 mcrha 2017-01-05 05:44:30 -0800 Running: $ ./Tools/Scripts/prepare-ChangeLog --help claims: --[no-]style Run check-webkit-style script when done (default: style) but this is not true, because if I do not use the --style argument, then the coding style is not checked. 1264097 1 298096 mcrha 2017-01-05 05:47:02 -0800 Created attachment 298096 proposed patch The variable was not initialized, which this one-liner does. 1264201 2 298096 ap 2017-01-05 12:41:26 -0800 Comment on attachment 298096 proposed patch This is intentional behavior, implemented in bug 132209. 1264202 3 ap 2017-01-05 12:42:50 -0800 The help text is wrong though, good catch! 1264370 4 mcrha 2017-01-06 00:31:56 -0800 Right, in that case the help text should be fixed. Thanks. 1264988 5 298359 mcrha 2017-01-09 08:24:40 -0800 Created attachment 298359 proposed patch ][ 1265014 6 298359 ap 2017-01-09 09:17:30 -0800 Comment on attachment 298359 proposed patch ][ r=me Thank you! 1265031 7 298359 commit-queue 2017-01-09 09:42:27 -0800 Comment on attachment 298359 proposed patch ][ Clearing flags on attachment: 298359 Committed r210512: <http://trac.webkit.org/changeset/210512> 1265032 8 commit-queue 2017-01-09 09:42:31 -0800 All reviewed patches have been landed. Closing bug. 298096 2017-01-05 05:47:02 -0800 2017-01-09 08:24:40 -0800 proposed patch wk.patch text/plain 955 mcrha ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhYmI5 MGQ0Li4wMjJmNjllIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTctMDEtMDUgIE1pbGFuIENyaGEgIDxtY3JoYUBy ZWRoYXQuY29tPgorCisgICAgICAgIHByZXBhcmUtQ2hhbmdlTG9nIGRvZXNuJ3QgY2hlY2sgY29k aW5nIHN0eWxlIGJ5IGRlZmF1bHQsIGV2ZW4gaXQgc2hvdWxkCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjY3MjUKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2c6 CisgICAgICAgIChtYWluKToKKwogMjAxNy0wMS0wNCAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3Nz eUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgY21ha2UgYnVpbGRmaXggYWZ0ZXIg cjIxMDI2Ni4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2cgYi9U b29scy9TY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nCmluZGV4IDEyZjhjNGUuLjZiNDJjYWQgMTAw NzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2cKKysrIGIvVG9vbHMvU2Ny aXB0cy9wcmVwYXJlLUNoYW5nZUxvZwpAQCAtMTQwLDcgKzE0MCw3IEBAIHN1YiBtYWluKCkKICAg ICBteSAkZ2l0Q29tbWl0ID0gMDsKICAgICBteSAkZ2l0SW5kZXggPSAiIjsKICAgICBteSAkZ2l0 UmV2aWV3ZXIgPSAiIjsKLSAgICBteSAkY2hlY2tXZWJLaXRTdHlsZTsKKyAgICBteSAkY2hlY2tX ZWJLaXRTdHlsZSA9IDE7CiAgICAgbXkgJG9wZW5DaGFuZ2VMb2dzID0gMDsKICAgICBteSAkd3Jp dGVDaGFuZ2VMb2dzID0gMTsKICAgICBteSAkZGVsaW1pdGVycyA9IDA7Cg== 298359 2017-01-09 08:24:40 -0800 2017-01-09 09:42:27 -0800 proposed patch ][ wk.patch text/plain 1868 mcrha ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAwYTk5 ZjU4Li5jMTZiYjdlIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTctMDEtMDkgIE1pbGFuIENyaGEgIDxtY3JoYUBy ZWRoYXQuY29tPgorCisgICAgICAgIHByZXBhcmUtQ2hhbmdlTG9nOiBDb3JyZWN0IGhlbHAgc3Ry aW5nIGZvciAtLXN0eWxlIG9wdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTY2NzI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nOgorICAgICAgICAobWFp bik6CisKIDIwMTctMDEtMDYgIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGd1c3Rhdm8ubm9yb25o YUBjb2xsYWJvcmEuY28udWs+CiAKICAgICAgICAgW0dUS10gU2hvdWxkIHN1cHBvcnQga2V5IGFu ZCBjb2RlIHByb3BlcnRpZXMgb24ga2V5Ym9hcmQgZXZlbnRzCmRpZmYgLS1naXQgYS9Ub29scy9T Y3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nIGIvVG9vbHMvU2NyaXB0cy9wcmVwYXJlLUNoYW5nZUxv ZwppbmRleCAxMmY4YzRlLi5iZWU3Nzc4IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3ByZXBh cmUtQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL1NjcmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2cKQEAgLTE0 MCw3ICsxNDAsNyBAQCBzdWIgbWFpbigpCiAgICAgbXkgJGdpdENvbW1pdCA9IDA7CiAgICAgbXkg JGdpdEluZGV4ID0gIiI7CiAgICAgbXkgJGdpdFJldmlld2VyID0gIiI7Ci0gICAgbXkgJGNoZWNr V2ViS2l0U3R5bGU7CisgICAgbXkgJGNoZWNrV2ViS2l0U3R5bGUgPSAwOwogICAgIG15ICRvcGVu Q2hhbmdlTG9ncyA9IDA7CiAgICAgbXkgJHdyaXRlQ2hhbmdlTG9ncyA9IDE7CiAgICAgbXkgJGRl bGltaXRlcnMgPSAwOwpAQCAtMTc0LDcgKzE3NCw3IEBAIHN1YiBtYWluKCkKICAgICAgICAgcHJp bnQgU1RERVJSICIgIC0tZ2l0LXJldmlld2VyICBXaGVuIHBvcHVsYXRpbmcgdGhlIENoYW5nZUxv Z3MgZnJvbSBhIGdpdCBjb21taXQgY2xhaW0gdGhhdCB0aGUgc3BjaWZpZWQgbmFtZSByZXZpZXdl ZCB0aGUgY2hhbmdlLlxuIjsKICAgICAgICAgcHJpbnQgU1RERVJSICIgICAgICAgICAgICAgICAg ICBUaGlzIG9wdGlvbiBpcyB1c2VmdWwgd2hlbiB0aGUgZ2l0IGNvbW1pdCBsYWNrcyBhIFNpZ25l ZC1PZmYtQnk6IGxpbmVcbiI7CiAgICAgICAgIHByaW50IFNUREVSUiAiICAtaHwtLWhlbHAgICAg ICAgU2hvdyB0aGlzIGhlbHAgbWVzc2FnZVxuIjsKLSAgICAgICAgcHJpbnQgU1RERVJSICIgIC0t W25vLV1zdHlsZSAgICBSdW4gY2hlY2std2Via2l0LXN0eWxlIHNjcmlwdCB3aGVuIGRvbmUgKGRl ZmF1bHQ6IHN0eWxlKVxuIjsKKyAgICAgICAgcHJpbnQgU1RERVJSICIgIC0tW25vLV1zdHlsZSAg ICBSdW4gY2hlY2std2Via2l0LXN0eWxlIHNjcmlwdCB3aGVuIGRvbmUgKGRlZmF1bHQ6IG5vLXN0 eWxlKVxuIjsKICAgICAgICAgcHJpbnQgU1RERVJSICIgIC1vfC0tb3BlbiAgICAgICBPcGVuIENo YW5nZUxvZ3MgaW4gYW4gZWRpdG9yIHdoZW4gZG9uZVxuIjsKICAgICAgICAgcHJpbnQgU1RERVJS ICIgIC0tW25vLV11cGRhdGUgICBVcGRhdGUgQ2hhbmdlTG9ncyBmcm9tIHN2biBiZWZvcmUgYWRk aW5nIGVudHJ5IChkZWZhdWx0OiB1cGRhdGUpXG4iOwogICAgICAgICBwcmludCBTVERFUlIgIiAg LS1bbm8tXXdyaXRlICAgIFdyaXRlIENoYW5nZUxvZ3MgdG8gZGlzayAob3RoZXJ3aXNlIHNlbmQg bmV3IGVudHJpZXMgdG8gc3Rkb3V0KSAoZGVmYXVsdDogd3JpdGUpXG4iOwo=