166699 2017-01-04 14:30:43 -0800 Web Inspector: application cache details not shown in Storage Tab 2017-01-04 18:01:29 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED http://safari.lishin.org InRadar P1 Normal --- 1 bburg nvasilyev commit-queue inspector-bugzilla-changes nvasilyev webkit-bug-importer oldest_to_newest 1263903 0 bburg 2017-01-04 14:30:43 -0800 Steps to reproduce: 1. Inspect page 2. Go to Storage Tab 3. Click on "Application Cache – cache.manifest" tree element => Nothing happens, should show the manifest resource tree elements and a data grid in the content view Backtrace: [Error] TypeError: null is not an object (evaluating 'manifestTreeElement.subtitle') updateTitles — Main.js:9659:104 ApplicationCacheFrameTreeElement — Main.js:9655:83 _addFrameManifest — Main.js:17894 _frameManifestAdded — Main.js:17891 dispatch — Main.js:163:149 dispatchEventToListeners — Main.js:165 _frameManifestUpdated — Main.js:19979:284 _framesWithManifestsLoaded — Main.js:19973 _framesWithManifestsLoaded _dispatchResponseToCallback — Main.js:1015 _dispatchResponse — Main.js:1007 dispatch — Main.js:994 dispatch — Main.js:918 dispatchNextQueuedMessageFromBackend — Main.js:1084 reportInternalError (Main.js:22738) _dispatchResponseToCallback (Main.js:1015:87) _dispatchResponse (Main.js:1007) dispatch (Main.js:994) dispatch (Main.js:918) dispatchNextQueuedMessageFromBackend (Main.js:1084) 1263904 1 webkit-bug-importer 2017-01-04 14:31:30 -0800 <rdar://problem/29871716> 1263939 2 298050 nvasilyev 2017-01-04 17:17:07 -0800 Created attachment 298050 Patch 1263940 3 nvasilyev 2017-01-04 17:17:48 -0800 This has been broken for at least 20 months. Possibly, never worked. 1263943 4 298050 bburg 2017-01-04 17:20:27 -0800 Comment on attachment 298050 Patch r=me 1263944 5 298051 nvasilyev 2017-01-04 17:22:57 -0800 Created attachment 298051 Patch 1263945 6 298052 nvasilyev 2017-01-04 17:23:48 -0800 Created attachment 298052 Patch 1263953 7 298052 commit-queue 2017-01-04 18:01:25 -0800 Comment on attachment 298052 Patch Clearing flags on attachment: 298052 Committed r210311: <http://trac.webkit.org/changeset/210311> 1263954 8 commit-queue 2017-01-04 18:01:29 -0800 All reviewed patches have been landed. Closing bug. 298050 2017-01-04 17:17:07 -0800 2017-01-04 17:22:57 -0800 Patch patch.txt text/plain 1880 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDMyYmZkMjcuLjU5NzY3ZGUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE3LTAxLTA0ICBOaWtpdGEgVmFzaWx5 ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IGFwcGxp Y2F0aW9uIGNhY2hlIGRldGFpbHMgbm90IHNob3duIGluIFN0b3JhZ2UgVGFiCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjY2OTkKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzI5ODcxNzE2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEZpeCBhIHRlcm5hcnkgb3BlcmF0b3IgcHJlY2VkZW5jZS4gVGhlIGZv bGxvd2luZyBleHByZXNzaW9uIHRocm93cyBhbiBleGNlcHRpb246CisKKyAgICAgICAgICAgIHRy dWUgfHwgZmFsc2UgPyBpLmRvbnQuZXhpc3QgOiBmYWxzZQorCisgICAgICAgIFRoZSBvbmUgYmVs b3cgZG9lcyBub3Q6CisKKyAgICAgICAgICAgIHRydWUgfHwgKGZhbHNlID8gaS5kb250LmV4aXN0 IDogZmFsc2UpCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0FwcGxpY2F0aW9uQ2Fj aGVGcmFtZVRyZWVFbGVtZW50LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkFwcGxpY2F0aW9u Q2FjaGVGcmFtZVRyZWVFbGVtZW50LnByb3RvdHlwZS51cGRhdGVUaXRsZXMpOgorCiAyMDE3LTAx LTAzICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2Vi IEluc3BlY3RvcjogIkludmFsaWQgQ2hhcmFjdGVycyIgc2V0dGluZyBkb2VzIHRoZSBvcHBvc2l0 ZSBvZiB0aGUgY2hlY2tib3gKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL0FwcGxpY2F0aW9uQ2FjaGVGcmFtZVRyZWVFbGVtZW50LmpzIGIvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQXBwbGljYXRpb25DYWNoZUZy YW1lVHJlZUVsZW1lbnQuanMKaW5kZXggNjUzNjc5OS4uMmJmN2U0NiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQXBwbGljYXRpb25DYWNoZUZy YW1lVHJlZUVsZW1lbnQuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvQXBwbGljYXRpb25DYWNoZUZyYW1lVHJlZUVsZW1lbnQuanMKQEAgLTU2LDcgKzU2 LDcgQEAgV2ViSW5zcGVjdG9yLkFwcGxpY2F0aW9uQ2FjaGVGcmFtZVRyZWVFbGVtZW50ID0gY2xh c3MgQXBwbGljYXRpb25DYWNoZUZyYW1lVHJlZUUKICAgICAgICAgICAgIGN1cnJlbnRBbmNlc3Rv ciA9IGN1cnJlbnRBbmNlc3Rvci5wYXJlbnQ7CiAgICAgICAgIH0KIAotICAgICAgICB2YXIgc3Vi dGl0bGVJc0R1cGxpY2F0ZSA9IHN1YnRpdGxlID09PSB0aGlzLl9tYWluVGl0bGUgfHwgbWFuaWZl c3RUcmVlRWxlbWVudCA/IHN1YnRpdGxlID09PSBtYW5pZmVzdFRyZWVFbGVtZW50LnN1YnRpdGxl IDogZmFsc2U7CisgICAgICAgIHZhciBzdWJ0aXRsZUlzRHVwbGljYXRlID0gc3VidGl0bGUgPT09 IHRoaXMuX21haW5UaXRsZSB8fCAobWFuaWZlc3RUcmVlRWxlbWVudCA/IHN1YnRpdGxlID09PSBt YW5pZmVzdFRyZWVFbGVtZW50LnN1YnRpdGxlIDogZmFsc2UpOwogICAgICAgICB0aGlzLnN1YnRp dGxlID0gc3VidGl0bGVJc0R1cGxpY2F0ZSA/IG51bGwgOiBzdWJ0aXRsZTsKICAgICB9CiB9Owo= 298051 2017-01-04 17:22:57 -0800 2017-01-04 17:23:48 -0800 Patch patch.txt text/plain 1784 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDMyYmZkMjcuLjgyM2IxMDggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTAxLTA0ICBOaWtpdGEgVmFzaWx5 ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IGFwcGxp Y2F0aW9uIGNhY2hlIGRldGFpbHMgbm90IHNob3duIGluIFN0b3JhZ2UgVGFiCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjY2OTkKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzI5ODcxNzE2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEZpeCBhIHRlcm5hcnkgb3BlcmF0b3IgcHJlY2VkZW5jZS4gVGhlIGZv bGxvd2luZyBleHByZXNzaW9uIHRocm93cyBhbiBleGNlcHRpb246CisKKyAgICAgICAgICAgIHRy dWUgfHwgZmFsc2UgPyBpLmRvbnQuZXhpc3QgOiBmYWxzZQorCisgICAgICAgICogVXNlckludGVy ZmFjZS9WaWV3cy9BcHBsaWNhdGlvbkNhY2hlRnJhbWVUcmVlRWxlbWVudC5qczoKKyAgICAgICAg KFdlYkluc3BlY3Rvci5BcHBsaWNhdGlvbkNhY2hlRnJhbWVUcmVlRWxlbWVudC5wcm90b3R5cGUu dXBkYXRlVGl0bGVzKToKKwogMjAxNy0wMS0wMyAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9A YXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6ICJJbnZhbGlkIENoYXJhY3RlcnMi IHNldHRpbmcgZG9lcyB0aGUgb3Bwb3NpdGUgb2YgdGhlIGNoZWNrYm94CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9BcHBsaWNhdGlvbkNhY2hl RnJhbWVUcmVlRWxlbWVudC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL0FwcGxpY2F0aW9uQ2FjaGVGcmFtZVRyZWVFbGVtZW50LmpzCmluZGV4IDY1MzY3OTku LjliMzQ2Y2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL0FwcGxpY2F0aW9uQ2FjaGVGcmFtZVRyZWVFbGVtZW50LmpzCisrKyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0FwcGxpY2F0aW9uQ2FjaGVGcmFtZVRy ZWVFbGVtZW50LmpzCkBAIC01Niw3ICs1Niw3IEBAIFdlYkluc3BlY3Rvci5BcHBsaWNhdGlvbkNh Y2hlRnJhbWVUcmVlRWxlbWVudCA9IGNsYXNzIEFwcGxpY2F0aW9uQ2FjaGVGcmFtZVRyZWVFCiAg ICAgICAgICAgICBjdXJyZW50QW5jZXN0b3IgPSBjdXJyZW50QW5jZXN0b3IucGFyZW50OwogICAg ICAgICB9CiAKLSAgICAgICAgdmFyIHN1YnRpdGxlSXNEdXBsaWNhdGUgPSBzdWJ0aXRsZSA9PT0g dGhpcy5fbWFpblRpdGxlIHx8IG1hbmlmZXN0VHJlZUVsZW1lbnQgPyBzdWJ0aXRsZSA9PT0gbWFu aWZlc3RUcmVlRWxlbWVudC5zdWJ0aXRsZSA6IGZhbHNlOworICAgICAgICB2YXIgc3VidGl0bGVJ c0R1cGxpY2F0ZSA9IHN1YnRpdGxlID09PSB0aGlzLl9tYWluVGl0bGUgfHwgKG1hbmlmZXN0VHJl ZUVsZW1lbnQgJiYgbWFuaWZlc3RUcmVlRWxlbWVudC5zdWJ0aXRsZSA9PT0gc3VidGl0bGUpOwog ICAgICAgICB0aGlzLnN1YnRpdGxlID0gc3VidGl0bGVJc0R1cGxpY2F0ZSA/IG51bGwgOiBzdWJ0 aXRsZTsKICAgICB9CiB9Owo= 298052 2017-01-04 17:23:48 -0800 2017-01-04 18:01:25 -0800 Patch patch.txt text/plain 1780 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDMyYmZkMjcuLjgyM2IxMDggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTAxLTA0ICBOaWtpdGEgVmFzaWx5 ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IGFwcGxp Y2F0aW9uIGNhY2hlIGRldGFpbHMgbm90IHNob3duIGluIFN0b3JhZ2UgVGFiCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjY2OTkKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzI5ODcxNzE2PgorCisgICAgICAgIFJldmlld2VkIGJ5IEJyaWFuIEJ1cmcu CisKKyAgICAgICAgRml4IGEgdGVybmFyeSBvcGVyYXRvciBwcmVjZWRlbmNlLiBUaGUgZm9sbG93 aW5nIGV4cHJlc3Npb24gdGhyb3dzIGFuIGV4Y2VwdGlvbjoKKworICAgICAgICAgICAgdHJ1ZSB8 fCBmYWxzZSA/IGkuZG9udC5leGlzdCA6IGZhbHNlCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNl L1ZpZXdzL0FwcGxpY2F0aW9uQ2FjaGVGcmFtZVRyZWVFbGVtZW50LmpzOgorICAgICAgICAoV2Vi SW5zcGVjdG9yLkFwcGxpY2F0aW9uQ2FjaGVGcmFtZVRyZWVFbGVtZW50LnByb3RvdHlwZS51cGRh dGVUaXRsZXMpOgorCiAyMDE3LTAxLTAzICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBs ZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogIkludmFsaWQgQ2hhcmFjdGVycyIgc2V0 dGluZyBkb2VzIHRoZSBvcHBvc2l0ZSBvZiB0aGUgY2hlY2tib3gKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0FwcGxpY2F0aW9uQ2FjaGVGcmFt ZVRyZWVFbGVtZW50LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvQXBwbGljYXRpb25DYWNoZUZyYW1lVHJlZUVsZW1lbnQuanMKaW5kZXggNjUzNjc5OS4uOWIz NDZjYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvQXBwbGljYXRpb25DYWNoZUZyYW1lVHJlZUVsZW1lbnQuanMKKysrIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQXBwbGljYXRpb25DYWNoZUZyYW1lVHJlZUVs ZW1lbnQuanMKQEAgLTU2LDcgKzU2LDcgQEAgV2ViSW5zcGVjdG9yLkFwcGxpY2F0aW9uQ2FjaGVG cmFtZVRyZWVFbGVtZW50ID0gY2xhc3MgQXBwbGljYXRpb25DYWNoZUZyYW1lVHJlZUUKICAgICAg ICAgICAgIGN1cnJlbnRBbmNlc3RvciA9IGN1cnJlbnRBbmNlc3Rvci5wYXJlbnQ7CiAgICAgICAg IH0KIAotICAgICAgICB2YXIgc3VidGl0bGVJc0R1cGxpY2F0ZSA9IHN1YnRpdGxlID09PSB0aGlz Ll9tYWluVGl0bGUgfHwgbWFuaWZlc3RUcmVlRWxlbWVudCA/IHN1YnRpdGxlID09PSBtYW5pZmVz dFRyZWVFbGVtZW50LnN1YnRpdGxlIDogZmFsc2U7CisgICAgICAgIHZhciBzdWJ0aXRsZUlzRHVw bGljYXRlID0gc3VidGl0bGUgPT09IHRoaXMuX21haW5UaXRsZSB8fCAobWFuaWZlc3RUcmVlRWxl bWVudCAmJiBtYW5pZmVzdFRyZWVFbGVtZW50LnN1YnRpdGxlID09PSBzdWJ0aXRsZSk7CiAgICAg ICAgIHRoaXMuc3VidGl0bGUgPSBzdWJ0aXRsZUlzRHVwbGljYXRlID8gbnVsbCA6IHN1YnRpdGxl OwogICAgIH0KIH07Cg==