166692 2017-01-04 14:12:26 -0800 Add Exception accessor to ExceptionOr to remove unnecessary releases 2017-01-04 15:01:02 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sam sam cdumez commit-queue dbates esprehn+autocc kangil.han oldest_to_newest 1263889 0 sam 2017-01-04 14:12:26 -0800 Add Exception accessor to ExceptionOr to remove unnecessary releases 1263890 1 298045 sam 2017-01-04 14:13:35 -0800 Created attachment 298045 Patch 1263910 2 298045 commit-queue 2017-01-04 15:00:57 -0800 Comment on attachment 298045 Patch Clearing flags on attachment: 298045 Committed r210292: <http://trac.webkit.org/changeset/210292> 1263911 3 commit-queue 2017-01-04 15:01:02 -0800 All reviewed patches have been landed. Closing bug. 298045 2017-01-04 14:13:35 -0800 2017-01-04 15:00:57 -0800 Patch bug-166692-20170104141208.patch text/plain 5131 sam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMDI4NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE3LTAxLTA0ICBTYW0gV2Vp bmlnICA8c2FtQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQWRkIEV4Y2VwdGlvbiBhY2Nlc3NvciB0 byBFeGNlcHRpb25PciB0byByZW1vdmUgdW5uZWNlc3NhcnkgcmVsZWFzZXMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NjY5MgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTW9kdWxlcy93ZWJkYXRhYmFz ZS9EYXRhYmFzZU1hbmFnZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RGF0YWJhc2VNYW5hZ2Vy OjpvcGVuRGF0YWJhc2VCYWNrZW5kKToKKyAgICAgICAgVXNlIG5ldyBleGNlcHRpb24oKSBmdW5j dGlvbi4KKworICAgICAgICAqIGRvbS9FeGNlcHRpb25Pci5oOgorICAgICAgICAoV2ViQ29yZTo6 RXhjZXB0aW9uT3I8UmV0dXJuVHlwZT46OmV4Y2VwdGlvbik6CisgICAgICAgIChXZWJDb3JlOjpF eGNlcHRpb25Pcjx2b2lkPjo6ZXhjZXB0aW9uKToKKyAgICAgICAgQWRkIGV4Y2VwdGlvbigpIGZ1 bmN0aW9uIHdoaWNoIHJldHVybnMgdGhlIGV4Y2VwdGlvbiB3aXRob3V0IHJlbGVhc2luZyBpdC4K KwogMjAxNy0wMS0wNCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAg IEFzc2VydGlvbiBoaXQgb24gcmVkZmluLmNvbTogQVNTRVJUSU9OIEZBSUxFRDogY29sbGVjdGlv bi0+bGVuZ3RoKCkgPiAxCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmRhdGFiYXNl L0RhdGFiYXNlTWFuYWdlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvTW9kdWxl cy93ZWJkYXRhYmFzZS9EYXRhYmFzZU1hbmFnZXIuY3BwCShyZXZpc2lvbiAyMTAyNzQpCisrKyBT b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmRhdGFiYXNlL0RhdGFiYXNlTWFuYWdlci5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTExNCw4ICsxMTQsNyBAQCBzdGF0aWMgaW5saW5lIHZvaWQgbG9nT3Bl bkRhdGFiYXNlRXJyb3IoCiAKIHN0YXRpYyB2b2lkIGxvZ09wZW5EYXRhYmFzZUVycm9yKFNjcmlw dEV4ZWN1dGlvbkNvbnRleHQmIGNvbnRleHQsIGNvbnN0IFN0cmluZyYgbmFtZSkKIHsKLSAgICBM T0coU3RvcmFnZUFQSSwgIkRhdGFiYXNlICVzIGZvciBvcmlnaW4gJXMgbm90IGFsbG93ZWQgdG8g YmUgZXN0YWJsaXNoZWQiLCBuYW1lLnV0ZjgoKS5kYXRhKCksCi0gICAgICAgIGNvbnRleHQuc2Vj dXJpdHlPcmlnaW4oKS0+dG9TdHJpbmcoKS51dGY4KCkuZGF0YSgpKTsKKyAgICBMT0coU3RvcmFn ZUFQSSwgIkRhdGFiYXNlICVzIGZvciBvcmlnaW4gJXMgbm90IGFsbG93ZWQgdG8gYmUgZXN0YWJs aXNoZWQiLCBuYW1lLnV0ZjgoKS5kYXRhKCksIGNvbnRleHQuc2VjdXJpdHlPcmlnaW4oKS0+dG9T dHJpbmcoKS51dGY4KCkuZGF0YSgpKTsKIH0KIAogI2VuZGlmCkBAIC0xMjcsMTAgKzEyNiw3IEBA IEV4Y2VwdGlvbk9yPFJlZjxEYXRhYmFzZT4+IERhdGFiYXNlTWFuYWcKICAgICBhdXRvIGJhY2tl bmQgPSB0cnlUb09wZW5EYXRhYmFzZUJhY2tlbmQoZGF0YWJhc2VDb250ZXh0LCBuYW1lLCBleHBl Y3RlZFZlcnNpb24sIGRpc3BsYXlOYW1lLCBlc3RpbWF0ZWRTaXplLCBzZXRWZXJzaW9uSW5OZXdE YXRhYmFzZSwgRmlyc3RUcnlUb09wZW5EYXRhYmFzZSk7CiAKICAgICBpZiAoYmFja2VuZC5oYXNF eGNlcHRpb24oKSkgewotICAgICAgICBhdXRvIGV4Y2VwdGlvbiA9IGJhY2tlbmQucmVsZWFzZUV4 Y2VwdGlvbigpOwotICAgICAgICBpZiAoZXhjZXB0aW9uLmNvZGUoKSAhPSBRVU9UQV9FWENFRURF RF9FUlIpCi0gICAgICAgICAgICBiYWNrZW5kID0gV1RGTW92ZShleGNlcHRpb24pOyAvLyBGSVhN RTogQmFkIHRvIGhhdmUgdG8gbW92ZSBleGNlcHRpb24gb3V0IGFuZCBiYWNrIGluLgotICAgICAg ICBlbHNlIHsKKyAgICAgICAgaWYgKGJhY2tlbmQuZXhjZXB0aW9uKCkuY29kZSgpID09IFFVT1RB X0VYQ0VFREVEX0VSUikgewogICAgICAgICAgICAgLy8gTm90aWZ5IHRoZSBjbGllbnQgdGhhdCB3 ZSd2ZSBleGNlZWRlZCB0aGUgZGF0YWJhc2UgcXVvdGEuCiAgICAgICAgICAgICAvLyBUaGUgY2xp ZW50IG1heSB3YW50IHRvIGluY3JlYXNlIHRoZSBxdW90YSwgYW5kIHdlJ2xsIGdpdmUgaXQKICAg ICAgICAgICAgIC8vIG9uZSBtb3JlIHRyeSBhZnRlciBpZiB0aGF0IGlzIHRoZSBjYXNlLgpAQCAt MTQ0LDEyICsxNDAsMTAgQEAgRXhjZXB0aW9uT3I8UmVmPERhdGFiYXNlPj4gRGF0YWJhc2VNYW5h ZwogICAgIH0KIAogICAgIGlmIChiYWNrZW5kLmhhc0V4Y2VwdGlvbigpKSB7Ci0gICAgICAgIGF1 dG8gZXhjZXB0aW9uID0gYmFja2VuZC5yZWxlYXNlRXhjZXB0aW9uKCk7Ci0gICAgICAgIGlmIChl eGNlcHRpb24uY29kZSgpID09IElOVkFMSURfU1RBVEVfRVJSKQotICAgICAgICAgICAgbG9nRXJy b3JNZXNzYWdlKGNvbnRleHQsIGV4Y2VwdGlvbi5tZXNzYWdlKCkpOworICAgICAgICBpZiAoYmFj a2VuZC5leGNlcHRpb24oKS5jb2RlKCkgPT0gSU5WQUxJRF9TVEFURV9FUlIpCisgICAgICAgICAg ICBsb2dFcnJvck1lc3NhZ2UoY29udGV4dCwgYmFja2VuZC5leGNlcHRpb24oKS5tZXNzYWdlKCkp OwogICAgICAgICBlbHNlCiAgICAgICAgICAgICBsb2dPcGVuRGF0YWJhc2VFcnJvcihjb250ZXh0 LCBuYW1lKTsKLSAgICAgICAgYmFja2VuZCA9IFdURk1vdmUoZXhjZXB0aW9uKTsgLy8gRklYTUU6 IEJhZCB0byBoYXZlIHRvIG1vdmUgZXhjZXB0aW9uIG91dCBhbmQgYmFjayBpbi4KICAgICB9CiAK ICAgICByZXR1cm4gYmFja2VuZDsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2RvbS9FeGNlcHRpb25P ci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9FeGNlcHRpb25Pci5oCShyZXZp c2lvbiAyMTAyNzQpCisrKyBTb3VyY2UvV2ViQ29yZS9kb20vRXhjZXB0aW9uT3IuaAkod29ya2lu ZyBjb3B5KQpAQCAtMzgsNiArMzgsNyBAQCBwdWJsaWM6CiAgICAgdGVtcGxhdGU8dHlwZW5hbWUg T3RoZXJUeXBlPiBFeGNlcHRpb25Pcihjb25zdCBPdGhlclR5cGUmLCB0eXBlbmFtZSBzdGQ6OmVu YWJsZV9pZjxzdGQ6OmlzX3NjYWxhcjxPdGhlclR5cGU+Ojp2YWx1ZSAmJiBzdGQ6OmlzX2NvbnZl cnRpYmxlPE90aGVyVHlwZSwgUmV0dXJuVHlwZT46OnZhbHVlPjo6dHlwZSogPSBudWxscHRyKTsK IAogICAgIGJvb2wgaGFzRXhjZXB0aW9uKCkgY29uc3Q7CisgICAgY29uc3QgRXhjZXB0aW9uJiBl eGNlcHRpb24oKSBjb25zdDsKICAgICBFeGNlcHRpb24mJiByZWxlYXNlRXhjZXB0aW9uKCk7CiAg ICAgUmV0dXJuVHlwZSYmIHJlbGVhc2VSZXR1cm5WYWx1ZSgpOwogCkBAIC01MSw2ICs1Miw3IEBA IHB1YmxpYzoKICAgICBFeGNlcHRpb25PcihSZXR1cm5SZWZlcmVuY2VUeXBlJik7CiAKICAgICBi b29sIGhhc0V4Y2VwdGlvbigpIGNvbnN0OworICAgIGNvbnN0IEV4Y2VwdGlvbiYgZXhjZXB0aW9u KCkgY29uc3Q7CiAgICAgRXhjZXB0aW9uJiYgcmVsZWFzZUV4Y2VwdGlvbigpOwogICAgIFJldHVy blJlZmVyZW5jZVR5cGUmIHJlbGVhc2VSZXR1cm5WYWx1ZSgpOwogCkBAIC02NCw2ICs2Niw3IEBA IHB1YmxpYzoKICAgICBFeGNlcHRpb25PcigpID0gZGVmYXVsdDsKIAogICAgIGJvb2wgaGFzRXhj ZXB0aW9uKCkgY29uc3Q7CisgICAgY29uc3QgRXhjZXB0aW9uJiBleGNlcHRpb24oKSBjb25zdDsK ICAgICBFeGNlcHRpb24mJiByZWxlYXNlRXhjZXB0aW9uKCk7CiAKIHByaXZhdGU6CkBAIC05Nyw2 ICsxMDAsMTEgQEAgdGVtcGxhdGU8dHlwZW5hbWUgUmV0dXJuVHlwZT4gaW5saW5lIEV4YwogICAg IHJldHVybiBXVEZNb3ZlKG1fdmFsdWUuZXJyb3IoKSk7CiB9CiAKK3RlbXBsYXRlPHR5cGVuYW1l IFJldHVyblR5cGU+IGlubGluZSBjb25zdCBFeGNlcHRpb24mIEV4Y2VwdGlvbk9yPFJldHVyblR5 cGU+OjpleGNlcHRpb24oKSBjb25zdAoreworICAgIHJldHVybiBtX3ZhbHVlLmVycm9yKCk7Cit9 CisKIHRlbXBsYXRlPHR5cGVuYW1lIFJldHVyblR5cGU+IGlubGluZSBSZXR1cm5UeXBlJiYgRXhj ZXB0aW9uT3I8UmV0dXJuVHlwZT46OnJlbGVhc2VSZXR1cm5WYWx1ZSgpCiB7CiAgICAgcmV0dXJu IFdURk1vdmUobV92YWx1ZS52YWx1ZSgpKTsKQEAgLTExNyw2ICsxMjUsMTEgQEAgdGVtcGxhdGU8 dHlwZW5hbWUgUmV0dXJuUmVmZXJlbmNlVHlwZT4gaQogICAgIHJldHVybiBtX3ZhbHVlLmhhc0V4 Y2VwdGlvbigpOwogfQogCit0ZW1wbGF0ZTx0eXBlbmFtZSBSZXR1cm5SZWZlcmVuY2VUeXBlPiBp bmxpbmUgY29uc3QgRXhjZXB0aW9uJiBFeGNlcHRpb25PcjxSZXR1cm5SZWZlcmVuY2VUeXBlJj46 OmV4Y2VwdGlvbigpIGNvbnN0Cit7CisgICAgcmV0dXJuIG1fdmFsdWUuZXhjZXB0aW9uKCk7Cit9 CisKIHRlbXBsYXRlPHR5cGVuYW1lIFJldHVyblJlZmVyZW5jZVR5cGU+IGlubGluZSBFeGNlcHRp b24mJiBFeGNlcHRpb25PcjxSZXR1cm5SZWZlcmVuY2VUeXBlJj46OnJlbGVhc2VFeGNlcHRpb24o KQogewogICAgIHJldHVybiBtX3ZhbHVlLnJlbGVhc2VFeGNlcHRpb24oKTsKQEAgLTEzNyw2ICsx NTAsMTEgQEAgaW5saW5lIGJvb2wgRXhjZXB0aW9uT3I8dm9pZD46Omhhc0V4Y2VwdAogICAgIHJl dHVybiAhbV92YWx1ZS5oYXNWYWx1ZSgpOwogfQogCitpbmxpbmUgY29uc3QgRXhjZXB0aW9uJiBF eGNlcHRpb25Pcjx2b2lkPjo6ZXhjZXB0aW9uKCkgY29uc3QKK3sKKyAgICByZXR1cm4gbV92YWx1 ZS5lcnJvcigpOworfQorCiBpbmxpbmUgRXhjZXB0aW9uJiYgRXhjZXB0aW9uT3I8dm9pZD46OnJl bGVhc2VFeGNlcHRpb24oKQogewogICAgIHJldHVybiBXVEZNb3ZlKG1fdmFsdWUuZXJyb3IoKSk7 Cg==