166664 2017-01-03 14:39:23 -0800 Web Inspector: "Invalid Characters" setting does the opposite of the checkbox 2017-01-03 15:07:54 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue hi inspector-bugzilla-changes joepeck mmaxfield webkit-bug-importer oldest_to_newest 1263556 0 joepeck 2017-01-03 14:39:23 -0800 Summary: "Invalid Characters" setting does the opposite of the checkbox Steps to Reproduce: 1. Inspect http://www.apple.com/kr/watchos/ 2. Uncheck "Invalid Characters" in Web Inspector's Preferences Tab 3. Show one of the font Stylesheets in the Resources Tab => ␍ characters show 4. Check "Invalid Characters" in Web Inspector's Preferences Tab => ␍ characters do not show Seems this setting is inverted! 1263557 1 297955 joepeck 2017-01-03 14:40:23 -0800 Created attachment 297955 [PATCH] Proposed Fix 1263558 2 webkit-bug-importer 2017-01-03 14:41:00 -0800 <rdar://problem/29854762> 1263559 3 297955 bburg 2017-01-03 14:43:12 -0800 Comment on attachment 297955 [PATCH] Proposed Fix r=me @_@ 1263567 4 297955 commit-queue 2017-01-03 15:07:48 -0800 Comment on attachment 297955 [PATCH] Proposed Fix Clearing flags on attachment: 297955 Committed r210252: <http://trac.webkit.org/changeset/210252> 1263568 5 commit-queue 2017-01-03 15:07:54 -0800 All reviewed patches have been landed. Closing bug. 297955 2017-01-03 14:40:23 -0800 2017-01-03 15:07:48 -0800 [PATCH] Proposed Fix invalid-chars-1.patch text/plain 1529 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDZkZDcyNzkuLjM3YTAyMmEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE3LTAxLTAzICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogIkludmFs aWQgQ2hhcmFjdGVycyIgc2V0dGluZyBkb2VzIHRoZSBvcHBvc2l0ZSBvZiB0aGUgY2hlY2tib3gK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NjY2NAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlcklu dGVyZmFjZS9WaWV3cy9Db2RlTWlycm9yT3ZlcnJpZGVzLmNzczoKKyAgICAgICAgKC5Db2RlTWly cm9yIC5jbS1pbnZhbGlkY2hhcik6CisgICAgICAgICguc2hvdy1pbnZhbGlkLWNoYXJhY3RlcnMg LkNvZGVNaXJyb3IgLmNtLWludmFsaWRjaGFyKToKKyAgICAgICAgSGlkZSBpbnZhbGlkIGNoYXJh Y3RlcnMgYnkgZGVmYXVsdCwgYW5kIHNob3cgdGhlbSB3aXRoIHRoZSBzaG93IGNsYXNzLgorCisy MDE3LTAxLTAzICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAg ICAgV2ViIEluc3BlY3RvcjogRml4IENvbnRlbnQgRmxvdyBDb250YWluZXIgUmVnaW9ucyBDb21w dXRlZCBTdHlsZSBzZWN0aW9uCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNjYyOTQKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvQ29kZU1pcnJvck92ZXJyaWRlcy5jc3MgYi9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db2RlTWlycm9yT3ZlcnJpZGVzLmNzcwppbmRl eCA4ZDhmMDI5Li5lMjE5ZWVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9Db2RlTWlycm9yT3ZlcnJpZGVzLmNzcworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db2RlTWlycm9yT3ZlcnJpZGVzLmNzcwpA QCAtOTUsNiArOTUsMTAgQEAKICAgICBwb3NpdGlvbjogcmVsYXRpdmU7CiB9CiAKKy5Db2RlTWly cm9yIC5jbS1pbnZhbGlkY2hhciB7CisgICAgZGlzcGxheTogbm9uZTsKK30KKwogLnNob3ctd2hp dGVzcGFjZS1jaGFyYWN0ZXJzIC5Db2RlTWlycm9yIC5jbS10YWI6OmJlZm9yZSB7CiAgICAgcG9z aXRpb246IGFic29sdXRlOwogICAgIHdpZHRoOiA5MCU7CkBAIC0xNzUsNSArMTc5LDUgQEAKIH0K IAogLnNob3ctaW52YWxpZC1jaGFyYWN0ZXJzIC5Db2RlTWlycm9yIC5jbS1pbnZhbGlkY2hhciB7 Ci0gICAgZGlzcGxheTogbm9uZTsKKyAgICBkaXNwbGF5OiBpbml0aWFsOwogfQo=