<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>166623</bug_id>
          
          <creation_ts>2016-12-30 12:05:11 -0800</creation_ts>
          <short_desc>WebAssembly: avoid pinning registers when no Memory is present</short_desc>
          <delta_ts>2017-04-14 16:22:45 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>CONFIGURATION CHANGED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>165282</dependson>
          <blocked>161709</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="JF Bastien">jfbastien</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>jfbastien</cc>
    
    <cc>keith_miller</cc>
    
    <cc>saam</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1263165</commentid>
    <comment_count>0</comment_count>
    <who name="JF Bastien">jfbastien</who>
    <bug_when>2016-12-30 12:05:11 -0800</bug_when>
    <thetext>In bug #165282 I&apos;m changing pinning so that we unconditionally pin registers for all Modules, even if we technically don&apos;t need to when no Memory is present. This makes it easier to implement the wasm -&gt; wasm call thunks because the thunk needs to set up the callee&apos;s pinned registers and therefore necessarily clobbers the caller&apos;s values. The caller thinks these registers are callee-saved, but that&apos;s annoying to do because wasm -&gt; wasm is a tail call. We could teach B3 that these calls clobber those registers.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1294237</commentid>
    <comment_count>1</comment_count>
    <who name="JF Bastien">jfbastien</who>
    <bug_when>2017-04-04 15:56:31 -0700</bug_when>
    <thetext>To clarify: this is for memory and size pinned registers, if any.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1297565</commentid>
    <comment_count>2</comment_count>
    <who name="JF Bastien">jfbastien</who>
    <bug_when>2017-04-14 16:22:45 -0700</bug_when>
    <thetext>Keith says this is done.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>