<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>166616</bug_id>
          
          <creation_ts>2016-12-29 14:20:50 -0800</creation_ts>
          <short_desc>WebAssembly: Some loads don&apos;t take into account the offset</short_desc>
          <delta_ts>2017-01-02 16:33:46 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Saam Barati">saam</reporter>
          <assigned_to name="Saam Barati">saam</assigned_to>
          <cc>benjamin</cc>
    
    <cc>fpizlo</cc>
    
    <cc>ggaren</cc>
    
    <cc>gskachkov</cc>
    
    <cc>jfbastien</cc>
    
    <cc>keith_miller</cc>
    
    <cc>mark.lam</cc>
    
    <cc>msaboff</cc>
    
    <cc>oliver</cc>
    
    <cc>ticaiolima</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1263110</commentid>
    <comment_count>0</comment_count>
    <who name="Saam Barati">saam</who>
    <bug_when>2016-12-29 14:20:50 -0800</bug_when>
    <thetext>...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1263115</commentid>
    <comment_count>1</comment_count>
    <who name="Saam Barati">saam</who>
    <bug_when>2016-12-29 16:51:15 -0800</bug_when>
    <thetext>This can be seen my looking at emitLoadOp. This is part of the reason we can&apos;t unity. However, there are still other errors I&apos;m hitting after fixing this locally.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1263330</commentid>
    <comment_count>2</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2017-01-02 11:46:13 -0800</bug_when>
    <thetext>&lt;rdar://problem/29841541&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1263332</commentid>
    <comment_count>3</comment_count>
      <attachid>297906</attachid>
    <who name="Saam Barati">saam</who>
    <bug_when>2017-01-02 12:13:28 -0800</bug_when>
    <thetext>Created attachment 297906
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1263350</commentid>
    <comment_count>4</comment_count>
      <attachid>297906</attachid>
    <who name="JF Bastien">jfbastien</who>
    <bug_when>2017-01-02 14:06:09 -0800</bug_when>
    <thetext>Comment on attachment 297906
patch

lgtm</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1263351</commentid>
    <comment_count>5</comment_count>
    <who name="JF Bastien">jfbastien</who>
    <bug_when>2017-01-02 14:06:26 -0800</bug_when>
    <thetext>Forgot to ask: are there new spec tests that pass?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1263353</commentid>
    <comment_count>6</comment_count>
    <who name="Saam Barati">saam</who>
    <bug_when>2017-01-02 14:24:51 -0800</bug_when>
    <thetext>(In reply to comment #5)
&gt; Forgot to ask: are there new spec tests that pass?

I didn&apos;t try all of them, but memory.wast.js still fails. I can check all of them.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1263357</commentid>
    <comment_count>7</comment_count>
      <attachid>297914</attachid>
    <who name="Saam Barati">saam</who>
    <bug_when>2017-01-02 15:40:46 -0800</bug_when>
    <thetext>Created attachment 297914
patch

Two more tests pass for me locally, but I&apos;m not convinced they&apos;re related to this patch. They could be tests we forgot to update.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1263359</commentid>
    <comment_count>8</comment_count>
      <attachid>297914</attachid>
    <who name="Keith Miller">keith_miller</who>
    <bug_when>2017-01-02 15:47:18 -0800</bug_when>
    <thetext>Comment on attachment 297914
patch

r=me if you add a test for each load.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1263365</commentid>
    <comment_count>9</comment_count>
    <who name="Saam Barati">saam</who>
    <bug_when>2017-01-02 16:33:46 -0800</bug_when>
    <thetext>landed in:
https://trac.webkit.org/changeset/210228
with tests for all loads that were missing offset.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>297906</attachid>
            <date>2017-01-02 12:13:28 -0800</date>
            <delta_ts>2017-01-02 15:40:46 -0800</delta_ts>
            <desc>patch</desc>
            <filename>c-backup.diff</filename>
            <type>text/plain</type>
            <size>4507</size>
            <attacher name="Saam Barati">saam</attacher>
            
              <data encoding="base64">SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n
CShyZXZpc2lvbiAyMTAyMjUpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA
QCAtMSwzICsxLDEzIEBACisyMDE3LTAxLTAyICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu
Y29tPgorCisgICAgICAgIFdlYkFzc2VtYmx5OiBTb21lIGxvYWRzIGRvbid0IHRha2UgaW50byBh
Y2NvdW50IHRoZSBvZmZzZXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i
dWcuY2dpP2lkPTE2NjYxNgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjk4NDE1NDE+CisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3YXNtL2Z1bmN0
aW9uLXRlc3RzL2xvYWQtb2Zmc2V0LmpzOiBBZGRlZC4KKwogMjAxNi0xMi0yOSAgU2FhbSBCYXJh
dGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWJBc3NlbWJseTogUmViYXNlIHNw
ZWMtdGVzdHMgbm93IHRoYXQgd2FidCBoYXMgYmVlbiB1cGRhdGVkIHRvIHByb2R1Y2UgY2VydGFp
biBraW5kcyBvZiBpbnZhbGlkIG1vZHVsZXMKSW5kZXg6IEpTVGVzdHMvd2FzbS9mdW5jdGlvbi10
ZXN0cy9sb2FkLW9mZnNldC5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL3dhc20vZnVuY3Rpb24t
dGVzdHMvbG9hZC1vZmZzZXQuanMJKG5vbmV4aXN0ZW50KQorKysgSlNUZXN0cy93YXNtL2Z1bmN0
aW9uLXRlc3RzL2xvYWQtb2Zmc2V0LmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMjggQEAK
K2ltcG9ydCBCdWlsZGVyIGZyb20gJy4uL0J1aWxkZXIuanMnCitpbXBvcnQgKiBhcyBhc3NlcnQg
ZnJvbSAnLi4vYXNzZXJ0LmpzJworCit7CisgICAgY29uc3QgYnVpbGRlciA9IChuZXcgQnVpbGRl
cigpKQorICAgICAgICAuVHlwZSgpLkVuZCgpCisgICAgICAgIC5JbXBvcnQoKQorICAgICAgICAg
ICAgLk1lbW9yeSgiaW1wIiwgIm1lbSIsIHtpbml0aWFsOiAxfSkKKyAgICAgICAgLkVuZCgpCisg
ICAgICAgIC5GdW5jdGlvbigpLkVuZCgpCisgICAgICAgIC5FeHBvcnQoKS5GdW5jdGlvbigiZm9v
IikuRW5kKCkKKyAgICAgICAgLkNvZGUoKQorICAgICAgICAgICAgLkZ1bmN0aW9uKCJmb28iLCB7
cGFyYW1zOiBbImkzMiJdLCByZXQ6ICJpMzIifSkKKyAgICAgICAgICAgICAgICAuR2V0TG9jYWwo
MCkKKyAgICAgICAgICAgICAgICAuSTMyTG9hZCgyLCA0KQorICAgICAgICAgICAgICAgIC5SZXR1
cm4oKQorICAgICAgICAgICAgLkVuZCgpCisgICAgICAgIC5FbmQoKTsKKworICAgIGNvbnN0IGJp
biA9IGJ1aWxkZXIuV2ViQXNzZW1ibHkoKS5nZXQoKTsKKyAgICBjb25zdCBtb2R1bGUgPSBuZXcg
V2ViQXNzZW1ibHkuTW9kdWxlKGJpbik7CisgICAgY29uc3QgbWVtb3J5ID0gbmV3IFdlYkFzc2Vt
Ymx5Lk1lbW9yeSh7aW5pdGlhbDogMX0pOworICAgIGNvbnN0IGluc3RhbmNlID0gbmV3IFdlYkFz
c2VtYmx5Lkluc3RhbmNlKG1vZHVsZSwge2ltcDoge21lbTogbWVtb3J5fX0pOworICAgIAorICAg
IGNvbnN0IG51bWJlciA9IDB4MGFiYmNjZGQ7CisgICAgKG5ldyBVaW50MzJBcnJheShtZW1vcnku
YnVmZmVyKSlbMV0gPSBudW1iZXI7CisgICAgYXNzZXJ0LmVxKGluc3RhbmNlLmV4cG9ydHMuZm9v
KDApLCBudW1iZXIpOworfQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAy
MTAyMjUpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp
CkBAIC0xLDMgKzEsMTQgQEAKKzIwMTctMDEtMDIgIFNhYW0gQmFyYXRpICA8c2JhcmF0aUBhcHBs
ZS5jb20+CisKKyAgICAgICAgV2ViQXNzZW1ibHk6IFNvbWUgbG9hZHMgZG9uJ3QgdGFrZSBpbnRv
IGFjY291bnQgdGhlIG9mZnNldAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93
X2J1Zy5jZ2k/aWQ9MTY2NjE2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yOTg0MTU0MT4KKwor
ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHdhc20vV2Fz
bUIzSVJHZW5lcmF0b3IuY3BwOgorICAgICAgICAoSlNDOjpXYXNtOjpCM0lSR2VuZXJhdG9yOjpl
bWl0TG9hZE9wKToKKwogMjAxNy0wMS0wMSAgSmVmZiBNaWxsZXIgIDxqZWZmbUBhcHBsZS5jb20+
CiAKICAgICAgICAgVXBkYXRlIHVzZXItdmlzaWJsZSBjb3B5cmlnaHQgc3RyaW5ncyB0byBpbmNs
dWRlIDIwMTcKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dhc21CM0lSR2VuZXJh
dG9yLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9XYXNtQjNJ
UkdlbmVyYXRvci5jcHAJKHJldmlzaW9uIDIxMDIyNSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y
ZS93YXNtL1dhc21CM0lSR2VuZXJhdG9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTE0LDI5ICs1
MTQsMjkgQEAgaW5saW5lIFZhbHVlKiBCM0lSR2VuZXJhdG9yOjplbWl0TG9hZE9wKAogICAgIH0K
IAogICAgIGNhc2UgTG9hZE9wVHlwZTo6STMyTG9hZDogewotICAgICAgICByZXR1cm4gbV9jdXJy
ZW50QmxvY2stPmFwcGVuZE5ldzxNZW1vcnlWYWx1ZT4obV9wcm9jLCBMb2FkLCBJbnQzMiwgb3Jp
Z2luLCBwb2ludGVyKTsKKyAgICAgICAgcmV0dXJuIG1fY3VycmVudEJsb2NrLT5hcHBlbmROZXc8
TWVtb3J5VmFsdWU+KG1fcHJvYywgTG9hZCwgSW50MzIsIG9yaWdpbiwgcG9pbnRlciwgb2Zmc2V0
KTsKICAgICB9CiAKICAgICBjYXNlIExvYWRPcFR5cGU6Okk2NExvYWQzMlU6IHsKLSAgICAgICAg
VmFsdWUqIHZhbHVlID0gbV9jdXJyZW50QmxvY2stPmFwcGVuZE5ldzxNZW1vcnlWYWx1ZT4obV9w
cm9jLCBMb2FkLCBJbnQzMiwgb3JpZ2luLCBwb2ludGVyKTsKKyAgICAgICAgVmFsdWUqIHZhbHVl
ID0gbV9jdXJyZW50QmxvY2stPmFwcGVuZE5ldzxNZW1vcnlWYWx1ZT4obV9wcm9jLCBMb2FkLCBJ
bnQzMiwgb3JpZ2luLCBwb2ludGVyLCBvZmZzZXQpOwogICAgICAgICByZXR1cm4gbV9jdXJyZW50
QmxvY2stPmFwcGVuZE5ldzxWYWx1ZT4obV9wcm9jLCBaRXh0MzIsIG9yaWdpbiwgdmFsdWUpOwog
ICAgIH0KIAogICAgIGNhc2UgTG9hZE9wVHlwZTo6STY0TG9hZDMyUzogewotICAgICAgICBWYWx1
ZSogdmFsdWUgPSBtX2N1cnJlbnRCbG9jay0+YXBwZW5kTmV3PE1lbW9yeVZhbHVlPihtX3Byb2Ms
IExvYWQsIEludDMyLCBvcmlnaW4sIHBvaW50ZXIpOworICAgICAgICBWYWx1ZSogdmFsdWUgPSBt
X2N1cnJlbnRCbG9jay0+YXBwZW5kTmV3PE1lbW9yeVZhbHVlPihtX3Byb2MsIExvYWQsIEludDMy
LCBvcmlnaW4sIHBvaW50ZXIsIG9mZnNldCk7CiAgICAgICAgIHJldHVybiBtX2N1cnJlbnRCbG9j
ay0+YXBwZW5kTmV3PFZhbHVlPihtX3Byb2MsIFNFeHQzMiwgb3JpZ2luLCB2YWx1ZSk7CiAgICAg
fQogCiAgICAgY2FzZSBMb2FkT3BUeXBlOjpJNjRMb2FkOiB7Ci0gICAgICAgIHJldHVybiBtX2N1
cnJlbnRCbG9jay0+YXBwZW5kTmV3PE1lbW9yeVZhbHVlPihtX3Byb2MsIExvYWQsIEludDY0LCBv
cmlnaW4sIHBvaW50ZXIpOworICAgICAgICByZXR1cm4gbV9jdXJyZW50QmxvY2stPmFwcGVuZE5l
dzxNZW1vcnlWYWx1ZT4obV9wcm9jLCBMb2FkLCBJbnQ2NCwgb3JpZ2luLCBwb2ludGVyLCBvZmZz
ZXQpOwogICAgIH0KIAogICAgIGNhc2UgTG9hZE9wVHlwZTo6RjMyTG9hZDogewotICAgICAgICBy
ZXR1cm4gbV9jdXJyZW50QmxvY2stPmFwcGVuZE5ldzxNZW1vcnlWYWx1ZT4obV9wcm9jLCBMb2Fk
LCBGbG9hdCwgb3JpZ2luLCBwb2ludGVyKTsKKyAgICAgICAgcmV0dXJuIG1fY3VycmVudEJsb2Nr
LT5hcHBlbmROZXc8TWVtb3J5VmFsdWU+KG1fcHJvYywgTG9hZCwgRmxvYXQsIG9yaWdpbiwgcG9p
bnRlciwgb2Zmc2V0KTsKICAgICB9CiAKICAgICBjYXNlIExvYWRPcFR5cGU6OkY2NExvYWQ6IHsK
LSAgICAgICAgcmV0dXJuIG1fY3VycmVudEJsb2NrLT5hcHBlbmROZXc8TWVtb3J5VmFsdWU+KG1f
cHJvYywgTG9hZCwgRG91YmxlLCBvcmlnaW4sIHBvaW50ZXIpOworICAgICAgICByZXR1cm4gbV9j
dXJyZW50QmxvY2stPmFwcGVuZE5ldzxNZW1vcnlWYWx1ZT4obV9wcm9jLCBMb2FkLCBEb3VibGUs
IG9yaWdpbiwgcG9pbnRlciwgb2Zmc2V0KTsKICAgICB9CiAKICAgICAvLyBGSVhNRTogQjMgZG9l
c24ndCBzdXBwb3J0IExvYWQxNlogeWV0LiBXZSBzaG91bGQgbG93ZXIgdG8gdGhhdCB2YWx1ZSB3
aGVuCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>297914</attachid>
            <date>2017-01-02 15:40:46 -0800</date>
            <delta_ts>2017-01-02 15:47:18 -0800</delta_ts>
            <desc>patch</desc>
            <filename>c-backup.diff</filename>
            <type>text/plain</type>
            <size>5052</size>
            <attacher name="Saam Barati">saam</attacher>
            
              <data encoding="base64">SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n
CShyZXZpc2lvbiAyMTAyMjUpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA
QCAtMSwzICsxLDEzIEBACisyMDE3LTAxLTAyICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu
Y29tPgorCisgICAgICAgIFdlYkFzc2VtYmx5OiBTb21lIGxvYWRzIGRvbid0IHRha2UgaW50byBh
Y2NvdW50IHRoZSBvZmZzZXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i
dWcuY2dpP2lkPTE2NjYxNgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjk4NDE1NDE+CisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3YXNtL2Z1bmN0
aW9uLXRlc3RzL2xvYWQtb2Zmc2V0LmpzOiBBZGRlZC4KKwogMjAxNi0xMi0yOSAgU2FhbSBCYXJh
dGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWJBc3NlbWJseTogUmViYXNlIHNw
ZWMtdGVzdHMgbm93IHRoYXQgd2FidCBoYXMgYmVlbiB1cGRhdGVkIHRvIHByb2R1Y2UgY2VydGFp
biBraW5kcyBvZiBpbnZhbGlkIG1vZHVsZXMKSW5kZXg6IEpTVGVzdHMvd2FzbS55YW1sCj09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT0KLS0tIEpTVGVzdHMvd2FzbS55YW1sCShyZXZpc2lvbiAyMTAyMjUpCisrKyBKU1Rlc3Rz
L3dhc20ueWFtbAkod29ya2luZyBjb3B5KQpAQCAtMTQ5LDEwICsxNDksMTAgQEAKICAgY21kOiBy
dW5XZWJBc3NlbWJseVNwZWNUZXN0IDpza2lwCiAKIC0gcGF0aDogd2FzbS9zcGVjLXRlc3RzL25v
cC53YXN0LmpzCi0gIGNtZDogcnVuV2ViQXNzZW1ibHlTcGVjVGVzdCA6c2tpcAorICBjbWQ6IHJ1
bldlYkFzc2VtYmx5U3BlY1Rlc3QgOm5vcm1hbAogCiAtIHBhdGg6IHdhc20vc3BlYy10ZXN0cy9y
ZXNpemluZy53YXN0LmpzCi0gIGNtZDogcnVuV2ViQXNzZW1ibHlTcGVjVGVzdCA6c2tpcAorICBj
bWQ6IHJ1bldlYkFzc2VtYmx5U3BlY1Rlc3QgOm5vcm1hbAogCiAtIHBhdGg6IHdhc20vc3BlYy10
ZXN0cy9yZXR1cm4ud2FzdC5qcwogICBjbWQ6IHJ1bldlYkFzc2VtYmx5U3BlY1Rlc3QgOm5vcm1h
bApJbmRleDogSlNUZXN0cy93YXNtL2Z1bmN0aW9uLXRlc3RzL2xvYWQtb2Zmc2V0LmpzCj09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT0KLS0tIEpTVGVzdHMvd2FzbS9mdW5jdGlvbi10ZXN0cy9sb2FkLW9mZnNldC5qcwkobm9u
ZXhpc3RlbnQpCisrKyBKU1Rlc3RzL3dhc20vZnVuY3Rpb24tdGVzdHMvbG9hZC1vZmZzZXQuanMJ
KHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwyOCBAQAoraW1wb3J0IEJ1aWxkZXIgZnJvbSAnLi4v
QnVpbGRlci5qcycKK2ltcG9ydCAqIGFzIGFzc2VydCBmcm9tICcuLi9hc3NlcnQuanMnCisKK3sK
KyAgICBjb25zdCBidWlsZGVyID0gKG5ldyBCdWlsZGVyKCkpCisgICAgICAgIC5UeXBlKCkuRW5k
KCkKKyAgICAgICAgLkltcG9ydCgpCisgICAgICAgICAgICAuTWVtb3J5KCJpbXAiLCAibWVtIiwg
e2luaXRpYWw6IDF9KQorICAgICAgICAuRW5kKCkKKyAgICAgICAgLkZ1bmN0aW9uKCkuRW5kKCkK
KyAgICAgICAgLkV4cG9ydCgpLkZ1bmN0aW9uKCJmb28iKS5FbmQoKQorICAgICAgICAuQ29kZSgp
CisgICAgICAgICAgICAuRnVuY3Rpb24oImZvbyIsIHtwYXJhbXM6IFsiaTMyIl0sIHJldDogImkz
MiJ9KQorICAgICAgICAgICAgICAgIC5HZXRMb2NhbCgwKQorICAgICAgICAgICAgICAgIC5JMzJM
b2FkKDIsIDQpCisgICAgICAgICAgICAgICAgLlJldHVybigpCisgICAgICAgICAgICAuRW5kKCkK
KyAgICAgICAgLkVuZCgpOworCisgICAgY29uc3QgYmluID0gYnVpbGRlci5XZWJBc3NlbWJseSgp
LmdldCgpOworICAgIGNvbnN0IG1vZHVsZSA9IG5ldyBXZWJBc3NlbWJseS5Nb2R1bGUoYmluKTsK
KyAgICBjb25zdCBtZW1vcnkgPSBuZXcgV2ViQXNzZW1ibHkuTWVtb3J5KHtpbml0aWFsOiAxfSk7
CisgICAgY29uc3QgaW5zdGFuY2UgPSBuZXcgV2ViQXNzZW1ibHkuSW5zdGFuY2UobW9kdWxlLCB7
aW1wOiB7bWVtOiBtZW1vcnl9fSk7CisgICAgCisgICAgY29uc3QgbnVtYmVyID0gMHgwYWJiY2Nk
ZDsKKyAgICAobmV3IFVpbnQzMkFycmF5KG1lbW9yeS5idWZmZXIpKVsxXSA9IG51bWJlcjsKKyAg
ICBhc3NlcnQuZXEoaW5zdGFuY2UuZXhwb3J0cy5mb28oMCksIG51bWJlcik7Cit9CkluZGV4OiBT
b3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZh
U2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMDIyNSkKKysrIFNvdXJjZS9KYXZhU2Ny
aXB0Q29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAxNy0w
MS0wMiAgU2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KKworICAgICAgICBXZWJBc3Nl
bWJseTogU29tZSBsb2FkcyBkb24ndCB0YWtlIGludG8gYWNjb3VudCB0aGUgb2Zmc2V0CisgICAg
ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjY2MTYKKyAgICAg
ICAgPHJkYXI6Ly9wcm9ibGVtLzI5ODQxNTQxPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E
WSAoT09QUyEpLgorCisgICAgICAgICogd2FzbS9XYXNtQjNJUkdlbmVyYXRvci5jcHA6CisgICAg
ICAgIChKU0M6Oldhc206OkIzSVJHZW5lcmF0b3I6OmVtaXRMb2FkT3ApOgorCiAyMDE3LTAxLTAx
ICBKZWZmIE1pbGxlciAgPGplZmZtQGFwcGxlLmNvbT4KIAogICAgICAgICBVcGRhdGUgdXNlci12
aXNpYmxlIGNvcHlyaWdodCBzdHJpbmdzIHRvIGluY2x1ZGUgMjAxNwpJbmRleDogU291cmNlL0ph
dmFTY3JpcHRDb3JlL3dhc20vV2FzbUIzSVJHZW5lcmF0b3IuY3BwCj09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv
dXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dhc21CM0lSR2VuZXJhdG9yLmNwcAkocmV2aXNpb24g
MjEwMjI1KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vV2FzbUIzSVJHZW5lcmF0b3Iu
Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC01MTQsMjkgKzUxNCwyOSBAQCBpbmxpbmUgVmFsdWUqIEIz
SVJHZW5lcmF0b3I6OmVtaXRMb2FkT3AoCiAgICAgfQogCiAgICAgY2FzZSBMb2FkT3BUeXBlOjpJ
MzJMb2FkOiB7Ci0gICAgICAgIHJldHVybiBtX2N1cnJlbnRCbG9jay0+YXBwZW5kTmV3PE1lbW9y
eVZhbHVlPihtX3Byb2MsIExvYWQsIEludDMyLCBvcmlnaW4sIHBvaW50ZXIpOworICAgICAgICBy
ZXR1cm4gbV9jdXJyZW50QmxvY2stPmFwcGVuZE5ldzxNZW1vcnlWYWx1ZT4obV9wcm9jLCBMb2Fk
LCBJbnQzMiwgb3JpZ2luLCBwb2ludGVyLCBvZmZzZXQpOwogICAgIH0KIAogICAgIGNhc2UgTG9h
ZE9wVHlwZTo6STY0TG9hZDMyVTogewotICAgICAgICBWYWx1ZSogdmFsdWUgPSBtX2N1cnJlbnRC
bG9jay0+YXBwZW5kTmV3PE1lbW9yeVZhbHVlPihtX3Byb2MsIExvYWQsIEludDMyLCBvcmlnaW4s
IHBvaW50ZXIpOworICAgICAgICBWYWx1ZSogdmFsdWUgPSBtX2N1cnJlbnRCbG9jay0+YXBwZW5k
TmV3PE1lbW9yeVZhbHVlPihtX3Byb2MsIExvYWQsIEludDMyLCBvcmlnaW4sIHBvaW50ZXIsIG9m
ZnNldCk7CiAgICAgICAgIHJldHVybiBtX2N1cnJlbnRCbG9jay0+YXBwZW5kTmV3PFZhbHVlPiht
X3Byb2MsIFpFeHQzMiwgb3JpZ2luLCB2YWx1ZSk7CiAgICAgfQogCiAgICAgY2FzZSBMb2FkT3BU
eXBlOjpJNjRMb2FkMzJTOiB7Ci0gICAgICAgIFZhbHVlKiB2YWx1ZSA9IG1fY3VycmVudEJsb2Nr
LT5hcHBlbmROZXc8TWVtb3J5VmFsdWU+KG1fcHJvYywgTG9hZCwgSW50MzIsIG9yaWdpbiwgcG9p
bnRlcik7CisgICAgICAgIFZhbHVlKiB2YWx1ZSA9IG1fY3VycmVudEJsb2NrLT5hcHBlbmROZXc8
TWVtb3J5VmFsdWU+KG1fcHJvYywgTG9hZCwgSW50MzIsIG9yaWdpbiwgcG9pbnRlciwgb2Zmc2V0
KTsKICAgICAgICAgcmV0dXJuIG1fY3VycmVudEJsb2NrLT5hcHBlbmROZXc8VmFsdWU+KG1fcHJv
YywgU0V4dDMyLCBvcmlnaW4sIHZhbHVlKTsKICAgICB9CiAKICAgICBjYXNlIExvYWRPcFR5cGU6
Okk2NExvYWQ6IHsKLSAgICAgICAgcmV0dXJuIG1fY3VycmVudEJsb2NrLT5hcHBlbmROZXc8TWVt
b3J5VmFsdWU+KG1fcHJvYywgTG9hZCwgSW50NjQsIG9yaWdpbiwgcG9pbnRlcik7CisgICAgICAg
IHJldHVybiBtX2N1cnJlbnRCbG9jay0+YXBwZW5kTmV3PE1lbW9yeVZhbHVlPihtX3Byb2MsIExv
YWQsIEludDY0LCBvcmlnaW4sIHBvaW50ZXIsIG9mZnNldCk7CiAgICAgfQogCiAgICAgY2FzZSBM
b2FkT3BUeXBlOjpGMzJMb2FkOiB7Ci0gICAgICAgIHJldHVybiBtX2N1cnJlbnRCbG9jay0+YXBw
ZW5kTmV3PE1lbW9yeVZhbHVlPihtX3Byb2MsIExvYWQsIEZsb2F0LCBvcmlnaW4sIHBvaW50ZXIp
OworICAgICAgICByZXR1cm4gbV9jdXJyZW50QmxvY2stPmFwcGVuZE5ldzxNZW1vcnlWYWx1ZT4o
bV9wcm9jLCBMb2FkLCBGbG9hdCwgb3JpZ2luLCBwb2ludGVyLCBvZmZzZXQpOwogICAgIH0KIAog
ICAgIGNhc2UgTG9hZE9wVHlwZTo6RjY0TG9hZDogewotICAgICAgICByZXR1cm4gbV9jdXJyZW50
QmxvY2stPmFwcGVuZE5ldzxNZW1vcnlWYWx1ZT4obV9wcm9jLCBMb2FkLCBEb3VibGUsIG9yaWdp
biwgcG9pbnRlcik7CisgICAgICAgIHJldHVybiBtX2N1cnJlbnRCbG9jay0+YXBwZW5kTmV3PE1l
bW9yeVZhbHVlPihtX3Byb2MsIExvYWQsIERvdWJsZSwgb3JpZ2luLCBwb2ludGVyLCBvZmZzZXQp
OwogICAgIH0KIAogICAgIC8vIEZJWE1FOiBCMyBkb2Vzbid0IHN1cHBvcnQgTG9hZDE2WiB5ZXQu
IFdlIHNob3VsZCBsb3dlciB0byB0aGF0IHZhbHVlIHdoZW4K
</data>
<flag name="review"
          id="320177"
          type_id="1"
          status="+"
          setter="keith_miller"
    />
          </attachment>
      

    </bug>

</bugzilla>