166571 2016-12-29 00:06:50 -0800 AX: Need to expose frames to iOS Accessibility 2016-12-29 10:47:25 -0800 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 cfleizach cfleizach aboxhall apinheiro commit-queue dmazzoni jcraig jdiggs mario samuel_white webkit-bug-importer oldest_to_newest 1263019 0 cfleizach 2016-12-29 00:06:50 -0800 To support navigation by frame for VoiceOver on iOS, we need to expose the frame ancestor 1263021 1 webkit-bug-importer 2016-12-29 00:08:22 -0800 <rdar://problem/29823724> 1263022 2 297825 cfleizach 2016-12-29 00:11:44 -0800 Created attachment 297825 patch 1263023 3 297826 cfleizach 2016-12-29 00:13:26 -0800 Created attachment 297826 patch 1263033 4 297826 darin 2016-12-29 01:30:55 -0800 Comment on attachment 297826 patch View in context: https://bugs.webkit.org/attachment.cgi?id=297826&action=review > Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:592 > + if (const AccessibilityObject* parent = AccessibilityObject::matchedParent(*m_object, false, [] (const AccessibilityObject& object) { > + return object.isWebArea(); > + })) > + return parent->wrapper(); > + return nil; In WebKit we normally use early exit for errors rather than wrapping success in an if. I also think auto would be good to use here. So I would write: auto* parent = AccessibilityObject::matchedParent(*m_object, false, [] (const AccessibilityObject& object) { return object.isWebArea(); }); if (!parent) return nil; return parent->wrapper; But I still think the auto* is an improvement even if you want ot keep it nested the way you have it. 1263060 5 cfleizach 2016-12-29 09:23:36 -0800 Thanks, will make those changes (In reply to comment #4) > Comment on attachment 297826 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=297826&action=review > > > Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:592 > > + if (const AccessibilityObject* parent = AccessibilityObject::matchedParent(*m_object, false, [] (const AccessibilityObject& object) { > > + return object.isWebArea(); > > + })) > > + return parent->wrapper(); > > + return nil; > > In WebKit we normally use early exit for errors rather than wrapping success > in an if. I also think auto would be good to use here. So I would write: > > auto* parent = AccessibilityObject::matchedParent(*m_object, false, [] > (const AccessibilityObject& object) { > return object.isWebArea(); > }); > if (!parent) > return nil; > return parent->wrapper; > > But I still think the auto* is an improvement even if you want ot keep it > nested the way you have it. 1263065 6 297835 cfleizach 2016-12-29 09:40:12 -0800 Created attachment 297835 patch for landing 1263071 7 297835 commit-queue 2016-12-29 10:47:22 -0800 Comment on attachment 297835 patch for landing Clearing flags on attachment: 297835 Committed r210205: <http://trac.webkit.org/changeset/210205> 1263072 8 commit-queue 2016-12-29 10:47:25 -0800 All reviewed patches have been landed. Closing bug. 297825 2016-12-29 00:11:44 -0800 2016-12-29 00:13:26 -0800 patch patch text/plain 1774 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMDIwMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE2LTEyLTI5ICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IE5lZWQgdG8gZXhw b3NlIGZyYW1lcyB0byBpT1MgQWNjZXNzaWJpbGl0eQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY2NTcxCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8y OTgyMzcyND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUbyBzdXBwb3J0IG5hdmlnYXRpb24gYnkgZnJhbWUgZm9yIFZvaWNlT3ZlciBvbiBpT1MsIHdl IG5lZWQgdG8gZXhwb3NlIHRoZSBmcmFtZSBhbmNlc3Rvci4gCisKKyAgICAgICAgKiBhY2Nlc3Np YmlsaXR5L2lvcy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlcklPUy5tbToKKyAgICAgICAg KC1bV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXIgX2FjY2Vzc2liaWxpdHlGcmFtZUFuY2Vz dG9yXSk6CisKIDIwMTYtMTItMDkgIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxp YS5jb20+CiAKICAgICAgICAgW2Nzcy1ncmlkXSBNb3ZlIEdyaWQgaW50byBHcmlkU2l6aW5nRGF0 YQpJbmRleDogU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9pb3MvV2ViQWNjZXNzaWJpbGl0 eU9iamVjdFdyYXBwZXJJT1MubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYWNjZXNz aWJpbGl0eS9pb3MvV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJJT1MubW0JKHJldmlzaW9u IDIxMDIwMykKKysrIFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvaW9zL1dlYkFjY2Vzc2li aWxpdHlPYmplY3RXcmFwcGVySU9TLm1tCSh3b3JraW5nIGNvcHkpCkBAIC01MzksNyArNTM5LDcg QEAKICAgICB9OwogICAgIAogICAgIGlmIChjb25zdCBBY2Nlc3NpYmlsaXR5T2JqZWN0KiBwYXJl bnQgPSBBY2Nlc3NpYmlsaXR5T2JqZWN0OjptYXRjaGVkUGFyZW50KCptX29iamVjdCwgZmFsc2Us IG1hdGNoRnVuYykpCi0gICAgICAgIHJldHVybiBwYXJlbnQtPndyYXBwZXIoKTsKK3JldHVybiBw YXJlbnQtPndyYXBwZXIoKTsKICAgICByZXR1cm4gbmlsOwogfQogCkBAIC01ODMsNiArNTgzLDE1 IEBACiAgICAgcmV0dXJuIG5pbDsKIH0KIAorLSAoQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXIq KV9hY2Nlc3NpYmlsaXR5RnJhbWVBbmNlc3RvcgoreworICAgIGlmIChjb25zdCBBY2Nlc3NpYmls aXR5T2JqZWN0KiBwYXJlbnQgPSBBY2Nlc3NpYmlsaXR5T2JqZWN0OjptYXRjaGVkUGFyZW50KCpt X29iamVjdCwgZmFsc2UsIFtdIChjb25zdCBBY2Nlc3NpYmlsaXR5T2JqZWN0JiBvYmplY3QpIHsK KyAgICAgICAgcmV0dXJuIG9iamVjdC5pc1dlYkFyZWEoKTsKKyAgICB9KSkKKyAgICAgICAgcmV0 dXJuIHBhcmVudC0+d3JhcHBlcigpOworICAgIHJldHVybiBuaWw7Cit9CisKIC0gKHVpbnQ2NF90 KV9hY2Nlc3NpYmlsaXR5VHJhaXRzRnJvbUFuY2VzdG9ycwogewogICAgIHVpbnQ2NF90IHRyYWl0 cyA9IDA7Cg== 297826 2016-12-29 00:13:26 -0800 2016-12-29 09:40:12 -0800 patch patch text/plain 1546 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMDIwMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE2LTEyLTI5ICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IE5lZWQgdG8gZXhw b3NlIGZyYW1lcyB0byBpT1MgQWNjZXNzaWJpbGl0eQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY2NTcxCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8y OTgyMzcyND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUbyBzdXBwb3J0IG5hdmlnYXRpb24gYnkgZnJhbWUgZm9yIFZvaWNlT3ZlciBvbiBpT1MsIHdl IG5lZWQgdG8gZXhwb3NlIHRoZSBmcmFtZSBhbmNlc3Rvci4gCisKKyAgICAgICAgKiBhY2Nlc3Np YmlsaXR5L2lvcy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlcklPUy5tbToKKyAgICAgICAg KC1bV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXIgX2FjY2Vzc2liaWxpdHlGcmFtZUFuY2Vz dG9yXSk6CisKIDIwMTYtMTItMDkgIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxp YS5jb20+CiAKICAgICAgICAgW2Nzcy1ncmlkXSBNb3ZlIEdyaWQgaW50byBHcmlkU2l6aW5nRGF0 YQpJbmRleDogU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9pb3MvV2ViQWNjZXNzaWJpbGl0 eU9iamVjdFdyYXBwZXJJT1MubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYWNjZXNz aWJpbGl0eS9pb3MvV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJJT1MubW0JKHJldmlzaW9u IDIxMDIwMykKKysrIFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvaW9zL1dlYkFjY2Vzc2li aWxpdHlPYmplY3RXcmFwcGVySU9TLm1tCSh3b3JraW5nIGNvcHkpCkBAIC01ODMsNiArNTgzLDE1 IEBACiAgICAgcmV0dXJuIG5pbDsKIH0KIAorLSAoQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXIq KV9hY2Nlc3NpYmlsaXR5RnJhbWVBbmNlc3RvcgoreworICAgIGlmIChjb25zdCBBY2Nlc3NpYmls aXR5T2JqZWN0KiBwYXJlbnQgPSBBY2Nlc3NpYmlsaXR5T2JqZWN0OjptYXRjaGVkUGFyZW50KCpt X29iamVjdCwgZmFsc2UsIFtdIChjb25zdCBBY2Nlc3NpYmlsaXR5T2JqZWN0JiBvYmplY3QpIHsK KyAgICAgICAgcmV0dXJuIG9iamVjdC5pc1dlYkFyZWEoKTsKKyAgICB9KSkKKyAgICAgICAgcmV0 dXJuIHBhcmVudC0+d3JhcHBlcigpOworICAgIHJldHVybiBuaWw7Cit9CisKIC0gKHVpbnQ2NF90 KV9hY2Nlc3NpYmlsaXR5VHJhaXRzRnJvbUFuY2VzdG9ycwogewogICAgIHVpbnQ2NF90IHRyYWl0 cyA9IDA7Cg== 297835 2016-12-29 09:40:12 -0800 2016-12-29 10:47:22 -0800 patch for landing patch text/plain 1536 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMDIwMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE2LTEyLTI5ICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IE5lZWQgdG8gZXhw b3NlIGZyYW1lcyB0byBpT1MgQWNjZXNzaWJpbGl0eQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY2NTcxCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8y OTgyMzcyND4KKworICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KKworICAgICAgICBU byBzdXBwb3J0IG5hdmlnYXRpb24gYnkgZnJhbWUgZm9yIFZvaWNlT3ZlciBvbiBpT1MsIHdlIG5l ZWQgdG8gZXhwb3NlIHRoZSBmcmFtZSBhbmNlc3Rvci4gCisKKyAgICAgICAgKiBhY2Nlc3NpYmls aXR5L2lvcy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlcklPUy5tbToKKyAgICAgICAgKC1b V2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXIgX2FjY2Vzc2liaWxpdHlGcmFtZUFuY2VzdG9y XSk6CisKIDIwMTYtMTItMDkgIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5j b20+CiAKICAgICAgICAgW2Nzcy1ncmlkXSBNb3ZlIEdyaWQgaW50byBHcmlkU2l6aW5nRGF0YQpJ bmRleDogU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9pb3MvV2ViQWNjZXNzaWJpbGl0eU9i amVjdFdyYXBwZXJJT1MubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYWNjZXNzaWJp bGl0eS9pb3MvV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJJT1MubW0JKHJldmlzaW9uIDIx MDIwMykKKysrIFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvaW9zL1dlYkFjY2Vzc2liaWxp dHlPYmplY3RXcmFwcGVySU9TLm1tCSh3b3JraW5nIGNvcHkpCkBAIC01ODMsNiArNTgzLDE2IEBA CiAgICAgcmV0dXJuIG5pbDsKIH0KIAorLSAoQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXIqKV9h Y2Nlc3NpYmlsaXR5RnJhbWVBbmNlc3RvcgoreworICAgIGF1dG8qIHBhcmVudCA9IEFjY2Vzc2li aWxpdHlPYmplY3Q6Om1hdGNoZWRQYXJlbnQoKm1fb2JqZWN0LCBmYWxzZSwgW10gKGNvbnN0IEFj Y2Vzc2liaWxpdHlPYmplY3QmIG9iamVjdCkgeworICAgICAgICByZXR1cm4gb2JqZWN0LmlzV2Vi QXJlYSgpOworICAgIH0pOworICAgIGlmICghcGFyZW50KQorICAgICAgICByZXR1cm4gbmlsOwor ICAgIHJldHVybiBwYXJlbnQtPndyYXBwZXIoKTsKK30KKwogLSAodWludDY0X3QpX2FjY2Vzc2li aWxpdHlUcmFpdHNGcm9tQW5jZXN0b3JzCiB7CiAgICAgdWludDY0X3QgdHJhaXRzID0gMDsK