166570 2016-12-28 22:19:55 -0800 Web Inspector: opening Test.html in a normal browser window doesn't log errors to console 2017-01-03 14:13:26 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 bburg bburg bburg commit-queue inspector-bugzilla-changes oldest_to_newest 1263014 0 bburg 2016-12-28 22:19:55 -0800 The check we used was not correct. 1263015 1 297821 bburg 2016-12-28 22:24:18 -0800 Created attachment 297821 Patch 1263513 2 297821 joepeck 2017-01-03 13:37:21 -0800 Comment on attachment 297821 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297821&action=review r=me, nice! I've hit this a few times in the past, this will be very useful. > Source/WebInspectorUI/UserInterface/Test/FrontendTestHarness.js:-198 > - if (this._originalConsole && (!InspectorFrontendHost || !InspectorBackend)) { Errr these checks would never have done anything anyways, they would have ReferenceErrored! Who reviewed that? =) 1263535 3 297821 commit-queue 2017-01-03 14:13:23 -0800 Comment on attachment 297821 Patch Clearing flags on attachment: 297821 Committed r210249: <http://trac.webkit.org/changeset/210249> 1263536 4 commit-queue 2017-01-03 14:13:26 -0800 All reviewed patches have been landed. Closing bug. 297821 2016-12-28 22:24:18 -0800 2017-01-03 14:13:23 -0800 Patch bug-166570-20161228222303.patch text/plain 2517 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjEwMDkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBi MmU4ZGJkNGYxNjYwZjU3YWEyMTA4Y2MyZmViMWU5OTAwNjVjMGEwLi5hMGJlMTQzNzQ5ODZhYTU0 YzJhMzdhNWRhN2EwNjY2YzI1NTc3NDNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxNi0xMi0yOCAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBvcGVuaW5nIFRlc3QuaHRtbCBpbiBhIG5vcm1hbCBicm93 c2VyIHdpbmRvdyBkb2Vzbid0IGxvZyBlcnJvcnMgdG8gY29uc29sZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY2NTcwCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRWFybHkgc3ludGF4IGVycm9ycyBpbiB0 aGUgdGVzdCBoYXJuZXNzIHNob3VsZCBiZSBsb2dnZWQgdG8gdGhlIHBhZ2UgY29uc29sZSBzaW5j ZSB0aGV5IGFyZSBlYXNpZXIgdG8KKyAgICAgICAgZGVidWcgaW4gYSBub3JtYWwgYnJvd3NlciB1 c2luZyBXZWIgSW5zcGVjdG9yLiBCdXQsIHRoZSBjaGVja3MgdG8gcmV2ZXJ0IHRvIG5vcm1hbCBj b25zb2xlIGRvbid0IHdvcmsuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1Rlc3QvRnJvbnRl bmRUZXN0SGFybmVzcy5qczoKKyAgICAgICAgKEZyb250ZW5kVGVzdEhhcm5lc3MucHJvdG90eXBl LnJlcG9ydFVuY2F1Z2h0RXhjZXB0aW9uKToKKyAgICAgICAgQWRkIGEgaGVscGVyIHRvIGVuY2Fw c3VsYXRlIHRoZSBtZWFuaW5nIG9mIGNoZWNraW5nIHRoaXMuX3Nob3VsZFJlc2VuZFJlc3VsdHMu CisgICAgICAgIFRoaXMgZmxhZyBpcyBhbHdheXMgdHJ1ZSB1bnRpbCB0aGUgdGVzdCBwYWdlIGlu amVjdHMgaXRzIGluaXRpYWxpemVycyBpbnRvIHRoZQorICAgICAgICBpbnNwZWN0b3IgcGFnZSwg d2hpY2ggd2lsbCBuZXZlciBoYXBwZW4gd2hlbiB3ZSB2aWV3IFRlc3QuaHRtbCBvdXRzaWRlIG9m IHRoZSB0ZXN0IGhhcm5lc3MuCisKIDIwMTYtMTItMjcgIEJyaWFuIEJ1cmcgIDxiYnVyZ0BhcHBs ZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTihyOTk5NjUpOiBXZWIgSW5zcGVjdG9yOiBsYXJn ZSBpbmxpbmUgc2NyaXB0cyBhbmQgdGV4dCBub2RlcyBhcmUgdHJ1bmNhdGVkIGF0IDEwLDAwMCBj aGFyYWN0ZXJzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9UZXN0L0Zyb250ZW5kVGVzdEhhcm5lc3MuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9UZXN0L0Zyb250ZW5kVGVzdEhhcm5lc3MuanMKaW5kZXggNzUwNGFhNGU2ZTQ3 ZmNhZjJlYzZmNDhjMTM0YzAyNzUzOTI2ODYzMC4uZDA3OGJlOTQ0OTY0YTYwMGVhNGEyOWQyOWRh MDJkNTMwMTA0YzIxYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVGVzdC9Gcm9udGVuZFRlc3RIYXJuZXNzLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1Rlc3QvRnJvbnRlbmRUZXN0SGFybmVzcy5qcwpAQCAtMTk1LDcg KzE5NSw3IEBAIEZyb250ZW5kVGVzdEhhcm5lc3MgPSBjbGFzcyBGcm9udGVuZFRlc3RIYXJuZXNz IGV4dGVuZHMgVGVzdEhhcm5lc3MKIAogICAgICAgICAvLyBJZiB0aGUgY29ubmVjdGlvbiB0byB0 aGUgdGVzdCBwYWdlIGlzIG5vdCBzZXQgdXAsIHRoZW4ganVzdCBkdW1wIHRvIGNvbnNvbGUgYW5k IGdpdmUgdXAuCiAgICAgICAgIC8vIEVycm9ycyBlbmNvdW50ZXJlZCB0aGlzIGVhcmx5IGNhbiBi ZSBkZWJ1Z2dlZCBieSBsb2FkaW5nIFRlc3QuaHRtbCBpbiBhIG5vcm1hbCBicm93c2VyIHBhZ2Uu Ci0gICAgICAgIGlmICh0aGlzLl9vcmlnaW5hbENvbnNvbGUgJiYgKCFJbnNwZWN0b3JGcm9udGVu ZEhvc3QgfHwgIUluc3BlY3RvckJhY2tlbmQpKSB7CisgICAgICAgIGlmICh0aGlzLl9vcmlnaW5h bENvbnNvbGUgJiYgIXRoaXMuX3Rlc3RQYWdlSGFzTG9hZGVkKCkpIHsKICAgICAgICAgICAgIHRo aXMuX29yaWdpbmFsQ29uc29sZVsiZXJyb3IiXShyZXN1bHQpOwogICAgICAgICAgICAgcmV0dXJu IGZhbHNlOwogICAgICAgICB9CkBAIC0yMDgsNiArMjA4LDExIEBAIEZyb250ZW5kVGVzdEhhcm5l c3MgPSBjbGFzcyBGcm9udGVuZFRlc3RIYXJuZXNzIGV4dGVuZHMgVGVzdEhhcm5lc3MKIAogICAg IC8vIFByaXZhdGUKIAorICAgIF90ZXN0UGFnZUhhc0xvYWRlZCgpCisgICAgeworICAgICAgICBy ZXR1cm4gc2VsZi5fc2hvdWxkUmVzZW5kUmVzdWx0czsKKyAgICB9CisKICAgICBfcmVzZW5kUmVz dWx0cygpCiAgICAgewogICAgICAgICBjb25zb2xlLmFzc2VydCh0aGlzLl9zaG91bGRSZXNlbmRS ZXN1bHRzKTsK