166539 2016-12-28 10:06:38 -0800 GraphicsContextCairo: setMiterLimit() is missing the DisplayListRecorder diversion 2017-01-01 08:47:37 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan oldest_to_newest 1262947 0 zan 2016-12-28 10:06:38 -0800 GraphicsContextCairo: setMiterLimit() is missing the DisplayListRecorder diversion 1262949 1 297815 zan 2016-12-28 10:12:42 -0800 Created attachment 297815 Patch 1262955 2 297815 mcatanzaro 2016-12-28 11:12:21 -0800 Comment on attachment 297815 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297815&action=review The amount of code duplication between these classes is quite worrisome. Things are just going to get desynced again in the future. :/ > Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:1021 > + m_displayListRecorder->setMiterLimit(limit); EWS is red: limit was not declared in this scope. The parameter is named differently here than in GraphicsContextCG. 1263229 3 zan 2017-01-01 08:08:52 -0800 (In reply to comment #2) > Comment on attachment 297815 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=297815&action=review > > The amount of code duplication between these classes is quite worrisome. > Things are just going to get desynced again in the future. :/ > True, maybe a recording-specific GraphicsContext class could work. > > Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:1021 > > + m_displayListRecorder->setMiterLimit(limit); > > EWS is red: limit was not declared in this scope. The parameter is named > differently here than in GraphicsContextCG. Oops! 1263231 4 297873 zan 2017-01-01 08:13:25 -0800 Created attachment 297873 Patch for landing 1263235 5 297873 zan 2017-01-01 08:47:29 -0800 Comment on attachment 297873 Patch for landing Clearing flags on attachment: 297873 Committed r210220: <http://trac.webkit.org/changeset/210220> 1263236 6 zan 2017-01-01 08:47:37 -0800 All reviewed patches have been landed. Closing bug. 297815 2016-12-28 10:12:42 -0800 2017-01-01 08:13:18 -0800 Patch bug-166539-20161228101127.patch text/plain 1584 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMjEwMjAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzgzNzQzZWVkYTgyNTNk NDZiNzg2MDk0YzdjNTFkZTgyNTQxNTc1Yy4uYmJmODYzZWVhNmEzZDQxOTc3OGFiZmYyMDcyNTFh MjYyYTI1ZmE1YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE2LTEyLTI4ICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBHcmFwaGljc0NvbnRl eHRDYWlybzogc2V0TWl0ZXJMaW1pdCgpIGlzIG1pc3NpbmcgdGhlIERpc3BsYXlMaXN0UmVjb3Jk ZXIgZGl2ZXJzaW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNjY1MzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dENhaXJvLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDo6c2V0TWl0ZXJMaW1pdCk6IENhbGwg dGhlIHNldE1pdGVyTGltaXQoKSBtZXRob2Qgb24gdGhlCisgICAgICAgIG1fZGlzcGxheUxpc3RS ZWNvcmRlciBvYmplY3Qgd2hlbiB0aGUgR3JhcGhpY3NDb250ZXh0IG9iamVjdCBpcyBpbiByZWNv cmRpbmcgbW9kZS4KKwogMjAxNi0xMi0wOSAgU2VyZ2lvIFZpbGxhciBTZW5pbiAgPHN2aWxsYXJA aWdhbGlhLmNvbT4KIAogICAgICAgICBbY3NzLWdyaWRdIE1vdmUgR3JpZCBpbnRvIEdyaWRTaXpp bmdEYXRhCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWly by9HcmFwaGljc0NvbnRleHRDYWlyby5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9jYWlyby9HcmFwaGljc0NvbnRleHRDYWlyby5jcHAKaW5kZXggYTIwYmYyMWU2ZDE3NzFh YjUwNGIxNDgxNTQ1YzAwNTMxNTcwZjkxMS4uNTI1NGE3MTk4ZTYzNmMzM2Q4ZTBiODdjMjIxZmUw M2JjM2E2ZTgyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Y2Fpcm8vR3JhcGhpY3NDb250ZXh0Q2Fpcm8uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dENhaXJvLmNwcApAQCAtMTAxNiw2ICsx MDE2LDEyIEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0OjpzZXRNaXRlckxpbWl0KGZsb2F0IG1pdGVy KQogICAgIGlmIChwYWludGluZ0Rpc2FibGVkKCkpCiAgICAgICAgIHJldHVybjsKIAorICAgIGlm IChpc1JlY29yZGluZygpKSB7CisgICAgICAgIC8vIE1heWJlIHRoaXMgc2hvdWxkIGJlIHBhcnQg b2YgdGhlIHN0YXRlLgorICAgICAgICBtX2Rpc3BsYXlMaXN0UmVjb3JkZXItPnNldE1pdGVyTGlt aXQobGltaXQpOworICAgICAgICByZXR1cm47CisgICAgfQorCiAgICAgY2Fpcm9fc2V0X21pdGVy X2xpbWl0KHBsYXRmb3JtQ29udGV4dCgpLT5jcigpLCBtaXRlcik7CiB9CiAK 297873 2017-01-01 08:13:25 -0800 2017-01-01 08:13:25 -0800 Patch for landing bug-166539-20170101171203.patch text/plain 1478 zan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMDIxOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE3LTAxLTAxICBaYW4gRG9i ZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBHcmFwaGljc0NvbnRleHRD YWlybzogc2V0TWl0ZXJMaW1pdCgpIGlzIG1pc3NpbmcgdGhlIERpc3BsYXlMaXN0UmVjb3JkZXIg ZGl2ZXJzaW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNjY1MzkKKworICAgICAgICBSZXZpZXdlZCBieSBNaWNoYWVsIENhdGFuemFyby4KKworICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dENhaXJvLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDo6c2V0TWl0ZXJMaW1pdCk6IENhbGwg dGhlIHNldE1pdGVyTGltaXQoKSBtZXRob2Qgb24gdGhlCisgICAgICAgIG1fZGlzcGxheUxpc3RS ZWNvcmRlciBvYmplY3Qgd2hlbiB0aGUgR3JhcGhpY3NDb250ZXh0IG9iamVjdCBpcyBpbiByZWNv cmRpbmcgbW9kZS4KKwogMjAxNi0xMi0zMSAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJv QGlnYWxpYS5jb20+CiAKICAgICAgICAgU2VjdXJpdHlPcmlnaW46OmNyZWF0ZSB0cmlwbGV0IGNv bnN0cnVjdG9yIGRvZXMgbm90IGNhbm9uaWNhbGl6ZSBwb3J0CkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHRDYWlyby5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3ND b250ZXh0Q2Fpcm8uY3BwCShyZXZpc2lvbiAyMTAyMTgpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHRDYWlyby5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTEwMTYsNiArMTAxNiwxMiBAQCB2b2lkIEdyYXBoaWNzQ29udGV4dDo6c2V0TWl0ZXJM aW1pdChmbG9hCiAgICAgaWYgKHBhaW50aW5nRGlzYWJsZWQoKSkKICAgICAgICAgcmV0dXJuOwog CisgICAgaWYgKGlzUmVjb3JkaW5nKCkpIHsKKyAgICAgICAgLy8gTWF5YmUgdGhpcyBzaG91bGQg YmUgcGFydCBvZiB0aGUgc3RhdGUuCisgICAgICAgIG1fZGlzcGxheUxpc3RSZWNvcmRlci0+c2V0 TWl0ZXJMaW1pdChtaXRlcik7CisgICAgICAgIHJldHVybjsKKyAgICB9CisKICAgICBjYWlyb19z ZXRfbWl0ZXJfbGltaXQocGxhdGZvcm1Db250ZXh0KCktPmNyKCksIG1pdGVyKTsKIH0KIAo=