166492 2016-12-27 10:31:43 -0800 [GTK] WebCore/CSSParser unit test is not being built 2017-01-02 08:42:10 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rego rego bugs-noreply cgarcia commit-queue jfernandez rego svillar oldest_to_newest 1262824 0 rego 2016-12-27 10:31:43 -0800 This test was introduced in bug #136217 (r175930). https://trac.webkit.org/changeset/r175930 But just the day after, as it was causing issues to build GTK+ port the unit test was removed from the CMake file so it's not build anymore since then (r176015). https://trac.webkit.org/changeset/176015 1262825 1 rego 2016-12-27 10:32:13 -0800 We should build this test in GTK+ too, but something like this is not enough: diff --git a/Tools/TestWebKitAPI/PlatformGTK.cmake b/Tools/TestWebKitAPI/PlatformGTK.cmake index 639d197c070..0bb8cdb4ac9 100644 --- a/Tools/TestWebKitAPI/PlatformGTK.cmake +++ b/Tools/TestWebKitAPI/PlatformGTK.cmake @@ -129,6 +129,7 @@ set_target_properties(TestWebKit2 PROPERTIES RUNTIME_OUTPUT_DIRECTORY ${TESTWEBK add_executable(TestWebCore ${test_main_SOURCES} ${TESTWEBKITAPI_DIR}/TestsController.cpp + ${TESTWEBKITAPI_DIR}/Tests/WebCore/CSSParser.cpp ${TESTWEBKITAPI_DIR}/Tests/WebCore/FileSystem.cpp ${TESTWEBKITAPI_DIR}/Tests/WebCore/HTMLParserIdioms.cpp ${TESTWEBKITAPI_DIR}/Tests/WebCore/LayoutUnit.cpp I'm getting some linking errors: http://sprunge.us/gBeQ 1262897 2 297800 rego 2016-12-28 01:56:31 -0800 Created attachment 297800 Patch 1262899 3 297800 cgarcia 2016-12-28 02:03:38 -0800 Comment on attachment 297800 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297800&action=review > Tools/TestWebKitAPI/PlatformGTK.cmake:56 > + WebKit2 Why do you need to link to WebKit2 for WebCore tests? I know you need this to avoid the linking issues you mentioned, but the thing is why you get linking issues. 1262904 4 297800 rego 2016-12-28 04:50:43 -0800 Comment on attachment 297800 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297800&action=review >> Tools/TestWebKitAPI/PlatformGTK.cmake:56 >> + WebKit2 > > Why do you need to link to WebKit2 for WebCore tests? I know you need this to avoid the linking issues you mentioned, but the thing is why you get linking issues. This was the way to fix the linking error, but I'm not sure where is the real problem. I see that if we call the following method we got the linking error: RuntimeEnabledFeatures& RuntimeEnabledFeatures::sharedFeatures() { static NeverDestroyed<RuntimeEnabledFeatures> runtimeEnabledFeatures; return runtimeEnabledFeatures; } Any idea is welcomed. :-) 1262953 5 297800 mcatanzaro 2016-12-28 10:57:26 -0800 Comment on attachment 297800 Patch Like Carlos says, this is a layering violation. All the missing symbols are in WebCore anyway, so linking to WebKit2 doesn't make sense; that's only fixing the problem because WebKit2 happens to link to the missing library. We need to figure out what's really wrong. Try linking to WebCore in addition to WebCorePlatformGTK, does that fix it? 1263024 6 rego 2016-12-29 00:43:19 -0800 (In reply to comment #5) > Try linking to WebCore in addition to WebCorePlatformGTK, does that fix it? No, I already tried that. Let's see if I manage to find what's going on... 1263285 7 297891 rego 2017-01-02 04:21:53 -0800 Created attachment 297891 Patch 1263286 8 rego 2017-01-02 04:23:01 -0800 It seems the issue is also fixed if we use "ADD_WHOLE_ARCHIVE_TO_LIBRARIES". What do you think about this approach? 1263312 9 297891 mcatanzaro 2017-01-02 08:15:03 -0800 Comment on attachment 297891 Patch Yeah this looks better! 1263315 10 297891 commit-queue 2017-01-02 08:42:06 -0800 Comment on attachment 297891 Patch Clearing flags on attachment: 297891 Committed r210225: <http://trac.webkit.org/changeset/210225> 1263316 11 commit-queue 2017-01-02 08:42:10 -0800 All reviewed patches have been landed. Closing bug. 297800 2016-12-28 01:56:31 -0800 2017-01-02 04:21:47 -0800 Patch bug-166492-20161228105517.patch text/plain 1816 rego U3VidmVyc2lvbiBSZXZpc2lvbjogMjEwMTUzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzEyZWEzNmZjMjdhMDc5ODFkMjg5Yzg5NDk3MTE1NWMx YjBmYzNlOC4uMzE4YTZkYjRmYmViNDM0YmI2ODdiYzFhNjA3ZTVhYmE3MTAzOTNmOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE2LTEyLTI4ICBNYW51ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIFdlYkNvcmUvQ1NTUGFyc2VyIHVuaXQgdGVzdCBpcyBub3QgYmVp bmcgYnVpbHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE2NjQ5MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFRoaXMgdGVzdCB3YXMgaW50cm9kdWNlZCBpbiByMTc1OTMwLCBidXQgd2Ugd2VyZSBub3QgYnVp bGRpbmcKKyAgICAgICAgaXQgb24gR1RLKyBwb3J0IHNpbmNlIHIxNzYwMTUuCisgICAgICAgIFRo aXMgcGF0Y2ggbWFya3MgdGhlIHRlc3QgdG8gYmUgYnVpbHQgYWdhaW4gb24gR1RLKy4KKyAgICAg ICAgSkZUUiwgdGhlIHRlc3QgaXMgcGFzc2luZyByaWdodCBub3cuCisKKyAgICAgICAgKiBUZXN0 V2ViS2l0QVBJL1BsYXRmb3JtR1RLLmNtYWtlOiBBZGQgQ1NTUGFyc2VyLmNwcCB0ZXN0IGZpbGUg YW5kIFdlYktpdDIKKyAgICAgICAgdG8gYXZvaWQgbGlua2luZyBlcnJvcnMuCisKIDIwMTYtMTIt MjMgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgUkVH UkVTU0lPTiAocjIwOTI5OSk6IFNlbGVjdGlvbiBpcyBicm9rZW4gd2hlbiB5b3Ugem9vbSBpbiB3 ZWJwYWdlIHVzaW5nIHRyYWNrcGFkCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Bs YXRmb3JtR1RLLmNtYWtlIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9QbGF0Zm9ybUdUSy5jbWFrZQpp bmRleCA2MzlkMTk3YzA3MDdlYmZhYTY5ZTc4MmZjM2UzZWZhMTA2NWZjZGE5Li4wMThmYWI0YTgx ZmIxMTFlM2UwYjc2M2VkZGE5ZjViNjY5ZDU2MGJkIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2Vi S2l0QVBJL1BsYXRmb3JtR1RLLmNtYWtlCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvUGxhdGZv cm1HVEsuY21ha2UKQEAgLTUzLDYgKzUzLDcgQEAgbGlzdChBUFBFTkQgdGVzdF93ZWJraXQyX2Fw aV9MSUJSQVJJRVMKIAogbGlzdChBUFBFTkQgdGVzdF93ZWJjb3JlX0xJQlJBUklFUwogICAgIFdl YkNvcmVQbGF0Zm9ybUdUSworICAgIFdlYktpdDIKICAgICAke0dESzNfTElCUkFSSUVTfQogICAg ICR7R1RLM19MSUJSQVJJRVN9CiApCkBAIC0xMjksNiArMTMwLDcgQEAgc2V0X3RhcmdldF9wcm9w ZXJ0aWVzKFRlc3RXZWJLaXQyIFBST1BFUlRJRVMgUlVOVElNRV9PVVRQVVRfRElSRUNUT1JZICR7 VEVTVFdFQksKIGFkZF9leGVjdXRhYmxlKFRlc3RXZWJDb3JlCiAgICAgJHt0ZXN0X21haW5fU09V UkNFU30KICAgICAke1RFU1RXRUJLSVRBUElfRElSfS9UZXN0c0NvbnRyb2xsZXIuY3BwCisgICAg JHtURVNUV0VCS0lUQVBJX0RJUn0vVGVzdHMvV2ViQ29yZS9DU1NQYXJzZXIuY3BwCiAgICAgJHtU RVNUV0VCS0lUQVBJX0RJUn0vVGVzdHMvV2ViQ29yZS9GaWxlU3lzdGVtLmNwcAogICAgICR7VEVT VFdFQktJVEFQSV9ESVJ9L1Rlc3RzL1dlYkNvcmUvSFRNTFBhcnNlcklkaW9tcy5jcHAKICAgICAk e1RFU1RXRUJLSVRBUElfRElSfS9UZXN0cy9XZWJDb3JlL0xheW91dFVuaXQuY3BwCg== 297891 2017-01-02 04:21:53 -0800 2017-01-02 08:42:06 -0800 Patch bug-166492-20170102132030.patch text/plain 1882 rego U3VidmVyc2lvbiBSZXZpc2lvbjogMjEwMTUzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzEyZWEzNmZjMjdhMDc5ODFkMjg5Yzg5NDk3MTE1NWMx YjBmYzNlOC4uZTY3M2YwMjZiMTk3NjYzOWE1YTVmMTdmYjA5ZTZhODUzYzc2N2VjOSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE2LTEyLTI4ICBNYW51ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIFdlYkNvcmUvQ1NTUGFyc2VyIHVuaXQgdGVzdCBpcyBub3QgYmVp bmcgYnVpbHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE2NjQ5MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFRoaXMgdGVzdCB3YXMgaW50cm9kdWNlZCBpbiByMTc1OTMwLCBidXQgd2Ugd2VyZSBub3QgYnVp bGRpbmcKKyAgICAgICAgaXQgb24gR1RLKyBwb3J0IHNpbmNlIHIxNzYwMTUuCisgICAgICAgIFRo aXMgcGF0Y2ggbWFya3MgdGhlIHRlc3QgdG8gYmUgYnVpbHQgYWdhaW4gb24gR1RLKy4KKyAgICAg ICAgSkZUUiwgdGhlIHRlc3QgaXMgcGFzc2luZyByaWdodCBub3cuCisKKyAgICAgICAgKiBUZXN0 V2ViS2l0QVBJL1BsYXRmb3JtR1RLLmNtYWtlOiBBZGQgQ1NTUGFyc2VyLmNwcCB0ZXN0IGZpbGUg YW5kIHVzZQorICAgICAgICBBRERfV0hPTEVfQVJDSElWRV9UT19MSUJSQVJJRVMgdG8gYXZvaWQg bGlua2luZyBlcnJvcnMuCisKIDIwMTYtMTItMjMgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNl ckBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjIwOTI5OSk6IFNlbGVjdGlvbiBp cyBicm9rZW4gd2hlbiB5b3Ugem9vbSBpbiB3ZWJwYWdlIHVzaW5nIHRyYWNrcGFkCmRpZmYgLS1n aXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1BsYXRmb3JtR1RLLmNtYWtlIGIvVG9vbHMvVGVzdFdl YktpdEFQSS9QbGF0Zm9ybUdUSy5jbWFrZQppbmRleCA2MzlkMTk3YzA3MDdlYmZhYTY5ZTc4MmZj M2UzZWZhMTA2NWZjZGE5Li44MGMwZjUwMzliMGJiOTBlNmVmMDE2ZjE0NmU1YmNkNTIyYjk2OGE5 IDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1BsYXRmb3JtR1RLLmNtYWtlCisrKyBi L1Rvb2xzL1Rlc3RXZWJLaXRBUEkvUGxhdGZvcm1HVEsuY21ha2UKQEAgLTU2LDYgKzU2LDcgQEAg bGlzdChBUFBFTkQgdGVzdF93ZWJjb3JlX0xJQlJBUklFUwogICAgICR7R0RLM19MSUJSQVJJRVN9 CiAgICAgJHtHVEszX0xJQlJBUklFU30KICkKK0FERF9XSE9MRV9BUkNISVZFX1RPX0xJQlJBUklF Uyh0ZXN0X3dlYmNvcmVfTElCUkFSSUVTKQogCiBsaXN0KEFQUEVORCBUZXN0V2ViS2l0QVBJX0xJ QlJBUklFUwogICAgICR7R0RLM19MSUJSQVJJRVN9CkBAIC0xMjksNiArMTMwLDcgQEAgc2V0X3Rh cmdldF9wcm9wZXJ0aWVzKFRlc3RXZWJLaXQyIFBST1BFUlRJRVMgUlVOVElNRV9PVVRQVVRfRElS RUNUT1JZICR7VEVTVFdFQksKIGFkZF9leGVjdXRhYmxlKFRlc3RXZWJDb3JlCiAgICAgJHt0ZXN0 X21haW5fU09VUkNFU30KICAgICAke1RFU1RXRUJLSVRBUElfRElSfS9UZXN0c0NvbnRyb2xsZXIu Y3BwCisgICAgJHtURVNUV0VCS0lUQVBJX0RJUn0vVGVzdHMvV2ViQ29yZS9DU1NQYXJzZXIuY3Bw CiAgICAgJHtURVNUV0VCS0lUQVBJX0RJUn0vVGVzdHMvV2ViQ29yZS9GaWxlU3lzdGVtLmNwcAog ICAgICR7VEVTVFdFQktJVEFQSV9ESVJ9L1Rlc3RzL1dlYkNvcmUvSFRNTFBhcnNlcklkaW9tcy5j cHAKICAgICAke1RFU1RXRUJLSVRBUElfRElSfS9UZXN0cy9XZWJDb3JlL0xheW91dFVuaXQuY3Bw Cg==