166490 2016-12-27 10:19:47 -0800 WebAssembly: Don't allow duplicate export names 2016-12-29 08:51:17 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov jfbastien keith_miller mark.lam msaboff oliver ticaiolima webkit-bug-importer ysuzuki oldest_to_newest 1262818 0 saam 2016-12-27 10:19:47 -0800 ... 1262823 1 webkit-bug-importer 2016-12-27 10:30:34 -0800 <rdar://problem/29815000> 1262826 2 saam 2016-12-27 10:34:10 -0800 Looks like this requires my grow_memory patch to fix the test which fixes creating memory w/ initial size of zero. 1262999 3 297816 saam 2016-12-28 16:31:03 -0800 Created attachment 297816 patch 1263002 4 297816 keith_miller 2016-12-28 18:39:25 -0800 Comment on attachment 297816 patch r=me. 1263003 5 297816 commit-queue 2016-12-28 19:10:54 -0800 Comment on attachment 297816 patch Clearing flags on attachment: 297816 Committed r210203: <http://trac.webkit.org/changeset/210203> 1263004 6 commit-queue 2016-12-28 19:11:00 -0800 All reviewed patches have been landed. Closing bug. 1263057 7 jfbastien 2016-12-29 08:51:17 -0800 Hmm, I find this surprising since duplicates aren't useful but are also harmless. I filed a PR in the design repo to add this restriction: https://github.com/WebAssembly/design/pull/932 It seems silly to restrict when overwrite semantics is clear and requires less work. In any case, this is a good PR to follow the spec, a nice corner case, and reversing polarity is easy in the future. 297816 2016-12-28 16:31:03 -0800 2016-12-28 19:10:54 -0800 patch b-backup.diff text/plain 3974 saam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMTAyMDIpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE0IEBACisyMDE2LTEyLTI4ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgorCisgICAgICAgIFdlYkFzc2VtYmx5OiBEb24ndCBhbGxvdyBkdXBsaWNhdGUgZXhwb3J0 IG5hbWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NjY0OTAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI5ODE1MDAwPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd2FzbS55YW1sOgorICAgICAgICAq IHdhc20vZnVuY3Rpb24tdGVzdHMvaW52YWxpZC1kdXBsaWNhdGUtZXhwb3J0LmpzOiBBZGRlZC4K KwogMjAxNi0xMi0yOCAgU2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KIAogICAgICAg ICBXZWJBc3NlbWJseTogSW1wbGVtZW50IGdyb3dfbWVtb3J5IGFuZCBjdXJyZW50X21lbW9yeQpJ bmRleDogSlNUZXN0cy93YXNtLnlhbWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSlNUZXN0cy93YXNtLnlhbWwJ KHJldmlzaW9uIDIxMDIwMikKKysrIEpTVGVzdHMvd2FzbS55YW1sCSh3b3JraW5nIGNvcHkpCkBA IC02OCw3ICs2OCw3IEBACiAgIGNtZDogcnVuV2ViQXNzZW1ibHlTcGVjVGVzdCA6bm9ybWFsCiAK IC0gcGF0aDogd2FzbS9zcGVjLXRlc3RzL2V4cG9ydHMud2FzdC5qcwotICBjbWQ6IHJ1bldlYkFz c2VtYmx5U3BlY1Rlc3QgOnNraXAKKyAgY21kOiBydW5XZWJBc3NlbWJseVNwZWNUZXN0IDpub3Jt YWwKIAogLSBwYXRoOiB3YXNtL3NwZWMtdGVzdHMvZjMyLndhc3QuanMKICAgY21kOiBydW5XZWJB c3NlbWJseVNwZWNUZXN0IDpub3JtYWwKSW5kZXg6IEpTVGVzdHMvd2FzbS9mdW5jdGlvbi10ZXN0 cy9pbnZhbGlkLWR1cGxpY2F0ZS1leHBvcnQuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSlNUZXN0cy93YXNt L2Z1bmN0aW9uLXRlc3RzL2ludmFsaWQtZHVwbGljYXRlLWV4cG9ydC5qcwkobm9uZXhpc3RlbnQp CisrKyBKU1Rlc3RzL3dhc20vZnVuY3Rpb24tdGVzdHMvaW52YWxpZC1kdXBsaWNhdGUtZXhwb3J0 LmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMTkgQEAKK2ltcG9ydCBCdWlsZGVyIGZyb20g Jy4uL0J1aWxkZXIuanMnOworaW1wb3J0ICogYXMgYXNzZXJ0IGZyb20gJy4uL2Fzc2VydC5qcyc7 CisKK3sKKyAgICBjb25zdCBidWlsZGVyID0gKG5ldyBCdWlsZGVyKCkpCisgICAgICAgIC5UeXBl KCkuRW5kKCkKKyAgICAgICAgLkZ1bmN0aW9uKCkuRW5kKCkKKyAgICAgICAgLkV4cG9ydCgpCisg ICAgICAgICAgICAuRnVuY3Rpb24oImZvbyIpCisgICAgICAgICAgICAuRnVuY3Rpb24oImZvbyIp CisgICAgICAgIC5FbmQoKQorICAgICAgICAuQ29kZSgpCisgICAgICAgICAgICAuRnVuY3Rpb24o ImZvbyIsIHtwYXJhbXM6IFtdLCByZXQ6ICJ2b2lkIn0pCisgICAgICAgICAgICAuRW5kKCkKKyAg ICAgICAgLkVuZCgpOworCisgICAgY29uc3QgYmluID0gYnVpbGRlci5XZWJBc3NlbWJseSgpLmdl dCgpOworICAgIGFzc2VydC50aHJvd3MoKCkgPT4gbmV3IFdlYkFzc2VtYmx5Lk1vZHVsZShiaW4p LCBXZWJBc3NlbWJseS5Db21waWxlRXJyb3IsICJXZWJBc3NlbWJseS5Nb2R1bGUgZG9lc24ndCBw YXJzZSBhdCBieXRlIDMxIC8gMzk6IGR1cGxpY2F0ZSBleHBvcnQ6ICdmb28nIik7Cit9CkluZGV4 OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMDIwMikKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAx Ni0xMi0yOCAgU2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KKworICAgICAgICBXZWJB c3NlbWJseTogRG9uJ3QgYWxsb3cgZHVwbGljYXRlIGV4cG9ydCBuYW1lcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY2NDkwCisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS8yOTgxNTAwMD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIHdhc20vV2FzbU1vZHVsZVBhcnNlci5jcHA6CisKIDIwMTYtMTItMjgg IFNhYW0gQmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4g Rml4IGpzYy5jcHAgYnVpbGQgZXJyb3IuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd2Fz bS9XYXNtTW9kdWxlUGFyc2VyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENv cmUvd2FzbS9XYXNtTW9kdWxlUGFyc2VyLmNwcAkocmV2aXNpb24gMjEwMjAyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL3dhc20vV2FzbU1vZHVsZVBhcnNlci5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTM3MSw2ICszNzEsNyBAQCBhdXRvIE1vZHVsZVBhcnNlcjo6cGFyc2VFeHBvcnQoKSAtPiBQ YXJ0CiAgICAgV0FTTV9QQVJTRVJfRkFJTF9JRihleHBvcnRDb3VudCA9PSBzdGQ6Om51bWVyaWNf bGltaXRzPHVpbnQzMl90Pjo6bWF4KCksICJFeHBvcnQgc2VjdGlvbidzIGNvdW50IGlzIHRvbyBi aWcgIiwgZXhwb3J0Q291bnQpOwogICAgIFdBU01fUEFSU0VSX0ZBSUxfSUYoIW1fcmVzdWx0Lm1v ZHVsZS0+ZXhwb3J0cy50cnlSZXNlcnZlQ2FwYWNpdHkoZXhwb3J0Q291bnQpLCAiY2FuJ3QgYWxs b2NhdGUgZW5vdWdoIG1lbW9yeSBmb3IgIiwgZXhwb3J0Q291bnQsICIgZXhwb3J0cyIpOwogCisg ICAgSGFzaFNldDxTdHJpbmc+IGV4cG9ydE5hbWVzOwogICAgIGZvciAodWludDMyX3QgZXhwb3J0 TnVtYmVyID0gMDsgZXhwb3J0TnVtYmVyIDwgZXhwb3J0Q291bnQ7ICsrZXhwb3J0TnVtYmVyKSB7 CiAgICAgICAgIEV4cG9ydCBleHA7CiAgICAgICAgIHVpbnQzMl90IGZpZWxkTGVuOwpAQCAtMzc4 LDYgKzM3OSw4IEBAIGF1dG8gTW9kdWxlUGFyc2VyOjpwYXJzZUV4cG9ydCgpIC0+IFBhcnQKIAog ICAgICAgICBXQVNNX1BBUlNFUl9GQUlMX0lGKCFwYXJzZVZhclVJbnQzMihmaWVsZExlbiksICJj YW4ndCBnZXQgIiwgZXhwb3J0TnVtYmVyLCAidGggRXhwb3J0J3MgZmllbGQgbmFtZSBsZW5ndGgi KTsKICAgICAgICAgV0FTTV9QQVJTRVJfRkFJTF9JRighY29uc3VtZVVURjhTdHJpbmcoZmllbGRT dHJpbmcsIGZpZWxkTGVuKSwgImNhbid0IGdldCAiLCBleHBvcnROdW1iZXIsICJ0aCBFeHBvcnQn cyBmaWVsZCBuYW1lIG9mIGxlbmd0aCAiLCBmaWVsZExlbik7CisgICAgICAgIFdBU01fUEFSU0VS X0ZBSUxfSUYoZXhwb3J0TmFtZXMuY29udGFpbnMoZmllbGRTdHJpbmcpLCAiZHVwbGljYXRlIGV4 cG9ydDogJyIsIGZpZWxkU3RyaW5nLCAiJyIpOworICAgICAgICBleHBvcnROYW1lcy5hZGQoZmll bGRTdHJpbmcpOwogICAgICAgICBleHAuZmllbGQgPSBJZGVudGlmaWVyOjpmcm9tU3RyaW5nKG1f dm0sIGZpZWxkU3RyaW5nKTsKIAogICAgICAgICBXQVNNX1BBUlNFUl9GQUlMX0lGKCFwYXJzZUV4 dGVybmFsS2luZChleHAua2luZCksICJjYW4ndCBnZXQgIiwgZXhwb3J0TnVtYmVyLCAidGggRXhw b3J0J3Mga2luZCwgbmFtZWQgJyIsIGZpZWxkU3RyaW5nLCAiJyIpOwo=