166482 2016-12-26 10:26:46 -0800 Use variadic templates in JSC Parser to clean up 2016-12-26 11:01:45 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ysuzuki ysuzuki commit-queue darin keith_miller mark.lam msaboff saam sam oldest_to_newest 1262752 0 ysuzuki 2016-12-26 10:26:46 -0800 Use variadic templates in JSC Parser to clean up 1262753 1 297769 ysuzuki 2016-12-26 10:27:02 -0800 Created attachment 297769 Patch 1262754 2 297769 saam 2016-12-26 10:34:19 -0800 Comment on attachment 297769 Patch r=me 1262757 3 297769 ysuzuki 2016-12-26 10:36:51 -0800 Comment on attachment 297769 Patch Thanks! 1262760 4 297769 commit-queue 2016-12-26 11:01:41 -0800 Comment on attachment 297769 Patch Clearing flags on attachment: 297769 Committed r210151: <http://trac.webkit.org/changeset/210151> 1262761 5 commit-queue 2016-12-26 11:01:45 -0800 All reviewed patches have been landed. Closing bug. 297769 2016-12-26 10:27:02 -0800 2016-12-26 11:01:41 -0800 Patch bug-166482-20161227032551.patch text/plain 6488 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjEwMTUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 Yjg1MTAxMjI5ZjYxMDQ5MDIyMjYyNzZiMWRlNmVmNGIwMTkyMWFiLi5iOTM3YmQ0MWQ1YmU5NjY2 OTY2YzU3NTg2MzliZDYyNWEyYmIzZWM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxNi0xMi0yNiAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBVc2UgdmFyaWFkaWMgdGVtcGxhdGVzIGluIEpTQyBQYXJzZXIgdG8g Y2xlYW4gdXAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE2NjQ4MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogcGFyc2VyL1BhcnNlci5jcHA6CisgICAgICAgIChKU0M6OlBhcnNlcjxMZXhlclR5cGU+Ojps b2dFcnJvcik6CisgICAgICAgICogcGFyc2VyL1BhcnNlci5oOgorCiAyMDE2LTEyLTI1ICBZdXN1 a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgogCiAgICAgICAgIFByb3BhZ2F0ZSB0 aGUgc291cmNlIG9yaWdpbiBhcyBtdWNoIGFzIHBvc3NpYmxlCmRpZmYgLS1naXQgYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvcGFyc2VyL1BhcnNlci5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv cGFyc2VyL1BhcnNlci5jcHAKaW5kZXggZTU4MmQyZmNlODZmNDdiMjkwNGVhYWFjYzkxM2U2MTZj NmFlMzhkNS4uNjVlYzM4YWE2MGViZThmMjBiZDgxNmI0ZjM3ZjVkZThmNDkzOWRkZiAxMDA2NDQK LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9QYXJzZXIuY3BwCisrKyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFyc2VyLmNwcApAQCAtOTEsOCArOTEsOCBAQCB2b2lk IFBhcnNlcjxMZXhlclR5cGU+Ojpsb2dFcnJvcihib29sKQogICAgIHNldEVycm9yTWVzc2FnZShz dHJlYW0udG9TdHJpbmdXaXRoTGF0aW4xRmFsbGJhY2soKSk7CiB9CiAKLXRlbXBsYXRlIDx0eXBl bmFtZSBMZXhlclR5cGU+IHRlbXBsYXRlIDx0eXBlbmFtZSBBPgotdm9pZCBQYXJzZXI8TGV4ZXJU eXBlPjo6bG9nRXJyb3IoYm9vbCBzaG91bGRQcmludFRva2VuLCBjb25zdCBBJiB2YWx1ZTEpCit0 ZW1wbGF0ZSA8dHlwZW5hbWUgTGV4ZXJUeXBlPiB0ZW1wbGF0ZSA8dHlwZW5hbWUuLi4gQXJncz4K K3ZvaWQgUGFyc2VyPExleGVyVHlwZT46OmxvZ0Vycm9yKGJvb2wgc2hvdWxkUHJpbnRUb2tlbiwg QXJncyYmLi4uIGFyZ3MpCiB7CiAgICAgaWYgKGhhc0Vycm9yKCkpCiAgICAgICAgIHJldHVybjsK QEAgLTEwMSw5MSArMTAxLDcgQEAgdm9pZCBQYXJzZXI8TGV4ZXJUeXBlPjo6bG9nRXJyb3IoYm9v bCBzaG91bGRQcmludFRva2VuLCBjb25zdCBBJiB2YWx1ZTEpCiAgICAgICAgIHByaW50VW5leHBl Y3RlZFRva2VuVGV4dChzdHJlYW0pOwogICAgICAgICBzdHJlYW0ucHJpbnQoIi4gIik7CiAgICAg fQotICAgIHN0cmVhbS5wcmludCh2YWx1ZTEsICIuIik7Ci0gICAgc2V0RXJyb3JNZXNzYWdlKHN0 cmVhbS50b1N0cmluZ1dpdGhMYXRpbjFGYWxsYmFjaygpKTsKLX0KLQotdGVtcGxhdGUgPHR5cGVu YW1lIExleGVyVHlwZT4gdGVtcGxhdGUgPHR5cGVuYW1lIEEsIHR5cGVuYW1lIEI+Ci12b2lkIFBh cnNlcjxMZXhlclR5cGU+Ojpsb2dFcnJvcihib29sIHNob3VsZFByaW50VG9rZW4sIGNvbnN0IEEm IHZhbHVlMSwgY29uc3QgQiYgdmFsdWUyKQotewotICAgIGlmIChoYXNFcnJvcigpKQotICAgICAg ICByZXR1cm47Ci0gICAgU3RyaW5nUHJpbnRTdHJlYW0gc3RyZWFtOwotICAgIGlmIChzaG91bGRQ cmludFRva2VuKSB7Ci0gICAgICAgIHByaW50VW5leHBlY3RlZFRva2VuVGV4dChzdHJlYW0pOwot ICAgICAgICBzdHJlYW0ucHJpbnQoIi4gIik7Ci0gICAgfQotICAgIHN0cmVhbS5wcmludCh2YWx1 ZTEsIHZhbHVlMiwgIi4iKTsKLSAgICBzZXRFcnJvck1lc3NhZ2Uoc3RyZWFtLnRvU3RyaW5nV2l0 aExhdGluMUZhbGxiYWNrKCkpOwotfQotCi10ZW1wbGF0ZSA8dHlwZW5hbWUgTGV4ZXJUeXBlPiB0 ZW1wbGF0ZSA8dHlwZW5hbWUgQSwgdHlwZW5hbWUgQiwgdHlwZW5hbWUgQz4KLXZvaWQgUGFyc2Vy PExleGVyVHlwZT46OmxvZ0Vycm9yKGJvb2wgc2hvdWxkUHJpbnRUb2tlbiwgY29uc3QgQSYgdmFs dWUxLCBjb25zdCBCJiB2YWx1ZTIsIGNvbnN0IEMmIHZhbHVlMykKLXsKLSAgICBpZiAoaGFzRXJy b3IoKSkKLSAgICAgICAgcmV0dXJuOwotICAgIFN0cmluZ1ByaW50U3RyZWFtIHN0cmVhbTsKLSAg ICBpZiAoc2hvdWxkUHJpbnRUb2tlbikgewotICAgICAgICBwcmludFVuZXhwZWN0ZWRUb2tlblRl eHQoc3RyZWFtKTsKLSAgICAgICAgc3RyZWFtLnByaW50KCIuICIpOwotICAgIH0KLSAgICBzdHJl YW0ucHJpbnQodmFsdWUxLCB2YWx1ZTIsIHZhbHVlMywgIi4iKTsKLSAgICBzZXRFcnJvck1lc3Nh Z2Uoc3RyZWFtLnRvU3RyaW5nV2l0aExhdGluMUZhbGxiYWNrKCkpOwotfQotCi10ZW1wbGF0ZSA8 dHlwZW5hbWUgTGV4ZXJUeXBlPiB0ZW1wbGF0ZSA8dHlwZW5hbWUgQSwgdHlwZW5hbWUgQiwgdHlw ZW5hbWUgQywgdHlwZW5hbWUgRD4KLXZvaWQgUGFyc2VyPExleGVyVHlwZT46OmxvZ0Vycm9yKGJv b2wgc2hvdWxkUHJpbnRUb2tlbiwgY29uc3QgQSYgdmFsdWUxLCBjb25zdCBCJiB2YWx1ZTIsIGNv bnN0IEMmIHZhbHVlMywgY29uc3QgRCYgdmFsdWU0KQotewotICAgIGlmIChoYXNFcnJvcigpKQot ICAgICAgICByZXR1cm47Ci0gICAgU3RyaW5nUHJpbnRTdHJlYW0gc3RyZWFtOwotICAgIGlmIChz aG91bGRQcmludFRva2VuKSB7Ci0gICAgICAgIHByaW50VW5leHBlY3RlZFRva2VuVGV4dChzdHJl YW0pOwotICAgICAgICBzdHJlYW0ucHJpbnQoIi4gIik7Ci0gICAgfQotICAgIHN0cmVhbS5wcmlu dCh2YWx1ZTEsIHZhbHVlMiwgdmFsdWUzLCB2YWx1ZTQsICIuIik7Ci0gICAgc2V0RXJyb3JNZXNz YWdlKHN0cmVhbS50b1N0cmluZ1dpdGhMYXRpbjFGYWxsYmFjaygpKTsKLX0KLQotdGVtcGxhdGUg PHR5cGVuYW1lIExleGVyVHlwZT4gdGVtcGxhdGUgPHR5cGVuYW1lIEEsIHR5cGVuYW1lIEIsIHR5 cGVuYW1lIEMsIHR5cGVuYW1lIEQsIHR5cGVuYW1lIEU+Ci12b2lkIFBhcnNlcjxMZXhlclR5cGU+ Ojpsb2dFcnJvcihib29sIHNob3VsZFByaW50VG9rZW4sIGNvbnN0IEEmIHZhbHVlMSwgY29uc3Qg QiYgdmFsdWUyLCBjb25zdCBDJiB2YWx1ZTMsIGNvbnN0IEQmIHZhbHVlNCwgY29uc3QgRSYgdmFs dWU1KQotewotICAgIGlmIChoYXNFcnJvcigpKQotICAgICAgICByZXR1cm47Ci0gICAgU3RyaW5n UHJpbnRTdHJlYW0gc3RyZWFtOwotICAgIGlmIChzaG91bGRQcmludFRva2VuKSB7Ci0gICAgICAg IHByaW50VW5leHBlY3RlZFRva2VuVGV4dChzdHJlYW0pOwotICAgICAgICBzdHJlYW0ucHJpbnQo Ii4gIik7Ci0gICAgfQotICAgIHN0cmVhbS5wcmludCh2YWx1ZTEsIHZhbHVlMiwgdmFsdWUzLCB2 YWx1ZTQsIHZhbHVlNSwgIi4iKTsKLSAgICBzZXRFcnJvck1lc3NhZ2Uoc3RyZWFtLnRvU3RyaW5n V2l0aExhdGluMUZhbGxiYWNrKCkpOwotfQotCi10ZW1wbGF0ZSA8dHlwZW5hbWUgTGV4ZXJUeXBl PiB0ZW1wbGF0ZSA8dHlwZW5hbWUgQSwgdHlwZW5hbWUgQiwgdHlwZW5hbWUgQywgdHlwZW5hbWUg RCwgdHlwZW5hbWUgRSwgdHlwZW5hbWUgRj4KLXZvaWQgUGFyc2VyPExleGVyVHlwZT46OmxvZ0Vy cm9yKGJvb2wgc2hvdWxkUHJpbnRUb2tlbiwgY29uc3QgQSYgdmFsdWUxLCBjb25zdCBCJiB2YWx1 ZTIsIGNvbnN0IEMmIHZhbHVlMywgY29uc3QgRCYgdmFsdWU0LCBjb25zdCBFJiB2YWx1ZTUsIGNv bnN0IEYmIHZhbHVlNikKLXsKLSAgICBpZiAoaGFzRXJyb3IoKSkKLSAgICAgICAgcmV0dXJuOwot ICAgIFN0cmluZ1ByaW50U3RyZWFtIHN0cmVhbTsKLSAgICBpZiAoc2hvdWxkUHJpbnRUb2tlbikg ewotICAgICAgICBwcmludFVuZXhwZWN0ZWRUb2tlblRleHQoc3RyZWFtKTsKLSAgICAgICAgc3Ry ZWFtLnByaW50KCIuICIpOwotICAgIH0KLSAgICBzdHJlYW0ucHJpbnQodmFsdWUxLCB2YWx1ZTIs IHZhbHVlMywgdmFsdWU0LCB2YWx1ZTUsIHZhbHVlNiwgIi4iKTsKLSAgICBzZXRFcnJvck1lc3Nh Z2Uoc3RyZWFtLnRvU3RyaW5nV2l0aExhdGluMUZhbGxiYWNrKCkpOwotfQotCi10ZW1wbGF0ZSA8 dHlwZW5hbWUgTGV4ZXJUeXBlPiB0ZW1wbGF0ZSA8dHlwZW5hbWUgQSwgdHlwZW5hbWUgQiwgdHlw ZW5hbWUgQywgdHlwZW5hbWUgRCwgdHlwZW5hbWUgRSwgdHlwZW5hbWUgRiwgdHlwZW5hbWUgRz4K LXZvaWQgUGFyc2VyPExleGVyVHlwZT46OmxvZ0Vycm9yKGJvb2wgc2hvdWxkUHJpbnRUb2tlbiwg Y29uc3QgQSYgdmFsdWUxLCBjb25zdCBCJiB2YWx1ZTIsIGNvbnN0IEMmIHZhbHVlMywgY29uc3Qg RCYgdmFsdWU0LCBjb25zdCBFJiB2YWx1ZTUsIGNvbnN0IEYmIHZhbHVlNiwgY29uc3QgRyYgdmFs dWU3KQotewotICAgIGlmIChoYXNFcnJvcigpKQotICAgICAgICByZXR1cm47Ci0gICAgU3RyaW5n UHJpbnRTdHJlYW0gc3RyZWFtOwotICAgIGlmIChzaG91bGRQcmludFRva2VuKSB7Ci0gICAgICAg IHByaW50VW5leHBlY3RlZFRva2VuVGV4dChzdHJlYW0pOwotICAgICAgICBzdHJlYW0ucHJpbnQo Ii4gIik7Ci0gICAgfQotICAgIHN0cmVhbS5wcmludCh2YWx1ZTEsIHZhbHVlMiwgdmFsdWUzLCB2 YWx1ZTQsIHZhbHVlNSwgdmFsdWU2LCB2YWx1ZTcsICIuIik7CisgICAgc3RyZWFtLnByaW50KHN0 ZDo6Zm9yd2FyZDxBcmdzPihhcmdzKS4uLiwgIi4iKTsKICAgICBzZXRFcnJvck1lc3NhZ2Uoc3Ry ZWFtLnRvU3RyaW5nV2l0aExhdGluMUZhbGxiYWNrKCkpOwogfQogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1BhcnNlci5oIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L3BhcnNlci9QYXJzZXIuaAppbmRleCA5NzQ4OGI2OGIxMTNiY2RlYzZjZmNkNGRhNmY1ZDliZmUx NDAxMDllLi4wNzliY2RkMmJlYjlhNGExMTdmYTU2MzZjYmMxN2ZkZGQyNTkyNDNkIDEwMDY0NAot LS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1BhcnNlci5oCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFyc2VyLmgKQEAgLTEzODEsMTMgKzEzODEsOCBAQCBjbGFz cyBQYXJzZXIgewogICAgIH0KICAgICAKICAgICBORVZFUl9JTkxJTkUgdm9pZCBsb2dFcnJvcihi b29sKTsKLSAgICB0ZW1wbGF0ZSA8dHlwZW5hbWUgQT4gTkVWRVJfSU5MSU5FIHZvaWQgbG9nRXJy b3IoYm9vbCwgY29uc3QgQSYpOwotICAgIHRlbXBsYXRlIDx0eXBlbmFtZSBBLCB0eXBlbmFtZSBC PiBORVZFUl9JTkxJTkUgdm9pZCBsb2dFcnJvcihib29sLCBjb25zdCBBJiwgY29uc3QgQiYpOwot ICAgIHRlbXBsYXRlIDx0eXBlbmFtZSBBLCB0eXBlbmFtZSBCLCB0eXBlbmFtZSBDPiBORVZFUl9J TkxJTkUgdm9pZCBsb2dFcnJvcihib29sLCBjb25zdCBBJiwgY29uc3QgQiYsIGNvbnN0IEMmKTsK LSAgICB0ZW1wbGF0ZSA8dHlwZW5hbWUgQSwgdHlwZW5hbWUgQiwgdHlwZW5hbWUgQywgdHlwZW5h bWUgRD4gTkVWRVJfSU5MSU5FIHZvaWQgbG9nRXJyb3IoYm9vbCwgY29uc3QgQSYsIGNvbnN0IEIm LCBjb25zdCBDJiwgY29uc3QgRCYpOwotICAgIHRlbXBsYXRlIDx0eXBlbmFtZSBBLCB0eXBlbmFt ZSBCLCB0eXBlbmFtZSBDLCB0eXBlbmFtZSBELCB0eXBlbmFtZSBFPiBORVZFUl9JTkxJTkUgdm9p ZCBsb2dFcnJvcihib29sLCBjb25zdCBBJiwgY29uc3QgQiYsIGNvbnN0IEMmLCBjb25zdCBEJiwg Y29uc3QgRSYpOwotICAgIHRlbXBsYXRlIDx0eXBlbmFtZSBBLCB0eXBlbmFtZSBCLCB0eXBlbmFt ZSBDLCB0eXBlbmFtZSBELCB0eXBlbmFtZSBFLCB0eXBlbmFtZSBGPiBORVZFUl9JTkxJTkUgdm9p ZCBsb2dFcnJvcihib29sLCBjb25zdCBBJiwgY29uc3QgQiYsIGNvbnN0IEMmLCBjb25zdCBEJiwg Y29uc3QgRSYsIGNvbnN0IEYmKTsKLSAgICB0ZW1wbGF0ZSA8dHlwZW5hbWUgQSwgdHlwZW5hbWUg QiwgdHlwZW5hbWUgQywgdHlwZW5hbWUgRCwgdHlwZW5hbWUgRSwgdHlwZW5hbWUgRiwgdHlwZW5h bWUgRz4gTkVWRVJfSU5MSU5FIHZvaWQgbG9nRXJyb3IoYm9vbCwgY29uc3QgQSYsIGNvbnN0IEIm LCBjb25zdCBDJiwgY29uc3QgRCYsIGNvbnN0IEUmLCBjb25zdCBGJiwgY29uc3QgRyYpOworICAg IHRlbXBsYXRlIDx0eXBlbmFtZS4uLiBBcmdzPgorICAgIE5FVkVSX0lOTElORSB2b2lkIGxvZ0Vy cm9yKGJvb2wsIEFyZ3MmJi4uLik7CiAgICAgCiAgICAgTkVWRVJfSU5MSU5FIHZvaWQgdXBkYXRl RXJyb3JXaXRoTmFtZUFuZE1lc3NhZ2UoY29uc3QgY2hhciogYmVmb3JlTWVzc2FnZSwgY29uc3Qg U3RyaW5nJiBuYW1lLCBjb25zdCBjaGFyKiBhZnRlck1lc3NhZ2UpCiAgICAgewo=