166438 2016-12-22 15:00:21 -0800 BytecodeGenerator::m_finallyDepth should be unsigned. 2016-12-22 15:25:17 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam commit-queue keith_miller msaboff saam oldest_to_newest 1262418 0 mark.lam 2016-12-22 15:00:21 -0800 Patch coming. 1262419 1 297677 mark.lam 2016-12-22 15:03:10 -0800 Created attachment 297677 proposed patch. 1262430 2 297682 mark.lam 2016-12-22 15:20:03 -0800 Created attachment 297682 updated patch. 1262432 3 mark.lam 2016-12-22 15:25:17 -0800 Thanks for the review. Landed in r210119: <http://trac.webkit.org/r210119>. 297677 2016-12-22 15:03:10 -0800 2016-12-22 15:20:03 -0800 proposed patch. bug-166438.patch text/plain 3371 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjEwMTE3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE2LTEyLTIyICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBC eXRlY29kZUdlbmVyYXRvcjo6bV9maW5hbGx5RGVwdGggc2hvdWxkIGJlIHVuc2lnbmVkLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY2NDM4CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBieXRlY29tcGls ZXIvQnl0ZWNvZGVHZW5lcmF0b3IuY3BwOgorICAgICAgICAoSlNDOjpCeXRlY29kZUdlbmVyYXRv cjo6bGFiZWxTY29wZURlcHRoKToKKyAgICAgICAgKiBieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5l cmF0b3IuaDoKKyAgICAgICAgKEpTQzo6RmluYWxseUNvbnRleHQ6OkZpbmFsbHlDb250ZXh0KToK KyAgICAgICAgKEpTQzo6RmluYWxseUNvbnRleHQ6OmRlcHRoKToKKwogMjAxNi0xMi0yMiAgTWFy ayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgRGUtZHVwbGljYXRlIGZpbmFs bHkgYmxvY2tzLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxlci9CeXRl Y29kZUdlbmVyYXRvci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2J5 dGVjb21waWxlci9CeXRlY29kZUdlbmVyYXRvci5jcHAJKHJldmlzaW9uIDIxMDExNikKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3IuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0zODg2LDggKzM4ODYsOCBAQCBpbnQgQnl0ZWNvZGVHZW5lcmF0b3I6 OmxvY2FsU2NvcGVEZXB0aCgpCiAKIGludCBCeXRlY29kZUdlbmVyYXRvcjo6bGFiZWxTY29wZURl cHRoKCkgY29uc3QKIHsKLSAgICBpbnQgZGVwdGggPSBsb2NhbFNjb3BlRGVwdGgoKSArIG1fZmlu YWxseURlcHRoOwotICAgIEFTU0VSVChkZXB0aCA9PSBzdGF0aWNfY2FzdDxpbnQ+KG1fY29udHJv bEZsb3dTY29wZVN0YWNrLnNpemUoKSkpOworICAgIHVuc2lnbmVkIGRlcHRoID0gbG9jYWxTY29w ZURlcHRoKCkgKyBtX2ZpbmFsbHlEZXB0aDsKKyAgICBBU1NFUlQoZGVwdGggPT0gbV9jb250cm9s Rmxvd1Njb3BlU3RhY2suc2l6ZSgpKTsKICAgICByZXR1cm4gZGVwdGg7CiB9CiAKSW5kZXg6IFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3IuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVyL0J5dGVjb2RlR2Vu ZXJhdG9yLmgJKHJldmlzaW9uIDIxMDExNikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRl Y29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3IuaAkod29ya2luZyBjb3B5KQpAQCAtMTIxLDE4ICsx MjEsMTcgQEAgbmFtZXNwYWNlIEpTQyB7CiAKICAgICBzdHJ1Y3QgRmluYWxseUNvbnRleHQgewog ICAgICAgICBGaW5hbGx5Q29udGV4dCgpIHsgfQotICAgICAgICBGaW5hbGx5Q29udGV4dChGaW5h bGx5Q29udGV4dCogb3V0ZXJDb250ZXh0LCBMYWJlbCogZmluYWxseUxhYmVsLCBpbnQgZmluYWxs eURlcHRoKQorICAgICAgICBGaW5hbGx5Q29udGV4dChGaW5hbGx5Q29udGV4dCogb3V0ZXJDb250 ZXh0LCBMYWJlbCogZmluYWxseUxhYmVsLCB1bnNpZ25lZCBmaW5hbGx5RGVwdGgpCiAgICAgICAg ICAgICA6IG1fb3V0ZXJDb250ZXh0KG91dGVyQ29udGV4dCkKICAgICAgICAgICAgICwgbV9maW5h bGx5TGFiZWwoZmluYWxseUxhYmVsKQogICAgICAgICAgICAgLCBtX2ZpbmFsbHlEZXB0aChmaW5h bGx5RGVwdGgpCiAgICAgICAgIHsKLSAgICAgICAgICAgIEFTU0VSVChtX2ZpbmFsbHlEZXB0aCA+ PSAwKTsKICAgICAgICAgICAgIEFTU0VSVChtX2p1bXBzLmlzRW1wdHkoKSk7CiAgICAgICAgIH0K IAogICAgICAgICBGaW5hbGx5Q29udGV4dCogb3V0ZXJDb250ZXh0KCkgY29uc3QgeyByZXR1cm4g bV9vdXRlckNvbnRleHQ7IH0KICAgICAgICAgTGFiZWwqIGZpbmFsbHlMYWJlbCgpIGNvbnN0IHsg cmV0dXJuIG1fZmluYWxseUxhYmVsOyB9Ci0gICAgICAgIGludCBkZXB0aCgpIGNvbnN0IHsgcmV0 dXJuIG1fZmluYWxseURlcHRoOyB9CisgICAgICAgIHVuc2lnbmVkIGRlcHRoKCkgY29uc3QgeyBy ZXR1cm4gbV9maW5hbGx5RGVwdGg7IH0KIAogICAgICAgICB1aW50MzJfdCBudW1iZXJPZkJyZWFr c09yQ29udGludWVzKCkgY29uc3QgeyByZXR1cm4gbV9udW1iZXJPZkJyZWFrc09yQ29udGludWVz LnVuc2FmZUdldCgpOyB9CiAgICAgICAgIHZvaWQgaW5jTnVtYmVyT2ZCcmVha3NPckNvbnRpbnVl cygpIHsgbV9udW1iZXJPZkJyZWFrc09yQ29udGludWVzKys7IH0KQEAgLTE1MSw3ICsxNTAsNyBA QCBuYW1lc3BhY2UgSlNDIHsKICAgICBwcml2YXRlOgogICAgICAgICBGaW5hbGx5Q29udGV4dCog bV9vdXRlckNvbnRleHQgeyBudWxscHRyIH07CiAgICAgICAgIExhYmVsKiBtX2ZpbmFsbHlMYWJl bCB7IG51bGxwdHIgfTsKLSAgICAgICAgaW50IG1fZmluYWxseURlcHRoIHsgMCB9OworICAgICAg ICB1bnNpZ25lZCBtX2ZpbmFsbHlEZXB0aCB7IDAgfTsKICAgICAgICAgQ2hlY2tlZDx1aW50MzJf dCwgV1RGOjpDcmFzaE9uT3ZlcmZsb3c+IG1fbnVtYmVyT2ZCcmVha3NPckNvbnRpbnVlczsKICAg ICAgICAgYm9vbCBtX2hhbmRsZXNSZXR1cm5zIHsgZmFsc2UgfTsKICAgICAgICAgVmVjdG9yPEZp bmFsbHlKdW1wPiBtX2p1bXBzOwpAQCAtMTA5MSw3ICsxMDkwLDcgQEAgbmFtZXNwYWNlIEpTQyB7 CiAgICAgICAgIFNlZ21lbnRlZFZlY3RvcjxSZWdpc3RlcklELCAzMj4gbV9wYXJhbWV0ZXJzOwog ICAgICAgICBTZWdtZW50ZWRWZWN0b3I8TGFiZWwsIDMyPiBtX2xhYmVsczsKICAgICAgICAgTGFi ZWxTY29wZVN0b3JlIG1fbGFiZWxTY29wZXM7Ci0gICAgICAgIGludCBtX2ZpbmFsbHlEZXB0aCB7 IDAgfTsKKyAgICAgICAgdW5zaWduZWQgbV9maW5hbGx5RGVwdGggeyAwIH07CiAgICAgICAgIGlu dCBtX2xvY2FsU2NvcGVEZXB0aCB7IDAgfTsKICAgICAgICAgY29uc3QgQ29kZVR5cGUgbV9jb2Rl VHlwZTsKIAo= 297682 2016-12-22 15:20:03 -0800 2016-12-22 15:23:12 -0800 updated patch. bug-166438.patch text/plain 3991 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjEwMTE3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDE2LTEyLTIyICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBC eXRlY29kZUdlbmVyYXRvcjo6bV9maW5hbGx5RGVwdGggc2hvdWxkIGJlIHVuc2lnbmVkLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY2NDM4CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWxzbyByZW1vdmVk IEZpbmFsbHlDb250ZXh0OjptX2ZpbmFsbHlEZXB0aCBiZWNhdXNlIGl0IGlzIG5vdCB1c2VkLgor CisgICAgICAgICogYnl0ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmNwcDoKKyAgICAgICAg KEpTQzo6Qnl0ZWNvZGVHZW5lcmF0b3I6OnB1c2hGaW5hbGx5Q29udHJvbEZsb3dTY29wZSk6Cisg ICAgICAgIChKU0M6OkJ5dGVjb2RlR2VuZXJhdG9yOjpsYWJlbFNjb3BlRGVwdGgpOgorICAgICAg ICAqIGJ5dGVjb21waWxlci9CeXRlY29kZUdlbmVyYXRvci5oOgorICAgICAgICAoSlNDOjpGaW5h bGx5Q29udGV4dDo6RmluYWxseUNvbnRleHQpOgorICAgICAgICAoSlNDOjpGaW5hbGx5Q29udGV4 dDo6ZmluYWxseUxhYmVsKToKKyAgICAgICAgKEpTQzo6RmluYWxseUNvbnRleHQ6OmRlcHRoKTog RGVsZXRlZC4KKwogMjAxNi0xMi0yMiAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAK ICAgICAgICAgRGUtZHVwbGljYXRlIGZpbmFsbHkgYmxvY2tzLgpJbmRleDogU291cmNlL0phdmFT Y3JpcHRDb3JlL2J5dGVjb21waWxlci9CeXRlY29kZUdlbmVyYXRvci5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxlci9CeXRlY29kZUdlbmVyYXRvci5j cHAJKHJldmlzaW9uIDIxMDExNikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGls ZXIvQnl0ZWNvZGVHZW5lcmF0b3IuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNjg3LDcgKzM2ODcs NyBAQCBGaW5hbGx5Q29udGV4dCogQnl0ZWNvZGVHZW5lcmF0b3I6OnB1c2hGCiAgICAgd2hpbGUg KG1fbGFiZWxTY29wZXMuc2l6ZSgpICYmICFtX2xhYmVsU2NvcGVzLmxhc3QoKS5yZWZDb3VudCgp KQogICAgICAgICBtX2xhYmVsU2NvcGVzLnJlbW92ZUxhc3QoKTsKIAotICAgIENvbnRyb2xGbG93 U2NvcGUgc2NvcGUoQ29udHJvbEZsb3dTY29wZTo6RmluYWxseSwgY3VycmVudExleGljYWxTY29w ZUluZGV4KCksIEZpbmFsbHlDb250ZXh0KG1fY3VycmVudEZpbmFsbHlDb250ZXh0LCBmaW5hbGx5 TGFiZWwsIG1fZmluYWxseURlcHRoKSk7CisgICAgQ29udHJvbEZsb3dTY29wZSBzY29wZShDb250 cm9sRmxvd1Njb3BlOjpGaW5hbGx5LCBjdXJyZW50TGV4aWNhbFNjb3BlSW5kZXgoKSwgRmluYWxs eUNvbnRleHQobV9jdXJyZW50RmluYWxseUNvbnRleHQsIGZpbmFsbHlMYWJlbCkpOwogICAgIG1f Y29udHJvbEZsb3dTY29wZVN0YWNrLmFwcGVuZChXVEZNb3ZlKHNjb3BlKSk7CiAKICAgICBtX2Zp bmFsbHlEZXB0aCsrOwpAQCAtMzg4Niw4ICszODg2LDggQEAgaW50IEJ5dGVjb2RlR2VuZXJhdG9y Ojpsb2NhbFNjb3BlRGVwdGgoKQogCiBpbnQgQnl0ZWNvZGVHZW5lcmF0b3I6OmxhYmVsU2NvcGVE ZXB0aCgpIGNvbnN0CiB7Ci0gICAgaW50IGRlcHRoID0gbG9jYWxTY29wZURlcHRoKCkgKyBtX2Zp bmFsbHlEZXB0aDsKLSAgICBBU1NFUlQoZGVwdGggPT0gc3RhdGljX2Nhc3Q8aW50PihtX2NvbnRy b2xGbG93U2NvcGVTdGFjay5zaXplKCkpKTsKKyAgICB1bnNpZ25lZCBkZXB0aCA9IGxvY2FsU2Nv cGVEZXB0aCgpICsgbV9maW5hbGx5RGVwdGg7CisgICAgQVNTRVJUKGRlcHRoID09IG1fY29udHJv bEZsb3dTY29wZVN0YWNrLnNpemUoKSk7CiAgICAgcmV0dXJuIGRlcHRoOwogfQogCkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxlci9CeXRlY29kZUdl bmVyYXRvci5oCShyZXZpc2lvbiAyMTAxMTYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0 ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmgJKHdvcmtpbmcgY29weSkKQEAgLTEyMSwxOCAr MTIxLDE1IEBAIG5hbWVzcGFjZSBKU0MgewogCiAgICAgc3RydWN0IEZpbmFsbHlDb250ZXh0IHsK ICAgICAgICAgRmluYWxseUNvbnRleHQoKSB7IH0KLSAgICAgICAgRmluYWxseUNvbnRleHQoRmlu YWxseUNvbnRleHQqIG91dGVyQ29udGV4dCwgTGFiZWwqIGZpbmFsbHlMYWJlbCwgaW50IGZpbmFs bHlEZXB0aCkKKyAgICAgICAgRmluYWxseUNvbnRleHQoRmluYWxseUNvbnRleHQqIG91dGVyQ29u dGV4dCwgTGFiZWwqIGZpbmFsbHlMYWJlbCkKICAgICAgICAgICAgIDogbV9vdXRlckNvbnRleHQo b3V0ZXJDb250ZXh0KQogICAgICAgICAgICAgLCBtX2ZpbmFsbHlMYWJlbChmaW5hbGx5TGFiZWwp Ci0gICAgICAgICAgICAsIG1fZmluYWxseURlcHRoKGZpbmFsbHlEZXB0aCkKICAgICAgICAgewot ICAgICAgICAgICAgQVNTRVJUKG1fZmluYWxseURlcHRoID49IDApOwogICAgICAgICAgICAgQVNT RVJUKG1fanVtcHMuaXNFbXB0eSgpKTsKICAgICAgICAgfQogCiAgICAgICAgIEZpbmFsbHlDb250 ZXh0KiBvdXRlckNvbnRleHQoKSBjb25zdCB7IHJldHVybiBtX291dGVyQ29udGV4dDsgfQogICAg ICAgICBMYWJlbCogZmluYWxseUxhYmVsKCkgY29uc3QgeyByZXR1cm4gbV9maW5hbGx5TGFiZWw7 IH0KLSAgICAgICAgaW50IGRlcHRoKCkgY29uc3QgeyByZXR1cm4gbV9maW5hbGx5RGVwdGg7IH0K IAogICAgICAgICB1aW50MzJfdCBudW1iZXJPZkJyZWFrc09yQ29udGludWVzKCkgY29uc3QgeyBy ZXR1cm4gbV9udW1iZXJPZkJyZWFrc09yQ29udGludWVzLnVuc2FmZUdldCgpOyB9CiAgICAgICAg IHZvaWQgaW5jTnVtYmVyT2ZCcmVha3NPckNvbnRpbnVlcygpIHsgbV9udW1iZXJPZkJyZWFrc09y Q29udGludWVzKys7IH0KQEAgLTE1MSw3ICsxNDgsNiBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICBw cml2YXRlOgogICAgICAgICBGaW5hbGx5Q29udGV4dCogbV9vdXRlckNvbnRleHQgeyBudWxscHRy IH07CiAgICAgICAgIExhYmVsKiBtX2ZpbmFsbHlMYWJlbCB7IG51bGxwdHIgfTsKLSAgICAgICAg aW50IG1fZmluYWxseURlcHRoIHsgMCB9OwogICAgICAgICBDaGVja2VkPHVpbnQzMl90LCBXVEY6 OkNyYXNoT25PdmVyZmxvdz4gbV9udW1iZXJPZkJyZWFrc09yQ29udGludWVzOwogICAgICAgICBi b29sIG1faGFuZGxlc1JldHVybnMgeyBmYWxzZSB9OwogICAgICAgICBWZWN0b3I8RmluYWxseUp1 bXA+IG1fanVtcHM7CkBAIC0xMDkxLDcgKzEwODcsNyBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAg ICAgU2VnbWVudGVkVmVjdG9yPFJlZ2lzdGVySUQsIDMyPiBtX3BhcmFtZXRlcnM7CiAgICAgICAg IFNlZ21lbnRlZFZlY3RvcjxMYWJlbCwgMzI+IG1fbGFiZWxzOwogICAgICAgICBMYWJlbFNjb3Bl U3RvcmUgbV9sYWJlbFNjb3BlczsKLSAgICAgICAgaW50IG1fZmluYWxseURlcHRoIHsgMCB9Owor ICAgICAgICB1bnNpZ25lZCBtX2ZpbmFsbHlEZXB0aCB7IDAgfTsKICAgICAgICAgaW50IG1fbG9j YWxTY29wZURlcHRoIHsgMCB9OwogICAgICAgICBjb25zdCBDb2RlVHlwZSBtX2NvZGVUeXBlOwog Cg==