166429 2016-12-22 12:50:06 -0800 WebAssembly: Make the spec-tests/address.wast.js test pass 2016-12-22 14:42:10 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin fpizlo ggaren gskachkov jfbastien keith_miller mark.lam msaboff oliver ticaiolima webkit-bug-importer ysuzuki oldest_to_newest 1262363 0 saam 2016-12-22 12:50:06 -0800 ... 1262397 1 webkit-bug-importer 2016-12-22 14:27:51 -0800 <rdar://problem/29793220> 1262403 2 297674 saam 2016-12-22 14:34:51 -0800 Created attachment 297674 patch 1262405 3 297674 keith_miller 2016-12-22 14:36:29 -0800 Comment on attachment 297674 patch r=me. 1262406 4 297674 jfbastien 2016-12-22 14:38:47 -0800 Comment on attachment 297674 patch lgtm 1262408 5 saam 2016-12-22 14:42:10 -0800 landed in: https://trac.webkit.org/changeset/210115 297674 2016-12-22 14:34:51 -0800 2016-12-22 14:36:29 -0800 patch a-backup.diff text/plain 5084 saam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMTAxMTMpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEyIEBACisyMDE2LTEyLTIyICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgorCisgICAgICAgIFdlYkFzc2VtYmx5OiBNYWtlIHRoZSBzcGVjLXRlc3RzL2FkZHJlc3Mu d2FzdC5qcyB0ZXN0IHBhc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE2NjQyOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogd2FzbS55YW1sOgorCiAyMDE2LTEyLTIyICBLZWl0aCBNaWxsZXIgIDxrZWl0 aF9taWxsZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYkFzc2VtYmx5OiBUaGUgdmFsaWRhdG9y IHNob3VsZCBub3QgYWxsb3cgdW51c2VkIHN0YWNrIGVudHJpZXMgYXQgdGhlIGVuZCBvZiBhIGJs b2NrCkluZGV4OiBKU1Rlc3RzL3dhc20ueWFtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL3dhc20u eWFtbAkocmV2aXNpb24gMjEwMTEyKQorKysgSlNUZXN0cy93YXNtLnlhbWwJKHdvcmtpbmcgY29w eSkKQEAgLTI5LDcgKzI5LDcgQEAKICAgY21kOiBydW5XZWJBc3NlbWJseQogCiAtIHBhdGg6IHdh c20vc3BlYy10ZXN0cy9hZGRyZXNzLndhc3QuanMKLSAgY21kOiBydW5XZWJBc3NlbWJseVNwZWNU ZXN0IDpza2lwCisgIGNtZDogcnVuV2ViQXNzZW1ibHlTcGVjVGVzdCA6bm9ybWFsCiAKIC0gcGF0 aDogd2FzbS9zcGVjLXRlc3RzL2JpbmFyeS53YXN0LmpzCiAgIGNtZDogcnVuV2ViQXNzZW1ibHlT cGVjVGVzdCA6bm9ybWFsCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIx MDExMikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkK QEAgLTEsMyArMSwxOCBAQAorMjAxNi0xMi0yMiAgU2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxl LmNvbT4KKworICAgICAgICBXZWJBc3NlbWJseTogTWFrZSB0aGUgc3BlYy10ZXN0cy9hZGRyZXNz Lndhc3QuanMgdGVzdCBwYXNzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNjY0MjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBSaWdodCBub3csIHByb3ZhYmx5IG91dCBvZiBib3VuZCBsb2Fkcy9zdG9yZXMg KGdpdmVuIGEgbG9hZC9zdG9yZSdzIGNvbnN0YW50CisgICAgICAgIG9mZnNldCkgYXJlIG5vdCBh IHZhbGlkYXRpb24gZXJyb3IuIEhvd2V2ZXIsIHdlIHdlcmUgZmFpbGluZyB0byBjYXRjaCB1aW50 MzJfdAorICAgICAgICBvdmVyZmxvd3MgaW4gcmVsZWFzZSBidWlsZHMgKHdlIGRpZCBoYXZlIGEg ZGVidWcgYXNzZXJ0aW9uKS4gVG8gZml4IHRoaXMsCisgICAgICAgIEkgbm93IGRldGVjdCB3aGVu IHVpbnQzMl90IGFkZGl0aW9uIHdpbGwgb3ZlcmZsb3csIGFuZCBpbnN0ZWFkIG9mIGVtaXR0aW5n CisgICAgICAgIGEgbm9ybWFsIGxvYWQvc3RvcmUsIEkgZW1pdCBjb2RlIHRoYXQgdGhyb3dzIGFu IG91dCBvZiBib3VuZHMgbWVtb3J5IGV4Y2VwdGlvbi4KKworICAgICAgICAqIHdhc20vV2FzbUIz SVJHZW5lcmF0b3IuY3BwOgorCiAyMDE2LTEyLTIyICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxs ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYkFzc2VtYmx5OiBUaGUgdmFsaWRhdG9yIHNob3Vs ZCBub3QgYWxsb3cgdW51c2VkIHN0YWNrIGVudHJpZXMgYXQgdGhlIGVuZCBvZiBhIGJsb2NrCklu ZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9XYXNtQjNJUkdlbmVyYXRvci5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vV2FzbUIzSVJHZW5lcmF0b3Iu Y3BwCShyZXZpc2lvbiAyMTAxMTIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9XYXNt QjNJUkdlbmVyYXRvci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ2NSw3ICs0NjUsNDIgQEAgYXV0 byBCM0lSR2VuZXJhdG9yOjpsb2FkKExvYWRPcFR5cGUgb3AsIAogewogICAgIEFTU0VSVChwb2lu dGVyLT50eXBlKCkgPT0gSW50MzIpOwogCi0gICAgcmVzdWx0ID0gZW1pdExvYWRPcChvcCwgT3Jp Z2luKCksIGVtaXRDaGVja0FuZFByZXBhcmVQb2ludGVyKHBvaW50ZXIsIG9mZnNldCwgc2l6ZU9m TG9hZE9wKG9wKSksIG9mZnNldCk7CisgICAgaWYgKFVOTElLRUxZKHN1bU92ZXJmbG93czx1aW50 MzJfdD4ob2Zmc2V0LCBzaXplT2ZMb2FkT3Aob3ApKSkpIHsKKyAgICAgICAgLy8gRklYTUU6IEV2 ZW4gdGhvdWdoIHRoaXMgaXMgcHJvdmFibHkgb3V0IG9mIGJvdW5kcywgaXQncyBub3QgYSB2YWxp ZGF0aW9uIGVycm9yLCBzbyB3ZSBoYXZlIHRvIGhhbmRsZSBpdAorICAgICAgICAvLyBhcyBhIHJ1 bnRpbWUgZXhjZXB0aW9uLiBIb3dldmVyLCB0aGlzIG1heSBjaGFuZ2U6IGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjY0MzUKKyAgICAgICAgQjM6OlBhdGNocG9pbnRW YWx1ZSogdGhyb3dFeGNlcHRpb24gPSBtX2N1cnJlbnRCbG9jay0+YXBwZW5kTmV3PEIzOjpQYXRj aHBvaW50VmFsdWU+KG1fcHJvYywgQjM6OlZvaWQsIE9yaWdpbigpKTsKKyAgICAgICAgdGhyb3dF eGNlcHRpb24tPnNldEdlbmVyYXRvcihbdGhpc10gKENDYWxsSGVscGVycyYgaml0LCBjb25zdCBC Mzo6U3RhY2ttYXBHZW5lcmF0aW9uUGFyYW1zJikgeworICAgICAgICAgICAgdGhpcy0+ZW1pdEV4 Y2VwdGlvbkNoZWNrKGppdCwgRXhjZXB0aW9uVHlwZTo6T3V0T2ZCb3VuZHNNZW1vcnlBY2Nlc3Mp OworICAgICAgICB9KTsKKworICAgICAgICBzd2l0Y2ggKG9wKSB7CisgICAgICAgIGNhc2UgTG9h ZE9wVHlwZTo6STMyTG9hZDhTOgorICAgICAgICBjYXNlIExvYWRPcFR5cGU6OkkzMkxvYWQxNlM6 CisgICAgICAgIGNhc2UgTG9hZE9wVHlwZTo6STMyTG9hZDoKKyAgICAgICAgY2FzZSBMb2FkT3BU eXBlOjpJMzJMb2FkMTZVOgorICAgICAgICBjYXNlIExvYWRPcFR5cGU6OkkzMkxvYWQ4VToKKyAg ICAgICAgICAgIHJlc3VsdCA9IHplcm9Gb3JUeXBlKEkzMik7CisgICAgICAgICAgICBicmVhazsK KyAgICAgICAgY2FzZSBMb2FkT3BUeXBlOjpJNjRMb2FkOFM6CisgICAgICAgIGNhc2UgTG9hZE9w VHlwZTo6STY0TG9hZDhVOgorICAgICAgICBjYXNlIExvYWRPcFR5cGU6Okk2NExvYWQxNlM6Cisg ICAgICAgIGNhc2UgTG9hZE9wVHlwZTo6STY0TG9hZDMyVToKKyAgICAgICAgY2FzZSBMb2FkT3BU eXBlOjpJNjRMb2FkMzJTOgorICAgICAgICBjYXNlIExvYWRPcFR5cGU6Okk2NExvYWQ6CisgICAg ICAgIGNhc2UgTG9hZE9wVHlwZTo6STY0TG9hZDE2VToKKyAgICAgICAgICAgIHJlc3VsdCA9IHpl cm9Gb3JUeXBlKEk2NCk7CisgICAgICAgICAgICBicmVhazsKKyAgICAgICAgY2FzZSBMb2FkT3BU eXBlOjpGMzJMb2FkOgorICAgICAgICAgICAgcmVzdWx0ID0gemVyb0ZvclR5cGUoRjMyKTsKKyAg ICAgICAgICAgIGJyZWFrOworICAgICAgICBjYXNlIExvYWRPcFR5cGU6OkY2NExvYWQ6CisgICAg ICAgICAgICByZXN1bHQgPSB6ZXJvRm9yVHlwZShGNjQpOworICAgICAgICAgICAgYnJlYWs7Cisg ICAgICAgIH0KKworICAgIH0gZWxzZQorICAgICAgICByZXN1bHQgPSBlbWl0TG9hZE9wKG9wLCBP cmlnaW4oKSwgZW1pdENoZWNrQW5kUHJlcGFyZVBvaW50ZXIocG9pbnRlciwgb2Zmc2V0LCBzaXpl T2ZMb2FkT3Aob3ApKSwgb2Zmc2V0KTsKKwogICAgIHJldHVybiB7IH07CiB9CiAKQEAgLTUyNyw3 ICs1NjIsMTYgQEAgYXV0byBCM0lSR2VuZXJhdG9yOjpzdG9yZShTdG9yZU9wVHlwZSBvcAogewog ICAgIEFTU0VSVChwb2ludGVyLT50eXBlKCkgPT0gSW50MzIpOwogCi0gICAgZW1pdFN0b3JlT3Ao b3AsIE9yaWdpbigpLCBlbWl0Q2hlY2tBbmRQcmVwYXJlUG9pbnRlcihwb2ludGVyLCBvZmZzZXQs IHNpemVPZlN0b3JlT3Aob3ApKSwgdmFsdWUsIG9mZnNldCk7CisgICAgaWYgKFVOTElLRUxZKHN1 bU92ZXJmbG93czx1aW50MzJfdD4ob2Zmc2V0LCBzaXplT2ZTdG9yZU9wKG9wKSkpKSB7CisgICAg ICAgIC8vIEZJWE1FOiBFdmVuIHRob3VnaCB0aGlzIGlzIHByb3ZhYmx5IG91dCBvZiBib3VuZHMs IGl0J3Mgbm90IGEgdmFsaWRhdGlvbiBlcnJvciwgc28gd2UgaGF2ZSB0byBoYW5kbGUgaXQKKyAg ICAgICAgLy8gYXMgYSBydW50aW1lIGV4Y2VwdGlvbi4gSG93ZXZlciwgdGhpcyBtYXkgY2hhbmdl OiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY2NDM1CisgICAgICAg IEIzOjpQYXRjaHBvaW50VmFsdWUqIHRocm93RXhjZXB0aW9uID0gbV9jdXJyZW50QmxvY2stPmFw cGVuZE5ldzxCMzo6UGF0Y2hwb2ludFZhbHVlPihtX3Byb2MsIEIzOjpWb2lkLCBPcmlnaW4oKSk7 CisgICAgICAgIHRocm93RXhjZXB0aW9uLT5zZXRHZW5lcmF0b3IoW3RoaXNdIChDQ2FsbEhlbHBl cnMmIGppdCwgY29uc3QgQjM6OlN0YWNrbWFwR2VuZXJhdGlvblBhcmFtcyYpIHsKKyAgICAgICAg ICAgIHRoaXMtPmVtaXRFeGNlcHRpb25DaGVjayhqaXQsIEV4Y2VwdGlvblR5cGU6Ok91dE9mQm91 bmRzTWVtb3J5QWNjZXNzKTsKKyAgICAgICAgfSk7CisgICAgfSBlbHNlCisgICAgICAgIGVtaXRT dG9yZU9wKG9wLCBPcmlnaW4oKSwgZW1pdENoZWNrQW5kUHJlcGFyZVBvaW50ZXIocG9pbnRlciwg b2Zmc2V0LCBzaXplT2ZTdG9yZU9wKG9wKSksIHZhbHVlLCBvZmZzZXQpOworCiAgICAgcmV0dXJu IHsgfTsKIH0KIAo=