166403 2016-12-21 17:26:13 -0800 Make http/tests/security/popup-blocked-from-{fake-event, window-open}.html actually test popup blocker; run on WebKit2 2016-12-22 14:27:25 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=166402 P2 Normal --- 1 dbates dbates andersca ap lforschler oldest_to_newest 1262221 0 dbates 2016-12-21 17:26:13 -0800 The tests LayoutTests/http/tests/security/popup-blocked-from-{fake-event, window-open}.html inadvertently depend on the implementation implications of testRunner.setCanOpenWindows(), which is not implemented in WebKitTestRunner (see bug #166402), instead of testing that popup blocker logic. 1262224 1 297641 dbates 2016-12-21 17:27:23 -0800 Created attachment 297641 Layout tests 1262396 2 dbates 2016-12-22 14:27:25 -0800 Committed r210113: <http://trac.webkit.org/changeset/210113> 297641 2016-12-21 17:27:23 -0800 2016-12-22 09:19:05 -0800 Layout tests bug-166403-20161221172620.patch text/plain 4013 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjEwMDIyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYWM3MTQwMjI3YjYxMzQ3MWI1MmZj NzA2MGYyODU4Mjk5MWI4YmVkNy4uYTZkMzE4MWY0MTE3NDZmNjUwNmFmZmE4MDExZTA0ZTJjMmI5 MTI2MyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDE2LTEyLTIxICBEYW5pZWwgQmF0ZXMgIDxk YWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBNYWtlIGh0dHAvdGVzdHMvc2VjdXJpdHkvcG9w dXAtYmxvY2tlZC1mcm9tLXtmYWtlLWV2ZW50LCB3aW5kb3ctb3Blbn0uaHRtbCBhY3R1YWxseSB0 ZXN0IHBvcHVwCisgICAgICAgIGJsb2NrZXI7IHJ1biBvbiBXZWJLaXQyCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjY0MDMKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgdGVzdHMgaHR0cC90ZXN0cy9z ZWN1cml0eS9wb3B1cC1ibG9ja2VkLWZyb20te2Zha2UtZXZlbnQsIHdpbmRvdy1vcGVufS5odG1s IGluYWR2ZXJ0ZW50bHkKKyAgICAgICAgZGVwZW5kZWQgb24gdGhlIGRlZmF1bHQgYmVoYXZpb3Ig b2YgRHVtcFJlbmRlclRyZWUgdG8gaWdub3JlIHRoZSBDaHJvbWVDbGllbnQ6OmNyZWF0ZVdpbmRv dygpCisgICAgICAgIGNhbGxiYWNrIHdoZW4gYXNrZWQgdG8gY3JlYXRlIGEgbmV3IHdpbmRvdyBp bnN0ZWFkIG9mIHRlc3RpbmcgdGhhdCB0aGUgcG9wdXAgYmxvY2tlciBibG9ja2VkCisgICAgICAg IG9wZW5pbmcgd2luZG93cy4gV2Ugc2hvdWxkIGNhbGwgdGVzdFJ1bm5lci5zZXRDYW5PcGVuV2lu ZG93cygpIGFuZCB0ZXN0UnVubmVyLnNldFBvcHVwQmxvY2tpbmdFbmFibGVkKHRydWUpCisgICAg ICAgIGZyb20gYm90aCBvZiB0aGVzZSB0ZXN0cyB0byBzbyB0aGF0IER1bXBSZW5kZXJUcmVlIHJl c3BlY3RzIHJlcXVlc3RzIHRvIG9wZW4gd2luZG93cyBhbmQgZW5hYmxlCisgICAgICAgIHRoZSBw b3B1cCBibG9ja2VyIChpdCBpcyBkaXNhYmxlZCBieSBkZWZhdWx0KSwgcmVzcGVjdGl2ZWx5Lgor CisgICAgICAgIFRoZSBkZWZhdWx0IGJlaGF2aW9yIG9mIER1bXBSZW5kZXJUcmVlIHRvIGRpc2Fs bG93IG9wZW5pbmcgd2luZG93cyBmYWxscyBvdXQgZnJvbSB0aGUgcHVycG9zZQorICAgICAgICBh bmQgaW1wbGVtZW50YXRpb24gb2YgdGVzdFJ1bm5lci5zZXRDYW5PcGVuV2luZG93cygpIHRvIHN1 cHBvcnQgd3JpdGluZyB0ZXN0cyB3aGVyZSB0aGUgZW1iZWRkaW5nCisgICAgICAgIGNsaWVudCBp Z25vcmVzIHJlcXVlc3RzIHRvIGNyZWF0ZSBhIG5ldyB3aW5kb3cuIFdlIGRvIG5vdCBpbXBsZW1l bnQgc3VjaCBhIGNvbmNlcHQgaW4gV2ViS2l0VGVzdFJ1bm5lcgorICAgICAgICAoc2VlIDxodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY2NDAyPikuCisKKyAgICAgICAg KiBodHRwL3Rlc3RzL3NlY3VyaXR5L3BvcHVwLWJsb2NrZWQtZnJvbS1mYWtlLWV2ZW50Lmh0bWw6 CisgICAgICAgICogaHR0cC90ZXN0cy9zZWN1cml0eS9wb3B1cC1ibG9ja2VkLWZyb20td2luZG93 LW9wZW4uaHRtbDoKKyAgICAgICAgKiBwbGF0Zm9ybS93azIvVGVzdEV4cGVjdGF0aW9uczogVW5z a2lwIHRoZSBhYm92ZSB0ZXN0cyBhcyB0aGV5IG5vdyBwYXNzLgorCiAyMDE2LTEyLTIwICBNZWdh biBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IG1lbW9y eSBsZWFrIGluIG1hbGZvcm1lZCB0ZXN0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rl c3RzL3NlY3VyaXR5L3BvcHVwLWJsb2NrZWQtZnJvbS1mYWtlLWV2ZW50Lmh0bWwgYi9MYXlvdXRU ZXN0cy9odHRwL3Rlc3RzL3NlY3VyaXR5L3BvcHVwLWJsb2NrZWQtZnJvbS1mYWtlLWV2ZW50Lmh0 bWwKaW5kZXggNmE0ZGU1M2FiZDZiNGU4OTg5NTMzZTMzNTUwYWM5ZjgyOTVmNDFhNC4uOTMwYzk0 ZWU1ODYwMTVlYjdkMWRhMWI1NjA1YmY5YWZmOWExNjg5ZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvaHR0cC90ZXN0cy9zZWN1cml0eS9wb3B1cC1ibG9ja2VkLWZyb20tZmFrZS1ldmVudC5odG1s CisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvc2VjdXJpdHkvcG9wdXAtYmxvY2tlZC1mcm9t LWZha2UtZXZlbnQuaHRtbApAQCAtNCw2ICs0LDggQEAKIDxzY3JpcHQ+IAogaWYgKHdpbmRvdy50 ZXN0UnVubmVyKSB7CiAgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7CisgICAgdGVzdFJ1bm5l ci5zZXRDYW5PcGVuV2luZG93cygpOworICAgIHRlc3RSdW5uZXIuc2V0UG9wdXBCbG9ja2luZ0Vu YWJsZWQodHJ1ZSk7CiAgICAgdGVzdFJ1bm5lci5zZXRDbG9zZVJlbWFpbmluZ1dpbmRvd3NXaGVu Q29tcGxldGUodHJ1ZSk7CiB9CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMv c2VjdXJpdHkvcG9wdXAtYmxvY2tlZC1mcm9tLXdpbmRvdy1vcGVuLmh0bWwgYi9MYXlvdXRUZXN0 cy9odHRwL3Rlc3RzL3NlY3VyaXR5L3BvcHVwLWJsb2NrZWQtZnJvbS13aW5kb3ctb3Blbi5odG1s CmluZGV4IDQ3NmVhMmY4NmY4NTQ0ZmNjMjgwZWY3ZWY5YTQwMDIwNDA0MmI1YzUuLjY0MmMxYTIy NDU2OTQ5ZDgxODliODAyZmQ2MTkxZDc0NjBmZjU0ODAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L2h0dHAvdGVzdHMvc2VjdXJpdHkvcG9wdXAtYmxvY2tlZC1mcm9tLXdpbmRvdy1vcGVuLmh0bWwK KysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9zZWN1cml0eS9wb3B1cC1ibG9ja2VkLWZyb20t d2luZG93LW9wZW4uaHRtbApAQCAtMyw2ICszLDggQEAKIDxzY3JpcHQ+IAogaWYgKHdpbmRvdy50 ZXN0UnVubmVyKSB7CiAgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7CisgICAgdGVzdFJ1bm5l ci5zZXRDYW5PcGVuV2luZG93cygpOworICAgIHRlc3RSdW5uZXIuc2V0UG9wdXBCbG9ja2luZ0Vu YWJsZWQodHJ1ZSk7CiAgICAgdGVzdFJ1bm5lci5zZXRDbG9zZVJlbWFpbmluZ1dpbmRvd3NXaGVu Q29tcGxldGUodHJ1ZSk7CiB9CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3dr Mi9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2syL1Rlc3RFeHBlY3Rh dGlvbnMKaW5kZXggOTNkYTdlZjNiMDlhNmU0ZDQ5ZjI2YzhiYzNhZDdkNjMyMTAwNGI5Yi4uNjdj ODFkYThhZWExNjMxZGRkNmFlYjQzN2M0YWUwYmUwMzU5MTljZiAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vd2syL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxh dGZvcm0vd2syL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTQzNyw4ICs0MzcsNiBAQCBodHRwL3Rlc3Rz L3NlY3VyaXR5L2ZyYW1lTmF2aWdhdGlvbi94c3MtREVOSUVELXRhcmdldGVkLWxpbmstbmF2aWdh dGlvbi5odG1sCiBodHRwL3Rlc3RzL3NlY3VyaXR5L2phdmFzY3JpcHRVUkwveHNzLUFMTE9XRUQt dG8tamF2YXNjcmlwdC11cmwtd2luZG93LW9wZW4uaHRtbAogaHR0cC90ZXN0cy9zZWN1cml0eS9q YXZhc2NyaXB0VVJML3hzcy1ERU5JRUQtZnJvbS1qYXZhc2NyaXB0LXVybC1pbi1mb3JlaWduLWRv bWFpbi13aW5kb3ctb3Blbi5odG1sCiBodHRwL3Rlc3RzL3NlY3VyaXR5L2phdmFzY3JpcHRVUkwv eHNzLURFTklFRC10by1qYXZhc2NyaXB0LXVybC1pbi1mb3JlaWduLWRvbWFpbi13aW5kb3ctb3Bl bi5odG1sCi1odHRwL3Rlc3RzL3NlY3VyaXR5L3BvcHVwLWJsb2NrZWQtZnJvbS1mYWtlLWV2ZW50 Lmh0bWwKLWh0dHAvdGVzdHMvc2VjdXJpdHkvcG9wdXAtYmxvY2tlZC1mcm9tLXdpbmRvdy1vcGVu Lmh0bWwKIAogIyBVbmV4cGxhaW5lZCBmYWlsdXJlcyB0aGF0IHdlcmUgZm9ybWVybHkgaW4gdGhl ICJ1bnNhZmUgYWNjZXNzIiBsaXN0LgogaHR0cC90ZXN0cy9zZWN1cml0eS9jcm9zcy1mcmFtZS1h Y2Nlc3MtZW51bWVyYXRpb24uaHRtbAo=