166401 2016-12-21 17:23:08 -0800 [Cocoa] SPI for setloadsImagesAutomatically 2016-12-22 11:50:24 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 a.tion.surf webkit-unassigned a.tion.surf beidson commit-queue jberlin oldest_to_newest 1262218 0 a.tion.surf 2016-12-21 17:23:08 -0800 Cocoa SPI for setloadsImagesAutomatically. 1262231 1 297642 a.tion.surf 2016-12-21 17:40:19 -0800 Created attachment 297642 Patch 1262339 2 297642 achristensen 2016-12-22 11:27:33 -0800 Comment on attachment 297642 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297642&action=review > Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:51 > + [preferences _setLoadsImagesAutomatically:NO]; > + EXPECT_FALSE([preferences _loadsImagesAutomatically]); This doesn't test the actual functionality of the preference. 1262348 3 297642 commit-queue 2016-12-22 11:50:20 -0800 Comment on attachment 297642 Patch Clearing flags on attachment: 297642 Committed r210103: <http://trac.webkit.org/changeset/210103> 1262349 4 commit-queue 2016-12-22 11:50:24 -0800 All reviewed patches have been landed. Closing bug. 297642 2016-12-21 17:40:19 -0800 2016-12-22 11:50:20 -0800 Patch patch text/plain 4951 a.tion.surf Y29tbWl0IGQ0OGQ1ZjY2OTM1YWM5NzVhMTQyNzZlMDIzNzg5Mzc2NWQ0MTBhYmUKQXV0aG9yOiBa aHVvIExpIDx6YWNobGlAYXBwbGUuY29tPgpEYXRlOiAgIFdlZCBEZWMgMjEgMTc6Mjg6NTUgMjAx NiAtMDgwMAoKICAgIFNvdXJjZS9XZWJLaXQyOgogICAgW0NvY29hXSBTUEkgZm9yIHNldGxvYWRz SW1hZ2VzQXV0b21hdGljYWxseQogICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE2NjQwMQogICAgCiAgICBQYXRjaCBieSBaaHVvIExpIDx6YWNobGlAYXBwbGUuY29t PiBvbiAyMDE2LTEyLTIxCiAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KICAgIAogICAg KiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLUHJlZmVyZW5jZXMubW06IENhbGwgdGhlIEMgQVBJIHVu ZGVyIHRoZSBob29kLgogICAgKC1bV0tQcmVmZXJlbmNlcyBfbG9hZHNJbWFnZXNBdXRvbWF0aWNh bGx5XSk6CiAgICAoLVtXS1ByZWZlcmVuY2VzIF9zZXRMb2Fkc0ltYWdlc0F1dG9tYXRpY2FsbHk6 XSk6CiAgICAKICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1ByZWZlcmVuY2VzUHJpdmF0ZS5o OgogICAgQWRkIGBfbG9hZHNJbWFnZXNBdXRvbWF0aWNhbGx5YCBwcm9wZXJ0eS4KICAgIAogICAg VG9vbHM6CiAgICBbQ29jb2FdIFNQSSBmb3Igc2V0bG9hZHNJbWFnZXNBdXRvbWF0aWNhbGx5Lgog ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NjQwMS4KICAgIAog ICAgUGF0Y2ggYnkgWmh1byBMaSA8emFjaGxpQGFwcGxlLmNvbT4gb24gMjAxNi0xMi0yMQogICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCiAgICAKICAgICogVGVzdFdlYktpdEFQSS9UZXN0 cy9XZWJLaXQyQ29jb2EvUHJlZmVyZW5jZXMubW06CiAgICAoVEVTVCk6IFRlc3QgdGhlIF9zZXRM b2Fkc0ltYWdlc0F1dG9tYXRpY2FsbHkgU1BJLiBCeSBkZWZhdWx0LAogICAgX2xvYWRzSW1hZ2Vz QXV0b21hdGljYWxseSByZXR1cm5zIFlFUy4KCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODk1YjE1OC4uMDA2MDBl NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJL aXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE2LTEyLTIxICBaaHVvIExpICA8emFj aGxpQGFwcGxlLmNvbT4KKworICAgICAgICBbQ29jb2FdIFNQSSBmb3Igc2V0bG9hZHNJbWFnZXNB dXRvbWF0aWNhbGx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNjY0MDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcmVmZXJlbmNlcy5tbTogQ2FsbCB0aGUgQyBB UEkgdW5kZXIgdGhlIGhvb2QuCisgICAgICAgICgtW1dLUHJlZmVyZW5jZXMgX2xvYWRzSW1hZ2Vz QXV0b21hdGljYWxseV0pOgorICAgICAgICAoLVtXS1ByZWZlcmVuY2VzIF9zZXRMb2Fkc0ltYWdl c0F1dG9tYXRpY2FsbHk6XSk6CisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLUHJl ZmVyZW5jZXNQcml2YXRlLmg6CisgICAgICAgIEFkZCBgX2xvYWRzSW1hZ2VzQXV0b21hdGljYWxs eWAgcHJvcGVydHkuCisKIDIwMTYtMTItMTUgIE15bGVzIEMuIE1heGZpZWxkICA8bW1heGZpZWxk QGFwcGxlLmNvbT4KIAogICAgICAgICBTb3J0IFhjb2RlIHByb2plY3QgZmlsZXMKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcmVmZXJlbmNlcy5tbSBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcmVmZXJlbmNlcy5tbQppbmRl eCA4OGRhNWJlLi4xNzcwOTUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL0NvY29hL1dLUHJlZmVyZW5jZXMubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9Db2NvYS9XS1ByZWZlcmVuY2VzLm1tCkBAIC01MDcsNiArNTA3LDE2IEBAIC0gKHZvaWQp X3NldEFwcGxlUGF5Q2FwYWJpbGl0eURpc2Nsb3N1cmVBbGxvd2VkOihCT09MKWFwcGxlUGF5Q2Fw YWJpbGl0eURpc2Nsb3N1CiAjZW5kaWYKIH0KIAorLSAoQk9PTClfbG9hZHNJbWFnZXNBdXRvbWF0 aWNhbGx5Cit7CisgICAgcmV0dXJuIF9wcmVmZXJlbmNlcy0+bG9hZHNJbWFnZXNBdXRvbWF0aWNh bGx5KCk7Cit9CisKKy0gKHZvaWQpX3NldExvYWRzSW1hZ2VzQXV0b21hdGljYWxseTooQk9PTCls b2Fkc0ltYWdlc0F1dG9tYXRpY2FsbHkKK3sKKyAgICBfcHJlZmVyZW5jZXMtPnNldExvYWRzSW1h Z2VzQXV0b21hdGljYWxseShsb2Fkc0ltYWdlc0F1dG9tYXRpY2FsbHkpOworfQorCiBAZW5kCiAK ICNlbmRpZiAvLyBXS19BUElfRU5BQkxFRApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9Db2NvYS9XS1ByZWZlcmVuY2VzUHJpdmF0ZS5oIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9Db2NvYS9XS1ByZWZlcmVuY2VzUHJpdmF0ZS5oCmluZGV4IGYwYzEyMmEu LjlmZGMyNmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2Ev V0tQcmVmZXJlbmNlc1ByaXZhdGUuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L0NvY29hL1dLUHJlZmVyZW5jZXNQcml2YXRlLmgKQEAgLTkzLDYgKzkzLDggQEAgdHlwZWRlZiBO U19PUFRJT05TKE5TVUludGVnZXIsIF9XS0phdmFTY3JpcHRSdW50aW1lRmxhZ3MpIHsKIAogQHBy b3BlcnR5IChub25hdG9taWMsIHNldHRlcj1fc2V0QXBwbGVQYXlDYXBhYmlsaXR5RGlzY2xvc3Vy ZUFsbG93ZWQ6KSBCT09MIF9hcHBsZVBheUNhcGFiaWxpdHlEaXNjbG9zdXJlQWxsb3dlZCBXS19B UElfQVZBSUxBQkxFKG1hY29zeCgxMC4xMiksIGlvcygxMC4wKSk7CiAKK0Bwcm9wZXJ0eSAobm9u YXRvbWljLCBzZXR0ZXI9X3NldExvYWRzSW1hZ2VzQXV0b21hdGljYWxseTopIEJPT0wgX2xvYWRz SW1hZ2VzQXV0b21hdGljYWxseSBXS19BUElfQVZBSUxBQkxFKG1hY29zeChXS19NQUNfVEJBKSwg aW9zKFdLX0lPU19UQkEpKTsKKwogKyAoTlNBcnJheTxfV0tFeHBlcmltZW50YWxGZWF0dXJlICo+ ICopX2V4cGVyaW1lbnRhbEZlYXR1cmVzIFdLX0FQSV9BVkFJTEFCTEUobWFjb3N4KDEwLjEyKSwg aW9zKDEwLjApKTsKIC0gKEJPT0wpX2lzRW5hYmxlZEZvckZlYXR1cmU6KF9XS0V4cGVyaW1lbnRh bEZlYXR1cmUgKilmZWF0dXJlIFdLX0FQSV9BVkFJTEFCTEUobWFjb3N4KDEwLjEyKSwgaW9zKDEw LjApKTsKIC0gKHZvaWQpX3NldEVuYWJsZWQ6KEJPT0wpdmFsdWUgZm9yRmVhdHVyZTooX1dLRXhw ZXJpbWVudGFsRmVhdHVyZSAqKWZlYXR1cmUgV0tfQVBJX0FWQUlMQUJMRShtYWNvc3goMTAuMTIp LCBpb3MoMTAuMCkpOwpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdl TG9nCmluZGV4IDUyZDJkM2UuLjY2N2I5NjIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZwor KysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxNi0xMi0yMSAgWmh1byBM aSAgPHphY2hsaUBhcHBsZS5jb20+CisKKyAgICAgICAgW0NvY29hXSBTUEkgZm9yIHNldGxvYWRz SW1hZ2VzQXV0b21hdGljYWxseS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE2NjQwMS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0MkNvY29hL1ByZWZlcmVu Y2VzLm1tOgorICAgICAgICAoVEVTVCk6IFRlc3QgdGhlIF9zZXRMb2Fkc0ltYWdlc0F1dG9tYXRp Y2FsbHkgU1BJLiBCeSBkZWZhdWx0LAorICAgICAgICBfbG9hZHNJbWFnZXNBdXRvbWF0aWNhbGx5 IHJldHVybnMgWUVTLgorCiAyMDE2LTEyLTE1ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBw bGUuY29tPgogCiAgICAgICAgIE1vdmUgSlNDIHRlc3RlcnMgZnJvbSBZb3NlbWl0ZSB0byBTaWVy cmEKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0MkNvY29hL1By ZWZlcmVuY2VzLm1tIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyQ29jb2EvUHJl ZmVyZW5jZXMubW0KaW5kZXggMWFmMDM1ZC4uMjEyOTA0NyAxMDA2NDQKLS0tIGEvVG9vbHMvVGVz dFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyQ29jb2EvUHJlZmVyZW5jZXMubW0KKysrIGIvVG9vbHMv VGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyQ29jb2EvUHJlZmVyZW5jZXMubW0KQEAgLTQyLDYg KzQyLDE3IEBAIFRFU1QoV2ViS2l0MiwgRGVmYXVsdFdLUHJlZmVyZW5jZXMpCiAgICAgRVhQRUNU X1RSVUUoW3ByZWZlcmVuY2VzIF9pc1N0YW5kYWxvbmVdKTsKIH0KIAorVEVTVChXZWJLaXQyLCBM b2Fkc0ltYWdlc0F1dG9tYXRpY2FsbHkpCit7CisgICAgUmV0YWluUHRyPFdLUHJlZmVyZW5jZXM+ IHByZWZlcmVuY2VzID0gYWRvcHROUyhbW1dLUHJlZmVyZW5jZXMgYWxsb2NdIGluaXRdKTsKKwor ICAgIEVYUEVDVF9UUlVFKFtwcmVmZXJlbmNlcyBfbG9hZHNJbWFnZXNBdXRvbWF0aWNhbGx5XSk7 CisgICAgW3ByZWZlcmVuY2VzIF9zZXRMb2Fkc0ltYWdlc0F1dG9tYXRpY2FsbHk6Tk9dOworICAg IEVYUEVDVF9GQUxTRShbcHJlZmVyZW5jZXMgX2xvYWRzSW1hZ2VzQXV0b21hdGljYWxseV0pOwor ICAgIFtwcmVmZXJlbmNlcyBfc2V0TG9hZHNJbWFnZXNBdXRvbWF0aWNhbGx5OllFU107CisgICAg RVhQRUNUX1RSVUUoW3ByZWZlcmVuY2VzIF9sb2Fkc0ltYWdlc0F1dG9tYXRpY2FsbHldKTsKK30K KwogVEVTVChXZWJLaXQyLCBFeHBlcmltZW50YWxGZWF0dXJlcykKIHsKICAgICBOU0FycmF5ICpm ZWF0dXJlcyA9IFtXS1ByZWZlcmVuY2VzIF9leHBlcmltZW50YWxGZWF0dXJlc107Cg==