166400 2016-12-21 17:11:15 -0800 WebAssembly: Fix decode floating point constants in unreachable code 2016-12-21 21:03:45 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 keith_miller keith_miller commit-queue mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1262208 0 keith_miller 2016-12-21 17:11:15 -0800 WebAssembly: Fix decode floating point constants in unreachable code 1262209 1 297635 keith_miller 2016-12-21 17:12:06 -0800 Created attachment 297635 Patch 1262210 2 297635 jfbastien 2016-12-21 17:15:45 -0800 Comment on attachment 297635 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297635&action=review lgtm > Source/JavaScriptCore/ChangeLog:8 > + We decoded these as variable length but they should be fixed length. Can you specify which test hits this? Does it now pass? 1262213 3 297635 saam 2016-12-21 17:19:14 -0800 Comment on attachment 297635 Patch r=me Please unskip the spec tests that now pass. 1262223 4 keith_miller 2016-12-21 17:26:54 -0800 Committed r210091: <http://trac.webkit.org/changeset/210091> 1262257 5 webkit-bug-importer 2016-12-21 21:03:44 -0800 <rdar://problem/29782833> 297635 2016-12-21 17:12:06 -0800 2016-12-21 17:19:14 -0800 Patch bug-166400-20161221171103.patch text/plain 2014 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjEwMDkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 MzJiZWIwYWJkNDE5NTc3OWQ1ZmFlNWUyOTY2ZTc3Yzc0MDQ3M2I4Li4yODUyNmZkYTBmZTc2NDYw M2UxODYwNGRjNGIyYmI4ZDE4M2QwZDkzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxNiBAQAogMjAxNi0xMi0yMSAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KIAorICAgICAgICBXZWJBc3NlbWJseTogRml4IGRlY29kZSBmbG9hdGluZyBwb2ludCBj b25zdGFudHMgaW4gdW5yZWFjaGFibGUgY29kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY2NDAwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV2UgZGVjb2RlZCB0aGVzZSBhcyB2YXJpYWJsZSBsZW5ndGgg YnV0IHRoZXkgc2hvdWxkIGJlIGZpeGVkIGxlbmd0aC4KKworICAgICAgICAqIHdhc20vV2FzbUZ1 bmN0aW9uUGFyc2VyLmg6CisKKzIwMTYtMTItMjEgIEtlaXRoIE1pbGxlciAgPGtlaXRoX21pbGxl ckBhcHBsZS5jb20+CisKICAgICAgICAgV2ViQXNzZW1ibHk6IEFsbG93IGJyLCBicl9pZiwgYW5k IGJyX3RhYmxlIHRvIGFjdCBhcyBhIHJldHVybgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY2MzkzCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS93YXNtL1dhc21GdW5jdGlvblBhcnNlci5oIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L3dhc20vV2FzbUZ1bmN0aW9uUGFyc2VyLmgKaW5kZXggNmFhZjhkYmFmMjE1YTE0MzIxMmNmMmJh OGEzMmEzYTg4ZjVjMmViNS4uYTYwYWM0Nzg1MDJiODU4ODhjODFlOGY5NTJjNTNhMTNlMjk1YTJi NyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vV2FzbUZ1bmN0aW9uUGFy c2VyLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vV2FzbUZ1bmN0aW9uUGFyc2Vy LmgKQEAgLTU0Nyw2ICs1NDcsMTggQEAgYXV0byBGdW5jdGlvblBhcnNlcjxDb250ZXh0Pjo6cGFy c2VVbnJlYWNoYWJsZUV4cHJlc3Npb24oT3BUeXBlIG9wKSAtPiBQYXJ0aWFsUmUKICAgICAgICAg cmV0dXJuIHsgfTsKICAgICB9CiAKKyAgICBjYXNlIEYzMkNvbnN0OiB7CisgICAgICAgIHVpbnQz Ml90IHVudXNlZDsKKyAgICAgICAgV0FTTV9QQVJTRVJfRkFJTF9JRighcGFyc2VVSW50MzIodW51 c2VkKSwgImNhbid0IHBhcnNlIDMyLWJpdCBmbG9hdGluZy1wb2ludCBjb25zdGFudCIpOworICAg ICAgICByZXR1cm4geyB9OworICAgIH0KKworICAgIGNhc2UgRjY0Q29uc3Q6IHsKKyAgICAgICAg dWludDY0X3QgY29uc3RhbnQ7CisgICAgICAgIFdBU01fUEFSU0VSX0ZBSUxfSUYoIXBhcnNlVUlu dDY0KGNvbnN0YW50KSwgImNhbid0IHBhcnNlIDY0LWJpdCBmbG9hdGluZy1wb2ludCBjb25zdGFu dCIpOworICAgICAgICByZXR1cm4geyB9OworICAgIH0KKwogICAgIC8vIHR3byBpbW1lZGlhdGUg Y2FzZXMKICAgICBGT1JfRUFDSF9XQVNNX01FTU9SWV9MT0FEX09QKENSRUFURV9DQVNFKQogICAg IEZPUl9FQUNIX1dBU01fTUVNT1JZX1NUT1JFX09QKENSRUFURV9DQVNFKSB7CkBAIC01NTcsOSAr NTY5LDcgQEAgYXV0byBGdW5jdGlvblBhcnNlcjxDb250ZXh0Pjo6cGFyc2VVbnJlYWNoYWJsZUV4 cHJlc3Npb24oT3BUeXBlIG9wKSAtPiBQYXJ0aWFsUmUKICAgICB9CiAKICAgICAvLyBvbmUgaW1t ZWRpYXRlIGNhc2VzCi0gICAgY2FzZSBGMzJDb25zdDoKICAgICBjYXNlIEkzMkNvbnN0OgotICAg IGNhc2UgRjY0Q29uc3Q6CiAgICAgY2FzZSBJNjRDb25zdDoKICAgICBjYXNlIFNldExvY2FsOgog ICAgIGNhc2UgR2V0TG9jYWw6Cg==