166367 2016-12-21 12:50:40 -0800 Holding down on candidates in the TouchBar should show panel on screen 2017-01-03 14:21:39 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin bdakin andersca bdakin dbates sam thorton wenson_hsieh oldest_to_newest 1262101 0 bdakin 2016-12-21 12:50:40 -0800 Holding down on candidates in the TouchBar should show panel on screen rdar://problem/28479236 1262105 1 297619 bdakin 2016-12-21 12:59:31 -0800 Created attachment 297619 Patch 1262131 2 bdakin 2016-12-21 13:31:37 -0800 Thanks Tim! https://trac.webkit.org/changeset/210075 1263494 3 dbates 2017-01-03 12:33:37 -0800 (In reply to comment #2) > Thanks Tim! https://trac.webkit.org/changeset/210075 This broke the Apple Sierra Release 32-bit build, which builds without Touch Bar support: [[ release/build/Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm:2991:6: error: use of undeclared identifier 'candidateListTouchBarItem' [candidateListTouchBarItem() setCandidates:candidates forSelectedRange:selectedRange inString:postLayoutData.paragraphContextForCandidateRequest rect:offsetSelectionRect view:m_view completionHandler:nil]; ^ ]] <https://build.webkit.org/builders/Apple%20Sierra%20Release%20%2832-bit%20Build%29/builds/2528/steps/compile-webkit/logs/stdio> 1263495 4 dbates 2017-01-03 12:35:30 -0800 (In reply to comment #3) > (In reply to comment #2) > > Thanks Tim! https://trac.webkit.org/changeset/210075 > > This broke the Apple Sierra Release 32-bit build, which builds without Touch > Bar support: > > [[ > release/build/Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm:2991:6: error: > use of undeclared identifier 'candidateListTouchBarItem' > [candidateListTouchBarItem() setCandidates:candidates > forSelectedRange:selectedRange > inString:postLayoutData.paragraphContextForCandidateRequest > rect:offsetSelectionRect view:m_view completionHandler:nil]; > ^ > ]] > <https://build.webkit.org/builders/Apple%20Sierra%20Release%20%2832- > bit%20Build%29/builds/2528/steps/compile-webkit/logs/stdio> Committed build fix in <https://trac.webkit.org/changeset/210245>. 1263496 5 dbates 2017-01-03 12:44:14 -0800 We should look to extract out the Touch Bar code from Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm or at least consolidate it at one end of this file. Currently the Touch Bar code is scattered throughout this file and in #if/else chunks that are many lines long. As demonstrated by the Apple Sierra Release 32-bit build failure (comment #3) it is easy to lose track of what chunk in the file is HAVE(TOUCH_BAR)-guarded or not. I needed to use an editor that supports collapsing code regions in order to be able to track the #if HAVE(TOUCH_BAR) and #else chunks. This significantly affects the hackability of this file and makes refactoring code in it error prone. 1263500 6 dbates 2017-01-03 12:55:03 -0800 Committed another attempt to fix the Apple Sierra Release 32-bit build in <https://trac.webkit.org/changeset/210247>. 1263503 7 ap 2017-01-03 13:01:51 -0800 We need to update Xcode on this bot; I don't think that this is a supported configuration any more. 1263545 8 ap 2017-01-03 14:21:39 -0800 Ryan took care of updating it. 297619 2016-12-21 12:59:31 -0800 2016-12-21 13:03:28 -0800 Patch for-review.txt text/plain 8529 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMDA3MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE2LTEyLTIxICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBIb2xkaW5nIGRvd24gb24gY2FuZGlk YXRlcyBpbiB0aGUgVG91Y2hCYXIgc2hvdWxkIHNob3cgcGFuZWwgb24gc2NyZWVuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjYzNjcKKyAgICAgICAg LWFuZCBjb3JyZXNwb25kaW5nLQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjg0NzkyMzY+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRXhwb3NlIHRo ZSB2ZXJzaW9uIG9mIHNldENhbmRpZGF0ZXM6IHRoYXQgdGFrZXMgYSByZWN0LgorICAgICAgICAq IHBsYXRmb3JtL3NwaS9jb2NvYS9OU1RvdWNoQmFyU1BJLmg6CisKIDIwMTYtMTItMjEgIEVyaWMg Q2FybHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgW01lZGlhU3RyZWFt XSBNZWRpYVBsYXllclByaXZhdGVNZWRpYVN0cmVhbUFWRk9iakM6OmVuc3VyZUxheWVyIGNhbiBi ZSBjYWxsZWQgYmVmb3JlIGl0IGhhcyBhIG1lZGlhIHN0cmVhbQpJbmRleDogU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vc3BpL2NvY29hL05TVG91Y2hCYXJTUEkuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9zcGkvY29jb2EvTlNUb3VjaEJhclNQSS5oCShyZXZpc2lvbiAy MDk5OTIpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9zcGkvY29jb2EvTlNUb3VjaEJhclNQ SS5oCSh3b3JraW5nIGNvcHkpCkBAIC0yNyw2ICsyNyw3IEBACiAKICNpZiBVU0UoQVBQTEVfSU5U RVJOQUxfU0RLKQogCisjaW1wb3J0IDxBcHBLaXQvTlNDYW5kaWRhdGVMaXN0VG91Y2hCYXJJdGVt X1ByaXZhdGUuaD4KICNpbXBvcnQgPEFwcEtpdC9OU0Z1bmN0aW9uQmFyX1ByaXZhdGUuaD4KICNp bXBvcnQgPEFwcEtpdC9OU1RleHRUb3VjaEJhckl0ZW1Db250cm9sbGVyX1dlYktpdFNQSS5oPgog I2ltcG9ydCA8QXBwS2l0L05TVG91Y2hCYXJfUHJpdmF0ZS5oPgpAQCAtNTQsNiArNTUsMTAgQEAg TlNfQVNTVU1FX05PTk5VTExfQkVHSU4KIAogQGVuZAogCitAaW50ZXJmYWNlIE5TQ2FuZGlkYXRl TGlzdFRvdWNoQmFySXRlbSAoKQorLSAodm9pZClzZXRDYW5kaWRhdGVzOihOU0FycmF5ICopY2Fu ZGlkYXRlcyBmb3JTZWxlY3RlZFJhbmdlOihOU1JhbmdlKXNlbGVjdGVkUmFuZ2UgaW5TdHJpbmc6 KG51bGxhYmxlIE5TU3RyaW5nICopc3RyaW5nIHJlY3Q6KE5TUmVjdClyZWN0IHZpZXc6KG51bGxh YmxlIE5TVmlldyAqKXZpZXcgY29tcGxldGlvbkhhbmRsZXI6KG51bGxhYmxlIHZvaWQgKF4pKGlk IGFjY2VwdGVkQ2FuZGlkYXRlKSljb21wbGV0aW9uQmxvY2s7CitAZW5kCisKICNlbmRpZiAvLyAh VVNFKEFQUExFX0lOVEVSTkFMX1NESykKIAogQVBQS0lUX0VYVEVSTiBOU05vdGlmaWNhdGlvbk5h bWUgY29uc3QgTlNUb3VjaEJhcldpbGxFbnRlckN1c3RvbWl6YXRpb24gQVBJX0FWQUlMQUJMRSht YWNvc3goMTAuMTIuMikpOwpJbmRleDogU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwkocmV2aXNpb24gMjEwMDczKQorKysgU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjMgQEAKKzIw MTYtMTItMjEgIEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgorCisgICAgICAgIEhvbGRp bmcgZG93biBvbiBjYW5kaWRhdGVzIGluIHRoZSBUb3VjaEJhciBzaG91bGQgc2hvdyBwYW5lbCBv biBzY3JlZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE2NjM2NworICAgICAgICAtYW5kIGNvcnJlc3BvbmRpbmctCisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS8yODQ3OTIzNj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUaGUgc2hvd0NhbmRpZGF0ZXMoKSBoZWxwZXIgZnVuY3Rpb24gaXMgbm90IG5lZWRl ZC4gV2UgY2FuIGNhbGwgdGhlIEFwcEtpdCBtZXRob2QgCisgICAgICAgIGRpcmVjdGx5IGF0IHRo ZSBvbmUgY2FsbCBzaXRlLgorICAgICAgICAqIFVJUHJvY2Vzcy9Db2NvYS9XZWJWaWV3SW1wbC5o OgorICAgICAgICAqIFVJUHJvY2Vzcy9Db2NvYS9XZWJWaWV3SW1wbC5tbToKKworICAgICAgICBU aGUgcGFuZWwgc2hvdWxkIGFwcGVhciB1bmRlciB0aGUgc2VsZWN0aW9uLCBzbyBvZmZzZXQgdGhl IHNlbGVjdGlvbiByZWN0LgorICAgICAgICAoV2ViS2l0OjpXZWJWaWV3SW1wbDo6aGFuZGxlUmVx dWVzdGVkQ2FuZGlkYXRlcyk6CisKKyAgICAgICAgTm8gbW9yZSBzaG93Q2FuZGlkYXRlcygpIHNp bmNlIHdlIGNhbiBjYWxsIGl0IGRpcmVjdGx5LiAKKyAgICAgICAgKFdlYktpdDo6V2ViVmlld0lt cGw6OnNob3dDYW5kaWRhdGVzKTogRGVsZXRlZC4KKwogMjAxNi0xMi0yMCAgVGFyYXMgVHN1Z3Jp aSAgPHR0c3VncmlpQGZiLmNvbT4KIAogICAgICAgICBGaXggdW5kZWZpbmVkIGJlaGF2aW9yIGNh dXNlZCBieSBtYWNybyBleHBhbnNpb24gcHJvZHVjaW5nICdkZWZpbmVkJwpJbmRleDogU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0NvY29hL1dlYlZpZXdJbXBsLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0NvY29hL1dlYlZpZXdJbXBsLmgJKHJldmlzaW9uIDIwOTk5 MikKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db2NvYS9XZWJWaWV3SW1wbC5oCSh3b3Jr aW5nIGNvcHkpCkBAIC00OTMsNyArNDkzLDYgQEAgcHVibGljOgogCiAgICAgdm9pZCBmb3JjZVJl cXVlc3RDYW5kaWRhdGVzRm9yVGVzdGluZygpOwogICAgIGJvb2wgc2hvdWxkUmVxdWVzdENhbmRp ZGF0ZXMoKSBjb25zdDsKLSAgICB2b2lkIHNob3dDYW5kaWRhdGVzKE5TQXJyYXkgKmNhbmRpZGF0 ZXMsIE5TU3RyaW5nICosIE5TUmVjdCByZWN0T2ZUeXBlZFN0cmluZywgTlNSYW5nZSBzZWxlY3Rl ZFJhbmdlLCBOU1ZpZXcgKiwgdm9pZCAoXmNvbXBsZXRpb25IYW5kbGVyKShOU1RleHRDaGVja2lu Z1Jlc3VsdCAqYWNjZXB0ZWRDYW5kaWRhdGUpKTsKIAogICAgIGJvb2wgd2luZG93SXNGcm9udFdp bmRvd1VuZGVyTW91c2UoTlNFdmVudCAqKTsKIApJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0NvY29hL1dlYlZpZXdJbXBsLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9Db2NvYS9XZWJWaWV3SW1wbC5tbQkocmV2aXNpb24gMjA5OTkyKQorKysgU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0NvY29hL1dlYlZpZXdJbXBsLm1tCSh3b3JraW5nIGNvcHkpCkBA IC0xMTgzLDExICsxMTgzLDYgQEAgYm9vbCBXZWJWaWV3SW1wbDo6c2hvdWxkUmVxdWVzdENhbmRp ZGF0ZQogICAgIHJldHVybiAhbV9wYWdlLT5lZGl0b3JTdGF0ZSgpLmlzSW5QYXNzd29yZEZpZWxk ICYmIGNhbmRpZGF0ZUxpc3RUb3VjaEJhckl0ZW0oKS5jYW5kaWRhdGVMaXN0VmlzaWJsZTsKIH0K IAotdm9pZCBXZWJWaWV3SW1wbDo6c2hvd0NhbmRpZGF0ZXMoTlNBcnJheSAqY2FuZGlkYXRlcywg TlNTdHJpbmcgKnN0cmluZywgTlNSZWN0IHJlY3RPZlR5cGVkU3RyaW5nLCBOU1JhbmdlIHNlbGVj dGVkUmFuZ2UsIE5TVmlldyAqdmlldywgdm9pZCAoXmNvbXBsZXRpb25IYW5kbGVyKShOU1RleHRD aGVja2luZ1Jlc3VsdCAqYWNjZXB0ZWRDYW5kaWRhdGUpKQotewotICAgIFtjYW5kaWRhdGVMaXN0 VG91Y2hCYXJJdGVtKCkgc2V0Q2FuZGlkYXRlczpjYW5kaWRhdGVzIGZvclNlbGVjdGVkUmFuZ2U6 c2VsZWN0ZWRSYW5nZSBpblN0cmluZzpzdHJpbmddOwotfQotCiB2b2lkIFdlYlZpZXdJbXBsOjpz ZXRFZGl0YWJsZUVsZW1lbnRJc0ZvY3VzZWQoYm9vbCBlZGl0YWJsZUVsZW1lbnRJc0ZvY3VzZWQp CiB7CiAgICAgbV9lZGl0YWJsZUVsZW1lbnRJc0ZvY3VzZWQgPSBlZGl0YWJsZUVsZW1lbnRJc0Zv Y3VzZWQ7CkBAIC0xMjEyLDEwICsxMjA3LDYgQEAgYm9vbCBXZWJWaWV3SW1wbDo6c2hvdWxkUmVx dWVzdENhbmRpZGF0ZQogICAgIHJldHVybiBmYWxzZTsKIH0KIAotdm9pZCBXZWJWaWV3SW1wbDo6 c2hvd0NhbmRpZGF0ZXMoTlNBcnJheSAqY2FuZGlkYXRlcywgTlNTdHJpbmcgKnN0cmluZywgTlNS ZWN0IHJlY3RPZlR5cGVkU3RyaW5nLCBOU1JhbmdlIHNlbGVjdGVkUmFuZ2UsIE5TVmlldyAqdmll dywgdm9pZCAoXmNvbXBsZXRpb25IYW5kbGVyKShOU1RleHRDaGVja2luZ1Jlc3VsdCAqYWNjZXB0 ZWRDYW5kaWRhdGUpKQotewotfQotCiB2b2lkIFdlYlZpZXdJbXBsOjpzZXRFZGl0YWJsZUVsZW1l bnRJc0ZvY3VzZWQoYm9vbCBlZGl0YWJsZUVsZW1lbnRJc0ZvY3VzZWQpCiB7CiAgICAgbV9lZGl0 YWJsZUVsZW1lbnRJc0ZvY3VzZWQgPSBlZGl0YWJsZUVsZW1lbnRJc0ZvY3VzZWQ7CkBAIC0yOTk0 LDEzICsyOTg1LDEwIEBAIHZvaWQgV2ViVmlld0ltcGw6OmhhbmRsZVJlcXVlc3RlZENhbmRpZGEK IAogICAgIE5TUmFuZ2Ugc2VsZWN0ZWRSYW5nZSA9IE5TTWFrZVJhbmdlKHBvc3RMYXlvdXREYXRh LmNhbmRpZGF0ZVJlcXVlc3RTdGFydFBvc2l0aW9uLCBwb3N0TGF5b3V0RGF0YS5zZWxlY3RlZFRl eHRMZW5ndGgpOwogICAgIGF1dG8gd2Vha1RoaXMgPSBjcmVhdGVXZWFrUHRyKCk7Ci0gICAgc2hv d0NhbmRpZGF0ZXMoY2FuZGlkYXRlcywgcG9zdExheW91dERhdGEucGFyYWdyYXBoQ29udGV4dEZv ckNhbmRpZGF0ZVJlcXVlc3QsIHBvc3RMYXlvdXREYXRhLnNlbGVjdGlvbkNsaXBSZWN0LCBzZWxl Y3RlZFJhbmdlLCBtX3ZpZXcsIFt3ZWFrVGhpc10oTlNUZXh0Q2hlY2tpbmdSZXN1bHQgKmFjY2Vw dGVkQ2FuZGlkYXRlKSB7Ci0gICAgICAgIGRpc3BhdGNoX2FzeW5jKGRpc3BhdGNoX2dldF9tYWlu X3F1ZXVlKCksIF57Ci0gICAgICAgICAgICBpZiAoIXdlYWtUaGlzKQotICAgICAgICAgICAgICAg IHJldHVybjsKLSAgICAgICAgICAgIHdlYWtUaGlzLT5oYW5kbGVBY2NlcHRlZENhbmRpZGF0ZShh Y2NlcHRlZENhbmRpZGF0ZSk7Ci0gICAgICAgIH0pOwotICAgIH0pOworICAgIFdlYkNvcmU6Oklu dFJlY3Qgb2Zmc2V0U2VsZWN0aW9uUmVjdCA9IHBvc3RMYXlvdXREYXRhLnNlbGVjdGlvbkNsaXBS ZWN0OworICAgIG9mZnNldFNlbGVjdGlvblJlY3QubW92ZSgwLCBvZmZzZXRTZWxlY3Rpb25SZWN0 LmhlaWdodCgpKTsKKworICAgIFtjYW5kaWRhdGVMaXN0VG91Y2hCYXJJdGVtKCkgc2V0Q2FuZGlk YXRlczpjYW5kaWRhdGVzIGZvclNlbGVjdGVkUmFuZ2U6c2VsZWN0ZWRSYW5nZSBpblN0cmluZzpw b3N0TGF5b3V0RGF0YS5wYXJhZ3JhcGhDb250ZXh0Rm9yQ2FuZGlkYXRlUmVxdWVzdCByZWN0Om9m ZnNldFNlbGVjdGlvblJlY3QgdmlldzptX3ZpZXcgY29tcGxldGlvbkhhbmRsZXI6bmlsXTsKIH0K IAogc3RhdGljIFdlYkNvcmU6OlRleHRDaGVja2luZ1Jlc3VsdCB0ZXh0Q2hlY2tpbmdSZXN1bHRG cm9tTlNUZXh0Q2hlY2tpbmdSZXN1bHQoTlNUZXh0Q2hlY2tpbmdSZXN1bHQgKm5zUmVzdWx0KQpJ bmRleDogU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQvbWFjL0NoYW5nZUxvZwkocmV2aXNpb24gMjEwMDczKQorKysgU291cmNlL1dlYktpdC9t YWMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTYtMTItMjEg IEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgorCisgICAgICAgIEhvbGRpbmcgZG93biBv biBjYW5kaWRhdGVzIGluIHRoZSBUb3VjaEJhciBzaG91bGQgc2hvdyBwYW5lbCBvbiBzY3JlZW4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NjM2Nwor ICAgICAgICAtYW5kIGNvcnJlc3BvbmRpbmctCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yODQ3 OTIzNj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBT dHJheSB3aGl0ZXNwYWNlLgorICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L1dlYkVkaXRvckNsaWVu dC5tbToKKyAgICAgICAgKFdlYkVkaXRvckNsaWVudDo6aGFuZGxlUmVxdWVzdGVkQ2FuZGlkYXRl cyk6CisKKyAgICAgICAgQ2FsbCB0aGUgdmVyc2lvbiBvZiBzZXRDYW5kaWRhdGVzOiB0aGF0IHRh a2VzIGEgcmVjdC4gV2UgbmVlZCB0byBrZWVwIHRoZSBoZWxwZXIgCisgICAgICAgIGZ1bmN0aW9u IGluIFdLMSAodW5saWtlIFdLMikgc2luY2Ugd2UgYWxzbyB1c2UgaXQgZm9yIHRlc3RpbmcuCisg ICAgICAgICogV2ViVmlldy9XZWJWaWV3Lm1tOgorICAgICAgICAoLVtXZWJWaWV3IHNob3dDYW5k aWRhdGVzOmZvclN0cmluZzppblJlY3Q6Zm9yU2VsZWN0ZWRSYW5nZTp2aWV3OmNvbXBsZXRpb25I YW5kbGVyOl0pOgorCiAyMDE2LTEyLTIwICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4K IAogICAgICAgICBSZW1vdmUgSU5ESUVfVUkKSW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL1dlYkNv cmVTdXBwb3J0L1dlYkVkaXRvckNsaWVudC5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0 L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJFZGl0b3JDbGllbnQubW0JKHJldmlzaW9uIDIwOTk5MikK KysrIFNvdXJjZS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYkVkaXRvckNsaWVudC5tbQko d29ya2luZyBjb3B5KQpAQCAtMTI0OCw3ICsxMjQ4LDYgQEAgdm9pZCBXZWJFZGl0b3JDbGllbnQ6 OmhhbmRsZVJlcXVlc3RlZENhbgogICAgICAgICByZWN0Rm9yU2VsZWN0aW9uQ2FuZGlkYXRlcyA9 IGZyYW1lLT52aWV3KCktPmNvbnRlbnRzVG9XaW5kb3cocXVhZHNbMF0uZW5jbG9zaW5nQm91bmRp bmdCb3goKSk7CiAKICAgICBbbV93ZWJWaWV3IHNob3dDYW5kaWRhdGVzOmNhbmRpZGF0ZXMgZm9y U3RyaW5nOm1fcGFyYWdyYXBoQ29udGV4dEZvckNhbmRpZGF0ZVJlcXVlc3QuZ2V0KCkgaW5SZWN0 OnJlY3RGb3JTZWxlY3Rpb25DYW5kaWRhdGVzIGZvclNlbGVjdGVkUmFuZ2U6bV9yYW5nZUZvckNh bmRpZGF0ZXMgdmlldzptX3dlYlZpZXcgY29tcGxldGlvbkhhbmRsZXI6bmlsXTsKLQogfQogCiB2 b2lkIFdlYkVkaXRvckNsaWVudDo6aGFuZGxlQWNjZXB0ZWRDYW5kaWRhdGVXaXRoU29mdFNwYWNl cyhUZXh0Q2hlY2tpbmdSZXN1bHQgYWNjZXB0ZWRDYW5kaWRhdGUpCkluZGV4OiBTb3VyY2UvV2Vi S2l0L21hYy9XZWJWaWV3L1dlYlZpZXcubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9t YWMvV2ViVmlldy9XZWJWaWV3Lm1tCShyZXZpc2lvbiAyMDk5OTIpCisrKyBTb3VyY2UvV2ViS2l0 L21hYy9XZWJWaWV3L1dlYlZpZXcubW0JKHdvcmtpbmcgY29weSkKQEAgLTUwMjcsNyArNTAyNyw3 IEBAIC0gKHZvaWQpX3NldEZvbnRGYWxsYmFja1ByZWZlcnNQaWN0b2dyYXAKIAogLSAodm9pZClz aG93Q2FuZGlkYXRlczooTlNBcnJheTxOU1RleHRDaGVja2luZ1Jlc3VsdCAqPiAqKWNhbmRpZGF0 ZXMgZm9yU3RyaW5nOihOU1N0cmluZyAqKXN0cmluZyBpblJlY3Q6KE5TUmVjdClyZWN0T2ZUeXBl ZFN0cmluZyBmb3JTZWxlY3RlZFJhbmdlOihOU1JhbmdlKXJhbmdlIHZpZXc6KE5TVmlldyAqKXZp ZXcgY29tcGxldGlvbkhhbmRsZXI6KHZvaWQgKF4pKE5TVGV4dENoZWNraW5nUmVzdWx0ICphY2Nl cHRlZENhbmRpZGF0ZSkpY29tcGxldGlvbkJsb2NrCiB7Ci0gICAgW3NlbGYuY2FuZGlkYXRlTGlz dCBzZXRDYW5kaWRhdGVzOmNhbmRpZGF0ZXMgZm9yU2VsZWN0ZWRSYW5nZTpyYW5nZSBpblN0cmlu ZzpzdHJpbmddOworICAgIFtzZWxmLmNhbmRpZGF0ZUxpc3Qgc2V0Q2FuZGlkYXRlczpjYW5kaWRh dGVzIGZvclNlbGVjdGVkUmFuZ2U6cmFuZ2UgaW5TdHJpbmc6c3RyaW5nIHJlY3Q6cmVjdE9mVHlw ZWRTdHJpbmcgdmlldzp2aWV3IGNvbXBsZXRpb25IYW5kbGVyOmNvbXBsZXRpb25CbG9ja107CiB9 CiAKIC0gKEJPT0wpc2hvdWxkUmVxdWVzdENhbmRpZGF0ZXMK