166356 2016-12-21 11:28:41 -0800 WebKitTestRunner: Add comment to TestRunner::setCanOpenWindows() 2019-05-02 16:17:12 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 dbates webkit-unassigned andersca ap EmmaGSherman lforschler sam oldest_to_newest 1262045 0 dbates 2016-12-21 11:28:41 -0800 The remark in the patch for bug #43389 makes it unclear whether we should remove the test plugins/get-url-with-blank-target.html. Should we feel this test has value and want to keep it then we will need to implement testRunner.setCanOpenWindows() in WebKitTestRunner such that WebKitTestRunner forbids opening windows by default (this matches the behavior in DumpRenderTree). We should update the comment in TestRunner::setCanOpenWindows() to explain its purpose should we decide to keep the test plugins/get-url-with-blank-target.html. 1262047 1 297610 dbates 2016-12-21 11:33:45 -0800 Created attachment 297610 Patch - add comment 1262048 2 dbates 2016-12-21 11:36:42 -0800 Committed r210070: <http://trac.webkit.org/changeset/210070> 297610 2016-12-21 11:33:45 -0800 2016-12-21 11:35:33 -0800 Patch - add comment Bug166356.patch text/plain 5525 dbates RnJvbSBkMWQ0MjMxYmQ0ODlhYjAyYTE0YmRkMTY5NDA5ZjlmYmRkNDU2YTQyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYW5pZWwgQmF0ZXMgPGRiYXRlc0B3ZWJraXQub3JnPgpEYXRl OiBXZWQsIDIxIERlYyAyMDE2IDExOjMwOjQ1IC0wODAwClN1YmplY3Q6IFtQQVRDSF0gV2ViS2l0 VGVzdFJ1bm5lcjogQWRkIGNvbW1lbnQgdG8KIFRlc3RSdW5uZXI6OnNldENhbk9wZW5XaW5kb3dz KCkKIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjYzNTYKClJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKVG9vbHM6CgpBZGQgY29tbWVudCBpbiBUZXN0UnVubmVy OjpzZXRDYW5PcGVuV2luZG93cygpIHRvIGVsYWJvcmF0ZSBmdXJ0aGVyIG9uIGl0cyBwdXJwb3Nl CmFzIGEgbWVhbnMgdG8gYWxsb3cgYSB0ZXN0IHRvIGV4cGxpY2l0IGFsbG93IGFuIGVtYmVkZGlu ZyBjbGllbnQgdG8gb3BlbiBhIG5ldyB3aW5kb3dzCnN1Y2ggdGhhdCB0aGUgZGVmYXVsdCBiZWhh dmlvciBpcyBmb3IgdGhlIGVtYmVkZGluZyBjbGllbnQgdG8gZm9yYmlkIHN1Y2ggYW4gYWN0aW9u LgpUaGUgdGVzdCBwbHVnaW5zL2dldC11cmwtd2l0aC1ibGFuay10YXJnZXQuaHRtbCBhc3N1bWVz IHRoaXMgZGVmYXVsdCBiZWhhdmlvciB0aG91Z2gKaXQgaXMgY3VycmVudGx5IHNraXBwZWQgb24g V2ViS2l0MiBiZWNhdXNlIHF1ZXN0aW9ucyB3ZXJlIHJhaXNlZCBpbiB0aGUgcGF0Y2ggZm9yCjxo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDMzODk+IGFib3V0IGl0cyBj b3JyZWN0bmVzcyBhbmQgdXNlZnVsbmVzcy4KV2Ugd2lsbCBuZWVkIHRvIGltcGxlbWVudCBUZXN0 UnVubmVyOjpzZXRDYW5PcGVuV2luZG93cygpIHNob3VsZCB3ZSBkZWNpZGUgdG8gdW5za2lwCnRo aXMgdGVzdC4KCiogV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9UZXN0UnVubmVyLmNw cDoKKFdUUjo6VGVzdFJ1bm5lcjo6c2V0Q2FuT3BlbldpbmRvd3MpOgoKTGF5b3V0VGVzdHM6CgpB ZGQgYSByZW1hcmsgdGhhdCB0aGUgdGVzdCBwbHVnaW5zL2dldC11cmwtd2l0aC1ibGFuay10YXJn ZXQuaHRtbCBkZXBlbmRzIG9uCnRoZSBhc3N1bXB0aW9uIHRoYXQgV2ViS2l0VGVzdFJ1bm5lciBm b3JiaWRzIG9wZW5pbmcgd2luZG93cyBieSBkZWZhdWx0LgoKKiBwbGF0Zm9ybS93azIvVGVzdEV4 cGVjdGF0aW9uczoKLS0tCiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHwgMTIgKysrKysrKysrKysrCiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS93azIv VGVzdEV4cGVjdGF0aW9ucyAgICAgICAgICAgIHwgIDMgKystCiBUb29scy9DaGFuZ2VMb2cgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgMTkgKysrKysrKysrKysrKysrKysr KwogVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9UZXN0UnVubmVyLmNwcCB8 ICA5ICsrKysrKystLQogNCBmaWxlcyBjaGFuZ2VkLCA0MCBpbnNlcnRpb25zKCspLCAzIGRlbGV0 aW9ucygtKQoKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwppbmRleCBhYzcxNDAyLi5jMmYxMjlhOCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBA CisyMDE2LTEyLTIxICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAg ICBXZWJLaXRUZXN0UnVubmVyOiBBZGQgY29tbWVudCB0byBUZXN0UnVubmVyOjpzZXRDYW5PcGVu V2luZG93cygpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNjYzNTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBZGQgYSByZW1hcmsgdGhhdCB0aGUgdGVzdCBwbHVnaW5zL2dldC11cmwtd2l0aC1ibGFuay10 YXJnZXQuaHRtbCBkZXBlbmRzIG9uCisgICAgICAgIHRoZSBhc3N1bXB0aW9uIHRoYXQgV2ViS2l0 VGVzdFJ1bm5lciBmb3JiaWRzIG9wZW5pbmcgd2luZG93cyBieSBkZWZhdWx0LgorCisgICAgICAg ICogcGxhdGZvcm0vd2syL1Rlc3RFeHBlY3RhdGlvbnM6CisKIDIwMTYtMTItMjAgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggbWVtb3J5IGxl YWsgaW4gbWFsZm9ybWVkIHRlc3QKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3dr Mi9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2syL1Rlc3RFeHBlY3Rh dGlvbnMKaW5kZXggNjdjODFkYS4uNWRhYjI4NiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxh dGZvcm0vd2syL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2sy L1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTMxNSw3ICszMTUsOCBAQCBwbHVnaW5zL3BsdWdpbi1kb2N1 bWVudC13aWxsU2VuZFJlcXVlc3QtbnVsbC5odG1sIFsgU2tpcCBdCiBwbHVnaW5zL3BsdWdpbi1y ZW1vdmUtcmVhZHlzdGF0ZWNoYW5nZS5odG1sIFsgU2tpcCBdCiAKICMgVGhpcyB0ZXN0IGNoZWNr cyB0aGF0IE5QTl9HZXRVUkwgd2l0aCBhIGJsYW5rIHRhcmdldCB3aWxsIHJldHVybiBhbiBlcnJv ciBpZiB0aGUgd2luZG93IGlzbid0IG9wZW5lZC4gVGhpcyBiZWhhdmlvciBkb2Vzbid0Ci0jIG1h dGNoIEZpcmVmb3ggb3IgQ2hyb21lLiBXZSBzaG91bGQgZWl0aGVyIGZpeCB0aGUgdGVzdCwgb3Ig Z2V0IHJpZCBvZiBpdC4KKyMgbWF0Y2ggRmlyZWZveCBvciBDaHJvbWUuIFdlIHNob3VsZCBlaXRo ZXIgZml4IHRoZSB0ZXN0LCBvciBnZXQgcmlkIG9mIGl0LiBUaGlzIHRlc3QgYWxzbyBkZXBlbmRz IG9uIGltcGxlbWVudGluZworIyB0ZXN0UnVubmVyOjpzZXRDYW5PcGVuV2luZG93cygpIHN1Y2gg dGhhdCBvcGVuaW5nIHdpbmRvd3MgYXJlIGZvcmJpZGRlbiBieSBkZWZhdWx0LgogcGx1Z2lucy9n ZXQtdXJsLXdpdGgtYmxhbmstdGFyZ2V0Lmh0bWwKIAogIyByZXF1aXJlcyB2aWRlby5idWZmZXJl ZCB0byBiZSBhYmxlIHRvIHJldHVybiBtdWx0aXBsZSB0aW1lcmFuZ2VzCmRpZmYgLS1naXQgYS9U b29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzFhYzliMy4uYmEwZDBmZSAx MDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDIyIEBACisyMDE2LTEyLTIxICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4K KworICAgICAgICBXZWJLaXRUZXN0UnVubmVyOiBBZGQgY29tbWVudCB0byBUZXN0UnVubmVyOjpz ZXRDYW5PcGVuV2luZG93cygpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNjYzNTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBBZGQgY29tbWVudCBpbiBUZXN0UnVubmVyOjpzZXRDYW5PcGVuV2luZG93cygp IHRvIGVsYWJvcmF0ZSBmdXJ0aGVyIG9uIGl0cyBwdXJwb3NlCisgICAgICAgIGFzIGEgbWVhbnMg dG8gYWxsb3cgYSB0ZXN0IHRvIGV4cGxpY2l0IGFsbG93IGFuIGVtYmVkZGluZyBjbGllbnQgdG8g b3BlbiBhIG5ldyB3aW5kb3dzCisgICAgICAgIHN1Y2ggdGhhdCB0aGUgZGVmYXVsdCBiZWhhdmlv ciBpcyBmb3IgdGhlIGVtYmVkZGluZyBjbGllbnQgdG8gZm9yYmlkIHN1Y2ggYW4gYWN0aW9uLgor ICAgICAgICBUaGUgdGVzdCBwbHVnaW5zL2dldC11cmwtd2l0aC1ibGFuay10YXJnZXQuaHRtbCBh c3N1bWVzIHRoaXMgZGVmYXVsdCBiZWhhdmlvciB0aG91Z2gKKyAgICAgICAgaXQgaXMgY3VycmVu dGx5IHNraXBwZWQgb24gV2ViS2l0MiBiZWNhdXNlIHF1ZXN0aW9ucyB3ZXJlIHJhaXNlZCBpbiB0 aGUgcGF0Y2ggZm9yCisgICAgICAgIDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NDMzODk+IGFib3V0IGl0cyBjb3JyZWN0bmVzcyBhbmQgdXNlZnVsbmVzcy4KKyAgICAg ICAgV2Ugd2lsbCBuZWVkIHRvIGltcGxlbWVudCBUZXN0UnVubmVyOjpzZXRDYW5PcGVuV2luZG93 cygpIHNob3VsZCB3ZSBkZWNpZGUgdG8gdW5za2lwCisgICAgICAgIHRoaXMgdGVzdC4KKworICAg ICAgICAqIFdlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvVGVzdFJ1bm5lci5jcHA6Cisg ICAgICAgIChXVFI6OlRlc3RSdW5uZXI6OnNldENhbk9wZW5XaW5kb3dzKToKKwogMjAxNi0xMi0x OSAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWlsLmNvbT4KIAogICAgICAgICBbRVM2 XSBFbmFibGUgRVM2IE1vZHVsZXMKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIv SW5qZWN0ZWRCdW5kbGUvVGVzdFJ1bm5lci5jcHAgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0lu amVjdGVkQnVuZGxlL1Rlc3RSdW5uZXIuY3BwCmluZGV4IDE0MTMxMjMuLmIzYmY5OTUgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvVGVzdFJ1bm5lci5j cHAKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9UZXN0UnVubmVy LmNwcApAQCAtMzI5LDggKzMyOSwxMyBAQCBib29sIFRlc3RSdW5uZXI6OmlzQ29tbWFuZEVuYWJs ZWQoSlNTdHJpbmdSZWYgbmFtZSkKIAogdm9pZCBUZXN0UnVubmVyOjpzZXRDYW5PcGVuV2luZG93 cyhib29sKQogewotICAgIC8vIEl0J3Mgbm90IGNsZWFyIGlmIG9yIHdoeSBhbnkgdGVzdHMgcmVx dWlyZSBvcGVuaW5nIHdpbmRvd3MgYmUgZm9yYmlkZGVuLgotICAgIC8vIEZvciBub3csIGp1c3Qg aWdub3JlIHRoaXMgc2V0dGluZywgYW5kIGlmIHdlIGZpbmQgbGF0ZXIgaXQncyBuZWVkZWQgd2Ug Y2FuIGFkZCBpdC4KKyAgICAvLyBUaGUgdGVzdCBwbHVnaW5zL2dldC11cmwtd2l0aC1ibGFuay10 YXJnZXQuaHRtbCByZXF1aXJlcyB0aGF0IHRoZSBlbWJlZGRpbmcgY2xpZW50IGZvcmJpZAorICAg IC8vIG9wZW5pbmcgd2luZG93cyAoYnkgb21pdHRpbmcgYSBjYWxsIHRvIHRoaXMgZnVuY3Rpb24p IHNvIGFzIHRvIHRlc3QgdGhhdCBOUE5fR2V0VVJMKCkKKyAgICAvLyB3aXRoIGEgYmxhbmsgdGFy Z2V0IHdpbGwgcmV0dXJuIGFuIGVycm9yLgorICAgIC8vCisgICAgLy8gSXQgaXMgbm90IGNsZWFy IGlmIHdlIHNob3VsZCBpbXBsZW1lbnQgdGhpcyBmdW5jdGlvbmFsaXR5IG9yIHJlbW92ZSBpdCBh bmQgcGx1Z2lucy9nZXQtdXJsLXdpdGgtYmxhbmstdGFyZ2V0Lmh0bWwKKyAgICAvLyBwZXIgdGhl IHJlbWFyayBpbiA8aHR0cHM6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzY0NTA0L3RydW5r L0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvU2tpcHBlZD4uCisgICAgLy8gRm9yIG5vdywg anVzdCBpZ25vcmUgdGhpcyBzZXR0aW5nLgogfQogCiB2b2lkIFRlc3RSdW5uZXI6OnNldFhTU0F1 ZGl0b3JFbmFibGVkKGJvb2wgZW5hYmxlZCkKLS0gCjIuOC40IChBcHBsZSBHaXQtNzMpCgo=