166346 2016-12-21 10:27:27 -0800 [WebRTC] Add support for runtime PeerConnection setting, required after r209757 2016-12-22 01:23:30 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 165251 1 alex alex berto bugs-noreply cgarcia commit-queue darin eric.carlson gustavo mcatanzaro mrobinson youennf oldest_to_newest 1262006 0 alex 2016-12-21 10:27:27 -0800 After that commit webrtc is controlled using a runtime flags, we are going to enable by default and use the same gUM setting for both things in our case. 1262024 1 297604 alex 2016-12-21 10:46:24 -0800 Created attachment 297604 Patch 1262027 2 commit-queue 2016-12-21 10:48:39 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1262274 3 297604 cgarcia 2016-12-22 00:44:42 -0800 Comment on attachment 297604 Patch Ok, I guess it makes sense to reuse the media stream setting for now. 1262278 4 297604 commit-queue 2016-12-22 01:23:26 -0800 Comment on attachment 297604 Patch Clearing flags on attachment: 297604 Committed r210096: <http://trac.webkit.org/changeset/210096> 1262279 5 commit-queue 2016-12-22 01:23:30 -0800 All reviewed patches have been landed. Closing bug. 297604 2016-12-21 10:46:24 -0800 2016-12-22 01:23:26 -0800 Patch bug-166346-20161221194520.patch text/plain 2992 alex U3VidmVyc2lvbiBSZXZpc2lvbjogMjEwMDU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNmIxZWYyOTcyYjE5ZWVk ZTAxYmQwOTQ2OTIzMmUxNDIyZDU4ODcyYy4uZDA2NWE4YWY3ZTgwNGE0YTdiMDhmY2MwNjdhNTky ZDVmZmUyN2RhYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE2LTEyLTIxICBBbGVq YW5kcm8gRy4gQ2FzdHJvICA8YWxleEBpZ2FsaWEuY29tPgorCisgICAgICAgIFtXZWJSVENdIEFk ZCBzdXBwb3J0IGZvciBydW50aW1lIFBlZUNvbm5lY3Rpb24gc2V0dGluZywgcmVxdWlyZWQgYWZ0 ZXIgcjIwOTc1NworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTY2MzQ2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQWZ0ZXIgdGhhdCBjb21taXQgd2UgaGF2ZSB0byBlbmFibGUgdGhlIHBlZXJDb25uZWN0aW9u IHJ1bnRpbWUKKyAgICAgICAgZmxhZyBpZiB3ZSB3YW50IHdlYnJ0YyB0byB3b3JrLiBXZSBhcmUg bm90IGFkZGluZyBhIG5ldyBBUEkgZm9yCisgICAgICAgIHRoZSBtb21lbnQgdG8gY29udHJvbCB0 aGUgcGVlckNvbm5lY3Rpb24gZmVhdHVyZS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3Rr L1dlYktpdFNldHRpbmdzLmNwcDoKKyAgICAgICAgKHdlYmtpdF9zZXR0aW5nc19zZXRfZW5hYmxl X21lZGlhX3N0cmVhbSk6IFVzZSB0aGUgbWVkaWFTdHJlYW0KKyAgICAgICAgc2V0dGluZyB0byBj b250cm9sIHRoZSBwZWVyQ29ubmVjdGlvbgorCiAyMDE2LTEyLTIwICBUYXJhcyBUc3VncmlpICA8 dHRzdWdyaWlAZmIuY29tPgogCiAgICAgICAgIEZpeCB1bmRlZmluZWQgYmVoYXZpb3IgY2F1c2Vk IGJ5IG1hY3JvIGV4cGFuc2lvbiBwcm9kdWNpbmcgJ2RlZmluZWQnCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRTZXR0aW5ncy5jcHAgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRTZXR0aW5ncy5jcHAKaW5kZXggZDQ4ZDky ODZhZjVhMTQxOWNiMWExMjg2M2U5MGY3YWMxNzlkMzM0MC4uZTIzM2M5MTcxMWY1OWQxYzI3MDVl NWQzZjNkNGJiN2VlYWMzMzdhYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9ndGsvV2ViS2l0U2V0dGluZ3MuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvZ3RrL1dlYktpdFNldHRpbmdzLmNwcApAQCAtMjk3Myw2ICsyOTczLDcgQEAgdm9pZCB3 ZWJraXRfc2V0dGluZ3Nfc2V0X2VuYWJsZV9tZWRpYV9zdHJlYW0oV2ViS2l0U2V0dGluZ3MqIHNl dHRpbmdzLCBnYm9vbGVhbgogICAgICAgICByZXR1cm47CiAKICAgICBwcml2LT5wcmVmZXJlbmNl cy0+c2V0TWVkaWFTdHJlYW1FbmFibGVkKGVuYWJsZWQpOworICAgIHByaXYtPnByZWZlcmVuY2Vz LT5zZXRQZWVyQ29ubmVjdGlvbkVuYWJsZWQoZW5hYmxlZCk7CiAgICAgZ19vYmplY3Rfbm90aWZ5 KEdfT0JKRUNUKHNldHRpbmdzKSwgImVuYWJsZS1tZWRpYS1zdHJlYW0iKTsKIH0KIApkaWZmIC0t Z2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDkzYTJlNTc0NWFm N2JjOTkzNWFiZjY3OGRlZDViNDg4MmIwMzljOTYuLjcxNGUyNDVmNjI2MTkxYzBjYzU2ZmU4ZDA2 MWRkZmJmYzVhODZkYzUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxNi0xMi0yMSAgQWxlamFuZHJvIEcuIENhc3Ry byAgPGFsZXhAaWdhbGlhLmNvbT4KKworICAgICAgICBbV2ViUlRDXSBBZGQgc3VwcG9ydCBmb3Ig cnVudGltZSBQZWVDb25uZWN0aW9uIHNldHRpbmcsIHJlcXVpcmVkIGFmdGVyIHIyMDk3NTcKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NjM0NgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVuYWJsZSBXZWJS VEMgYnkgZGVmYXVsdCB0byBzaW1wbGlmeSB0ZXN0aW5nLgorCisgICAgICAgICogTWluaUJyb3dz ZXIvZ3RrL21haW4uYzoKKyAgICAgICAgKG1haW4pOgorCiAyMDE2LTEyLTIwICBTaW1vbiBGcmFz ZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT046IEFQSSB0 ZXN0IGZhaWx1cmU6IFdLV2ViVmlldy5FdmFsdWF0ZUphdmFTY3JpcHRCbG9ja0NyYXNoCmRpZmYg LS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci9ndGsvbWFpbi5jIGIvVG9vbHMvTWluaUJyb3dzZXIv Z3RrL21haW4uYwppbmRleCA5YWYzMjg2YjkzM2E4ZmU1MGMzNDkzMmM5ZDYwNGMxNWU1OTc1MDFj Li4zNGI5YTg1Njc5MWNlNGUyZGU1ZWU1NGFmYmM2ZmMzMDEwMjg4YjUxIDEwMDY0NAotLS0gYS9U b29scy9NaW5pQnJvd3Nlci9ndGsvbWFpbi5jCisrKyBiL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9t YWluLmMKQEAgLTI2OSw2ICsyNjksNyBAQCBpbnQgbWFpbihpbnQgYXJnYywgY2hhciAqYXJndltd KQogICAgIFdlYktpdFNldHRpbmdzICp3ZWJraXRTZXR0aW5ncyA9IHdlYmtpdF9zZXR0aW5nc19u ZXcoKTsKICAgICB3ZWJraXRfc2V0dGluZ3Nfc2V0X2VuYWJsZV9kZXZlbG9wZXJfZXh0cmFzKHdl YmtpdFNldHRpbmdzLCBUUlVFKTsKICAgICB3ZWJraXRfc2V0dGluZ3Nfc2V0X2VuYWJsZV93ZWJn bCh3ZWJraXRTZXR0aW5ncywgVFJVRSk7CisgICAgd2Via2l0X3NldHRpbmdzX3NldF9lbmFibGVf bWVkaWFfc3RyZWFtKHdlYmtpdFNldHRpbmdzLCBUUlVFKTsKICAgICBpZiAoIWFkZFNldHRpbmdz R3JvdXBUb0NvbnRleHQoY29udGV4dCwgd2Via2l0U2V0dGluZ3MpKQogICAgICAgICBnX2NsZWFy X29iamVjdCgmd2Via2l0U2V0dGluZ3MpOwogCg==