166328 2016-12-21 08:39:04 -0800 MediaStream: ASSERTION FAILED: m_ids.size() == m_handles.size() in MediaDeviceSandboxExtensions 2016-12-22 08:41:58 -0800 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 nael.ouedp nael.ouedp commit-queue eric.carlson youennf oldest_to_newest 1261957 0 nael.ouedp 2016-12-21 08:39:04 -0800 This assertion failure happens for port with SANDBOX_EXTENSION disabled. SandboxExtension::HandleArray is empty and HandleArray:size() always returns 0. 1261966 1 297590 nael.ouedp 2016-12-21 08:48:04 -0800 Created attachment 297590 Patch 1261978 2 eric.carlson 2016-12-21 09:18:55 -0800 This will break the macOS/iOS builds because you haven't defined ENABLE_SANDBOX_EXTENSIONS for those builds. Instead of doing that, could you add an early return to the UserMediaPermissionRequestManager destructor when m_userMediaDeviceSandboxExtensions is empty? 1262002 3 nael.ouedp 2016-12-21 10:18:06 -0800 (In reply to comment #2) > This will break the macOS/iOS builds because you haven't defined > ENABLE_SANDBOX_EXTENSIONS for those builds. Ok it seems that the patch passed for mac and ios build bots. Maybe ENABLE_SANDBOX_EXTENSIONS is defined for those build ? > Instead of doing that, could you > add an early return to the UserMediaPermissionRequestManager destructor when > m_userMediaDeviceSandboxExtensions is empty? I tried but the same assertions fail. First ASSERTION FAILURE happens in MediaDeviceSandboxExtensions constructor when called in UserMediaProcessManager::willCreateMediaStream. 1262038 4 eric.carlson 2016-12-21 11:12:01 -0800 (In reply to comment #3) > (In reply to comment #2) > > This will break the macOS/iOS builds because you haven't defined > > ENABLE_SANDBOX_EXTENSIONS for those builds. > Ok it seems that the patch passed for mac and ios build bots. Maybe > ENABLE_SANDBOX_EXTENSIONS is defined for those build ? > You are correct, silly me! > > Instead of doing that, could you > > add an early return to the UserMediaPermissionRequestManager destructor when > > m_userMediaDeviceSandboxExtensions is empty? > > I tried but the same assertions fail. > > First ASSERTION FAILURE happens in MediaDeviceSandboxExtensions constructor > when called in UserMediaProcessManager::willCreateMediaStream. While this patch gets rid of the assertions, wouldn't it be more efficient to change UserMediaProcessManager to not create/delete the extensions and avoid the extra IPC unless ENABLE_SANDBOX_EXTENSIONS is defined? 1262283 5 297652 nael.ouedp 2016-12-22 05:13:43 -0800 Created attachment 297652 Patch 1262284 6 nael.ouedp 2016-12-22 05:23:54 -0800 > While this patch gets rid of the assertions, wouldn't it be more efficient > to change UserMediaProcessManager to not create/delete the extensions and > avoid the extra IPC unless ENABLE_SANDBOX_EXTENSIONS is defined? Yes ! Uploaded patch avoids to create and delete the extensions in UserMediaProcessManager. I think that GrantUserMediaDeviceSandboxExtensions and RevokeUserMediaDeviceSandboxExtensions messages should be also disabled. Is it correct? 1262286 7 eric.carlson 2016-12-22 06:32:08 -0800 (In reply to comment #6) > Uploaded patch avoids to create and delete the extensions in > UserMediaProcessManager. I think that GrantUserMediaDeviceSandboxExtensions > and RevokeUserMediaDeviceSandboxExtensions messages should be also disabled. > > Is it correct? That makes sense to me! 1262289 8 nael.ouedp 2016-12-22 08:17:07 -0800 Thanks for the review ! 1262293 9 297652 commit-queue 2016-12-22 08:41:54 -0800 Comment on attachment 297652 Patch Clearing flags on attachment: 297652 Committed r210097: <http://trac.webkit.org/changeset/210097> 1262294 10 commit-queue 2016-12-22 08:41:58 -0800 All reviewed patches have been landed. Closing bug. 297590 2016-12-21 08:48:04 -0800 2016-12-22 05:13:35 -0800 Patch bug-166328-20161221174701.patch text/plain 2643 nael.ouedp U3VidmVyc2lvbiBSZXZpc2lvbjogMjEwMDU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNmIxZWYyOTcyYjE5ZWVk ZTAxYmQwOTQ2OTIzMmUxNDIyZDU4ODcyYy4uMTU1OTNjMjc0M2YyYjg4YjkwYzA2Y2ZjZjNjYmQ2 NzM1ZDhkOTY1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE2LTEyLTIxICBOYWVs IE91ZWRyYW9nbyAgPG5hZWwub3VlZHJhb2dvQGNyZi5jYW5vbi5mcj4KKworICAgICAgICBNZWRp YVN0cmVhbTogQVNTRVJUSU9OIEZBSUxFRDogbV9pZHMuc2l6ZSgpID09IG1faGFuZGxlcy5zaXpl KCkgaW4gTWVkaWFEZXZpY2VTYW5kYm94RXh0ZW5zaW9ucworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY2MzI4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBhc3NlcnRpb24gZmFpbHVyZSBoYXBwZW5z IGZvciBwb3J0IHdpdGggU0FOREJPWF9FWFRFTlNJT04gZGlzYWJsZWQuIFNhbmRib3hFeHRlbnNp b246OkhhbmRsZUFycmF5IGlzIGVtcHR5CisgICAgICAgIGFuZCBIYW5kbGVBcnJheTpzaXplKCkg YWx3YXlzIHJldHVybnMgMC4gRGlzYWJsZSB0aGUgYXNzZXJ0aW9uIHdoZW4gU0FOREJPWF9FWFRF TlNJT04gaXMgZGlzYWJsZWQuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL01lZGlhU3RyZWFtL01l ZGlhRGV2aWNlU2FuZGJveEV4dGVuc2lvbnMuY3BwOgorICAgICAgICAoV2ViS2l0OjpNZWRpYURl dmljZVNhbmRib3hFeHRlbnNpb25zOjpNZWRpYURldmljZVNhbmRib3hFeHRlbnNpb25zKToKKyAg ICAgICAgKFdlYktpdDo6TWVkaWFEZXZpY2VTYW5kYm94RXh0ZW5zaW9uczo6b3BlcmF0b3JbXSk6 CisKIDIwMTYtMTItMjAgIFRhcmFzIFRzdWdyaWkgIDx0dHN1Z3JpaUBmYi5jb20+CiAKICAgICAg ICAgRml4IHVuZGVmaW5lZCBiZWhhdmlvciBjYXVzZWQgYnkgbWFjcm8gZXhwYW5zaW9uIHByb2R1 Y2luZyAnZGVmaW5lZCcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvTWVk aWFTdHJlYW0vTWVkaWFEZXZpY2VTYW5kYm94RXh0ZW5zaW9ucy5jcHAgYi9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL01lZGlhU3RyZWFtL01lZGlhRGV2aWNlU2FuZGJveEV4dGVuc2lvbnMuY3Bw CmluZGV4IDJhNGZiNTI1YzA2ODRjZTIxODY2OTZjYmJkNTViMDVmNDdiNmM0NWYuLmU2MzQ3MzZh NDNhYjI4YzVkMjVjMjQxNjQ5NGYxMWFmZDZjNjgxNzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvTWVkaWFTdHJlYW0vTWVkaWFEZXZpY2VTYW5kYm94RXh0ZW5zaW9ucy5j cHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9NZWRpYVN0cmVhbS9NZWRpYURldmlj ZVNhbmRib3hFeHRlbnNpb25zLmNwcApAQCAtMzYsNyArMzYsOSBAQCBNZWRpYURldmljZVNhbmRi b3hFeHRlbnNpb25zOjpNZWRpYURldmljZVNhbmRib3hFeHRlbnNpb25zKFZlY3RvcjxTdHJpbmc+ IGlkcywgUwogICAgIDogbV9pZHMoaWRzKQogICAgICwgbV9oYW5kbGVzKFdURk1vdmUoaGFuZGxl cykpCiB7CisjaWYgRU5BQkxFKFNBTkRCT1hfRVhURU5TSU9OUykKICAgICBBU1NFUlRfV0lUSF9T RUNVUklUWV9JTVBMSUNBVElPTihtX2lkcy5zaXplKCkgPT0gbV9oYW5kbGVzLnNpemUoKSk7Cisj ZW5kaWYKIH0KIAogdm9pZCBNZWRpYURldmljZVNhbmRib3hFeHRlbnNpb25zOjplbmNvZGUoSVBD OjpFbmNvZGVyJiBlbmNvZGVyKSBjb25zdApAQCAtNTgsMTQgKzYwLDE4IEBAIGJvb2wgTWVkaWFE ZXZpY2VTYW5kYm94RXh0ZW5zaW9uczo6ZGVjb2RlKElQQzo6RGVjb2RlciYgZGVjb2RlciwgTWVk aWFEZXZpY2VTYW5kCiAKIHN0ZDo6cGFpcjxTdHJpbmcsIFJlZlB0cjxTYW5kYm94RXh0ZW5zaW9u Pj4gTWVkaWFEZXZpY2VTYW5kYm94RXh0ZW5zaW9uczo6b3BlcmF0b3JbXShzaXplX3QgaSkKIHsK KyNpZiBFTkFCTEUoU0FOREJPWF9FWFRFTlNJT05TKQogICAgIEFTU0VSVF9XSVRIX1NFQ1VSSVRZ X0lNUExJQ0FUSU9OKG1faWRzLnNpemUoKSA9PSBtX2hhbmRsZXMuc2l6ZSgpKTsKKyNlbmRpZgog ICAgIEFTU0VSVF9XSVRIX1NFQ1VSSVRZX0lNUExJQ0FUSU9OKGkgPCBtX2lkcy5zaXplKCkpOwog ICAgIHJldHVybiB7IG1faWRzW2ldLCBTYW5kYm94RXh0ZW5zaW9uOjpjcmVhdGUobV9oYW5kbGVz W2ldKSB9OwogfQogCiBjb25zdCBzdGQ6OnBhaXI8U3RyaW5nLCBSZWZQdHI8U2FuZGJveEV4dGVu c2lvbj4+IE1lZGlhRGV2aWNlU2FuZGJveEV4dGVuc2lvbnM6Om9wZXJhdG9yW10oc2l6ZV90IGkp IGNvbnN0CiB7CisjaWYgRU5BQkxFKFNBTkRCT1hfRVhURU5TSU9OUykKICAgICBBU1NFUlRfV0lU SF9TRUNVUklUWV9JTVBMSUNBVElPTihtX2lkcy5zaXplKCkgPT0gbV9oYW5kbGVzLnNpemUoKSk7 CisjZW5kaWYKICAgICBBU1NFUlRfV0lUSF9TRUNVUklUWV9JTVBMSUNBVElPTihpIDwgbV9pZHMu c2l6ZSgpKTsKICAgICByZXR1cm4geyBtX2lkc1tpXSwgU2FuZGJveEV4dGVuc2lvbjo6Y3JlYXRl KG1faGFuZGxlc1tpXSkgfTsKIH0K 297652 2016-12-22 05:13:43 -0800 2016-12-22 08:41:54 -0800 Patch bug-166328-20161222141238.patch text/plain 6442 nael.ouedp U3VidmVyc2lvbiBSZXZpc2lvbjogMjEwMDU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNmIxZWYyOTcyYjE5ZWVk ZTAxYmQwOTQ2OTIzMmUxNDIyZDU4ODcyYy4uZmNkOTAwYjViMDdkOTZiNzA2Yjg4YTQyOTI0YWZl MTM0M2VhYzc4NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE2LTEyLTIyICBOYWVs IE91ZWRyYW9nbyAgPG5hZWwub3VlZHJhb2dvQGNyZi5jYW5vbi5mcj4KKworICAgICAgICBNZWRp YVN0cmVhbTogQVNTRVJUSU9OIEZBSUxFRDogbV9pZHMuc2l6ZSgpID09IG1faGFuZGxlcy5zaXpl KCkgaW4gTWVkaWFEZXZpY2VTYW5kYm94RXh0ZW5zaW9ucworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY2MzI4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBhc3NlcnRpb24gZmFpbHVyZSBoYXBwZW5z IGZvciBwb3J0cyB3aXRoIHNhbmRib3ggZXh0ZW5zaW9ucyBkaXNhYmxlZC4gU2FuZGJveEV4dGVu c2lvbiBpcyBlbXB0eSBhbmQKKyAgICAgICAgSGFuZGxlQXJyYXk6c2l6ZSgpIGFsd2F5cyByZXR1 cm5zIDAuIERpc2FibGUgY3JlYXRpb24gb2YgTWVkaWFEZXZpY2VzU2FuZGJveEV4dGVuc2lvbiBp biBVc2VyTWVkaWFQcm9jZXNzTWFuYWdlcgorICAgICAgICB3aGVuIGJ1aWxkaW5nIHdpdGhvdXQg c3VwcG9ydCBvZiBzYW5kYm94IGV4dGVuc2lvbi4gRGlzYWJsZSBhbHNvIFdlYlBhZ2U6OmdyYW50 VXNlck1lZGlhRGV2aWNlU2FuZGJveEV4dGVuc2lvbnMKKyAgICAgICAgYW5kIFdlYlBhZ2U6OnJl dm9rZVVzZXJNZWRpYURldmljZVNhbmRib3hFeHRlbnNpb25zIHdoaWNoIGNhbiBiZSBhdm9pZGVk IHdoZW4gc2FuZGJveCBleHRlbnNpb24gaXMgZW1wdHkuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv VXNlck1lZGlhUHJvY2Vzc01hbmFnZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpVc2VyTWVkaWFQ cm9jZXNzTWFuYWdlcjo6d2lsbENyZWF0ZU1lZGlhU3RyZWFtKToKKyAgICAgICAgKFdlYktpdDo6 VXNlck1lZGlhUHJvY2Vzc01hbmFnZXI6OmVuZGVkQ2FwdHVyZVNlc3Npb24pOgorICAgICAgICAq IFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcDoKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dl YlBhZ2UvV2ViUGFnZS5oOgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLm1l c3NhZ2VzLmluOgorCiAyMDE2LTEyLTIwICBUYXJhcyBUc3VncmlpICA8dHRzdWdyaWlAZmIuY29t PgogCiAgICAgICAgIEZpeCB1bmRlZmluZWQgYmVoYXZpb3IgY2F1c2VkIGJ5IG1hY3JvIGV4cGFu c2lvbiBwcm9kdWNpbmcgJ2RlZmluZWQnCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvVXNlck1lZGlhUHJvY2Vzc01hbmFnZXIuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL1VzZXJNZWRpYVByb2Nlc3NNYW5hZ2VyLmNwcAppbmRleCA2NjRmMjY2MGRjNjliNjQyMzlm OTFiYzYyNTYyODE3YzM1YjYxYWE1Li5hMGFmODVmNmVmYzIyODQ0NGQzZWY1ZjU1NzcwMmEyNWI1 M2RhYjQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvVXNlck1lZGlhUHJv Y2Vzc01hbmFnZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Vc2VyTWVkaWFQ cm9jZXNzTWFuYWdlci5jcHAKQEAgLTExMSw2ICsxMTEsNyBAQCB2b2lkIFVzZXJNZWRpYVByb2Nl c3NNYW5hZ2VyOjpyZW1vdmVVc2VyTWVkaWFQZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXJQcm94eShV c2VyTQogCiB2b2lkIFVzZXJNZWRpYVByb2Nlc3NNYW5hZ2VyOjp3aWxsQ3JlYXRlTWVkaWFTdHJl YW0oVXNlck1lZGlhUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyUHJveHkmIHByb3h5LCBib29sIHdp dGhBdWRpbywgYm9vbCB3aXRoVmlkZW8pCiB7CisjaWYgRU5BQkxFKFNBTkRCT1hfRVhURU5TSU9O UykKICAgICBBU1NFUlQoc3RhdGVNYXAoKS5jb250YWlucygmcHJveHkucGFnZSgpLnByb2Nlc3Mo KSkpOwogCiAgICAgYXV0byYgc3RhdGUgPSBwcm9jZXNzU3RhdGUocHJveHkucGFnZSgpLnByb2Nl c3MoKSk7CkBAIC0xNTEsNiArMTUyLDcgQEAgdm9pZCBVc2VyTWVkaWFQcm9jZXNzTWFuYWdlcjo6 d2lsbENyZWF0ZU1lZGlhU3RyZWFtKFVzZXJNZWRpYVBlcm1pc3Npb25SZXF1ZXN0TWEKICAgICAg ICAgc3RhdGUuc2V0U2FuZGJveEV4dGVuc2lvbnNHcmFudGVkKGN1cnJlbnRFeHRlbnNpb25zKTsK ICAgICAgICAgcHJveHkucGFnZSgpLnByb2Nlc3MoKS5zZW5kKE1lc3NhZ2VzOjpXZWJQYWdlOjpH cmFudFVzZXJNZWRpYURldmljZVNhbmRib3hFeHRlbnNpb25zKE1lZGlhRGV2aWNlU2FuZGJveEV4 dGVuc2lvbnMoaWRzLCBXVEZNb3ZlKGhhbmRsZXMpKSksIHByb3h5LnBhZ2UoKS5wYWdlSUQoKSk7 CiAgICAgfQorI2VuZGlmCiB9CiAKIHZvaWQgVXNlck1lZGlhUHJvY2Vzc01hbmFnZXI6OnN0YXJ0 ZWRDYXB0dXJlU2Vzc2lvbihVc2VyTWVkaWFQZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXJQcm94eSYg cHJveHkpCkBAIC0xNjAsNiArMTYyLDcgQEAgdm9pZCBVc2VyTWVkaWFQcm9jZXNzTWFuYWdlcjo6 c3RhcnRlZENhcHR1cmVTZXNzaW9uKFVzZXJNZWRpYVBlcm1pc3Npb25SZXF1ZXN0TWEKIAogdm9p ZCBVc2VyTWVkaWFQcm9jZXNzTWFuYWdlcjo6ZW5kZWRDYXB0dXJlU2Vzc2lvbihVc2VyTWVkaWFQ ZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXJQcm94eSYgcHJveHkpCiB7CisjaWYgRU5BQkxFKFNBTkRC T1hfRVhURU5TSU9OUykKICAgICBBU1NFUlQoc3RhdGVNYXAoKS5jb250YWlucygmcHJveHkucGFn ZSgpLnByb2Nlc3MoKSkpOwogCiAgICAgYXV0byYgc3RhdGUgPSBwcm9jZXNzU3RhdGUocHJveHku cGFnZSgpLnByb2Nlc3MoKSk7CkBAIC0xOTEsNiArMTk0LDcgQEAgdm9pZCBVc2VyTWVkaWFQcm9j ZXNzTWFuYWdlcjo6ZW5kZWRDYXB0dXJlU2Vzc2lvbihVc2VyTWVkaWFQZXJtaXNzaW9uUmVxdWVz dE1hbmEKIAogICAgIHN0YXRlLnNldFNhbmRib3hFeHRlbnNpb25zR3JhbnRlZChjdXJyZW50RXh0 ZW5zaW9ucyk7CiAgICAgcHJveHkucGFnZSgpLnByb2Nlc3MoKS5zZW5kKE1lc3NhZ2VzOjpXZWJQ YWdlOjpSZXZva2VVc2VyTWVkaWFEZXZpY2VTYW5kYm94RXh0ZW5zaW9ucyhwYXJhbXMpLCBwcm94 eS5wYWdlKCkucGFnZUlEKCkpOworI2VuZGlmCiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYktpdApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3Bw IGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCmluZGV4IDI3 ZTgzOTMzYzcyMGJlMTM3ODMyZDY5NWEzMGI1YzU2YTFkMGU0YzUuLjY3ZWYyYTY2ZmViZjk1OWMy YzBjM2MyNjVkODY1NzI5YmNjM2NkZGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L1dlYlBhZ2UvV2ViUGFnZS5jcHAKQEAgLTM3MTksNyArMzcxOSw3IEBAIHZvaWQgV2ViUGFnZTo6 ZGlkQ29tcGxldGVNZWRpYURldmljZUVudW1lcmF0aW9uKHVpbnQ2NF90IHVzZXJNZWRpYUlELCBj b25zdCBWZWN0CiB7CiAgICAgbV91c2VyTWVkaWFQZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXIuZGlk Q29tcGxldGVNZWRpYURldmljZUVudW1lcmF0aW9uKHVzZXJNZWRpYUlELCBkZXZpY2VzLCBkZXZp Y2VJZGVudGlmaWVySGFzaFNhbHQsIG9yaWdpbkhhc1BlcnNpc3RlbnRBY2Nlc3MpOwogfQotCisj aWYgRU5BQkxFKFNBTkRCT1hfRVhURU5TSU9OUykKIHZvaWQgV2ViUGFnZTo6Z3JhbnRVc2VyTWVk aWFEZXZpY2VTYW5kYm94RXh0ZW5zaW9ucyhjb25zdCBNZWRpYURldmljZVNhbmRib3hFeHRlbnNp b25zJiBleHRlbnNpb25zKQogewogICAgIG1fdXNlck1lZGlhUGVybWlzc2lvblJlcXVlc3RNYW5h Z2VyLmdyYW50VXNlck1lZGlhRGV2aWNlU2FuZGJveEV4dGVuc2lvbnMoZXh0ZW5zaW9ucyk7CkBA IC0zNzMwLDYgKzM3MzAsNyBAQCB2b2lkIFdlYlBhZ2U6OnJldm9rZVVzZXJNZWRpYURldmljZVNh bmRib3hFeHRlbnNpb25zKGNvbnN0IFZlY3RvcjxTdHJpbmc+JiBleHRlbgogICAgIG1fdXNlck1l ZGlhUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyLnJldm9rZVVzZXJNZWRpYURldmljZVNhbmRib3hF eHRlbnNpb25zKGV4dGVuc2lvbklEcyk7CiB9CiAjZW5kaWYKKyNlbmRpZgogCiAjaWYgIVBMQVRG T1JNKElPUykKIHZvaWQgV2ViUGFnZTo6YWR2YW5jZVRvTmV4dE1pc3NwZWxsaW5nKGJvb2wgc3Rh cnRCZWZvcmVTZWxlY3Rpb24pCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L1dlYlBhZ2UvV2ViUGFnZS5oIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dl YlBhZ2UuaAppbmRleCA4MTA0MDgyNDNjM2Q3MjU1ZTg3NjNlZDI0MGM2OTdiYWViMjcxZjk0Li44 MWNlNzUxZjhlYmQxZDhlMGUwYjdkY2E1ZmYwN2JiNzNkM2QyMTY1IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5oCisrKyBiL1NvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmgKQEAgLTExODAsOSArMTE4MCwxMSBAQCBw cml2YXRlOgogICAgIHZvaWQgdXNlck1lZGlhQWNjZXNzV2FzRGVuaWVkKHVpbnQ2NF90IHVzZXJN ZWRpYUlELCB1aW50NjRfdCByZWFzb24sIFN0cmluZyBpbnZhbGlkQ29uc3RyYWludCk7CiAKICAg ICB2b2lkIGRpZENvbXBsZXRlTWVkaWFEZXZpY2VFbnVtZXJhdGlvbih1aW50NjRfdCB1c2VyTWVk aWFJRCwgY29uc3QgVmVjdG9yPFdlYkNvcmU6OkNhcHR1cmVEZXZpY2U+JiBkZXZpY2VzLCBjb25z dCBTdHJpbmcmIGRldmljZUlkZW50aWZpZXJIYXNoU2FsdCwgYm9vbCBvcmlnaW5IYXNQZXJzaXN0 ZW50QWNjZXNzKTsKKyNpZiBFTkFCTEUoU0FOREJPWF9FWFRFTlNJT05TKQogICAgIHZvaWQgZ3Jh bnRVc2VyTWVkaWFEZXZpY2VTYW5kYm94RXh0ZW5zaW9ucyhjb25zdCBNZWRpYURldmljZVNhbmRi b3hFeHRlbnNpb25zJik7CiAgICAgdm9pZCByZXZva2VVc2VyTWVkaWFEZXZpY2VTYW5kYm94RXh0 ZW5zaW9ucyhjb25zdCBWZWN0b3I8U3RyaW5nPiYpOwogI2VuZGlmCisjZW5kaWYKIAogICAgIHZv aWQgYWR2YW5jZVRvTmV4dE1pc3NwZWxsaW5nKGJvb2wgc3RhcnRCZWZvcmVTZWxlY3Rpb24pOwog ICAgIHZvaWQgY2hhbmdlU3BlbGxpbmdUb1dvcmQoY29uc3QgU3RyaW5nJiB3b3JkKTsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLm1lc3NhZ2Vz LmluIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UubWVzc2FnZXMu aW4KaW5kZXggZDQxNWZmZTMyZGU1NDFmNzgyZWY1NjgzOTJhMWM4YjVmNGFiYTI1ZS4uNzU2YjYy MjZjOTIyYzBiYjIwNjE0NWJiMmI0YmY2NDZlNzU3MmZlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UubWVzc2FnZXMuaW4KKysrIGIvU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UubWVzc2FnZXMuaW4KQEAgLTI5Miw5 ICsyOTIsMTEgQEAgbWVzc2FnZXMgLT4gV2ViUGFnZSBMZWdhY3lSZWNlaXZlciB7CiAgICAgVXNl ck1lZGlhQWNjZXNzV2FzR3JhbnRlZCh1aW50NjRfdCB1c2VyTWVkaWFJRCwgU3RyaW5nIGF1ZGlv RGV2aWNlVUlELCBTdHJpbmcgdmlkZW9EZXZpY2VVSUQpCiAgICAgVXNlck1lZGlhQWNjZXNzV2Fz RGVuaWVkKHVpbnQ2NF90IHVzZXJNZWRpYUlELCB1aW50NjRfdCByZWFzb24sIFN0cmluZyBpbnZh bGlkQ29uc3RyYWludCkKICAgICBEaWRDb21wbGV0ZU1lZGlhRGV2aWNlRW51bWVyYXRpb24odWlu dDY0X3QgdXNlck1lZGlhSUQsIFZlY3RvcjxXZWJDb3JlOjpDYXB0dXJlRGV2aWNlPiBkZXZpY2Vz LCBTdHJpbmcgbWVkaWFEZXZpY2VJZGVudGlmaWVySGFzaFNhbHQsIGJvb2wgaGFzUGVyc2lzdGVu dEFjY2VzcykKKyNpZiBFTkFCTEUoU0FOREJPWF9FWFRFTlNJT05TKQogICAgIEdyYW50VXNlck1l ZGlhRGV2aWNlU2FuZGJveEV4dGVuc2lvbnMoV2ViS2l0OjpNZWRpYURldmljZVNhbmRib3hFeHRl bnNpb25zIHNhbmRib3hFeHRlbnNpb25zKQogICAgIFJldm9rZVVzZXJNZWRpYURldmljZVNhbmRi b3hFeHRlbnNpb25zKFZlY3RvcjxTdHJpbmc+IHNhbmRib3hFeHRlbnNpb25JRHMpCiAjZW5kaWYK KyNlbmRpZgogCiAgICAgIyBOb3RpZmljYXRpb24KICAgICBEaWRSZWNlaXZlTm90aWZpY2F0aW9u UGVybWlzc2lvbkRlY2lzaW9uKHVpbnQ2NF90IG5vdGlmaWNhdGlvbklELCBib29sIGFsbG93ZWQp Cg==