166300 2016-12-20 21:00:40 -0800 Web Inspector: Address failures under LayoutTests/inspector/debugger/stepping 2017-01-03 14:33:01 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck commit-queue inspector-bugzilla-changes joepeck keith_miller mark.lam msaboff saam oldest_to_newest 1261885 0 joepeck 2016-12-20 21:00:40 -0800 Summary: Address failures under LayoutTests/inspector/debugger/stepping When running these tests with --force I've seen some consistent failures in a few places. Steps to Reproduce: 1. $ run-webkit-tests LayoutTests/inspector/debugger/stepping --force --iterations=5 => Failures Notes: - Looks like stepping past the end of a program is causing a pause in later executed code but that should have resumed - Some numbers need to be updated. 1261887 1 297578 joepeck 2016-12-20 21:17:14 -0800 Created attachment 297578 [PATCH] Proposed Fix 1262022 2 297578 bburg 2016-12-21 10:45:25 -0800 Comment on attachment 297578 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=297578&action=review r=me > LayoutTests/ChangeLog:8 > + * inspector/debugger/stepping/stepping-classes-expected.txt: Should we unskip this test? > LayoutTests/ChangeLog:9 > + Rebasline these results to new column values. Speling > Source/JavaScriptCore/ChangeLog:10 > + When continuing clear states that would have had us pause again. continuing, > Source/JavaScriptCore/ChangeLog:14 > + When resuming after becoming idle be sure to clear Debugger state. idle, > Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.cpp:793 > + m_scriptDebugServer.continueProgram(); > m_frontendDispatcher->resumed(); Hmm, in what conditions was this bug user-visible, stepping past the last step into an idle state? 1263484 3 joepeck 2017-01-03 12:07:05 -0800 > > Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.cpp:793 > > + m_scriptDebugServer.continueProgram(); > > m_frontendDispatcher->resumed(); > > Hmm, in what conditions was this bug user-visible, stepping past the last > step into an idle state? Correct. Though I wasn't always seeing this locally I certainly was in the tests. 1263551 4 joepeck 2017-01-03 14:33:01 -0800 <https://trac.webkit.org/changeset/210251> 297578 2016-12-20 21:17:14 -0800 2016-12-21 10:45:25 -0800 [PATCH] Proposed Fix debugger-1.patch text/plain 3581 joepeck ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAyMTY2YzdhLi5jNGY4ZDQwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTUgQEAKIDIwMTYtMTIt MjAgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAorICAgICAgICBXZWIg SW5zcGVjdG9yOiBBZGRyZXNzIGZhaWx1cmVzIHVuZGVyIExheW91dFRlc3RzL2luc3BlY3Rvci9k ZWJ1Z2dlci9zdGVwcGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTY2MzAwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBpbnNwZWN0b3IvZGVidWdnZXIvc3RlcHBpbmcvc3RlcHBpbmctY2xhc3Nlcy1l eHBlY3RlZC50eHQ6CisgICAgICAgIFJlYmFzbGluZSB0aGVzZSByZXN1bHRzIHRvIG5ldyBjb2x1 bW4gdmFsdWVzLgorCisyMDE2LTEyLTIwICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBs ZS5jb20+CisKICAgICAgICAgV2ViIEluc3BlY3RvcjogRml4IENvbnRlbnQgRmxvdyBDb250YWlu ZXIgUmVnaW9ucyBDb21wdXRlZCBTdHlsZSBzZWN0aW9uCiAgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjYyOTQKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvaW5zcGVjdG9yL2RlYnVnZ2VyL3N0ZXBwaW5nL3N0ZXBwaW5nLWNsYXNzZXMtZXhwZWN0ZWQu dHh0IGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2RlYnVnZ2VyL3N0ZXBwaW5nL3N0ZXBwaW5nLWNs YXNzZXMtZXhwZWN0ZWQudHh0CmluZGV4IDY2YWM4NzQuLmU0NDMzZjIgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL2luc3BlY3Rvci9kZWJ1Z2dlci9zdGVwcGluZy9zdGVwcGluZy1jbGFzc2VzLWV4 cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvZGVidWdnZXIvc3RlcHBpbmcv c3RlcHBpbmctY2xhc3Nlcy1leHBlY3RlZC50eHQKQEAgLTI1MCw3ICsyNTAsNyBAQCBQQVVTRSBB VCBlbnRyeUNsYXNzRGVmYXVsdENvbnN0cnVjdG9yOjY3OjUKICAgICAgNjkgICAgZnVuY3Rpb24g ZW50cnlDbGFzc0dldHRlclNldHRlcigpIHsKIAogQUNUSU9OOiBzdGVwLWluCi1QQVVTRSBBVCBD aGlsZDI6MToxNgorUEFVU0UgQVQgQ2hpbGQyOjE6MjMKIC0tLSBTb3VyY2UgVW5hdmFpbGFibGUg LS0tCiAKIEFDVElPTjogc3RlcC1pbgpAQCAtMjY0LDcgKzI2NCw3IEBAIFBBVVNFIEFUIEJhc2U6 MTg6OQogICAgICAyMCAgICAgICAgYmFzZU1ldGhvZCgpCiAKIEFDVElPTjogc3RlcC1vdXQKLVBB VVNFIEFUIENoaWxkMjoxOjM4CitQQVVTRSBBVCBDaGlsZDI6MTo0MAogLS0tIFNvdXJjZSBVbmF2 YWlsYWJsZSAtLS0KIAogQUNUSU9OOiBzdGVwLW91dApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5k ZXggNjkyOGMwYS4uZmYwMTBiZSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZworKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTggQEAKKzIwMTYtMTItMjAgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4K KworICAgICAgICBXZWIgSW5zcGVjdG9yOiBBZGRyZXNzIGZhaWx1cmVzIHVuZGVyIExheW91dFRl c3RzL2luc3BlY3Rvci9kZWJ1Z2dlci9zdGVwcGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY2MzAwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBkZWJ1Z2dlci9EZWJ1Z2dlci5jcHA6CisgICAgICAg IChKU0M6OkRlYnVnZ2VyOjpjb250aW51ZVByb2dyYW0pOgorICAgICAgICBXaGVuIGNvbnRpbnVp bmcgY2xlYXIgc3RhdGVzIHRoYXQgd291bGQgaGF2ZSBoYWQgdXMgcGF1c2UgYWdhaW4uCisKKyAg ICAgICAgKiBpbnNwZWN0b3IvYWdlbnRzL0luc3BlY3RvckRlYnVnZ2VyQWdlbnQuY3BwOgorICAg ICAgICAoSW5zcGVjdG9yOjpJbnNwZWN0b3JEZWJ1Z2dlckFnZW50OjpkaWRCZWNvbWVJZGxlKToK KyAgICAgICAgV2hlbiByZXN1bWluZyBhZnRlciBiZWNvbWluZyBpZGxlIGJlIHN1cmUgdG8gY2xl YXIgRGVidWdnZXIgc3RhdGUuCisKIDIwMTYtMTItMjAgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBw bGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBJTkRJRV9VSQpkaWZmIC0tZ2l0IGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL2RlYnVnZ2VyL0RlYnVnZ2VyLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9kZWJ1Z2dlci9EZWJ1Z2dlci5jcHAKaW5kZXggZmFkODY1Yi4uYjgwNDkyYyAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RlYnVnZ2VyL0RlYnVnZ2VyLmNwcAorKysgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvZGVidWdnZXIvRGVidWdnZXIuY3BwCkBAIC02MTIsMTAgKzYxMiwx MSBAQCB2b2lkIERlYnVnZ2VyOjpicmVha1Byb2dyYW0oKQogCiB2b2lkIERlYnVnZ2VyOjpjb250 aW51ZVByb2dyYW0oKQogeworICAgIGNsZWFyTmV4dFBhdXNlU3RhdGUoKTsKKwogICAgIGlmICgh bV9pc1BhdXNlZCkKICAgICAgICAgcmV0dXJuOwogCi0gICAgbV9wYXVzZUF0TmV4dE9wcG9ydHVu aXR5ID0gZmFsc2U7CiAgICAgbm90aWZ5RG9uZVByb2Nlc3NpbmdEZWJ1Z2dlckV2ZW50cygpOwog fQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL2FnZW50cy9J bnNwZWN0b3JEZWJ1Z2dlckFnZW50LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0 b3IvYWdlbnRzL0luc3BlY3RvckRlYnVnZ2VyQWdlbnQuY3BwCmluZGV4IGFiZmIxNzQuLjNmMWE5 NWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvYWdlbnRzL0lu c3BlY3RvckRlYnVnZ2VyQWdlbnQuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNw ZWN0b3IvYWdlbnRzL0luc3BlY3RvckRlYnVnZ2VyQWdlbnQuY3BwCkBAIC03ODcsOCArNzg3LDEx IEBAIHZvaWQgSW5zcGVjdG9yRGVidWdnZXJBZ2VudDo6ZGlkQmVjb21lSWRsZSgpCiB7CiAgICAg bV9yZWdpc3RlcmVkSWRsZUNhbGxiYWNrID0gZmFsc2U7CiAKLSAgICBpZiAobV9jb25kaXRpb25U b0Rpc3BhdGNoUmVzdW1lZCA9PSBTaG91bGREaXNwYXRjaFJlc3VtZWQ6OldoZW5JZGxlKQorICAg IGlmIChtX2NvbmRpdGlvblRvRGlzcGF0Y2hSZXN1bWVkID09IFNob3VsZERpc3BhdGNoUmVzdW1l ZDo6V2hlbklkbGUpIHsKKyAgICAgICAgY2FuY2VsUGF1c2VPbk5leHRTdGF0ZW1lbnQoKTsKKyAg ICAgICAgbV9zY3JpcHREZWJ1Z1NlcnZlci5jb250aW51ZVByb2dyYW0oKTsKICAgICAgICAgbV9m cm9udGVuZERpc3BhdGNoZXItPnJlc3VtZWQoKTsKKyAgICB9CiAKICAgICBtX2NvbmRpdGlvblRv RGlzcGF0Y2hSZXN1bWVkID0gU2hvdWxkRGlzcGF0Y2hSZXN1bWVkOjpObzsKIAo=