166271 2016-12-20 14:33:42 -0800 Throw Exception when test doesn't clean up HID Events properly 2016-12-20 17:11:14 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 megan_gardner webkit-unassigned bdakin commit-queue megan_gardner simon.fraser thorton oldest_to_newest 1261772 0 megan_gardner 2016-12-20 14:33:42 -0800 Throw Exception when test doesn't clean up HID Events properly 1261776 1 297555 megan_gardner 2016-12-20 14:36:13 -0800 Created attachment 297555 Patch 1261831 2 297555 simon.fraser 2016-12-20 16:07:05 -0800 Comment on attachment 297555 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297555&action=review > Tools/WebKitTestRunner/ios/HIDEventGenerator.mm:772 > +- (bool)checkHIDCallbacksClear I would call this checkForOutstandingCallbacks Return type should be BOOL > Tools/WebKitTestRunner/ios/HIDEventGenerator.mm:776 > + if ([_eventCallbacks count]) > + return NO; > + return YES; Or just return [_eventCallbacks count] > 0 > Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:57 > +void UIScriptController::checkForClean() Call this checkForOutstandingCallbacks() too. > Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:60 > + [NSException raise:@"WebKitTestRunnerTestProblem" format:@"Unhandled HID Event exists after NotifyDone, please make sure you are not adding additional HID calls after calling NotifyDone"]; What happens in a test run the this exception fires? Would anyone notice it? Would it be better to RELEASE_ASSERT? The message is also hard to understand for test writers. What's HID? It should say something more like: "The test completed before all synthesized events had been handled. Perhaps you're calling notifyDone() too early?". 1261840 3 297567 megan_gardner 2016-12-20 16:24:21 -0800 Created attachment 297567 Patch 1261852 4 297567 commit-queue 2016-12-20 17:11:10 -0800 Comment on attachment 297567 Patch Clearing flags on attachment: 297567 Committed r210048: <http://trac.webkit.org/changeset/210048> 1261853 5 commit-queue 2016-12-20 17:11:14 -0800 All reviewed patches have been landed. Closing bug. 297555 2016-12-20 14:36:13 -0800 2016-12-20 16:24:17 -0800 Patch bug-166271-20161220143512.patch text/plain 6086 megan_gardner SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxMDAzOCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDI5IEBACisyMDE2LTEyLTIwICBNZWdhbiBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBs ZS5jb20+CisKKyAgICAgICAgVGhyb3cgRXhjZXB0aW9uIHdoZW4gdGVzdCBkb2Vzbid0IGNsZWFu IHVwIEhJRCBFdmVudHMgcHJvcGVybHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE2NjI3MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEFkZCBpbiBhIGNoZWNrIHdoZW4gVUlTY3JpcHRDb250cm9sbGVyIGlz IGRlbGV0ZWQgdG8gbWFrZSBzdXJlIHRoYXQgdGhlIEhJRCBldmVudAorICAgICAgICBjYWxsYmFj ayBkaWN0aW9uYXJ5IGlzIGVtcHR5LiBJZiBpdCBpcyBub3QsIGFuZCBhIEhJRCBldmVudCBpcyBo aXQsIHRoaXMgd2lsbCBjYXVzZQorICAgICAgICB0aGUgcHJvZ3JhbSB0byBjcmFzaCB3aXRob3V0 IGFueSBnb29kIGluZm9ybWF0aW9uLiBDcmFzaGVzIGFyZSByYWNlLXksIGFuZCB3aWxsIHN0aWxs CisgICAgICAgIGhhcHBlbiB3aXRoIG1hbGZvcm1lZCB0ZXN0LCBidXQgdGhlIGluZm9ybWF0aW9u IHdpbGwgYmUgbXVjaCBtb3JlIGhlbHBmdWwuIAorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUv aW9zL1VJU2NyaXB0Q29udHJvbGxlcklPUy5tbToKKyAgICAgICAgKFdUUjo6VUlTY3JpcHRDb250 cm9sbGVyOjpjaGVja0ZvckNsZWFuKToKKyAgICAgICAgKiBUZXN0UnVubmVyU2hhcmVkL1VJU2Ny aXB0Q29udGV4dC9VSVNjcmlwdENvbnRleHQuY3BwOgorICAgICAgICAoVUlTY3JpcHRDb250ZXh0 Ojp+VUlTY3JpcHRDb250ZXh0KToKKyAgICAgICAgKiBUZXN0UnVubmVyU2hhcmVkL1VJU2NyaXB0 Q29udGV4dC9VSVNjcmlwdENvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV1RSOjpVSVNjcmlwdENv bnRyb2xsZXI6OmNoZWNrRm9yQ2xlYW4pOgorICAgICAgICAqIFRlc3RSdW5uZXJTaGFyZWQvVUlT Y3JpcHRDb250ZXh0L1VJU2NyaXB0Q29udHJvbGxlci5oOgorICAgICAgICAqIFdlYktpdFRlc3RS dW5uZXIvaW9zL0hJREV2ZW50R2VuZXJhdG9yLmg6CisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5l ci9pb3MvSElERXZlbnRHZW5lcmF0b3IubW06CisgICAgICAgICgtW0hJREV2ZW50R2VuZXJhdG9y IGNoZWNrSElEQ2FsbGJhY2tzQ2xlYXJdKToKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL2lv cy9UZXN0Q29udHJvbGxlcklPUy5tbToKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL2lvcy9V SVNjcmlwdENvbnRyb2xsZXJJT1MubW06CisgICAgICAgIChXVFI6OlVJU2NyaXB0Q29udHJvbGxl cjo6Y2hlY2tGb3JDbGVhbik6CisKIDIwMTYtMTItMjAgIEFuZHkgRXN0ZXMgIDxhZXN0ZXNAYXBw bGUuY29tPgogCiAgICAgICAgIFtDb2NvYV0gUkVHUkVTU0lPTiAocjIwOTU1OCk6IENhbGxpbmcg ZGVjaXNpb25IYW5kbGVyIG11bHRpcGxlIHRpbWVzIGluIHdlYlZpZXc6ZGVjaWRlUG9saWN5Rm9y TmF2aWdhdGlvbkFjdGlvbjpkZWNpc2lvbkhhbmRsZXI6IGxlYWRzIHRvIGEgY3Jhc2gKSW5kZXg6 IFRvb2xzL0R1bXBSZW5kZXJUcmVlL2lvcy9VSVNjcmlwdENvbnRyb2xsZXJJT1MubW0KPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gVG9vbHMvRHVtcFJlbmRlclRyZWUvaW9zL1VJU2NyaXB0Q29udHJvbGxlcklPUy5t bQkocmV2aXNpb24gMjA5OTM2KQorKysgVG9vbHMvRHVtcFJlbmRlclRyZWUvaW9zL1VJU2NyaXB0 Q29udHJvbGxlcklPUy5tbQkod29ya2luZyBjb3B5KQpAQCAtMzcsNiArMzcsMTAgQEAgZXh0ZXJu IER1bXBSZW5kZXJUcmVlQnJvd3NlclZpZXcgKmdXZWJCcgogZXh0ZXJuIER1bXBSZW5kZXJUcmVl V2ViU2Nyb2xsVmlldyAqZ1dlYlNjcm9sbFZpZXc7CiAKIG5hbWVzcGFjZSBXVFIgeworICAgIAor dm9pZCBVSVNjcmlwdENvbnRyb2xsZXI6OmNoZWNrRm9yQ2xlYW4oKQoreworfQogCiB2b2lkIFVJ U2NyaXB0Q29udHJvbGxlcjo6ZG9Bc3luY1Rhc2soSlNWYWx1ZVJlZiBjYWxsYmFjaykKIHsKSW5k ZXg6IFRvb2xzL1Rlc3RSdW5uZXJTaGFyZWQvVUlTY3JpcHRDb250ZXh0L1VJU2NyaXB0Q29udGV4 dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvVGVzdFJ1bm5lclNoYXJlZC9VSVNjcmlwdENvbnRl eHQvVUlTY3JpcHRDb250ZXh0LmNwcAkocmV2aXNpb24gMjA5OTM2KQorKysgVG9vbHMvVGVzdFJ1 bm5lclNoYXJlZC9VSVNjcmlwdENvbnRleHQvVUlTY3JpcHRDb250ZXh0LmNwcAkod29ya2luZyBj b3B5KQpAQCAtNTIsNiArNTIsNyBAQCBVSVNjcmlwdENvbnRleHQ6OlVJU2NyaXB0Q29udGV4dChV SVNjcmlwCiAKIFVJU2NyaXB0Q29udGV4dDo6flVJU2NyaXB0Q29udGV4dCgpCiB7CisgICAgbV9j b250cm9sbGVyLT5jaGVja0ZvckNsZWFuKCk7CiAgICAgbV9jb250cm9sbGVyLT5jb250ZXh0RGVz dHJveWVkKCk7CiB9CiAKSW5kZXg6IFRvb2xzL1Rlc3RSdW5uZXJTaGFyZWQvVUlTY3JpcHRDb250 ZXh0L1VJU2NyaXB0Q29udHJvbGxlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvVGVzdFJ1bm5l clNoYXJlZC9VSVNjcmlwdENvbnRleHQvVUlTY3JpcHRDb250cm9sbGVyLmNwcAkocmV2aXNpb24g MjA5OTM2KQorKysgVG9vbHMvVGVzdFJ1bm5lclNoYXJlZC9VSVNjcmlwdENvbnRleHQvVUlTY3Jp cHRDb250cm9sbGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzcsNiArMzcsMTIgQEAgVUlTY3Jp cHRDb250cm9sbGVyOjpVSVNjcmlwdENvbnRyb2xsZXIoVQogewogfQogCisjaWYgIVBMQVRGT1JN KElPUykKK3ZvaWQgVUlTY3JpcHRDb250cm9sbGVyOjpjaGVja0ZvckNsZWFuKCkKK3sKK30KKyNl bmRpZgorCiB2b2lkIFVJU2NyaXB0Q29udHJvbGxlcjo6Y29udGV4dERlc3Ryb3llZCgpCiB7CiAg ICAgbV9jb250ZXh0ID0gbnVsbHB0cjsKSW5kZXg6IFRvb2xzL1Rlc3RSdW5uZXJTaGFyZWQvVUlT Y3JpcHRDb250ZXh0L1VJU2NyaXB0Q29udHJvbGxlci5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Rl c3RSdW5uZXJTaGFyZWQvVUlTY3JpcHRDb250ZXh0L1VJU2NyaXB0Q29udHJvbGxlci5oCShyZXZp c2lvbiAyMDk5MzYpCisrKyBUb29scy9UZXN0UnVubmVyU2hhcmVkL1VJU2NyaXB0Q29udGV4dC9V SVNjcmlwdENvbnRyb2xsZXIuaAkod29ya2luZyBjb3B5KQpAQCAtNDcsNiArNDcsNyBAQCBwdWJs aWM6CiAgICAgfQogCiAgICAgdm9pZCBjb250ZXh0RGVzdHJveWVkKCk7CisgICAgdm9pZCBjaGVj a0ZvckNsZWFuKCk7CiAKICAgICB2b2lkIG1ha2VXaW5kb3dPYmplY3QoSlNDb250ZXh0UmVmLCBK U09iamVjdFJlZiB3aW5kb3dPYmplY3QsIEpTVmFsdWVSZWYqIGV4Y2VwdGlvbik7CiAgICAgCklu ZGV4OiBUb29scy9XZWJLaXRUZXN0UnVubmVyL2lvcy9ISURFdmVudEdlbmVyYXRvci5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvaW9zL0hJREV2ZW50R2VuZXJhdG9yLmgJ KHJldmlzaW9uIDIwOTkzNikKKysrIFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvaW9zL0hJREV2ZW50 R2VuZXJhdG9yLmgJKHdvcmtpbmcgY29weSkKQEAgLTk4LDYgKzk4LDcgQEAgZXh0ZXJuIE5TU3Ry aW5nKiBjb25zdCBISURFdmVudFBoYXNlQ2FuYwogLSAodm9pZClzZW5kRXZlbnRTdHJlYW06KE5T RGljdGlvbmFyeSAqKWV2ZW50SW5mbyBjb21wbGV0aW9uQmxvY2s6KHZvaWQgKF4pKHZvaWQpKWNv bXBsZXRpb25CbG9jazsKIAogLSAodm9pZCltYXJrZXJFdmVudFJlY2VpdmVkOihJT0hJREV2ZW50 UmVmKWV2ZW50OworLSAoYm9vbCljaGVja0hJRENhbGxiYWNrc0NsZWFyOwogCiAvLyBLZXlib2Fy ZAogLSAodm9pZClrZXlQcmVzczooTlNTdHJpbmcgKiljaGFyYWN0ZXIgY29tcGxldGlvbkJsb2Nr Oih2b2lkICheKSh2b2lkKSljb21wbGV0aW9uQmxvY2s7CkluZGV4OiBUb29scy9XZWJLaXRUZXN0 UnVubmVyL2lvcy9ISURFdmVudEdlbmVyYXRvci5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9XZWJL aXRUZXN0UnVubmVyL2lvcy9ISURFdmVudEdlbmVyYXRvci5tbQkocmV2aXNpb24gMjA5OTM2KQor KysgVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9pb3MvSElERXZlbnRHZW5lcmF0b3IubW0JKHdvcmtp bmcgY29weSkKQEAgLTc2OSw2ICs3NjksMTMgQEAgLSAodm9pZCltYXJrZXJFdmVudFJlY2VpdmVk OihJT0hJREV2ZW50UgogICAgIH0KIH0KIAorLSAoYm9vbCljaGVja0hJRENhbGxiYWNrc0NsZWFy Cit7CisgICAgaWYgKFtfZXZlbnRDYWxsYmFja3MgY291bnRdKQorICAgICAgICByZXR1cm4gTk87 CisgICAgcmV0dXJuIFlFUzsKK30KKwogc3RhdGljIGlubGluZSBib29sIHNob3VsZFdyYXBXaXRo U2hpZnRLZXlFdmVudEZvckNoYXJhY3RlcihOU1N0cmluZyAqa2V5KQogewogICAgIGlmIChrZXku bGVuZ3RoICE9IDEpCkluZGV4OiBUb29scy9XZWJLaXRUZXN0UnVubmVyL2lvcy9UZXN0Q29udHJv bGxlcklPUy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9XZWJLaXRUZXN0UnVubmVyL2lvcy9UZXN0 Q29udHJvbGxlcklPUy5tbQkocmV2aXNpb24gMjA5OTM2KQorKysgVG9vbHMvV2ViS2l0VGVzdFJ1 bm5lci9pb3MvVGVzdENvbnRyb2xsZXJJT1MubW0JKHdvcmtpbmcgY29weSkKQEAgLTI2LDYgKzI2 LDcgQEAKICNpbXBvcnQgImNvbmZpZy5oIgogI2ltcG9ydCAiVGVzdENvbnRyb2xsZXIuaCIKIAor I2ltcG9ydCAiSElERXZlbnRHZW5lcmF0b3IuaCIKICNpbXBvcnQgIlBsYXRmb3JtV2ViVmlldy5o IgogI2ltcG9ydCAiVGVzdEludm9jYXRpb24uaCIKICNpbXBvcnQgIlRlc3RSdW5uZXJXS1dlYlZp ZXcuaCIKSW5kZXg6IFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvaW9zL1VJU2NyaXB0Q29udHJvbGxl cklPUy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9XZWJLaXRUZXN0UnVubmVyL2lvcy9VSVNjcmlw dENvbnRyb2xsZXJJT1MubW0JKHJldmlzaW9uIDIwOTkzNikKKysrIFRvb2xzL1dlYktpdFRlc3RS dW5uZXIvaW9zL1VJU2NyaXB0Q29udHJvbGxlcklPUy5tbQkod29ya2luZyBjb3B5KQpAQCAtNTMs NiArNTMsMTIgQEAgc3RhdGljIE5TRGljdGlvbmFyeSAqdG9OU0RpY3Rpb25hcnkoQ0dSZQogICAg ICAgICBAImhlaWdodCI6IEAocmVjdC5zaXplLmhlaWdodCkKICAgICB9OwogfQorICAgIAordm9p ZCBVSVNjcmlwdENvbnRyb2xsZXI6OmNoZWNrRm9yQ2xlYW4oKQoreworICAgIGlmICghW1tISURF dmVudEdlbmVyYXRvciBzaGFyZWRISURFdmVudEdlbmVyYXRvcl0gY2hlY2tISURDYWxsYmFja3ND bGVhcl0pCisgICAgICAgIFtOU0V4Y2VwdGlvbiByYWlzZTpAIldlYktpdFRlc3RSdW5uZXJUZXN0 UHJvYmxlbSIgZm9ybWF0OkAiVW5oYW5kbGVkIEhJRCBFdmVudCBleGlzdHMgYWZ0ZXIgTm90aWZ5 RG9uZSwgcGxlYXNlIG1ha2Ugc3VyZSB5b3UgYXJlIG5vdCBhZGRpbmcgYWRkaXRpb25hbCBISUQg Y2FsbHMgYWZ0ZXIgY2FsbGluZyBOb3RpZnlEb25lIl07Cit9CiAKIHZvaWQgVUlTY3JpcHRDb250 cm9sbGVyOjpkb0FzeW5jVGFzayhKU1ZhbHVlUmVmIGNhbGxiYWNrKQogewo= 297567 2016-12-20 16:24:21 -0800 2016-12-20 17:11:10 -0800 Patch bug-166271-20161220162320.patch text/plain 6139 megan_gardner SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxMDAzOCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDI5IEBACisyMDE2LTEyLTIwICBNZWdhbiBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBs ZS5jb20+CisKKyAgICAgICAgVGhyb3cgRXhjZXB0aW9uIHdoZW4gdGVzdCBkb2Vzbid0IGNsZWFu IHVwIEhJRCBFdmVudHMgcHJvcGVybHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE2NjI3MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEFkZCBpbiBhIGNoZWNrIHdoZW4gVUlTY3JpcHRDb250cm9sbGVyIGlz IGRlbGV0ZWQgdG8gbWFrZSBzdXJlIHRoYXQgdGhlIEhJRCBldmVudAorICAgICAgICBjYWxsYmFj ayBkaWN0aW9uYXJ5IGlzIGVtcHR5LiBJZiBpdCBpcyBub3QsIGFuZCBhIEhJRCBldmVudCBpcyBo aXQsIHRoaXMgd2lsbCBjYXVzZQorICAgICAgICB0aGUgcHJvZ3JhbSB0byBjcmFzaCB3aXRob3V0 IGFueSBnb29kIGluZm9ybWF0aW9uLiBDcmFzaGVzIGFyZSByYWNlLXksIGFuZCB3aWxsIHN0aWxs CisgICAgICAgIGhhcHBlbiB3aXRoIG1hbGZvcm1lZCB0ZXN0LCBidXQgdGhlIGluZm9ybWF0aW9u IHdpbGwgYmUgbXVjaCBtb3JlIGhlbHBmdWwuIAorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUv aW9zL1VJU2NyaXB0Q29udHJvbGxlcklPUy5tbToKKyAgICAgICAgKFdUUjo6VUlTY3JpcHRDb250 cm9sbGVyOjpjaGVja0ZvckNsZWFuKToKKyAgICAgICAgKiBUZXN0UnVubmVyU2hhcmVkL1VJU2Ny aXB0Q29udGV4dC9VSVNjcmlwdENvbnRleHQuY3BwOgorICAgICAgICAoVUlTY3JpcHRDb250ZXh0 Ojp+VUlTY3JpcHRDb250ZXh0KToKKyAgICAgICAgKiBUZXN0UnVubmVyU2hhcmVkL1VJU2NyaXB0 Q29udGV4dC9VSVNjcmlwdENvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV1RSOjpVSVNjcmlwdENv bnRyb2xsZXI6OmNoZWNrRm9yQ2xlYW4pOgorICAgICAgICAqIFRlc3RSdW5uZXJTaGFyZWQvVUlT Y3JpcHRDb250ZXh0L1VJU2NyaXB0Q29udHJvbGxlci5oOgorICAgICAgICAqIFdlYktpdFRlc3RS dW5uZXIvaW9zL0hJREV2ZW50R2VuZXJhdG9yLmg6CisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5l ci9pb3MvSElERXZlbnRHZW5lcmF0b3IubW06CisgICAgICAgICgtW0hJREV2ZW50R2VuZXJhdG9y IGNoZWNrSElEQ2FsbGJhY2tzQ2xlYXJdKToKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL2lv cy9UZXN0Q29udHJvbGxlcklPUy5tbToKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL2lvcy9V SVNjcmlwdENvbnRyb2xsZXJJT1MubW06CisgICAgICAgIChXVFI6OlVJU2NyaXB0Q29udHJvbGxl cjo6Y2hlY2tGb3JDbGVhbik6CisKIDIwMTYtMTItMjAgIEFuZHkgRXN0ZXMgIDxhZXN0ZXNAYXBw bGUuY29tPgogCiAgICAgICAgIFtDb2NvYV0gUkVHUkVTU0lPTiAocjIwOTU1OCk6IENhbGxpbmcg ZGVjaXNpb25IYW5kbGVyIG11bHRpcGxlIHRpbWVzIGluIHdlYlZpZXc6ZGVjaWRlUG9saWN5Rm9y TmF2aWdhdGlvbkFjdGlvbjpkZWNpc2lvbkhhbmRsZXI6IGxlYWRzIHRvIGEgY3Jhc2gKSW5kZXg6 IFRvb2xzL0R1bXBSZW5kZXJUcmVlL2lvcy9VSVNjcmlwdENvbnRyb2xsZXJJT1MubW0KPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gVG9vbHMvRHVtcFJlbmRlclRyZWUvaW9zL1VJU2NyaXB0Q29udHJvbGxlcklPUy5t bQkocmV2aXNpb24gMjA5OTM2KQorKysgVG9vbHMvRHVtcFJlbmRlclRyZWUvaW9zL1VJU2NyaXB0 Q29udHJvbGxlcklPUy5tbQkod29ya2luZyBjb3B5KQpAQCAtMzcsNiArMzcsMTAgQEAgZXh0ZXJu IER1bXBSZW5kZXJUcmVlQnJvd3NlclZpZXcgKmdXZWJCcgogZXh0ZXJuIER1bXBSZW5kZXJUcmVl V2ViU2Nyb2xsVmlldyAqZ1dlYlNjcm9sbFZpZXc7CiAKIG5hbWVzcGFjZSBXVFIgeworICAgIAor dm9pZCBVSVNjcmlwdENvbnRyb2xsZXI6OmNoZWNrRm9yT3V0c3RhbmRpbmdDYWxsYmFja3MoKQor eworfQogCiB2b2lkIFVJU2NyaXB0Q29udHJvbGxlcjo6ZG9Bc3luY1Rhc2soSlNWYWx1ZVJlZiBj YWxsYmFjaykKIHsKSW5kZXg6IFRvb2xzL1Rlc3RSdW5uZXJTaGFyZWQvVUlTY3JpcHRDb250ZXh0 L1VJU2NyaXB0Q29udGV4dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvVGVzdFJ1bm5lclNoYXJl ZC9VSVNjcmlwdENvbnRleHQvVUlTY3JpcHRDb250ZXh0LmNwcAkocmV2aXNpb24gMjA5OTM2KQor KysgVG9vbHMvVGVzdFJ1bm5lclNoYXJlZC9VSVNjcmlwdENvbnRleHQvVUlTY3JpcHRDb250ZXh0 LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTIsNiArNTIsNyBAQCBVSVNjcmlwdENvbnRleHQ6OlVJ U2NyaXB0Q29udGV4dChVSVNjcmlwCiAKIFVJU2NyaXB0Q29udGV4dDo6flVJU2NyaXB0Q29udGV4 dCgpCiB7CisgICAgbV9jb250cm9sbGVyLT5jaGVja0Zvck91dHN0YW5kaW5nQ2FsbGJhY2tzKCk7 CiAgICAgbV9jb250cm9sbGVyLT5jb250ZXh0RGVzdHJveWVkKCk7CiB9CiAKSW5kZXg6IFRvb2xz L1Rlc3RSdW5uZXJTaGFyZWQvVUlTY3JpcHRDb250ZXh0L1VJU2NyaXB0Q29udHJvbGxlci5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gVG9vbHMvVGVzdFJ1bm5lclNoYXJlZC9VSVNjcmlwdENvbnRleHQvVUlT Y3JpcHRDb250cm9sbGVyLmNwcAkocmV2aXNpb24gMjA5OTM2KQorKysgVG9vbHMvVGVzdFJ1bm5l clNoYXJlZC9VSVNjcmlwdENvbnRleHQvVUlTY3JpcHRDb250cm9sbGVyLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMzcsNiArMzcsMTIgQEAgVUlTY3JpcHRDb250cm9sbGVyOjpVSVNjcmlwdENvbnRy b2xsZXIoVQogewogfQogCisjaWYgIVBMQVRGT1JNKElPUykKK3ZvaWQgVUlTY3JpcHRDb250cm9s bGVyOjpjaGVja0Zvck91dHN0YW5kaW5nQ2FsbGJhY2tzKCkKK3sKK30KKyNlbmRpZgorCiB2b2lk IFVJU2NyaXB0Q29udHJvbGxlcjo6Y29udGV4dERlc3Ryb3llZCgpCiB7CiAgICAgbV9jb250ZXh0 ID0gbnVsbHB0cjsKSW5kZXg6IFRvb2xzL1Rlc3RSdW5uZXJTaGFyZWQvVUlTY3JpcHRDb250ZXh0 L1VJU2NyaXB0Q29udHJvbGxlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Rlc3RSdW5uZXJTaGFy ZWQvVUlTY3JpcHRDb250ZXh0L1VJU2NyaXB0Q29udHJvbGxlci5oCShyZXZpc2lvbiAyMDk5MzYp CisrKyBUb29scy9UZXN0UnVubmVyU2hhcmVkL1VJU2NyaXB0Q29udGV4dC9VSVNjcmlwdENvbnRy b2xsZXIuaAkod29ya2luZyBjb3B5KQpAQCAtNDcsNiArNDcsNyBAQCBwdWJsaWM6CiAgICAgfQog CiAgICAgdm9pZCBjb250ZXh0RGVzdHJveWVkKCk7CisgICAgdm9pZCBjaGVja0Zvck91dHN0YW5k aW5nQ2FsbGJhY2tzKCk7CiAKICAgICB2b2lkIG1ha2VXaW5kb3dPYmplY3QoSlNDb250ZXh0UmVm LCBKU09iamVjdFJlZiB3aW5kb3dPYmplY3QsIEpTVmFsdWVSZWYqIGV4Y2VwdGlvbik7CiAgICAg CkluZGV4OiBUb29scy9XZWJLaXRUZXN0UnVubmVyL2lvcy9ISURFdmVudEdlbmVyYXRvci5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvaW9zL0hJREV2ZW50R2VuZXJhdG9y LmgJKHJldmlzaW9uIDIwOTkzNikKKysrIFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvaW9zL0hJREV2 ZW50R2VuZXJhdG9yLmgJKHdvcmtpbmcgY29weSkKQEAgLTk4LDYgKzk4LDcgQEAgZXh0ZXJuIE5T U3RyaW5nKiBjb25zdCBISURFdmVudFBoYXNlQ2FuYwogLSAodm9pZClzZW5kRXZlbnRTdHJlYW06 KE5TRGljdGlvbmFyeSAqKWV2ZW50SW5mbyBjb21wbGV0aW9uQmxvY2s6KHZvaWQgKF4pKHZvaWQp KWNvbXBsZXRpb25CbG9jazsKIAogLSAodm9pZCltYXJrZXJFdmVudFJlY2VpdmVkOihJT0hJREV2 ZW50UmVmKWV2ZW50OworLSAoQk9PTCljaGVja0Zvck91dHN0YW5kaW5nQ2FsbGJhY2tzOwogCiAv LyBLZXlib2FyZAogLSAodm9pZClrZXlQcmVzczooTlNTdHJpbmcgKiljaGFyYWN0ZXIgY29tcGxl dGlvbkJsb2NrOih2b2lkICheKSh2b2lkKSljb21wbGV0aW9uQmxvY2s7CkluZGV4OiBUb29scy9X ZWJLaXRUZXN0UnVubmVyL2lvcy9ISURFdmVudEdlbmVyYXRvci5tbQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBU b29scy9XZWJLaXRUZXN0UnVubmVyL2lvcy9ISURFdmVudEdlbmVyYXRvci5tbQkocmV2aXNpb24g MjA5OTM2KQorKysgVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9pb3MvSElERXZlbnRHZW5lcmF0b3Iu bW0JKHdvcmtpbmcgY29weSkKQEAgLTc2OSw2ICs3NjksMTEgQEAgLSAodm9pZCltYXJrZXJFdmVu dFJlY2VpdmVkOihJT0hJREV2ZW50UgogICAgIH0KIH0KIAorLSAoQk9PTCljaGVja0Zvck91dHN0 YW5kaW5nQ2FsbGJhY2tzCit7CisgICAgcmV0dXJuICEoW19ldmVudENhbGxiYWNrcyBjb3VudF0g PiAwKTsKK30KKwogc3RhdGljIGlubGluZSBib29sIHNob3VsZFdyYXBXaXRoU2hpZnRLZXlFdmVu dEZvckNoYXJhY3RlcihOU1N0cmluZyAqa2V5KQogewogICAgIGlmIChrZXkubGVuZ3RoICE9IDEp CkluZGV4OiBUb29scy9XZWJLaXRUZXN0UnVubmVyL2lvcy9UZXN0Q29udHJvbGxlcklPUy5tbQo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBUb29scy9XZWJLaXRUZXN0UnVubmVyL2lvcy9UZXN0Q29udHJvbGxlcklP Uy5tbQkocmV2aXNpb24gMjA5OTM2KQorKysgVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9pb3MvVGVz dENvbnRyb2xsZXJJT1MubW0JKHdvcmtpbmcgY29weSkKQEAgLTI2LDYgKzI2LDcgQEAKICNpbXBv cnQgImNvbmZpZy5oIgogI2ltcG9ydCAiVGVzdENvbnRyb2xsZXIuaCIKIAorI2ltcG9ydCAiSElE RXZlbnRHZW5lcmF0b3IuaCIKICNpbXBvcnQgIlBsYXRmb3JtV2ViVmlldy5oIgogI2ltcG9ydCAi VGVzdEludm9jYXRpb24uaCIKICNpbXBvcnQgIlRlc3RSdW5uZXJXS1dlYlZpZXcuaCIKSW5kZXg6 IFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvaW9zL1VJU2NyaXB0Q29udHJvbGxlcklPUy5tbQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBUb29scy9XZWJLaXRUZXN0UnVubmVyL2lvcy9VSVNjcmlwdENvbnRyb2xsZXJJ T1MubW0JKHJldmlzaW9uIDIwOTkzNikKKysrIFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvaW9zL1VJ U2NyaXB0Q29udHJvbGxlcklPUy5tbQkod29ya2luZyBjb3B5KQpAQCAtNTMsNiArNTMsMTIgQEAg c3RhdGljIE5TRGljdGlvbmFyeSAqdG9OU0RpY3Rpb25hcnkoQ0dSZQogICAgICAgICBAImhlaWdo dCI6IEAocmVjdC5zaXplLmhlaWdodCkKICAgICB9OwogfQorICAgIAordm9pZCBVSVNjcmlwdENv bnRyb2xsZXI6OmNoZWNrRm9yT3V0c3RhbmRpbmdDYWxsYmFja3MoKQoreworICAgIGlmICghW1tI SURFdmVudEdlbmVyYXRvciBzaGFyZWRISURFdmVudEdlbmVyYXRvcl0gY2hlY2tGb3JPdXRzdGFu ZGluZ0NhbGxiYWNrc10pCisgICAgICAgIFtOU0V4Y2VwdGlvbiByYWlzZTpAIldlYktpdFRlc3RS dW5uZXJUZXN0UHJvYmxlbSIgZm9ybWF0OkAiVGhlIHRlc3QgY29tcGxldGVkIGJlZm9yZSBhbGwg c3ludGhlc2l6ZWQgZXZlbnRzIGhhZCBiZWVuIGhhbmRsZWQuIFBlcmhhcHMgeW91J3JlIGNhbGxp bmcgbm90aWZ5RG9uZSgpIHRvbyBlYXJseT8iXTsKK30KIAogdm9pZCBVSVNjcmlwdENvbnRyb2xs ZXI6OmRvQXN5bmNUYXNrKEpTVmFsdWVSZWYgY2FsbGJhY2spCiB7Cg==