<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>166067</bug_id>
          
          <creation_ts>2016-12-20 09:11:29 -0800</creation_ts>
          <short_desc>check-webkit-style misinterprets &apos;const&apos; in declarations</short_desc>
          <delta_ts>2016-12-20 10:15:16 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=165975</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Brent Fulgham">bfulgham</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>lforschler</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1261398</commentid>
    <comment_count>0</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2016-12-20 09:11:29 -0800</bug_when>
    <thetext>The &apos;check-webkit-style&apos; script misinterprets the following method declaration;

    void setOverlayMessage(ErrorString&amp;, const String* const) final;

It improperly believes that the second &apos;const&apos; is a parameter name because it does not recognize that this is telling the compiler that the pointer cannot be changed:

    const String* immutableContents; // Declares a pointer whose contents cannot be changed.
    String* const immutablePointer; // Declares a pointer that cannot be changed.
    const String* const immutableContents; // Declares a pointer that cannot be changed, and whose contents cannot be changed.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>