166058 2016-12-20 06:20:45 -0800 [Cairo] Conditional jump or move depends on uninitialised value(s) 2017-01-04 23:29:02 -0800 1 1 1 Unclassified WebKit Platform WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply commit-queue mcatanzaro mmaxfield oldest_to_newest 1261368 0 cgarcia 2016-12-20 06:20:45 -0800 ==25564== Conditional jump or move depends on uninitialised value(s) ==25564== at 0x9A72001: _cairo_gstate_transform_glyphs_to_backend (cairo-gstate.c:2198) ==25564== by 0x9A757BC: _cairo_gstate_glyph_path (cairo-gstate.c:2085) ==25564== by 0x9A678A1: cairo_glyph_path (cairo.c:3555) ==25564== by 0x71DA2EE: WebCore::CairoGlyphToPathTranslator::path() (in /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37.16.0) ==25564== by 0x71DB01A: WebCore::FontCascade::dashesForIntersectionsWithRect(WebCore::TextRun const&, WebCore::FloatPoint const&, WebCore::FloatRect const&) const (in /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37.16.0) ==25564== by 0x6F19C58: WebCore::drawSkipInkUnderline(WebCore::GraphicsContext&, WebCore::FontCascade const&, WebCore::TextRun const&, WebCore::FloatPoint const&, WebCore::FloatPoint const&, float, float, bool, bool, WebCore::StrokeStyle) (in /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37.16.0) ==25564== by 0x6F1B01A: WebCore::TextDecorationPainter::paintTextDecoration(WebCore::TextRun const&, WebCore::FloatPoint const&, WebCore::FloatPoint const&) (in /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37.16.0) ==25564== by 0x6D4BE6B: WebCore::InlineTextBox::paintDecoration(WebCore::GraphicsContext&, WebCore::FontCascade const&, WebCore::RenderCombineText*, WebCore::TextRun const&, WebCore::FloatPoint const&, WebCore::FloatRect const&, WebCore::TextDecoration, WebCore::TextPaintStyle, WebCore::ShadowData const*) (in /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37.16.0) ==25564== by 0x6D509CC: WebCore::InlineTextBox::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&, WebCore::LayoutUnit, WebCore::LayoutUnit) (in /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37.16.0) ==25564== by 0x6D495B7: WebCore::InlineFlowBox::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&, WebCore::LayoutUnit, WebCore::LayoutUnit) (in /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37.16.0) ==25564== by 0x6D495B7: WebCore::InlineFlowBox::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&, WebCore::LayoutUnit, WebCore::LayoutUnit) (in /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37.16.0) ==25564== by 0x6D495B7: WebCore::InlineFlowBox::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&, WebCore::LayoutUnit, WebCore::LayoutUnit) (in /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37.16.0) ==25564== Uninitialised value was created by a stack allocation ==25564== at 0x5E3C720: ??? (in /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37.16.0) 1261369 1 297518 cgarcia 2016-12-20 06:22:52 -0800 Created attachment 297518 Patch 1261373 2 mcatanzaro 2016-12-20 06:49:17 -0800 It reminds me of https://bugs.freedesktop.org/show_bug.cgi?id=91271, which is very annoying when valgrinding as it happens every time when loading any page. But clearly this is a separate issue. 1261912 3 297518 commit-queue 2016-12-20 23:49:18 -0800 Comment on attachment 297518 Patch Clearing flags on attachment: 297518 Committed r210056: <http://trac.webkit.org/changeset/210056> 1261913 4 commit-queue 2016-12-20 23:49:23 -0800 All reviewed patches have been landed. Closing bug. 1263811 5 297518 sabouhallawa 2017-01-04 10:24:18 -0800 Comment on attachment 297518 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297518&action=review > Source/WebCore/platform/graphics/cairo/FontCairo.cpp:246 > cairo_glyph_t cairoGlyph; > cairoGlyph.index = m_glyphBuffer.glyphAt(m_index); > + cairoGlyph.x = cairoGlyph.y = 0; These could have been written like this: cairo_glyph_t cairoGlyph = { m_glyphBuffer.glyphAt(m_index), 0, 0 }; 1264028 6 cgarcia 2017-01-04 23:29:02 -0800 (In reply to comment #5) > Comment on attachment 297518 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=297518&action=review > > > Source/WebCore/platform/graphics/cairo/FontCairo.cpp:246 > > cairo_glyph_t cairoGlyph; > > cairoGlyph.index = m_glyphBuffer.glyphAt(m_index); > > + cairoGlyph.x = cairoGlyph.y = 0; > > These could have been written like this: > > cairo_glyph_t cairoGlyph = { m_glyphBuffer.glyphAt(m_index), 0, 0 }; Indeed! Done in r210321, thanks. 297518 2016-12-20 06:22:52 -0800 2016-12-20 23:49:18 -0800 Patch wcore-cairo-glyphs.diff text/plain 1366 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyOTdlNWQ1YzRkMS4uZDRhNWRkY2E4YTggMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxNi0xMi0yMCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CisKKyAgICAgICAgW0NhaXJvXSBDb25kaXRpb25hbCBqdW1wIG9yIG1vdmUgZGVw ZW5kcyBvbiB1bmluaXRpYWxpc2VkIHZhbHVlKHMpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjYwNTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBJbml0aWFsaXplIHggYW5kIHkgbWVtYmVycyBvZiBjYWly b19nbHlwaF90IHN0cnVjdCBiZWZvcmUgcGFzc2luZyBpdCB0byBjYWlyb19nbHlwaF9wYXRoLgor CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vRm9udENhaXJvLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkNhaXJvR2x5cGhUb1BhdGhUcmFuc2xhdG9yOjpwYXRoKToKKwogMjAxNi0x Mi0xOSAgRGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+CiAKICAgICAgICAgVXNlIEVOQUJM RSgpIGluIHBsYWNlIG9mIEVOQUJMRV9DU1NfU0VMRUNUT1JTX0xFVkVMNApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vRm9udENhaXJvLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0ZvbnRDYWlyby5jcHAKaW5kZXgg OWUzMDgwMTU4NTIuLjBhYTBiYWM3OGM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jYWlyby9Gb250Q2Fpcm8uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2NhaXJvL0ZvbnRDYWlyby5jcHAKQEAgLTI0Myw2ICsyNDMsNyBAQCBQ YXRoIENhaXJvR2x5cGhUb1BhdGhUcmFuc2xhdG9yOjpwYXRoKCkKIAogICAgIGNhaXJvX2dseXBo X3QgY2Fpcm9HbHlwaDsKICAgICBjYWlyb0dseXBoLmluZGV4ID0gbV9nbHlwaEJ1ZmZlci5nbHlw aEF0KG1faW5kZXgpOworICAgIGNhaXJvR2x5cGgueCA9IGNhaXJvR2x5cGgueSA9IDA7CiAgICAg Y2Fpcm9fc2V0X3NjYWxlZF9mb250KHBhdGgucGxhdGZvcm1QYXRoKCktPmNvbnRleHQoKSwgbV9m b250RGF0YS0+cGxhdGZvcm1EYXRhKCkuc2NhbGVkRm9udCgpKTsKICAgICBjYWlyb19nbHlwaF9w YXRoKHBhdGgucGxhdGZvcm1QYXRoKCktPmNvbnRleHQoKSwgJmNhaXJvR2x5cGgsIDEpOwogCg==