166040 2016-12-19 14:56:00 -0800 Fix unwanted deletion of record/replay files 2016-12-19 16:37:45 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 krollin krollin achristensen commit-queue koivisto oldest_to_newest 1261227 0 krollin 2016-12-19 14:56:00 -0800 As part of some refactoring, the objects that create the meta files that are part of the record/replay cache would get deleted. They were always getting opened in "write" mode", which would truncate the files. Fix this so that the files are opened in the write modes for record, replay, and neither. 1261228 1 krollin 2016-12-19 14:58:08 -0800 That is, the "right" modes, not the "write" modes. 1261229 2 297481 krollin 2016-12-19 14:59:00 -0800 Created attachment 297481 Patch 1261232 3 297481 achristensen 2016-12-19 15:05:02 -0800 Comment on attachment 297481 Patch r=me. Since the m_loadFileHandle and m_replayFileHandle are used only for logging when replaying, do you think it would be good to have "Log" somewhere in their name? 1261244 4 krollin 2016-12-19 15:43:42 -0800 I'll file a new bug for that, since naming things is one of the Big Unsolved Problems in Computer Science. 1261269 5 297481 commit-queue 2016-12-19 16:37:42 -0800 Comment on attachment 297481 Patch Clearing flags on attachment: 297481 Committed r210005: <http://trac.webkit.org/changeset/210005> 1261270 6 commit-queue 2016-12-19 16:37:45 -0800 All reviewed patches have been landed. Closing bug. 297481 2016-12-19 14:59:00 -0800 2016-12-19 16:37:42 -0800 Patch bug-166040-20161219145800.patch text/plain 2507 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjA5OTk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNWQxMmU3Mzk0MTc0ZmY4 MTFmY2Q0MzNmMjFjNzU4YWFlMzJiZTc0MS4uYTdhNTEzNWE0ZDNjZDA5MDllMzc3MzQ4YWUxZWY1 ZTNlNzJkZTk2MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE2LTEyLTE5ICBLZWl0 aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggdW53YW50ZWQgZGVs ZXRpb24gb2YgcmVjb3JkL3JlcGxheSBmaWxlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY2MDQwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQXMgcGFydCBvZiBzb21lIHJlZmFjdG9yaW5nLCB0aGUgb2Jq ZWN0cyB0aGF0IGNyZWF0ZSB0aGUgbWV0YSBmaWxlcworICAgICAgICB0aGF0IGFyZSBwYXJ0IG9m IHRoZSByZWNvcmQvcmVwbGF5IGNhY2hlIHdvdWxkIGdldCBkZWxldGVkLiBUaGV5IHdlcmUKKyAg ICAgICAgYWx3YXlzIGdldHRpbmcgb3BlbmVkIGluICJ3cml0ZSIgbW9kZSIsIHdoaWNoIHdvdWxk IHRydW5jYXRlIHRoZQorICAgICAgICBmaWxlcy4gRml4IHRoaXMgc28gdGhhdCB0aGUgZmlsZXMg YXJlIG9wZW5lZCBpbiB0aGUgcmlnaHQgbW9kZXMgZm9yCisgICAgICAgIHJlY29yZCwgcmVwbGF5 LCBhbmQgbmVpdGhlci4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL2NhcHR1cmUvTmV0d29y a0NhcHR1cmVNYW5hZ2VyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya0NhcHR1cmU6Ok1h bmFnZXI6OmluaXRpYWxpemUpOgorCiAyMDE2LTEyLTE4ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5m cmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEV4cG9zZSBhIHdheSBmb3IgTWluaUJyb3dzZXIg dG8gc2ltdWxhdGUgaGVhZGVyIGFuZCBmb290ZXIgYmFubmVycwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvY2FwdHVyZS9OZXR3b3JrQ2FwdHVyZU1hbmFnZXIuY3Bw IGIvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvY2FwdHVyZS9OZXR3b3JrQ2FwdHVyZU1h bmFnZXIuY3BwCmluZGV4IGJlODBhZTk2YTQ5MTkwYjlhZTdlM2Q5ODVlNjcyZjc5ZTM2Mjk4MTIu LjNkYWRjOTM2ZDIyMDhhZjdhMzU2OWYzMmRhMTBjNDMzZTk3Y2Y0MjYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NhcHR1cmUvTmV0d29ya0NhcHR1cmVNYW5hZ2Vy LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jYXB0dXJlL05ldHdvcmtD YXB0dXJlTWFuYWdlci5jcHAKQEAgLTcyLDkgKzcyLDE0IEBAIHZvaWQgTWFuYWdlcjo6aW5pdGlh bGl6ZShjb25zdCBTdHJpbmcmIHJlY29yZFJlcGxheU1vZGUsIGNvbnN0IFN0cmluZyYgcmVjb3Jk UmVwCiAgICAgICAgIG1fcmVjb3JkUmVwbGF5TW9kZSA9IERpc2FibGVkOwogCiAgICAgbV9yZWNv cmRSZXBsYXlDYWNoZUxvY2F0aW9uID0gV2ViQ29yZTo6cGF0aEJ5QXBwZW5kaW5nQ29tcG9uZW50 KHJlY29yZFJlcGxheUNhY2hlTG9jYXRpb24sIGtEaXJOYW1lUmVjb3JkUmVwbGF5KTsKLSAgICBt X2xvYWRGaWxlSGFuZGxlID0gV2ViQ29yZTo6RmlsZUhhbmRsZShyZXBvcnRMb2FkUGF0aCgpLCBX ZWJDb3JlOjpPcGVuRm9yV3JpdGUpOwotICAgIG1fcmVjb3JkRmlsZUhhbmRsZSA9IFdlYkNvcmU6 OkZpbGVIYW5kbGUocmVwb3J0UmVjb3JkUGF0aCgpLCBXZWJDb3JlOjpPcGVuRm9yV3JpdGUpOwot ICAgIG1fcmVwbGF5RmlsZUhhbmRsZSA9IFdlYkNvcmU6OkZpbGVIYW5kbGUocmVwb3J0UmVwbGF5 UGF0aCgpLCBXZWJDb3JlOjpPcGVuRm9yV3JpdGUpOworCisgICAgaWYgKGlzUmVjb3JkaW5nKCkp IHsKKyAgICAgICAgbV9yZWNvcmRGaWxlSGFuZGxlID0gV2ViQ29yZTo6RmlsZUhhbmRsZShyZXBv cnRSZWNvcmRQYXRoKCksIFdlYkNvcmU6Ok9wZW5Gb3JXcml0ZSk7CisgICAgfSBlbHNlIGlmIChp c1JlcGxheWluZygpKSB7CisgICAgICAgIG1fcmVjb3JkRmlsZUhhbmRsZSA9IFdlYkNvcmU6OkZp bGVIYW5kbGUocmVwb3J0UmVjb3JkUGF0aCgpLCBXZWJDb3JlOjpPcGVuRm9yUmVhZCk7CisgICAg ICAgIG1fbG9hZEZpbGVIYW5kbGUgPSBXZWJDb3JlOjpGaWxlSGFuZGxlKHJlcG9ydExvYWRQYXRo KCksIFdlYkNvcmU6Ok9wZW5Gb3JXcml0ZSk7CisgICAgICAgIG1fcmVwbGF5RmlsZUhhbmRsZSA9 IFdlYkNvcmU6OkZpbGVIYW5kbGUocmVwb3J0UmVwbGF5UGF0aCgpLCBXZWJDb3JlOjpPcGVuRm9y V3JpdGUpOworICAgIH0KIAogICAgIERFQlVHX0xPRygiQ2FjaGUgbG9jYXRpb24gPSAiIFNUUklO R19TUEVDSUZJRVIsIERFQlVHX1NUUihtX3JlY29yZFJlcGxheUNhY2hlTG9jYXRpb24pKTsKIAo=