166033 2016-12-19 13:32:18 -0800 REGRESSION: API test failure: _WKDownload.OriginatingWebView 2016-12-21 15:59:33 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=166032 https://bugs.webkit.org/show_bug.cgi?id=166031 InRadar P2 Normal --- 1 ryanhaddad ap aestes ap commit-queue simon.fraser webkit-bug-importer oldest_to_newest 1261193 0 ryanhaddad 2016-12-19 13:32:18 -0800 FAIL _WKDownload.OriginatingWebView /Volumes/Data/slave/sierra-release/build/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:250 Value of: !([download originatingWebView]) Actual: false Expected: true https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20%28Tests%29/builds/2323/steps/run-api-tests/logs/stdio 1261196 1 ryanhaddad 2016-12-19 13:32:56 -0800 Started after the Sierra bots were updated to 10.12.2 1261676 2 webkit-bug-importer 2016-12-20 12:35:57 -0800 <rdar://problem/29758428> 1262179 3 297627 ap 2016-12-21 15:31:16 -0800 Created attachment 297627 proposed fix Similar to Simon's fix in bug 166031. This fix seems a little weaker, since this test is async, and we can't drain all objects autoreleased by AppKit. It does fix the test though. 1262185 4 297627 commit-queue 2016-12-21 15:59:29 -0800 Comment on attachment 297627 proposed fix Clearing flags on attachment: 297627 Committed r210082: <http://trac.webkit.org/changeset/210082> 1262186 5 commit-queue 2016-12-21 15:59:33 -0800 All reviewed patches have been landed. Closing bug. 297627 2016-12-21 15:31:16 -0800 2016-12-21 15:59:29 -0800 proposed fix OriginatingWebView.txt text/plain 1659 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxMDA4MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE2LTEyLTIxICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIFJFR1JFU1NJT046IEFQSSB0ZXN0IGZhaWx1cmU6IF9XS0Rvd25sb2FkLk9y aWdpbmF0aW5nV2ViVmlldworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTY2MDMzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yOTc1ODQyOD4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYW4gQGF1dG9y ZWxlYXNlcG9vbCBhcm91bmQgdGhlIGNvZGUgdGhhdCBhbGxvY2F0ZXMgdGhlIFdLV2ViVmlldywg CisgICAgICAgIHNvIHRoYXQgaXQgY2FuIGJlIGRlc3Ryb3llZCBieSByZW1vdmluZyB0aGUgbGFz dCByZWZlcmVuY2UgaW4gX2Rvd25sb2FkRGlkU3RhcnQuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0 QVBJL1Rlc3RzL1dlYktpdDJDb2NvYS9Eb3dubG9hZC5tbToKKyAgICAgICAgKFRFU1QpOgorCiAy MDE2LTEyLTIxICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBX ZWJLaXRUZXN0UnVubmVyOiBBZGQgY29tbWVudCB0byBUZXN0UnVubmVyOjpzZXRDYW5PcGVuV2lu ZG93cygpCkluZGV4OiBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDJDb2NvYS9Eb3du bG9hZC5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDJD b2NvYS9Eb3dubG9hZC5tbQkocmV2aXNpb24gMjEwMDYwKQorKysgVG9vbHMvVGVzdFdlYktpdEFQ SS9UZXN0cy9XZWJLaXQyQ29jb2EvRG93bmxvYWQubW0JKHdvcmtpbmcgY29weSkKQEAgLTI1Nyw3 ICsyNTcsNyBAQCBURVNUKF9XS0Rvd25sb2FkLCBPcmlnaW5hdGluZ1dlYlZpZXcpCiB7CiAgICAg UmV0YWluUHRyPERvd25sb2FkTmF2aWdhdGlvbkRlbGVnYXRlPiBuYXZpZ2F0aW9uRGVsZWdhdGUg PSBhZG9wdE5TKFtbRG93bmxvYWROYXZpZ2F0aW9uRGVsZWdhdGUgYWxsb2NdIGluaXRdKTsgICAg ICAgICAgICAgICAgIAogICAgIFJldGFpblB0cjxPcmlnaW5hdGluZ1dlYlZpZXdEb3dubG9hZERl bGVnYXRlPiBkb3dubG9hZERlbGVnYXRlOwotICAgIHsKKyAgICBAYXV0b3JlbGVhc2Vwb29sIHsK ICAgICAgICAgUmV0YWluUHRyPFdLV2ViVmlldz4gd2ViVmlldyA9IGFkb3B0TlMoW1tXS1dlYlZp ZXcgYWxsb2NdIGluaXRXaXRoRnJhbWU6TlNNYWtlUmVjdCgwLCAwLCA4MDAsIDYwMCldKTsKICAg ICAgICAgW3dlYlZpZXcgc2V0TmF2aWdhdGlvbkRlbGVnYXRlOm5hdmlnYXRpb25EZWxlZ2F0ZS5n ZXQoKV07CiAgICAgICAgIGRvd25sb2FkRGVsZWdhdGUgPSBhZG9wdE5TKFtbT3JpZ2luYXRpbmdX ZWJWaWV3RG93bmxvYWREZWxlZ2F0ZSBhbGxvY10gaW5pdFdpdGhXZWJWaWV3OndlYlZpZXcuZ2V0 KCldKTsK