<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>166032</bug_id>
          
          <creation_ts>2016-12-19 13:32:16 -0800</creation_ts>
          <short_desc>REGRESSION: API test failure: WKWebView.LocalStorageClear</short_desc>
          <delta_ts>2016-12-21 17:58:11 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=166031</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=166033</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ryan Haddad">ryanhaddad</reporter>
          <assigned_to name="Alexey Proskuryakov">ap</assigned_to>
          <cc>ap</cc>
    
    <cc>beidson</cc>
    
    <cc>commit-queue</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1261192</commentid>
    <comment_count>0</comment_count>
    <who name="Ryan Haddad">ryanhaddad</who>
    <bug_when>2016-12-19 13:32:16 -0800</bug_when>
    <thetext>FAIL WKWebView.LocalStorageClear

/Volumes/Data/slave/sierra-release/build/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:84
Value of: [[NSFileManager defaultManager] fileExistsAtPath:dbWALPath]
  Actual: true
Expected: false


/Volumes/Data/slave/sierra-release/build/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:85
Value of: [[NSFileManager defaultManager] fileExistsAtPath:trackerPath]
  Actual: true
Expected: false


/Volumes/Data/slave/sierra-release/build/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:86
Value of: [[NSFileManager defaultManager] fileExistsAtPath:trackerSHMPath]
  Actual: true
Expected: false


/Volumes/Data/slave/sierra-release/build/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:87
Value of: [[NSFileManager defaultManager] fileExistsAtPath:trackerWALPath]
  Actual: true
Expected: false

https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20%28Tests%29/builds/2323/steps/run-api-tests/logs/stdio</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1261195</commentid>
    <comment_count>1</comment_count>
    <who name="Ryan Haddad">ryanhaddad</who>
    <bug_when>2016-12-19 13:32:53 -0800</bug_when>
    <thetext>Started after the Sierra bots were updated to 10.12.2</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1261675</commentid>
    <comment_count>2</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2016-12-20 12:35:26 -0800</bug_when>
    <thetext>&lt;rdar://problem/29758423&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1261678</commentid>
    <comment_count>3</comment_count>
    <who name="Brady Eidson">beidson</who>
    <bug_when>2016-12-20 12:39:08 -0800</bug_when>
    <thetext>Confirmed locally on my 10.12.2 machine (where API tests all passed back on 10.12.1)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1262178</commentid>
    <comment_count>4</comment_count>
      <attachid>297626</attachid>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2016-12-21 15:23:50 -0800</bug_when>
    <thetext>Created attachment 297626
proposed fix

Same as Simon&apos;s fix in bug 166031.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1262237</commentid>
    <comment_count>5</comment_count>
      <attachid>297626</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2016-12-21 17:58:07 -0800</bug_when>
    <thetext>Comment on attachment 297626
proposed fix

Clearing flags on attachment: 297626

Committed r210093: &lt;http://trac.webkit.org/changeset/210093&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1262238</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2016-12-21 17:58:11 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>297626</attachid>
            <date>2016-12-21 15:23:50 -0800</date>
            <delta_ts>2016-12-21 17:58:07 -0800</delta_ts>
            <desc>proposed fix</desc>
            <filename>LocalStorageClear.txt</filename>
            <type>text/plain</type>
            <size>2545</size>
            <attacher name="Alexey Proskuryakov">ap</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDIxMDA4MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDE3IEBACisyMDE2LTEyLTIxICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t
PgorCisgICAgICAgIFJFR1JFU1NJT046IEFQSSB0ZXN0IGZhaWx1cmU6IFdLV2ViVmlldy5Mb2Nh
bFN0b3JhZ2VDbGVhcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9MTY2MDMyCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yOTc1ODQyMz4KKworICAgICAg
ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYW4gQGF1dG9yZWxl
YXNlcG9vbCBhcm91bmQgdGhlIGNvZGUgdGhhdCBhbGxvY2F0ZXMgdGhlbiBjbGVhcnMgdGhlIFdL
V2ViVmlldywgCisgICAgICAgIHRvIGVuc3VyZSB0aGF0IHRoZSB2aWV3IGlzIGRlc3Ryb3llZCBi
ZWZvcmUgdGhlIGNhbGxiYWNrIGZpcmVzLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0
cy9XZWJLaXQyQ29jb2EvTG9jYWxTdG9yYWdlQ2xlYXIubW06CisgICAgICAgIChURVNUKToKKwog
MjAxNi0xMi0yMSAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+CiAKICAgICAgICAg
V2ViS2l0VGVzdFJ1bm5lcjogQWRkIGNvbW1lbnQgdG8gVGVzdFJ1bm5lcjo6c2V0Q2FuT3Blbldp
bmRvd3MoKQpJbmRleDogVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyQ29jb2EvTG9j
YWxTdG9yYWdlQ2xlYXIubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0
cy9XZWJLaXQyQ29jb2EvTG9jYWxTdG9yYWdlQ2xlYXIubW0JKHJldmlzaW9uIDIxMDA2MCkKKysr
IFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0MkNvY29hL0xvY2FsU3RvcmFnZUNsZWFy
Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC02MSwxNSArNjEsMTcgQEAgVEVTVChXS1dlYlZpZXcsIExv
Y2FsU3RvcmFnZUNsZWFyKQogICAgIFtjb25maWd1cmF0aW9uIF9zZXROZWVkc1N0b3JhZ2VBY2Nl
c3NGcm9tRmlsZVVSTHNRdWlyazpOT107CiAgICAgW2NvbmZpZ3VyYXRpb24gX3NldEFsbG93VW5p
dmVyc2FsQWNjZXNzRnJvbUZpbGVVUkxzOllFU107CiAKLSAgICBSZXRhaW5QdHI8V0tXZWJWaWV3
PiB3ZWJWaWV3ID0gYWRvcHROUyhbW1dLV2ViVmlldyBhbGxvY10gaW5pdFdpdGhGcmFtZTpOU01h
a2VSZWN0KDAsIDAsIDgwMCwgNjAwKSBjb25maWd1cmF0aW9uOmNvbmZpZ3VyYXRpb24uZ2V0KCld
KTsKKyAgICBAYXV0b3JlbGVhc2Vwb29sIHsKKyAgICAgICAgUmV0YWluUHRyPFdLV2ViVmlldz4g
d2ViVmlldyA9IGFkb3B0TlMoW1tXS1dlYlZpZXcgYWxsb2NdIGluaXRXaXRoRnJhbWU6TlNNYWtl
UmVjdCgwLCAwLCA4MDAsIDYwMCkgY29uZmlndXJhdGlvbjpjb25maWd1cmF0aW9uLmdldCgpXSk7
CiAKLSAgICBOU1VSTFJlcXVlc3QgKnJlcXVlc3QgPSBbTlNVUkxSZXF1ZXN0IHJlcXVlc3RXaXRo
VVJMOltbTlNCdW5kbGUgbWFpbkJ1bmRsZV0gVVJMRm9yUmVzb3VyY2U6QCJMb2NhbFN0b3JhZ2VD
bGVhciIgd2l0aEV4dGVuc2lvbjpAImh0bWwiIHN1YmRpcmVjdG9yeTpAIlRlc3RXZWJLaXRBUEku
cmVzb3VyY2VzIl1dOwotICAgIFt3ZWJWaWV3IGxvYWRSZXF1ZXN0OnJlcXVlc3RdOworICAgICAg
ICBOU1VSTFJlcXVlc3QgKnJlcXVlc3QgPSBbTlNVUkxSZXF1ZXN0IHJlcXVlc3RXaXRoVVJMOltb
TlNCdW5kbGUgbWFpbkJ1bmRsZV0gVVJMRm9yUmVzb3VyY2U6QCJMb2NhbFN0b3JhZ2VDbGVhciIg
d2l0aEV4dGVuc2lvbjpAImh0bWwiIHN1YmRpcmVjdG9yeTpAIlRlc3RXZWJLaXRBUEkucmVzb3Vy
Y2VzIl1dOworICAgICAgICBbd2ViVmlldyBsb2FkUmVxdWVzdDpyZXF1ZXN0XTsKIAotICAgIFRl
c3RXZWJLaXRBUEk6OlV0aWw6OnJ1bigmcmVhZHlUb0NvbnRpbnVlKTsKLSAgICByZWFkeVRvQ29u
dGludWUgPSBmYWxzZTsKKyAgICAgICAgVGVzdFdlYktpdEFQSTo6VXRpbDo6cnVuKCZyZWFkeVRv
Q29udGludWUpOworICAgICAgICByZWFkeVRvQ29udGludWUgPSBmYWxzZTsKIAotICAgIHdlYlZp
ZXcgPSBuaWw7CisgICAgICAgIHdlYlZpZXcgPSBuaWw7CisgICAgfQogCiAgICAgTlNTdHJpbmcg
KmRiUGF0aCA9IFtAIn4vTGlicmFyeS9XZWJLaXQvVGVzdFdlYktpdEFQSS9XZWJzaXRlRGF0YS9M
b2NhbFN0b3JhZ2UvZmlsZV9fMC5sb2NhbHN0b3JhZ2UiIHN0cmluZ0J5RXhwYW5kaW5nVGlsZGVJ
blBhdGhdOwogICAgIE5TU3RyaW5nICpkYlNITVBhdGggPSBbQCJ+L0xpYnJhcnkvV2ViS2l0L1Rl
c3RXZWJLaXRBUEkvV2Vic2l0ZURhdGEvTG9jYWxTdG9yYWdlL2ZpbGVfXzAubG9jYWxzdG9yYWdl
LXNobSIgc3RyaW5nQnlFeHBhbmRpbmdUaWxkZUluUGF0aF07Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>