166031 2016-12-19 13:32:14 -0800 REGRESSION: API test failure: WKWebView.EvaluateJavaScriptBlockCrash 2016-12-21 15:22:53 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=166032 https://bugs.webkit.org/show_bug.cgi?id=166033 InRadar P2 Normal --- 1 ryanhaddad simon.fraser ap commit-queue simon.fraser webkit-bug-importer oldest_to_newest 1261191 0 ryanhaddad 2016-12-19 13:32:14 -0800 FAIL WKWebView.EvaluateJavaScriptBlockCrash /Volumes/Data/slave/sierra-release/build/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:53 Value of: error Actual: false Expected: true https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20%28Tests%29/builds/2323/steps/run-api-tests/logs/stdio 1261194 1 ryanhaddad 2016-12-19 13:32:49 -0800 Started after the Sierra bots were updated to 10.12.2 1261630 2 simon.fraser 2016-12-20 11:57:13 -0800 Who added the test? 1261645 3 ryanhaddad 2016-12-20 12:06:09 -0800 (In reply to comment #2) > Who added the test? Blame points to you for adding the file, but the changelog has a lot of OOPS in it: https://trac.webkit.org/changeset/179160 1261657 4 simon.fraser 2016-12-20 12:14:14 -0800 Wow, have no memory of that. 1261674 5 webkit-bug-importer 2016-12-20 12:35:01 -0800 <rdar://problem/29758419> 1261844 6 simon.fraser 2016-12-20 16:54:10 -0800 This commit is more helpful: https://trac.webkit.org/changeset/179161 1261845 7 simon.fraser 2016-12-20 16:58:56 -0800 The test does this: // Force the WKWebView to be destroyed to allow evaluateJavaScript's completion handler to be called with an error. webView = nullptr; but it seems like this no longer has the desired result. 1261849 8 simon.fraser 2016-12-20 17:07:05 -0800 AppKit changed to start autoreleasing the WKWebView. The test is no longer valid. 1261856 9 297571 simon.fraser 2016-12-20 17:17:38 -0800 Created attachment 297571 Patch 1261866 10 297571 commit-queue 2016-12-20 18:18:33 -0800 Comment on attachment 297571 Patch Clearing flags on attachment: 297571 Committed r210050: <http://trac.webkit.org/changeset/210050> 1261867 11 commit-queue 2016-12-20 18:18:37 -0800 All reviewed patches have been landed. Closing bug. 297571 2016-12-20 17:17:38 -0800 2016-12-20 18:18:33 -0800 Patch bug-166031-20161220171641.patch text/plain 3244 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjA5OTczCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZjQ1MTBmNDYyYjBjOTlkZmI5NDI2N2FiMTdlZmVlOTRh NGExZDE1OS4uM2NiNjA1NTcxMWI4NjhjYzhhM2Y3NWFjNWM2NjNiZTljY2M3MTlhNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE2LTEyLTIwICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgor CisgICAgICAgIFJFR1JFU1NJT046IEFQSSB0ZXN0IGZhaWx1cmU6IFdLV2ViVmlldy5FdmFsdWF0 ZUphdmFTY3JpcHRCbG9ja0NyYXNoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNjYwMzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKyAgICAgICAgCisgICAgICAgIEFkZCBhbiBAYXV0b3JlbGVhc2Vwb29sIGFyb3VuZCB0aGUg Y29kZSB0aGF0IGFsbG9jYXRlcyB0aGVuIGNsZWFycyB0aGUgV0tXZWJWaWV3LCAKKyAgICAgICAg dG8gZW5zdXJlIHRoYXQgdGhlIHZpZXcgaXMgZGVzdHJveWVkIGJlZm9yZSB0aGUgY2FsbGJhY2sg ZmlyZXMuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDJDb2NvYS9XS1dl YlZpZXdFdmFsdWF0ZUphdmFTY3JpcHQubW06CisKIDIwMTYtMTItMTcgIFNpbW9uIEZyYXNlciAg PHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IGlPUyB0ZXN0IHJlc3VsdHMg YWZ0ZXIgcjIwOTk2Ny4KZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2Vi S2l0MkNvY29hL1dLV2ViVmlld0V2YWx1YXRlSmF2YVNjcmlwdC5tbSBiL1Rvb2xzL1Rlc3RXZWJL aXRBUEkvVGVzdHMvV2ViS2l0MkNvY29hL1dLV2ViVmlld0V2YWx1YXRlSmF2YVNjcmlwdC5tbQpp bmRleCBjYzY4ZDc3MTZlYTdhZTQ2NzAwMDY5MWJjYjVmNGE5N2Y5MjMxZWNiLi41NGQ3MjM0OTY3 OTY1OWNhYTJiMmUxMjMyNmM2YmI4Y2I1MjM4MTcyIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2Vi S2l0QVBJL1Rlc3RzL1dlYktpdDJDb2NvYS9XS1dlYlZpZXdFdmFsdWF0ZUphdmFTY3JpcHQubW0K KysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyQ29jb2EvV0tXZWJWaWV3RXZh bHVhdGVKYXZhU2NyaXB0Lm1tCkBAIC0zOSwyNCArMzksMjYgQEAgc3RhdGljIGJvb2wgaXNEb25l OwogCiBURVNUKFdLV2ViVmlldywgRXZhbHVhdGVKYXZhU2NyaXB0QmxvY2tDcmFzaCkKIHsKLSAg ICBSZXRhaW5QdHI8V0tXZWJWaWV3PiB3ZWJWaWV3ID0gYWRvcHROUyhbW1dLV2ViVmlldyBhbGxv Y10gaW5pdFdpdGhGcmFtZTpOU01ha2VSZWN0KDAsIDAsIDgwMCwgNjAwKV0pOwotCi0gICAgTlNV UkxSZXF1ZXN0ICpyZXF1ZXN0ID0gW05TVVJMUmVxdWVzdCByZXF1ZXN0V2l0aFVSTDpbW05TQnVu ZGxlIG1haW5CdW5kbGVdIFVSTEZvclJlc291cmNlOkAic2ltcGxlIiB3aXRoRXh0ZW5zaW9uOkAi aHRtbCIgc3ViZGlyZWN0b3J5OkAiVGVzdFdlYktpdEFQSS5yZXNvdXJjZXMiXV07Ci0gICAgW3dl YlZpZXcgbG9hZFJlcXVlc3Q6cmVxdWVzdF07Ci0KLSAgICBbd2ViVmlldyBldmFsdWF0ZUphdmFT Y3JpcHQ6QCIiIGNvbXBsZXRpb25IYW5kbGVyOl4oaWQgcmVzdWx0LCBOU0Vycm9yICplcnJvcikg ewotICAgICAgICAvLyBOT1RFOiBCeSByZWZlcmVuY2luZyB0aGUgcmVxdWVzdCBoZXJlLCB3ZSBj b252ZXJ0IHRoZSBibG9jayBpbnRvIGEgc3RhY2sgYmxvY2sgcmF0aGVyIHRoYW4gYSBnbG9iYWwg YmxvY2sgYW5kIHRodXMgYWxsb3cgdGhlIGNvcHlpbmcgb2YgdGhlIGJsb2NrCi0gICAgICAgIC8v IGluIGV2YWx1YXRlSmF2YVNjcmlwdCB0byBiZSBtZWFuaW5nZnVsLgotICAgICAgICAodm9pZCly ZXF1ZXN0OwotICAgICAgICAKLSAgICAgICAgRVhQRUNUX05VTEwocmVzdWx0KTsKLSAgICAgICAg RVhQRUNUX05PVF9OVUxMKGVycm9yKTsKLQotICAgICAgICBpc0RvbmUgPSB0cnVlOwotICAgIH1d OwotCi0gICAgLy8gRm9yY2UgdGhlIFdLV2ViVmlldyB0byBiZSBkZXN0cm95ZWQgdG8gYWxsb3cg ZXZhbHVhdGVKYXZhU2NyaXB0J3MgY29tcGxldGlvbiBoYW5kbGVyIHRvIGJlIGNhbGxlZCB3aXRo IGFuIGVycm9yLgotICAgIHdlYlZpZXcgPSBudWxscHRyOworICAgIEBhdXRvcmVsZWFzZXBvb2wg eworICAgICAgICBSZXRhaW5QdHI8V0tXZWJWaWV3PiB3ZWJWaWV3ID0gYWRvcHROUyhbW1dLV2Vi VmlldyBhbGxvY10gaW5pdFdpdGhGcmFtZTpOU01ha2VSZWN0KDAsIDAsIDgwMCwgNjAwKV0pOwor CisgICAgICAgIE5TVVJMUmVxdWVzdCAqcmVxdWVzdCA9IFtOU1VSTFJlcXVlc3QgcmVxdWVzdFdp dGhVUkw6W1tOU0J1bmRsZSBtYWluQnVuZGxlXSBVUkxGb3JSZXNvdXJjZTpAInNpbXBsZSIgd2l0 aEV4dGVuc2lvbjpAImh0bWwiIHN1YmRpcmVjdG9yeTpAIlRlc3RXZWJLaXRBUEkucmVzb3VyY2Vz Il1dOworICAgICAgICBbd2ViVmlldyBsb2FkUmVxdWVzdDpyZXF1ZXN0XTsKKworICAgICAgICBb d2ViVmlldyBldmFsdWF0ZUphdmFTY3JpcHQ6QCIiIGNvbXBsZXRpb25IYW5kbGVyOl4oaWQgcmVz dWx0LCBOU0Vycm9yICplcnJvcikgeworICAgICAgICAgICAgLy8gTk9URTogQnkgcmVmZXJlbmNp bmcgdGhlIHJlcXVlc3QgaGVyZSwgd2UgY29udmVydCB0aGUgYmxvY2sgaW50byBhIHN0YWNrIGJs b2NrIHJhdGhlciB0aGFuIGEgZ2xvYmFsIGJsb2NrIGFuZCB0aHVzIGFsbG93IHRoZSBjb3B5aW5n IG9mIHRoZSBibG9jaworICAgICAgICAgICAgLy8gaW4gZXZhbHVhdGVKYXZhU2NyaXB0IHRvIGJl IG1lYW5pbmdmdWwuCisgICAgICAgICAgICAodm9pZClyZXF1ZXN0OworICAgICAgICAgICAgCisg ICAgICAgICAgICBFWFBFQ1RfTlVMTChyZXN1bHQpOworICAgICAgICAgICAgRVhQRUNUX05PVF9O VUxMKGVycm9yKTsKKworICAgICAgICAgICAgaXNEb25lID0gdHJ1ZTsKKyAgICAgICAgfV07CisK KyAgICAgICAgLy8gRm9yY2UgdGhlIFdLV2ViVmlldyB0byBiZSBkZXN0cm95ZWQgdG8gYWxsb3cg ZXZhbHVhdGVKYXZhU2NyaXB0J3MgY29tcGxldGlvbiBoYW5kbGVyIHRvIGJlIGNhbGxlZCB3aXRo IGFuIGVycm9yLgorICAgICAgICB3ZWJWaWV3ID0gbnVsbHB0cjsKKyAgICB9CiAKICAgICBpc0Rv bmUgPSBmYWxzZTsKICAgICBUZXN0V2ViS2l0QVBJOjpVdGlsOjpydW4oJmlzRG9uZSk7Cg==