16602 2007-12-25 04:48:35 -0800 Remove unnecessary redundant check from property setting 2007-12-25 15:10:05 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.4 RESOLVED FIXED P3 Normal --- 1 mjs mjs oldest_to_newest 65237 0 mjs 2007-12-25 04:48:35 -0800 Setting JS properties does an unnecessary redundant check; the checking can be done as part of writing to the PropertyMap. 65238 1 18106 mjs 2007-12-25 04:51:20 -0800 Created attachment 18106 do the read-only check more efficiently - 1.3% speedup 18106 2007-12-25 04:51:20 -0800 2007-12-25 14:34:30 -0800 do the read-only check more efficiently - 1.3% speedup faster-put-check.patch.txt text/plain 2567 mjs SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDI4OTc5 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMDctMTIt MjUgIE1hY2llaiBTdGFjaG93aWFrICA8bWpzQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIC0gUmVtb3ZlIHVubmVjZXNz YXJ5IHJlZHVuZGFudCBjaGVjayBmcm9tIHByb3BlcnR5IHNldHRpbmcKKyAgICAgICAgaHR0cDov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY2MDIKKyAgICAgICAgCisgICAgICAg IDEuMyUgc3BlZWR1cCBvbiBTdW5TcGlkZXIuCisKKyAgICAgICAgKiBranMvb2JqZWN0LmNwcDoK KyAgICAgICAgKEtKUzo6SlNPYmplY3Q6OnB1dCk6IERvbid0IGRvIGNhblB1dCBjaGVjayB3aGVu IG5vdCBuZWVkZWQ7IGxldAorICAgICAgICB0aGUgUHJvcGVydHlNYXAgaGFuZGxlIGl0LiAgICAg ICAgCisgICAgICAgIChLSlM6OkpTT2JqZWN0OjpjYW5QdXQpOiBEb24ndCBjaGVjayB0aGUgc3Rh dGljIHByb3BlcnR5CisgICAgICAgIHRhYmxlLiBsb29rdXBQdXQgZG9lcyB0aGF0IGFscmVhZHku CisKIDIwMDctMTItMjQgIEFscCBUb2tlciAgPGFscEBhdG9rZXIuY29tPgogCiAgICAgICAgIEZp eCBidWlsZHMgdGhhdCBkb24ndCB1c2UgQWxsSW5PbmVGaWxlLmNwcCBmb2xsb3dpbmcgYnJlYWth Z2UKSW5kZXg6IGtqcy9vYmplY3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGtqcy9vYmplY3QuY3BwCShy ZXZpc2lvbiAyODk3OSkKKysrIGtqcy9vYmplY3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMjYs MTAgKzIyNiw3IEBAIHZvaWQgSlNPYmplY3Q6OnB1dChFeGVjU3RhdGUqIGV4ZWMsIGNvbnMKICAg Ly8gcHV0VmFsdWUoKSBpcyB1c2VkIGZvciBKUyBhc3NpZ25lbW50cy4gSXQgcGFzc2VzIG5vIGF0 dHJpYnV0ZS4KICAgLy8gQXNzdW1lIHRoYXQgYSBDKysgaW1wbGVtZW50YXRpb24ga25vd3Mgd2hh dCBpdCBpcyBkb2luZwogICAvLyBhbmQgbGV0IGl0IG92ZXJyaWRlIHRoZSBjYW5QdXQoKSBjaGVj ay4KLSAgaWYgKChhdHRyID09IE5vbmUgfHwgYXR0ciA9PSBEb250RGVsZXRlKSAmJiAhY2FuUHV0 KGV4ZWMscHJvcGVydHlOYW1lKSkgewotICAgIHJldHVybjsKLSAgfQotCisgIGJvb2wgY2hlY2tS ZWFkT25seSA9ICEoYXR0ciAmIChSZWFkT25seSB8IERvbnRFbnVtIHwgSW50ZXJuYWwgfCBGdW5j dGlvbiB8IEdldHRlclNldHRlcikpOwogICAvLyBDaGVjayBpZiB0aGVyZSBhcmUgYW55IHNldHRl cnMgb3IgZ2V0dGVycyBpbiB0aGUgcHJvdG90eXBlIGNoYWluCiAgIEpTT2JqZWN0ICpvYmogPSB0 aGlzOwogICBib29sIGhhc0dldHRlcnNPclNldHRlcnMgPSBmYWxzZTsKQEAgLTI0Niw2ICsyNDMs MTAgQEAgdm9pZCBKU09iamVjdDo6cHV0KEV4ZWNTdGF0ZSogZXhlYywgY29ucwogICB9CiAgIAog ICBpZiAoaGFzR2V0dGVyc09yU2V0dGVycykgeworICAgIGlmIChjaGVja1JlYWRPbmx5ICYmICFj YW5QdXQoZXhlYyxwcm9wZXJ0eU5hbWUpKSB7CisgICAgICByZXR1cm47CisgICAgfQorCiAgICAg b2JqID0gdGhpczsKICAgICB3aGlsZSAodHJ1ZSkgewogICAgICAgdW5zaWduZWQgYXR0cmlidXRl czsKQEAgLTI3Nyw3ICsyNzgsNyBAQCB2b2lkIEpTT2JqZWN0OjpwdXQoRXhlY1N0YXRlKiBleGVj LCBjb25zCiAgICAgfQogICB9CiAgIAotICBfcHJvcC5wdXQocHJvcGVydHlOYW1lLHZhbHVlLGF0 dHIpOworICBfcHJvcC5wdXQocHJvcGVydHlOYW1lLCB2YWx1ZSwgYXR0ciwgY2hlY2tSZWFkT25s eSk7CiB9CiAKIHZvaWQgSlNPYmplY3Q6OnB1dChFeGVjU3RhdGUgKmV4ZWMsIHVuc2lnbmVkIHBy b3BlcnR5TmFtZSwKQEAgLTI5MywxMSArMjk0LDEzIEBAIGJvb2wgSlNPYmplY3Q6OmNhblB1dChF eGVjU3RhdGUgKiwgY29uc3QKICAgICAKICAgLy8gRG9uJ3QgbG9vayBpbiB0aGUgcHJvdG90eXBl IGhlcmUuIFdlIGNhbiBhbHdheXMgcHV0IGFuIG92ZXJyaWRlCiAgIC8vIGluIHRoZSBvYmplY3Qs IGV2ZW4gaWYgdGhlIHByb3RvdHlwZSBoYXMgYSBSZWFkT25seSBwcm9wZXJ0eS4KKyAgLy8gQWxz bywgdGhlcmUgaXMgbm8gbmVlZCB0byBjaGVjayB0aGUgc3RhdGljIHByb3BlcnR5IHRhYmxlLCBh cyB0aGlzCisgIC8vIHdvdWxkIGhhdmUgYmVlbiBkb25lIGJ5IHRoZSBzdWJjbGFzcyBhbHJlYWR5 LgogCi0gIGlmICghZ2V0UHJvcGVydHlBdHRyaWJ1dGVzKHByb3BlcnR5TmFtZSwgYXR0cmlidXRl cykpCisgIGlmICghX3Byb3AuZ2V0KHByb3BlcnR5TmFtZSwgYXR0cmlidXRlcykpCiAgICAgcmV0 dXJuIHRydWU7Ci0gIGVsc2UKLSAgICByZXR1cm4gIShhdHRyaWJ1dGVzICYgUmVhZE9ubHkpOwor CisgIHJldHVybiAhKGF0dHJpYnV0ZXMgJiBSZWFkT25seSk7CiB9CiAKIC8vIEVDTUEgOC42LjIu NAo=