165987 2016-12-16 20:17:19 -0800 warning: the compiler can assume that the address of ‘thisObject’ will always evaluate to ‘true’ [-Waddress] in WebCore::JSHTMLDocument::getOwnPropertySlot 2016-12-17 10:14:12 -0800 1 1 1 Unclassified WebKit WebCore JavaScript WebKit Nightly Build PC Linux RESOLVED FIXED P2 Trivial --- 1 mcatanzaro mcatanzaro darin mark.lam mcatanzaro oldest_to_newest 1260879 0 mcatanzaro 2016-12-16 20:17:19 -0800 Seems ASSERT_GC_OBJECT_LOOKS_VALID is causing a warning again (like in r194303). Ways to fix this: * Use ASSERT_THIS_GC_OBJECT_INHERITS instead of ASSERT_GC_OBJECT_INHERITS. The only difference is ASSERT_THIS_GC_OBJECT_INHERITS doesn't have the null check that triggers the warning, so the behavior is what we want, but it'd be evil because here we are checking |thisObject| which is a normal parameter, not |this|. * Add more macros that do the same thing, with different names. * Just pass the original pointer rather than taking the address of a reference. If this starts happening in more cases we should probably go with the second option, but the last option seems cleanest for now. [1244/4409] Building CXX object Source...bindings/js/JSHTMLDocumentCustom.cpp.o In file included from ../../Source/WTF/wtf/StdLibExtras.h:33:0, from ../../Source/WTF/wtf/FastMalloc.h:26, from ../../Source/WebCore/config.h:75, from ../../Source/WebCore/bindings/js/JSHTMLDocumentCustom.cpp:26: ../../Source/WebCore/bindings/js/JSHTMLDocumentCustom.cpp: In static member function ‘static bool WebCore::JSHTMLDocument::getOwnPropertySlot(JSC::JSObject*, JSC::ExecState*, JSC::PropertyName, JSC::PropertySlot&)’: ../../Source/WTF/wtf/Assertions.h:283:20: warning: the compiler can assume that the address of ‘thisObject’ will always evaluate to ‘true’ [-Waddress] if (!(assertion)) { \ ^ ../../Source/WTF/wtf/Assertions.h:437:35: note: in expansion of macro ‘ASSERT’ #define RELEASE_ASSERT(assertion) ASSERT(assertion) ^~~~~~ ../../Source/JavaScriptCore/heap/GCAssertions.h:34:5: note: in expansion of macro ‘RELEASE_ASSERT’ RELEASE_ASSERT(cell);\ ^~~~~~~~~~~~~~ ../../Source/JavaScriptCore/heap/GCAssertions.h:39:5: note: in expansion of macro ‘ASSERT_GC_OBJECT_LOOKS_VALID’ ASSERT_GC_OBJECT_LOOKS_VALID(object); \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../Source/WebCore/bindings/js/JSHTMLDocumentCustom.cpp:58:5: note: in expansion of macro ‘ASSERT_GC_OBJECT_INHERITS’ ASSERT_GC_OBJECT_INHERITS((&thisObject), info()); ^ ../../Source/WTF/wtf/Assertions.h:283:20: warning: the compiler can assume that the address of ‘thisObject’ will always evaluate to ‘true’ [-Waddress] if (!(assertion)) { \ ^ ../../Source/WTF/wtf/Assertions.h:437:35: note: in expansion of macro ‘ASSERT’ #define RELEASE_ASSERT(assertion) ASSERT(assertion) ^~~~~~ ../../Source/JavaScriptCore/heap/GCAssertions.h:34:5: note: in expansion of macro ‘RELEASE_ASSERT’ RELEASE_ASSERT(cell);\ ^~~~~~~~~~~~~~ ../../Source/JavaScriptCore/heap/GCAssertions.h:39:5: note: in expansion of macro ‘ASSERT_GC_OBJECT_LOOKS_VALID’ ASSERT_GC_OBJECT_LOOKS_VALID(object); \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../Source/WebCore/bindings/js/JSHTMLDocumentCustom.cpp:58:5: note: in expansion of macro ‘ASSERT_GC_OBJECT_INHERITS’ ASSERT_GC_OBJECT_INHERITS((&thisObject), info()); ^ 1260920 1 297404 mcatanzaro 2016-12-17 07:00:01 -0800 Created attachment 297404 Patch 1260930 2 297404 mark.lam 2016-12-17 08:45:53 -0800 Comment on attachment 297404 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297404&action=review r=me > Source/WebCore/ChangeLog:3 > + warning: the compiler can assume that the address of ‘thisObject’ will always evaluate to ‘true’ [-Waddress] in WebCore::JSHTMLDocument::getOwnPropertySlot please fix non-ascii chars. 1260940 3 mcatanzaro 2016-12-17 10:14:12 -0800 Committed r209965: <http://trac.webkit.org/changeset/209965> 297404 2016-12-17 07:00:01 -0800 2016-12-17 08:45:53 -0800 Patch bug-165987-20161217085905.patch text/plain 1912 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjA5OTU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWQwYWY4ZmU0ZWM1ODQy ZjMwODgxMjY2NGEwMDE0NjdiN2M0MzVmMC4uYjQ0NGIwNTFmNWUxNzE0ODZhMmE3Mzg3ZjE4NmE0 YTc5MDY3M2Y2ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE2LTEyLTE3ICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICB3YXJuaW5n OiB0aGUgY29tcGlsZXIgY2FuIGFzc3VtZSB0aGF0IHRoZSBhZGRyZXNzIG9mIOKAmHRoaXNPYmpl Y3TigJkgd2lsbCBhbHdheXMgZXZhbHVhdGUgdG8g4oCYdHJ1ZeKAmSBbLVdhZGRyZXNzXSBpbiBX ZWJDb3JlOjpKU0hUTUxEb2N1bWVudDo6Z2V0T3duUHJvcGVydHlTbG90CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjU5ODcKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXb3JrIGFyb3VuZCB0aGUgd2Fybmlu ZyBieSBwYXNzaW5nIHRoZSBKU09iamVjdCBwb2ludGVyIHRoaXMgZnVuY3Rpb24gcmVjZWl2ZXMg ZGlyZWN0bHkgdG8KKyAgICAgICAgQVNTRVJUX0dDX09CSkVDVF9JTkhFUklUUywgaW5zdGVhZCBv ZiBjYXN0aW5nIGl0IHRvIGEgcmVmZXJlbmNlIGFuZCB0aGVuIHRha2luZyB0aGUgYWRkcmVzcwor ICAgICAgICBvZiB0aGF0LCB0byBhdm9pZCB0aGUgLVdhZGRyZXNzIHdhcm5pbmcuCisKKyAgICAg ICAgKiBiaW5kaW5ncy9qcy9KU0hUTUxEb2N1bWVudEN1c3RvbS5jcHA6CisgICAgICAgIChXZWJD b3JlOjpKU0hUTUxEb2N1bWVudDo6Z2V0T3duUHJvcGVydHlTbG90KToKKwogMjAxNi0xMi0xNiAg WmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFBvc3NpYmxlIG51bGxw dHIgZGVyZWZlcmVuY2Ugd2hlbiBhcHBseWluZyBwYWdpbmF0aW9uIHRvIHZpZXdwb3J0CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0hUTUxEb2N1bWVudEN1c3RvbS5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0hUTUxEb2N1bWVudEN1c3RvbS5jcHAK aW5kZXggZTkxNmI5YzUxNWJiZjZjZGUxNTM1M2M1MWQ4NmI5OGY4OWI0MDQ1NC4uZjE3MDI4OWU4 ZWJkNjlkODk5ZDY4ZDQ5NGQzYjY5NmNjOTEzOTZhZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvanMvSlNIVE1MRG9jdW1lbnRDdXN0b20uY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL2pzL0pTSFRNTERvY3VtZW50Q3VzdG9tLmNwcApAQCAtNTUsNyArNTUsNyBA QCBKU1ZhbHVlIHRvSlMoRXhlY1N0YXRlKiBzdGF0ZSwgSlNET01HbG9iYWxPYmplY3QqIGdsb2Jh bE9iamVjdCwgSFRNTERvY3VtZW50JiBkbwogYm9vbCBKU0hUTUxEb2N1bWVudDo6Z2V0T3duUHJv cGVydHlTbG90KEpTT2JqZWN0KiBvYmplY3QsIEV4ZWNTdGF0ZSogc3RhdGUsIFByb3BlcnR5TmFt ZSBwcm9wZXJ0eU5hbWUsIFByb3BlcnR5U2xvdCYgc2xvdCkKIHsKICAgICBhdXRvJiB0aGlzT2Jq ZWN0ID0gKmpzQ2FzdDxKU0hUTUxEb2N1bWVudCo+KG9iamVjdCk7Ci0gICAgQVNTRVJUX0dDX09C SkVDVF9JTkhFUklUUygoJnRoaXNPYmplY3QpLCBpbmZvKCkpOworICAgIEFTU0VSVF9HQ19PQkpF Q1RfSU5IRVJJVFMob2JqZWN0LCBpbmZvKCkpOwogCiAgICAgaWYgKHByb3BlcnR5TmFtZSA9PSAi b3BlbiIpIHsKICAgICAgICAgaWYgKEJhc2U6OmdldE93blByb3BlcnR5U2xvdCgmdGhpc09iamVj dCwgc3RhdGUsIHByb3BlcnR5TmFtZSwgc2xvdCkpCg==