165985 2016-12-16 19:36:14 -0800 [CMake] TestWebKitAPIBase links to itself 2016-12-19 11:13:23 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro achristensen annulen bugs-noreply commit-queue lforschler mcatanzaro oldest_to_newest 1260864 0 mcatanzaro 2016-12-16 19:36:14 -0800 CMake Warning (dev) at Tools/TestWebKitAPI/CMakeLists.txt:199 (add_library): Policy CMP0038 is not set: Targets may not link directly to themselves. Run "cmake --help-policy CMP0038" for policy details. Use the cmake_policy command to set the policy and suppress this warning. Target "TestWebKitAPIBase" links to itself. This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) at Tools/TestWebKitAPI/CMakeLists.txt:199 (add_library): Policy CMP0038 is not set: Targets may not link directly to themselves. Run "cmake --help-policy CMP0038" for policy details. Use the cmake_policy command to set the policy and suppress this warning. Target "TestWebKitAPIBase" links to itself. This warning is for project developers. Use -Wno-dev to suppress it. 1260918 1 mcatanzaro 2016-12-17 06:53:01 -0800 I think I hate linkers. This fixes the warnings and it links, but there's got to be a be a better way. I ran into linker errors when I tried anything else, though. In particular, it won't link if I remove TestWebKitAPIBase from test_webkit2_api_LIBRARIES and specify it manually in target_link_libraries for the tests. 1260919 2 297403 mcatanzaro 2016-12-17 06:54:23 -0800 Created attachment 297403 Patch 1260951 3 annulen 2016-12-17 11:16:34 -0800 LGTM I don't think linker can take any blame here, it might be cmake but most probably our project structure 1261162 4 297403 commit-queue 2016-12-19 11:13:19 -0800 Comment on attachment 297403 Patch Clearing flags on attachment: 297403 Committed r209991: <http://trac.webkit.org/changeset/209991> 1261163 5 commit-queue 2016-12-19 11:13:23 -0800 All reviewed patches have been landed. Closing bug. 297403 2016-12-17 06:54:23 -0800 2016-12-19 11:13:19 -0800 Patch bug-165985-20161217085327.patch text/plain 1387 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjA5OTU2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTBhMzRhZWUyNjJhZmRjZjIzOWU3YjAyZWIyNjY5ZTAz YmZiZTg0Yy4uYTZkYjg4YzE5MWFhNGEzMzU1OTE5MjBhOTBkZDA0YjRiN2VkMTMyYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE2LTEyLTE3ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNv bT4KKworICAgICAgICBbQ01ha2VdIFRlc3RXZWJLaXRBUElCYXNlIGxpbmtzIHRvIGl0c2VsZgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY1OTg1CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IENNYWtl IHdhcm5pbmcgYWJvdXQgYSB0YXJnZXQgbGlua2luZyB0byBpdHNlbGYsIHdoaWNoIG1ha2VzIG5v IHNlbnNlLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9DTWFrZUxpc3RzLnR4dDoKKwogMjAx Ni0xMi0xNiAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAg ICBWaXN1YWwgdmlld3BvcnRzOiBjYXJldHMgYW5kIHNlbGVjdGlvbiBVSSBhcmUgaW5jb3JyZWN0 bHkgcG9zaXRpb25lZCB3aGVuIGVkaXRpbmcgZml4ZWQgZWxlbWVudHMKZGlmZiAtLWdpdCBhL1Rv b2xzL1Rlc3RXZWJLaXRBUEkvQ01ha2VMaXN0cy50eHQgYi9Ub29scy9UZXN0V2ViS2l0QVBJL0NN YWtlTGlzdHMudHh0CmluZGV4IGVhN2EyMWVlMmE4N2Q5MDZmYjUxM2U4MGI1YmQxMjAwNTQwMjky OTcuLmRlMjY5OWUzNzZlZjM3NTgwYmEwMDRmYTFhY2MzZTI0Mjc4MGI2NDEgMTAwNjQ0Ci0tLSBh L1Rvb2xzL1Rlc3RXZWJLaXRBUEkvQ01ha2VMaXN0cy50eHQKKysrIGIvVG9vbHMvVGVzdFdlYktp dEFQSS9DTWFrZUxpc3RzLnR4dApAQCAtMjA0LDcgKzIwNCw3IEBAIGlmIChFTkFCTEVfV0VCS0lU MikKICAgICAgICAgJHtURVNUV0VCS0lUQVBJX0RJUn0vVGVzdHNDb250cm9sbGVyLmNwcAogICAg ICkKIAotICAgIHRhcmdldF9saW5rX2xpYnJhcmllcyhUZXN0V2ViS2l0QVBJQmFzZSAke3Rlc3Rf d2Via2l0Ml9hcGlfTElCUkFSSUVTfSkKKyAgICB0YXJnZXRfbGlua19saWJyYXJpZXMoVGVzdFdl YktpdEFQSUJhc2UgSmF2YVNjcmlwdENvcmUgV1RGIFdlYktpdDIgZ3Rlc3QpCiAKICAgICBhZGRf ZGVwZW5kZW5jaWVzKFRlc3RXZWJLaXRBUElCYXNlIFdlYktpdDIgJHtGb3J3YXJkaW5nSGVhZGVy c0ZvclRlc3RXZWJLaXRBUElfTkFNRX0gJHtGb3J3YXJkaW5nTmV0d29ya0hlYWRlcnNGb3JUZXN0 V2ViS2l0QVBJX05BTUV9KQogCg==