165981 2016-12-16 17:14:52 -0800 WebAssembly: We still have some incorrect parsing productions inside unreachable code 2016-12-16 19:20:32 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov jfbastien keith_miller mark.lam msaboff oliver ticaiolima ysuzuki oldest_to_newest 1260838 0 saam 2016-12-16 17:14:52 -0800 ... 1260841 1 297378 saam 2016-12-16 17:25:59 -0800 Created attachment 297378 patch 1260842 2 297379 saam 2016-12-16 17:27:33 -0800 Created attachment 297379 patch Hopefully this one builds. 1260849 3 297379 keith_miller 2016-12-16 18:53:18 -0800 Comment on attachment 297379 patch r=me. 1260858 4 297379 commit-queue 2016-12-16 19:20:25 -0800 Comment on attachment 297379 patch Clearing flags on attachment: 297379 Committed r209955: <http://trac.webkit.org/changeset/209955> 1260859 5 commit-queue 2016-12-16 19:20:32 -0800 All reviewed patches have been landed. Closing bug. 297378 2016-12-16 17:25:59 -0800 2016-12-16 17:27:33 -0800 patch b-backup.diff text/plain 2910 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjA5OTUzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDE2LTEyLTE2ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IFdlYkFzc2VtYmx5OiBXZSBzdGlsbCBoYXZlIHNvbWUgaW5jb3JyZWN0IHBhcnNpbmcgcHJvZHVj dGlvbnMgaW5zaWRlIHVucmVhY2hhYmxlIGNvZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NTk4MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaGFyZGVucyBvdXIgcGFyc2luZyBmb3IgQ2FsbElu ZGlyZWN0IGFuZCBMb29wL0Jsb2NrL0lmIHRvIGJlIGV4YWN0bHkgbGlrZSB0aGVpciByZWFjaGFi bGUgdmFyaWFudC4KKyAgICAgICAgCisgICAgICAgIEl0IGFsc28gZml4ZXMgYSBtb3JlIG5lZmFy aW91cyBidWcgaW4gd2hpY2ggd2Ugd2VyZSBkZWNvZGluZyBhbiBleHRyYSB2YXJ1aW50MzIKKyAg ICAgICAgZm9yIEJyL0JySWYgaW5zaWRlIHVucmVhY2hhYmxlIGNvZGUuCisKKyAgICAgICAgKiB3 YXNtL1dhc21GdW5jdGlvblBhcnNlci5oOgorCiAyMDE2LTEyLTE2ICBTYWFtIEJhcmF0aSAgPHNi YXJhdGlAYXBwbGUuY29tPgogCiAgICAgICAgIEIzOjpEb3VibGVUb0Zsb2F0UmVkdWN0aW9uIHdp bGwgYWNjaWRlbnRhbGx5IGNvbnZpbmNlIGl0c2VsZiBpdCBjb252ZXJ0ZWQgYSBQaGkgZnJvbSBE b3VibGUgdG8gRmxvYXQgYW5kIHRoZW4gY29udmVydCB1c2VzIG9mIHRoYXQgUGhpIGludG8gYSB1 c2Ugb2YgRmxvYXRUb0RvdWJsZShAUGhpKQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3dh c20vV2FzbUZ1bmN0aW9uUGFyc2VyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL3dhc20vV2FzbUZ1bmN0aW9uUGFyc2VyLmgJKHJldmlzaW9uIDIwOTk1MykKKysrIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dhc21GdW5jdGlvblBhcnNlci5oCSh3b3JraW5nIGNvcHkp CkBAIC01MjcsOCArNTI3LDggQEAgYXV0byBGdW5jdGlvblBhcnNlcjxDb250ZXh0Pjo6cGFyc2VV bnJlYQogICAgIGNhc2UgSWY6CiAgICAgY2FzZSBCbG9jazogewogICAgICAgICBtX3VucmVhY2hh YmxlQmxvY2tzKys7Ci0gICAgICAgIGludDhfdCB1bnVzZWQ7Ci0gICAgICAgIFdBU01fUEFSU0VS X0ZBSUxfSUYoIXBhcnNlSW50Nyh1bnVzZWQpLCAiY2FuJ3QgZ2V0IGlubGluZSB0eXBlIGZvciAi LCBvcCwgIiBpbiB1bnJlYWNoYWJsZSBjb250ZXh0Iik7CisgICAgICAgIFR5cGUgdW51c2VkOwor ICAgICAgICBXQVNNX1BBUlNFUl9GQUlMX0lGKCFwYXJzZVJlc3VsdFR5cGUodW51c2VkKSwgImNh bid0IGdldCBpbmxpbmUgdHlwZSBmb3IgIiwgb3AsICIgaW4gdW5yZWFjaGFibGUgY29udGV4dCIp OwogICAgICAgICByZXR1cm4geyB9OwogICAgIH0KIApAQCAtNTQ1LDEzICs1NDUsMTYgQEAgYXV0 byBGdW5jdGlvblBhcnNlcjxDb250ZXh0Pjo6cGFyc2VVbnJlYQogICAgICAgICByZXR1cm4geyB9 OwogICAgIH0KIAorICAgIGNhc2UgQ2FsbEluZGlyZWN0OiB7CisgICAgICAgIHVpbnQzMl90IHVu dXNlZDsKKyAgICAgICAgV0FTTV9QQVJTRVJfRkFJTF9JRighcGFyc2VWYXJVSW50MzIodW51c2Vk KSwgImNhbid0IGdldCBjYWxsX2luZGlyZWN0J3Mgc2lnbmF0dXJlIGluZGV4IGluIHVucmVhY2hh YmxlIGNvbnRleHQiKTsKKyAgICAgICAgV0FTTV9QQVJTRVJfRkFJTF9JRighcGFyc2VWYXJVSW50 MSh1bnVzZWQpLCAiY2FuJ3QgZ2V0IGNhbGxfaW5kaXJlY3QncyByZXNlcnZlZCBieXRlIGluIHVu cmVhY2hhYmxlIGNvbnRleHQiKTsKKyAgICAgICAgcmV0dXJuIHsgfTsKKyAgICB9CiAKICAgICAv LyB0d28gaW1tZWRpYXRlIGNhc2VzCiAgICAgRk9SX0VBQ0hfV0FTTV9NRU1PUllfTE9BRF9PUChD UkVBVEVfQ0FTRSkKLSAgICBGT1JfRUFDSF9XQVNNX01FTU9SWV9TVE9SRV9PUChDUkVBVEVfQ0FT RSkKLSAgICBjYXNlIEJyOgotICAgIGNhc2UgQnJJZjoKLSAgICBjYXNlIENhbGxJbmRpcmVjdDog eworICAgIEZPUl9FQUNIX1dBU01fTUVNT1JZX1NUT1JFX09QKENSRUFURV9DQVNFKSB7CiAgICAg ICAgIHVpbnQzMl90IHVudXNlZDsKICAgICAgICAgV0FTTV9QQVJTRVJfRkFJTF9JRighcGFyc2VW YXJVSW50MzIodW51c2VkKSwgImNhbid0IGdldCBmaXJzdCBpbW1lZGlhdGUgZm9yICIsIG9wLCAi IGluIHVucmVhY2hhYmxlIGNvbnRleHQiKTsKICAgICAgICAgV0FTTV9QQVJTRVJfRkFJTF9JRigh cGFyc2VWYXJVSW50MzIodW51c2VkKSwgImNhbid0IGdldCBzZWNvbmQgaW1tZWRpYXRlIGZvciAi LCBvcCwgIiBpbiB1bnJlYWNoYWJsZSBjb250ZXh0Iik7CkBAIC01NjgsNiArNTcxLDggQEAgYXV0 byBGdW5jdGlvblBhcnNlcjxDb250ZXh0Pjo6cGFyc2VVbnJlYQogICAgIGNhc2UgVGVlTG9jYWw6 CiAgICAgY2FzZSBHZXRHbG9iYWw6CiAgICAgY2FzZSBTZXRHbG9iYWw6CisgICAgY2FzZSBCcjoK KyAgICBjYXNlIEJySWY6CiAgICAgY2FzZSBDYWxsOiB7CiAgICAgICAgIHVpbnQzMl90IHVudXNl ZDsKICAgICAgICAgV0FTTV9QQVJTRVJfRkFJTF9JRighcGFyc2VWYXJVSW50MzIodW51c2VkKSwg ImNhbid0IGdldCBpbW1lZGlhdGUgZm9yICIsIG9wLCAiIGluIHVucmVhY2hhYmxlIGNvbnRleHQi KTsK 297379 2016-12-16 17:27:33 -0800 2016-12-16 19:20:25 -0800 patch b-backup.diff text/plain 2937 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjA5OTUzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDE2LTEyLTE2ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IFdlYkFzc2VtYmx5OiBXZSBzdGlsbCBoYXZlIHNvbWUgaW5jb3JyZWN0IHBhcnNpbmcgcHJvZHVj dGlvbnMgaW5zaWRlIHVucmVhY2hhYmxlIGNvZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NTk4MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaGFyZGVucyBvdXIgcGFyc2luZyBmb3IgQ2FsbElu ZGlyZWN0IGFuZCBMb29wL0Jsb2NrL0lmIHRvIGJlIGV4YWN0bHkgbGlrZSB0aGVpciByZWFjaGFi bGUgdmFyaWFudC4KKyAgICAgICAgCisgICAgICAgIEl0IGFsc28gZml4ZXMgYSBtb3JlIG5lZmFy aW91cyBidWcgaW4gd2hpY2ggd2Ugd2VyZSBkZWNvZGluZyBhbiBleHRyYSB2YXJ1aW50MzIKKyAg ICAgICAgZm9yIEJyL0JySWYgaW5zaWRlIHVucmVhY2hhYmxlIGNvZGUuCisKKyAgICAgICAgKiB3 YXNtL1dhc21GdW5jdGlvblBhcnNlci5oOgorCiAyMDE2LTEyLTE2ICBTYWFtIEJhcmF0aSAgPHNi YXJhdGlAYXBwbGUuY29tPgogCiAgICAgICAgIEIzOjpEb3VibGVUb0Zsb2F0UmVkdWN0aW9uIHdp bGwgYWNjaWRlbnRhbGx5IGNvbnZpbmNlIGl0c2VsZiBpdCBjb252ZXJ0ZWQgYSBQaGkgZnJvbSBE b3VibGUgdG8gRmxvYXQgYW5kIHRoZW4gY29udmVydCB1c2VzIG9mIHRoYXQgUGhpIGludG8gYSB1 c2Ugb2YgRmxvYXRUb0RvdWJsZShAUGhpKQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3dh c20vV2FzbUZ1bmN0aW9uUGFyc2VyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL3dhc20vV2FzbUZ1bmN0aW9uUGFyc2VyLmgJKHJldmlzaW9uIDIwOTk1MykKKysrIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dhc21GdW5jdGlvblBhcnNlci5oCSh3b3JraW5nIGNvcHkp CkBAIC01MjcsOCArNTI3LDggQEAgYXV0byBGdW5jdGlvblBhcnNlcjxDb250ZXh0Pjo6cGFyc2VV bnJlYQogICAgIGNhc2UgSWY6CiAgICAgY2FzZSBCbG9jazogewogICAgICAgICBtX3VucmVhY2hh YmxlQmxvY2tzKys7Ci0gICAgICAgIGludDhfdCB1bnVzZWQ7Ci0gICAgICAgIFdBU01fUEFSU0VS X0ZBSUxfSUYoIXBhcnNlSW50Nyh1bnVzZWQpLCAiY2FuJ3QgZ2V0IGlubGluZSB0eXBlIGZvciAi LCBvcCwgIiBpbiB1bnJlYWNoYWJsZSBjb250ZXh0Iik7CisgICAgICAgIFR5cGUgdW51c2VkOwor ICAgICAgICBXQVNNX1BBUlNFUl9GQUlMX0lGKCFwYXJzZVJlc3VsdFR5cGUodW51c2VkKSwgImNh bid0IGdldCBpbmxpbmUgdHlwZSBmb3IgIiwgb3AsICIgaW4gdW5yZWFjaGFibGUgY29udGV4dCIp OwogICAgICAgICByZXR1cm4geyB9OwogICAgIH0KIApAQCAtNTQ1LDEzICs1NDUsMTcgQEAgYXV0 byBGdW5jdGlvblBhcnNlcjxDb250ZXh0Pjo6cGFyc2VVbnJlYQogICAgICAgICByZXR1cm4geyB9 OwogICAgIH0KIAorICAgIGNhc2UgQ2FsbEluZGlyZWN0OiB7CisgICAgICAgIHVpbnQzMl90IHVu dXNlZDsKKyAgICAgICAgdWludDhfdCB1bnVzZWQyOworICAgICAgICBXQVNNX1BBUlNFUl9GQUlM X0lGKCFwYXJzZVZhclVJbnQzMih1bnVzZWQpLCAiY2FuJ3QgZ2V0IGNhbGxfaW5kaXJlY3QncyBz aWduYXR1cmUgaW5kZXggaW4gdW5yZWFjaGFibGUgY29udGV4dCIpOworICAgICAgICBXQVNNX1BB UlNFUl9GQUlMX0lGKCFwYXJzZVZhclVJbnQxKHVudXNlZDIpLCAiY2FuJ3QgZ2V0IGNhbGxfaW5k aXJlY3QncyByZXNlcnZlZCBieXRlIGluIHVucmVhY2hhYmxlIGNvbnRleHQiKTsKKyAgICAgICAg cmV0dXJuIHsgfTsKKyAgICB9CiAKICAgICAvLyB0d28gaW1tZWRpYXRlIGNhc2VzCiAgICAgRk9S X0VBQ0hfV0FTTV9NRU1PUllfTE9BRF9PUChDUkVBVEVfQ0FTRSkKLSAgICBGT1JfRUFDSF9XQVNN X01FTU9SWV9TVE9SRV9PUChDUkVBVEVfQ0FTRSkKLSAgICBjYXNlIEJyOgotICAgIGNhc2UgQnJJ ZjoKLSAgICBjYXNlIENhbGxJbmRpcmVjdDogeworICAgIEZPUl9FQUNIX1dBU01fTUVNT1JZX1NU T1JFX09QKENSRUFURV9DQVNFKSB7CiAgICAgICAgIHVpbnQzMl90IHVudXNlZDsKICAgICAgICAg V0FTTV9QQVJTRVJfRkFJTF9JRighcGFyc2VWYXJVSW50MzIodW51c2VkKSwgImNhbid0IGdldCBm aXJzdCBpbW1lZGlhdGUgZm9yICIsIG9wLCAiIGluIHVucmVhY2hhYmxlIGNvbnRleHQiKTsKICAg ICAgICAgV0FTTV9QQVJTRVJfRkFJTF9JRighcGFyc2VWYXJVSW50MzIodW51c2VkKSwgImNhbid0 IGdldCBzZWNvbmQgaW1tZWRpYXRlIGZvciAiLCBvcCwgIiBpbiB1bnJlYWNoYWJsZSBjb250ZXh0 Iik7CkBAIC01NjgsNiArNTcyLDggQEAgYXV0byBGdW5jdGlvblBhcnNlcjxDb250ZXh0Pjo6cGFy c2VVbnJlYQogICAgIGNhc2UgVGVlTG9jYWw6CiAgICAgY2FzZSBHZXRHbG9iYWw6CiAgICAgY2Fz ZSBTZXRHbG9iYWw6CisgICAgY2FzZSBCcjoKKyAgICBjYXNlIEJySWY6CiAgICAgY2FzZSBDYWxs OiB7CiAgICAgICAgIHVpbnQzMl90IHVudXNlZDsKICAgICAgICAgV0FTTV9QQVJTRVJfRkFJTF9J RighcGFyc2VWYXJVSW50MzIodW51c2VkKSwgImNhbid0IGdldCBpbW1lZGlhdGUgZm9yICIsIG9w LCAiIGluIHVucmVhY2hhYmxlIGNvbnRleHQiKTsK