165958 2016-12-16 10:23:31 -0800 Add predecessor info to dumps from JSC_dumpBytecodeLivenessResults=true. 2016-12-16 11:29:39 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam commit-queue keith_miller msaboff saam oldest_to_newest 1260618 0 mark.lam 2016-12-16 10:23:31 -0800 Also refactored the code to use a common lambda function to dump FastBitVectors. 1260620 1 297322 mark.lam 2016-12-16 10:28:48 -0800 Created attachment 297322 proposed patch. 1260648 2 297322 mark.lam 2016-12-16 11:05:12 -0800 Comment on attachment 297322 proposed patch. Thanks for the review. 1260673 3 297322 commit-queue 2016-12-16 11:29:35 -0800 Comment on attachment 297322 proposed patch. Clearing flags on attachment: 297322 Committed r209929: <http://trac.webkit.org/changeset/209929> 1260674 4 commit-queue 2016-12-16 11:29:39 -0800 All reviewed patches have been landed. Closing bug. 297322 2016-12-16 10:28:48 -0800 2016-12-16 11:29:35 -0800 proposed patch. bug-165958.patch text/plain 4250 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjA5OTIzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDE2LTEyLTE2ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBB ZGQgcHJlZGVjZXNzb3IgaW5mbyB0byBkdW1wcyBmcm9tIEpTQ19kdW1wQnl0ZWNvZGVMaXZlbmVz c1Jlc3VsdHM9dHJ1ZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE2NTk1OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEFsc286CisgICAgICAgIDEuIHJlZmFjdG9yZWQgdGhlIGNvZGUgdG8gdXNlIGEgY29t bW9uIGxhbWJkYSBmdW5jdGlvbiB0byBkdW1wIEZhc3RCaXRWZWN0b3JzLgorICAgICAgICAyLiBs aXN0IHN1Y2Nlc3NvcnMgYnkgdGhlaXIgYmxvY2sgaW5kZXggaW5zdGVhZCBvZiBwb2ludGVycy4K KworICAgICAgICAqIGJ5dGVjb2RlL0J5dGVjb2RlTGl2ZW5lc3NBbmFseXNpcy5jcHA6CisgICAg ICAgIChKU0M6OkJ5dGVjb2RlTGl2ZW5lc3NBbmFseXNpczo6ZHVtcFJlc3VsdHMpOgorCiAyMDE2 LTEyLTE2ICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgogCiAgICAgICAg IGk2NC5lcXogc2hvdWxkIHVzZSBhbiBJbnQ2NCB6ZXJvCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlw dENvcmUvYnl0ZWNvZGUvQnl0ZWNvZGVMaXZlbmVzc0FuYWx5c2lzLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQnl0ZWNvZGVMaXZlbmVzc0FuYWx5c2lz LmNwcAkocmV2aXNpb24gMjA5OTE4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2Rl L0J5dGVjb2RlTGl2ZW5lc3NBbmFseXNpcy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE0MiwxNCAr MTQyLDQzIEBAIHZvaWQgQnl0ZWNvZGVMaXZlbmVzc0FuYWx5c2lzOjpkdW1wUmVzdWwKICAgICBJ bnRlcnByZXRlciogaW50ZXJwcmV0ZXIgPSBjb2RlQmxvY2stPnZtKCktPmludGVycHJldGVyOwog ICAgIEluc3RydWN0aW9uKiBpbnN0cnVjdGlvbnNCZWdpbiA9IGNvZGVCbG9jay0+aW5zdHJ1Y3Rp b25zKCkuYmVnaW4oKTsKICAgICB1bnNpZ25lZCBpID0gMDsKKworICAgIHVuc2lnbmVkIG51bWJl ck9mQmxvY2tzID0gbV9ncmFwaC5zaXplKCk7CisgICAgVmVjdG9yPEZhc3RCaXRWZWN0b3I+IHBy ZWRlY2Vzc29ycyhudW1iZXJPZkJsb2Nrcyk7CisgICAgZm9yIChCeXRlY29kZUJhc2ljQmxvY2sq IGJsb2NrIDogbV9ncmFwaCkKKyAgICAgICAgcHJlZGVjZXNzb3JzW2Jsb2NrLT5pbmRleCgpXS5y ZXNpemUobnVtYmVyT2ZCbG9ja3MpOworICAgIGZvciAoQnl0ZWNvZGVCYXNpY0Jsb2NrKiBibG9j ayA6IG1fZ3JhcGgpIHsKKyAgICAgICAgZm9yICh1bnNpZ25lZCBqID0gMDsgaiA8IGJsb2NrLT5z dWNjZXNzb3JzKCkuc2l6ZSgpOyBqKyspIHsKKyAgICAgICAgICAgIHVuc2lnbmVkIGJsb2NrSW5k ZXggPSBibG9jay0+aW5kZXgoKTsKKyAgICAgICAgICAgIHVuc2lnbmVkIHN1Y2Nlc3NvckluZGV4 ID0gYmxvY2stPnN1Y2Nlc3NvcnMoKVtqXS0+aW5kZXgoKTsKKyAgICAgICAgICAgIHByZWRlY2Vz c29yc1tzdWNjZXNzb3JJbmRleF1bYmxvY2tJbmRleF0gPSB0cnVlOworICAgICAgICB9CisgICAg fQorCisgICAgYXV0byBkdW1wQml0VmVjdG9yID0gW10gKEZhc3RCaXRWZWN0b3ImIGJpdHMpIHsK KyAgICAgICAgZm9yICh1bnNpZ25lZCBqID0gMDsgaiA8IGJpdHMubnVtQml0cygpOyBqKyspIHsK KyAgICAgICAgICAgIGlmIChiaXRzW2pdKQorICAgICAgICAgICAgICAgIGRhdGFMb2dGKCIgJXUi LCBqKTsKKyAgICAgICAgfQorICAgIH07CisKICAgICBmb3IgKEJ5dGVjb2RlQmFzaWNCbG9jayog YmxvY2sgOiBtX2dyYXBoKSB7CiAgICAgICAgIGRhdGFMb2dGKCJcbkJ5dGVjb2RlIGJhc2ljIGJs b2NrICV1OiAlcCAob2Zmc2V0OiAldSwgbGVuZ3RoOiAldSlcbiIsIGkrKywgYmxvY2ssIGJsb2Nr LT5sZWFkZXJPZmZzZXQoKSwgYmxvY2stPnRvdGFsTGVuZ3RoKCkpOwotICAgICAgICBkYXRhTG9n RigiU3VjY2Vzc29yczogIik7CisKKyAgICAgICAgZGF0YUxvZ0YoIlByZWRlY2Vzc29yczoiKTsK KyAgICAgICAgZHVtcEJpdFZlY3RvcihwcmVkZWNlc3NvcnNbYmxvY2stPmluZGV4KCldKTsKKyAg ICAgICAgZGF0YUxvZ0YoIlxuIik7CisKKyAgICAgICAgZGF0YUxvZ0YoIlN1Y2Nlc3NvcnM6Iik7 CisgICAgICAgIEZhc3RCaXRWZWN0b3Igc3VjY2Vzc29yczsKKyAgICAgICAgc3VjY2Vzc29ycy5y ZXNpemUobnVtYmVyT2ZCbG9ja3MpOwogICAgICAgICBmb3IgKHVuc2lnbmVkIGogPSAwOyBqIDwg YmxvY2stPnN1Y2Nlc3NvcnMoKS5zaXplKCk7IGorKykgewogICAgICAgICAgICAgQnl0ZWNvZGVC YXNpY0Jsb2NrKiBzdWNjZXNzb3IgPSBibG9jay0+c3VjY2Vzc29ycygpW2pdOwotICAgICAgICAg ICAgZGF0YUxvZ0YoIiVwICIsIHN1Y2Nlc3Nvcik7CisgICAgICAgICAgICBzdWNjZXNzb3JzW3N1 Y2Nlc3Nvci0+aW5kZXgoKV0gPSB0cnVlOwogICAgICAgICB9CisgICAgICAgIGR1bXBCaXRWZWN0 b3Ioc3VjY2Vzc29ycyk7IC8vIER1bXAgaW4gc29ydGVkIG9yZGVyLgogICAgICAgICBkYXRhTG9n RigiXG4iKTsKKwogICAgICAgICBpZiAoYmxvY2stPmlzRW50cnlCbG9jaygpKSB7CiAgICAgICAg ICAgICBkYXRhTG9nRigiRW50cnkgYmxvY2sgJXBcbiIsIGJsb2NrKTsKICAgICAgICAgICAgIGNv bnRpbnVlOwpAQCAtMTYxLDEyICsxOTAsOSBAQCB2b2lkIEJ5dGVjb2RlTGl2ZW5lc3NBbmFseXNp czo6ZHVtcFJlc3VsCiAgICAgICAgIGZvciAodW5zaWduZWQgYnl0ZWNvZGVPZmZzZXQgPSBibG9j ay0+bGVhZGVyT2Zmc2V0KCk7IGJ5dGVjb2RlT2Zmc2V0IDwgYmxvY2stPmxlYWRlck9mZnNldCgp ICsgYmxvY2stPnRvdGFsTGVuZ3RoKCk7KSB7CiAgICAgICAgICAgICBjb25zdCBJbnN0cnVjdGlv biogY3VycmVudEluc3RydWN0aW9uID0gJmluc3RydWN0aW9uc0JlZ2luW2J5dGVjb2RlT2Zmc2V0 XTsKIAotICAgICAgICAgICAgZGF0YUxvZ0YoIkxpdmUgdmFyaWFibGVzOiAiKTsKKyAgICAgICAg ICAgIGRhdGFMb2dGKCJMaXZlIHZhcmlhYmxlczoiKTsKICAgICAgICAgICAgIEZhc3RCaXRWZWN0 b3IgbGl2ZUJlZm9yZSA9IGdldExpdmVuZXNzSW5mb0F0Qnl0ZWNvZGVPZmZzZXQoYnl0ZWNvZGVP ZmZzZXQpOwotICAgICAgICAgICAgZm9yICh1bnNpZ25lZCBqID0gMDsgaiA8IGxpdmVCZWZvcmUu bnVtQml0cygpOyBqKyspIHsKLSAgICAgICAgICAgICAgICBpZiAobGl2ZUJlZm9yZVtqXSkKLSAg ICAgICAgICAgICAgICAgICAgZGF0YUxvZ0YoIiV1ICIsIGopOwotICAgICAgICAgICAgfQorICAg ICAgICAgICAgZHVtcEJpdFZlY3RvcihsaXZlQmVmb3JlKTsKICAgICAgICAgICAgIGRhdGFMb2dG KCJcbiIpOwogICAgICAgICAgICAgY29kZUJsb2NrLT5kdW1wQnl0ZWNvZGUoV1RGOjpkYXRhRmls ZSgpLCBjb2RlQmxvY2stPmdsb2JhbE9iamVjdCgpLT5nbG9iYWxFeGVjKCksIGluc3RydWN0aW9u c0JlZ2luLCBjdXJyZW50SW5zdHJ1Y3Rpb24pOwogCkBAIC0xNzUsMTIgKzIwMSw5IEBAIHZvaWQg Qnl0ZWNvZGVMaXZlbmVzc0FuYWx5c2lzOjpkdW1wUmVzdWwKICAgICAgICAgICAgIGJ5dGVjb2Rl T2Zmc2V0ICs9IG9wY29kZUxlbmd0aDsKICAgICAgICAgfQogCi0gICAgICAgIGRhdGFMb2dGKCJM aXZlIHZhcmlhYmxlczogIik7CisgICAgICAgIGRhdGFMb2dGKCJMaXZlIHZhcmlhYmxlczoiKTsK ICAgICAgICAgRmFzdEJpdFZlY3RvciBsaXZlQWZ0ZXIgPSBibG9jay0+b3V0KCk7Ci0gICAgICAg IGZvciAodW5zaWduZWQgaiA9IDA7IGogPCBsaXZlQWZ0ZXIubnVtQml0cygpOyBqKyspIHsKLSAg ICAgICAgICAgIGlmIChsaXZlQWZ0ZXJbal0pCi0gICAgICAgICAgICAgICAgZGF0YUxvZ0YoIiV1 ICIsIGopOwotICAgICAgICB9CisgICAgICAgIGR1bXBCaXRWZWN0b3IobGl2ZUFmdGVyKTsKICAg ICAgICAgZGF0YUxvZ0YoIlxuIik7CiAgICAgfQogfQo=