165942 2016-12-15 19:32:21 -0800 i64.eqz should use an Int64 zero 2016-12-16 09:54:07 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 keith_miller keith_miller commit-queue mark.lam msaboff saam oldest_to_newest 1260497 0 keith_miller 2016-12-15 19:32:21 -0800 i64.eqz should use an Int64 zero 1260510 1 297293 keith_miller 2016-12-15 20:10:55 -0800 Created attachment 297293 Patch 1260511 2 commit-queue 2016-12-15 20:12:44 -0800 This patch modifies one of the wasm.json files. Please ensure that any changes in one have been mirrored to the other. You can find the wasm.json files at "Source/JavaScriptCore/wasm/wasm.json" and "JSTests/wasm/wasm.json". 1260522 3 297293 mark.lam 2016-12-15 20:50:36 -0800 Comment on attachment 297293 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297293&action=review r=me with suggested change. > Source/JavaScriptCore/wasm/generateWasmOpsHeader.py:268 > +inline const char* makeString(OpType op) I think "opName" would be a better name than "makeString". 1260594 4 297293 keith_miller 2016-12-16 09:18:14 -0800 Comment on attachment 297293 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297293&action=review >> Source/JavaScriptCore/wasm/generateWasmOpsHeader.py:268 >> +inline const char* makeString(OpType op) > > I think "opName" would be a better name than "makeString". I chose makeString because it works with the new WasmParser.h failure template code. 1260607 5 297293 commit-queue 2016-12-16 09:54:03 -0800 Comment on attachment 297293 Patch Clearing flags on attachment: 297293 Committed r209923: <http://trac.webkit.org/changeset/209923> 1260608 6 commit-queue 2016-12-16 09:54:07 -0800 All reviewed patches have been landed. Closing bug. 297293 2016-12-15 20:10:55 -0800 2016-12-16 09:54:03 -0800 Patch bug-165942-20161215201001.patch text/plain 6670 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjA5ODkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj ZWEzNzM1YWNjNzI0NjdlMjFmODM3ZmQ5MTMxMjEzNmVmMGRhOTQ5Li45OWQ0ZjZjNzFkMzhjNmZl MDM0NjJkMDJlNzQ3OTM2NGJiMDA2YWQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyMCBAQAogMjAxNi0xMi0xNSAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KIAorICAgICAgICBpNjQuZXF6IHNob3VsZCB1c2UgYW4gSW50NjQgemVybworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY1OTQyCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBmaXhl cyBpNjQuZXF6LCB3aGljaCB3YXMgdXNpbmcgYW4gSW50MzIgemVybworICAgICAgICBmb3IgdGhl IGNvbXBhcmlzb24gcHJldmlvdXNseS4gVGhpcyBwYXRjaCBhbHNvLCBhZGRzCisgICAgICAgIHBy aW50aW5nIG9wY29kZXMgbmFtZXMgaW4gdmVyYm9zZSBtb2RlLgorCisgICAgICAgICogd2FzbS9X YXNtRnVuY3Rpb25QYXJzZXIuaDoKKyAgICAgICAgKiB3YXNtL2dlbmVyYXRlV2FzbU9wc0hlYWRl ci5weToKKyAgICAgICAgKiB3YXNtL3dhc20uanNvbjoKKworMjAxNi0xMi0xNSAgS2VpdGggTWls bGVyICA8a2VpdGhfbWlsbGVyQGFwcGxlLmNvbT4KKwogICAgICAgICBXYXNtIHNob3VsZCBub3Qg Y3JlYXRlIGVtcHR5IHVubGlua2VkIGNhbGxzaXRlcwogICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY1OTMzCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS93YXNtL1dhc21GdW5jdGlvblBhcnNlci5oIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL3dhc20vV2FzbUZ1bmN0aW9uUGFyc2VyLmgKaW5kZXggNzg0YThjNjQ1NWU3ZjhmYTg0ODU4 ZjEwOTZkMWQ4NzZjZjM2YmViZS4uNzMxZWE2YjliMmFhZGViNWNhNmI2ZmM0MjZlNTM1ZjIwYjNi OWI1MCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vV2FzbUZ1bmN0aW9u UGFyc2VyLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vV2FzbUZ1bmN0aW9uUGFy c2VyLmgKQEAgLTEzMiw3ICsxMzIsNyBAQCBhdXRvIEZ1bmN0aW9uUGFyc2VyPENvbnRleHQ+Ojpw YXJzZUJvZHkoKSAtPiBQYXJ0aWFsUmVzdWx0CiAgICAgICAgIFdBU01fUEFSU0VSX0ZBSUxfSUYo IWlzVmFsaWRPcFR5cGUob3ApLCAiaW52YWxpZCBvcGNvZGUgIiwgb3ApOwogCiAgICAgICAgIGlm ICh2ZXJib3NlKSB7Ci0gICAgICAgICAgICBkYXRhTG9nTG4oInByb2Nlc3Npbmcgb3AgKCIsIG1f dW5yZWFjaGFibGVCbG9ja3MsICIpOiAiLCAgUmF3UG9pbnRlcihyZWludGVycHJldF9jYXN0PHZv aWQqPihvcCkpLCAiIGF0IG9mZnNldDogIiwgUmF3UG9pbnRlcihyZWludGVycHJldF9jYXN0PHZv aWQqPihtX29mZnNldCkpKTsKKyAgICAgICAgICAgIGRhdGFMb2dMbigicHJvY2Vzc2luZyBvcCAo IiwgbV91bnJlYWNoYWJsZUJsb2NrcywgIik6ICIsICBSYXdQb2ludGVyKHJlaW50ZXJwcmV0X2Nh c3Q8dm9pZCo+KG9wKSksICIsICIsIG1ha2VTdHJpbmcoc3RhdGljX2Nhc3Q8T3BUeXBlPihvcCkp LCAiIGF0IG9mZnNldDogIiwgUmF3UG9pbnRlcihyZWludGVycHJldF9jYXN0PHZvaWQqPihtX29m ZnNldCkpKTsKICAgICAgICAgICAgIG1fY29udGV4dC5kdW1wKG1fY29udHJvbFN0YWNrLCBtX2V4 cHJlc3Npb25TdGFjayk7CiAgICAgICAgIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL3dhc20vZ2VuZXJhdGVXYXNtT3BzSGVhZGVyLnB5IGIvU291cmNlL0phdmFTY3JpcHRD b3JlL3dhc20vZ2VuZXJhdGVXYXNtT3BzSGVhZGVyLnB5CmluZGV4IDE1YzFmM2M5YmIxNDU0YTQz ODBlMzhhNjEzMWE0YWNkMjQ4OWM1MDYuLmRlOGFhMmM2OTNhZTI2OWZhMzk4MzdkMTU3YjBkNjA1 ZjA1ODgyYzggMTAwNzU1Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL2dlbmVyYXRl V2FzbU9wc0hlYWRlci5weQorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9nZW5lcmF0 ZVdhc21PcHNIZWFkZXIucHkKQEAgLTI2NCw2ICsyNjQsMTcgQEAgaW5saW5lIGJvb2wgaXNTaW1w bGUoQmluYXJ5T3BUeXBlIG9wKQogICAgIHJldHVybiBmYWxzZTsKIH0KIAorI2RlZmluZSBDUkVB VEVfQ0FTRShuYW1lLCBpZCwgYjN0eXBlLCBpbmMpIGNhc2UgbmFtZTogcmV0dXJuICNuYW1lOwor aW5saW5lIGNvbnN0IGNoYXIqIG1ha2VTdHJpbmcoT3BUeXBlIG9wKQoreworICAgIHN3aXRjaCAo b3ApIHsKKyAgICBGT1JfRUFDSF9XQVNNX09QKENSRUFURV9DQVNFKQorICAgIH0KKyAgICBSRUxF QVNFX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgIHJldHVybiBudWxscHRyOworfQorI3VuZGVm IENSRUFURV9DQVNFCisKIH0gfSAvLyBuYW1lc3BhY2UgSlNDOjpXYXNtCiAKICNlbmRpZiAvLyBF TkFCTEUoV0VCQVNTRU1CTFkpCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd2Fz bS93YXNtLmpzb24gYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS93YXNtLmpzb24KaW5kZXgg OGE1YmY4YjU1NmJkODFjMjRhZTNjYTEzMmUwYTY4N2FiYjZkMTZhMC4uYjE4YmVlNWI3NWE3NjM4 ZmYwM2E2MjMzYzY4MmQ0NjUxZDhjMGU2OSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRD b3JlL3dhc20vd2FzbS5qc29uCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL3dhc20u anNvbgpAQCAtMTQ3LDcgKzE0Nyw3IEBACiAgICAgICAgICJpNjQuY2x6IjogICAgICAgICAgICAg eyAiY2F0ZWdvcnkiOiAiYXJpdGhtZXRpYyIsICJ2YWx1ZSI6IDEyMSwgInJldHVybiI6IFsiaTY0 Il0sICAgICAgInBhcmFtZXRlciI6IFsiaTY0Il0sICAgICAgICAgICAgICAgICAgImltbWVkaWF0 ZSI6IFtdLCAiYjNvcCI6ICJDbHoiICAgICAgICAgIH0sCiAgICAgICAgICJpNjQuY3R6IjogICAg ICAgICAgICAgeyAiY2F0ZWdvcnkiOiAiYXJpdGhtZXRpYyIsICJ2YWx1ZSI6IDEyMiwgInJldHVy biI6IFsiaTY0Il0sICAgICAgInBhcmFtZXRlciI6IFsiaTY0Il0sICAgICAgICAgICAgICAgICAg ImltbWVkaWF0ZSI6IFtdICAgICAgICAgICAgICAgICAgICAgICAgIH0sCiAgICAgICAgICJpNjQu cG9wY250IjogICAgICAgICAgeyAiY2F0ZWdvcnkiOiAiYXJpdGhtZXRpYyIsICJ2YWx1ZSI6IDEy MywgInJldHVybiI6IFsiaTY0Il0sICAgICAgInBhcmFtZXRlciI6IFsiaTY0Il0sICAgICAgICAg ICAgICAgICAgImltbWVkaWF0ZSI6IFtdICAgICAgICAgICAgICAgICAgICAgICAgIH0sCi0gICAg ICAgICJpNjQuZXF6IjogICAgICAgICAgICAgeyAiY2F0ZWdvcnkiOiAiY29tcGFyaXNvbiIsICJ2 YWx1ZSI6ICA4MCwgInJldHVybiI6IFsiYm9vbCJdLCAgICAgInBhcmFtZXRlciI6IFsiaTY0Il0s ICAgICAgICAgICAgICAgICAgImltbWVkaWF0ZSI6IFtdLCAiYjNvcCI6ICJFcXVhbChpMzIoMCks IEAwKSIgfSwKKyAgICAgICAgImk2NC5lcXoiOiAgICAgICAgICAgICB7ICJjYXRlZ29yeSI6ICJj b21wYXJpc29uIiwgInZhbHVlIjogIDgwLCAicmV0dXJuIjogWyJib29sIl0sICAgICAicGFyYW1l dGVyIjogWyJpNjQiXSwgICAgICAgICAgICAgICAgICAiaW1tZWRpYXRlIjogW10sICJiM29wIjog IkVxdWFsKGk2NCgwKSwgQDApIiB9LAogICAgICAgICAiZjMyLmFkZCI6ICAgICAgICAgICAgIHsg ImNhdGVnb3J5IjogImFyaXRobWV0aWMiLCAidmFsdWUiOiAxNDYsICJyZXR1cm4iOiBbImYzMiJd LCAgICAgICJwYXJhbWV0ZXIiOiBbImYzMiIsICJmMzIiXSwgICAgICAgICAgICJpbW1lZGlhdGUi OiBbXSwgImIzb3AiOiAiQWRkIiAgICAgICAgICB9LAogICAgICAgICAiZjMyLnN1YiI6ICAgICAg ICAgICAgIHsgImNhdGVnb3J5IjogImFyaXRobWV0aWMiLCAidmFsdWUiOiAxNDcsICJyZXR1cm4i OiBbImYzMiJdLCAgICAgICJwYXJhbWV0ZXIiOiBbImYzMiIsICJmMzIiXSwgICAgICAgICAgICJp bW1lZGlhdGUiOiBbXSwgImIzb3AiOiAiU3ViIiAgICAgICAgICB9LAogICAgICAgICAiZjMyLm11 bCI6ICAgICAgICAgICAgIHsgImNhdGVnb3J5IjogImFyaXRobWV0aWMiLCAidmFsdWUiOiAxNDgs ICJyZXR1cm4iOiBbImYzMiJdLCAgICAgICJwYXJhbWV0ZXIiOiBbImYzMiIsICJmMzIiXSwgICAg ICAgICAgICJpbW1lZGlhdGUiOiBbXSwgImIzb3AiOiAiTXVsIiAgICAgICAgICB9LApkaWZmIC0t Z2l0IGEvSlNUZXN0cy9DaGFuZ2VMb2cgYi9KU1Rlc3RzL0NoYW5nZUxvZwppbmRleCA3YzhhMWQ2 MTA4YTE0ZTA0NmRiNmJhMjQzMjBlOTlkYTBiMmQ2NGYxLi43NmNlN2IwMzQ5YzA1ZmNkNzBhNWY0 NTEwNjc5YmU1MmNiMDhjNGFhIDEwMDY0NAotLS0gYS9KU1Rlc3RzL0NoYW5nZUxvZworKysgYi9K U1Rlc3RzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE0IEBACiAyMDE2LTEyLTE1ICBLZWl0aCBNaWxs ZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgogCisgICAgICAgIGk2NC5lcXogc2hvdWxkIHVz ZSBhbiBJbnQ2NCB6ZXJvCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNjU5NDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIHdhc20vd2FzbS5qc29uOgorCisyMDE2LTEyLTE1ICBLZWl0aCBNaWxsZXIgIDxr ZWl0aF9taWxsZXJAYXBwbGUuY29tPgorCiAgICAgICAgIFdhc20gc2hvdWxkIG5vdCBjcmVhdGUg ZW1wdHkgdW5saW5rZWQgY2FsbHNpdGVzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNjU5MzMKIApkaWZmIC0tZ2l0IGEvSlNUZXN0cy93YXNtL3dhc20u anNvbiBiL0pTVGVzdHMvd2FzbS93YXNtLmpzb24KaW5kZXggOGE1YmY4YjU1NmJkODFjMjRhZTNj YTEzMmUwYTY4N2FiYjZkMTZhMC4uYjE4YmVlNWI3NWE3NjM4ZmYwM2E2MjMzYzY4MmQ0NjUxZDhj MGU2OSAxMDA2NDQKLS0tIGEvSlNUZXN0cy93YXNtL3dhc20uanNvbgorKysgYi9KU1Rlc3RzL3dh c20vd2FzbS5qc29uCkBAIC0xNDcsNyArMTQ3LDcgQEAKICAgICAgICAgImk2NC5jbHoiOiAgICAg ICAgICAgICB7ICJjYXRlZ29yeSI6ICJhcml0aG1ldGljIiwgInZhbHVlIjogMTIxLCAicmV0dXJu IjogWyJpNjQiXSwgICAgICAicGFyYW1ldGVyIjogWyJpNjQiXSwgICAgICAgICAgICAgICAgICAi aW1tZWRpYXRlIjogW10sICJiM29wIjogIkNseiIgICAgICAgICAgfSwKICAgICAgICAgImk2NC5j dHoiOiAgICAgICAgICAgICB7ICJjYXRlZ29yeSI6ICJhcml0aG1ldGljIiwgInZhbHVlIjogMTIy LCAicmV0dXJuIjogWyJpNjQiXSwgICAgICAicGFyYW1ldGVyIjogWyJpNjQiXSwgICAgICAgICAg ICAgICAgICAiaW1tZWRpYXRlIjogW10gICAgICAgICAgICAgICAgICAgICAgICAgfSwKICAgICAg ICAgImk2NC5wb3BjbnQiOiAgICAgICAgICB7ICJjYXRlZ29yeSI6ICJhcml0aG1ldGljIiwgInZh bHVlIjogMTIzLCAicmV0dXJuIjogWyJpNjQiXSwgICAgICAicGFyYW1ldGVyIjogWyJpNjQiXSwg ICAgICAgICAgICAgICAgICAiaW1tZWRpYXRlIjogW10gICAgICAgICAgICAgICAgICAgICAgICAg fSwKLSAgICAgICAgImk2NC5lcXoiOiAgICAgICAgICAgICB7ICJjYXRlZ29yeSI6ICJjb21wYXJp c29uIiwgInZhbHVlIjogIDgwLCAicmV0dXJuIjogWyJib29sIl0sICAgICAicGFyYW1ldGVyIjog WyJpNjQiXSwgICAgICAgICAgICAgICAgICAiaW1tZWRpYXRlIjogW10sICJiM29wIjogIkVxdWFs KGkzMigwKSwgQDApIiB9LAorICAgICAgICAiaTY0LmVxeiI6ICAgICAgICAgICAgIHsgImNhdGVn b3J5IjogImNvbXBhcmlzb24iLCAidmFsdWUiOiAgODAsICJyZXR1cm4iOiBbImJvb2wiXSwgICAg ICJwYXJhbWV0ZXIiOiBbImk2NCJdLCAgICAgICAgICAgICAgICAgICJpbW1lZGlhdGUiOiBbXSwg ImIzb3AiOiAiRXF1YWwoaTY0KDApLCBAMCkiIH0sCiAgICAgICAgICJmMzIuYWRkIjogICAgICAg ICAgICAgeyAiY2F0ZWdvcnkiOiAiYXJpdGhtZXRpYyIsICJ2YWx1ZSI6IDE0NiwgInJldHVybiI6 IFsiZjMyIl0sICAgICAgInBhcmFtZXRlciI6IFsiZjMyIiwgImYzMiJdLCAgICAgICAgICAgImlt bWVkaWF0ZSI6IFtdLCAiYjNvcCI6ICJBZGQiICAgICAgICAgIH0sCiAgICAgICAgICJmMzIuc3Vi IjogICAgICAgICAgICAgeyAiY2F0ZWdvcnkiOiAiYXJpdGhtZXRpYyIsICJ2YWx1ZSI6IDE0Nywg InJldHVybiI6IFsiZjMyIl0sICAgICAgInBhcmFtZXRlciI6IFsiZjMyIiwgImYzMiJdLCAgICAg ICAgICAgImltbWVkaWF0ZSI6IFtdLCAiYjNvcCI6ICJTdWIiICAgICAgICAgIH0sCiAgICAgICAg ICJmMzIubXVsIjogICAgICAgICAgICAgeyAiY2F0ZWdvcnkiOiAiYXJpdGhtZXRpYyIsICJ2YWx1 ZSI6IDE0OCwgInJldHVybiI6IFsiZjMyIl0sICAgICAgInBhcmFtZXRlciI6IFsiZjMyIiwgImYz MiJdLCAgICAgICAgICAgImltbWVkaWF0ZSI6IFtdLCAiYjNvcCI6ICJNdWwiICAgICAgICAgIH0s Cg==