165938 2016-12-15 18:01:22 -0800 Fix validation of non-void if blocks with no else 2016-12-15 18:39:12 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 keith_miller keith_miller commit-queue mark.lam msaboff saam oldest_to_newest 1260431 0 keith_miller 2016-12-15 18:01:22 -0800 Fix validation of non-void if blocks with no else 1260433 1 297270 keith_miller 2016-12-15 18:04:24 -0800 Created attachment 297270 Patch 1260457 2 297270 commit-queue 2016-12-15 18:28:57 -0800 Comment on attachment 297270 Patch Rejecting attachment 297270 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 297270, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: a/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors self._run(tool, options, state) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run step(tool, options).run(state) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 54, in run if changelog_entry.has_valid_reviewer(): AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer' Full output: http://webkit-queues.webkit.org/results/2733165 1260471 3 keith_miller 2016-12-15 18:39:12 -0800 Committed r209899: <http://trac.webkit.org/changeset/209899> 297270 2016-12-15 18:04:24 -0800 2016-12-15 18:28:57 -0800 Patch bug-165938-20161215180331.patch text/plain 4697 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjA5ODk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj ZWEzNzM1YWNjNzI0NjdlMjFmODM3ZmQ5MTMxMjEzNmVmMGRhOTQ5Li5mOTdmYzdhZWYwODEwOGU2 MTJiMDVlOGNiNGFjNjE0MWYzMGUyNWNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxOCBAQAogMjAxNi0xMi0xNSAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KIAorICAgICAgICBGaXggdmFsaWRhdGlvbiBvZiBub24tdm9pZCBpZiBibG9ja3Mgd2l0 aCBubyBlbHNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNjU5MzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBXZSBzaG91bGQgbm90IGhhdmUgYmVlbiBhbGxvd2luZyBub24tdm9pZCBpZi1ibG9ja3MgdGhh dCBkb24ndAorICAgICAgICBoYXZlIGFuIGVsc2UuIFNpbmNlIHRoaXMgY2F1c2VzIGEgdmFsdWUg dG8gYmUgcGxhY2VkIG9uIHRoZQorICAgICAgICBzdGFjayB0aGF0IG9ubHkgYXBwZWFycyB1bmRl ciBzb21lIGNvbnRyb2wgZmxvdyBhbmQgbm90IGFub3RoZXIuCisKKyAgICAgICAgKiB3YXNtL1dh c21WYWxpZGF0ZS5jcHA6CisKKzIwMTYtMTItMTUgIEtlaXRoIE1pbGxlciAgPGtlaXRoX21pbGxl ckBhcHBsZS5jb20+CisKICAgICAgICAgV2FzbSBzaG91bGQgbm90IGNyZWF0ZSBlbXB0eSB1bmxp bmtlZCBjYWxsc2l0ZXMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE2NTkzMwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9X YXNtVmFsaWRhdGUuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vV2FzbVZhbGlkYXRl LmNwcAppbmRleCBkMWI1NTZlM2ViMDViZTAyMDEyMzY5NmQ3MTU5ZTcxY2UyNTQ0NjM0Li4wYTEy OWE5N2VkZmRmZDVkNzk4NGM3ZTNiMjhmYTlhMGMyZmJhZDdiIDEwMDY0NAotLS0gYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvd2FzbS9XYXNtVmFsaWRhdGUuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS93YXNtL1dhc21WYWxpZGF0ZS5jcHAKQEAgLTI5MCw2ICsyOTAsNyBAQCBhdXRvIFZh bGlkYXRlOjplbmRCbG9jayhDb250cm9sRW50cnkmIGVudHJ5LCBFeHByZXNzaW9uTGlzdCYgc3Rh Y2spIC0+IFJlc3VsdAogICAgIGlmIChibG9jay5zaWduYXR1cmUoKSA9PSBWb2lkKQogICAgICAg ICByZXR1cm4geyB9OwogCisgICAgV0FTTV9WQUxJREFUT1JfRkFJTF9JRihibG9jay50eXBlKCkg PT0gQmxvY2tUeXBlOjpJZiwgIklmLWJsb2NrIGhhZCBhIG5vbi12b2lkIHJlc3VsdCB0eXBlOiAi LCBibG9jay5zaWduYXR1cmUoKSwgIiBidXQgaGFkIG5vIGVsc2UtYmxvY2siKTsKICAgICBXQVNN X1ZBTElEQVRPUl9GQUlMX0lGKHN0YWNrLmlzRW1wdHkoKSwgInR5cGVkIGJsb2NrIGZhbGxzIHRo cm91Z2ggb24gZW1wdHkgc3RhY2siKTsKICAgICBXQVNNX1ZBTElEQVRPUl9GQUlMX0lGKGJsb2Nr LnNpZ25hdHVyZSgpICE9IHN0YWNrLmxhc3QoKSwgImJsb2NrIGZhbGx0aHJvdWdoIGRvZXNuJ3Qg bWF0Y2ggaXRzIGRlY2xhcmVkIHR5cGUiKTsKIApAQCAtMjk5LDggKzMwMCwxMSBAQCBhdXRvIFZh bGlkYXRlOjplbmRCbG9jayhDb250cm9sRW50cnkmIGVudHJ5LCBFeHByZXNzaW9uTGlzdCYgc3Rh Y2spIC0+IFJlc3VsdAogCiBhdXRvIFZhbGlkYXRlOjphZGRFbmRUb1VucmVhY2hhYmxlKENvbnRy b2xFbnRyeSYgZW50cnkpIC0+IFJlc3VsdAogewotICAgIGlmIChlbnRyeS5jb250cm9sRGF0YS5z aWduYXR1cmUoKSAhPSBWb2lkKQotICAgICAgICBlbnRyeS5lbmNsb3NlZEV4cHJlc3Npb25TdGFj ay5hcHBlbmQoZW50cnkuY29udHJvbERhdGEuc2lnbmF0dXJlKCkpOworICAgIGF1dG8gYmxvY2sg PSBlbnRyeS5jb250cm9sRGF0YTsKKyAgICBpZiAoYmxvY2suc2lnbmF0dXJlKCkgIT0gVm9pZCkg eworICAgICAgICBXQVNNX1ZBTElEQVRPUl9GQUlMX0lGKGJsb2NrLnR5cGUoKSA9PSBCbG9ja1R5 cGU6OklmLCAiSWYtYmxvY2sgaGFkIGEgbm9uLXZvaWQgcmVzdWx0IHR5cGU6ICIsIGJsb2NrLnNp Z25hdHVyZSgpLCAiIGJ1dCBoYWQgbm8gZWxzZS1ibG9jayIpOworICAgICAgICBlbnRyeS5lbmNs b3NlZEV4cHJlc3Npb25TdGFjay5hcHBlbmQoYmxvY2suc2lnbmF0dXJlKCkpOworICAgIH0KICAg ICByZXR1cm4geyB9OwogfQogCmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxvZyBiL0pTVGVz dHMvQ2hhbmdlTG9nCmluZGV4IDdjOGExZDYxMDhhMTRlMDQ2ZGI2YmEyNDMyMGU5OWRhMGIyZDY0 ZjEuLmE4NmM0YjE4Njg5NWM2NWVjZDJmOWRiNDJjYWUyNTIyY2U0YzllZTAgMTAwNjQ0Ci0tLSBh L0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKK24yMDE2LTEyLTE1ICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgor CisgICAgICAgIEZpeCB2YWxpZGF0aW9uIG9mIG5vbi12b2lkIGlmIGJsb2NrcyB3aXRoIG5vIGVs c2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NTkz OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBh IG5ldyBmYWlsaW5nIHRlc3QgYW5kIGEgZml4IGFuIGV4aXN0aW5nIG9uZS4KKworICAgICAgICAq IHdhc20vZnVuY3Rpb24tdGVzdHMvZGVhZC1jYWxsLmpzOgorICAgICAgICAqIHdhc20vZnVuY3Rp b24tdGVzdHMvaWYtbm8tZWxzZS1ub24tdm9pZC5qczogQWRkZWQuCisKIDIwMTYtMTItMTUgIEtl aXRoIE1pbGxlciAgPGtlaXRoX21pbGxlckBhcHBsZS5jb20+CiAKICAgICAgICAgV2FzbSBzaG91 bGQgbm90IGNyZWF0ZSBlbXB0eSB1bmxpbmtlZCBjYWxsc2l0ZXMKZGlmZiAtLWdpdCBhL0pTVGVz dHMvd2FzbS9mdW5jdGlvbi10ZXN0cy9kZWFkLWNhbGwuanMgYi9KU1Rlc3RzL3dhc20vZnVuY3Rp b24tdGVzdHMvZGVhZC1jYWxsLmpzCmluZGV4IDNmYzJiNDQ5YTc2ZWQxZTQ4NmU5ODU4N2E2Mjg5 ZWJkYTg1OTUxMDcuLmQ1NmUxNWIxMWQyMDU5NDZiYTJlMjQwOTFhNWViNzJjMzlmNTlmYTEgMTAw NjQ0Ci0tLSBhL0pTVGVzdHMvd2FzbS9mdW5jdGlvbi10ZXN0cy9kZWFkLWNhbGwuanMKKysrIGIv SlNUZXN0cy93YXNtL2Z1bmN0aW9uLXRlc3RzL2RlYWQtY2FsbC5qcwpAQCAtMTQsOCArMTQsMTIg QEAgY29uc3QgYnVpbGRlciA9IChuZXcgQnVpbGRlcigpKQogCiAgICAgICAgICAgLkZ1bmN0aW9u KCJkZWFkLWNhbGwiLCB7IHBhcmFtczogW10sIHJldDogImkzMiIgfSkKICAgICAgICAgICAgICAg LkkzMkNvbnN0KDApCi0gICAgICAgICAgICAgIC5JZigiaTMyIiwgYiA9PiBiLkNhbGwoMCkuUmV0 dXJuKCkpCi0gICAgICAgICAgICAgIC5JMzJDb25zdCgxKQorICAgICAgICAgICAgICAuSWYoImkz MiIsIGIgPT4KKyAgICAgICAgICAgICAgICAgIGIuQ2FsbCgwKQorICAgICAgICAgICAgICAgICAg LlJldHVybigpCisgICAgICAgICAgICAgICAgICAuRWxzZSgpCisgICAgICAgICAgICAgICAgICAu STMyQ29uc3QoMSkKKyAgICAgICAgICAgICAgICAgKQogICAgICAgICAgIC5FbmQoKQogCiAgICAg ICAuRW5kKCk7CmRpZmYgLS1naXQgYS9KU1Rlc3RzL3dhc20vZnVuY3Rpb24tdGVzdHMvaWYtbm8t ZWxzZS1ub24tdm9pZC5qcyBiL0pTVGVzdHMvd2FzbS9mdW5jdGlvbi10ZXN0cy9pZi1uby1lbHNl LW5vbi12b2lkLmpzCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjIzMzhmZjhmYmNmMGFhYzJlNDA5YjI4NzkyNDg1ZjU0 NWNmMzk1MGYKLS0tIC9kZXYvbnVsbAorKysgYi9KU1Rlc3RzL3dhc20vZnVuY3Rpb24tdGVzdHMv aWYtbm8tZWxzZS1ub24tdm9pZC5qcwpAQCAtMCwwICsxLDE2IEBACitpbXBvcnQgKiBhcyBhc3Nl cnQgZnJvbSAnLi4vYXNzZXJ0LmpzJzsKK2ltcG9ydCBCdWlsZGVyIGZyb20gJy4uL0J1aWxkZXIu anMnOworCitjb25zdCBidWlsZGVyID0gKG5ldyBCdWlsZGVyKCkpCisgICAgICAuVHlwZSgpLkVu ZCgpCisgICAgICAuRnVuY3Rpb24oKS5FbmQoKQorICAgICAgLkNvZGUoKQorICAgICAgICAgIC5G dW5jdGlvbigiYmFkLWlmIiwgeyBwYXJhbXM6IFtdLCByZXQ6ICJpMzIiIH0pCisgICAgICAgICAg ICAgIC5JMzJDb25zdCgwKQorICAgICAgICAgICAgICAuSWYoImkzMiIsIGIgPT4gYi5JMzJDb25z dCgwKSkKKyAgICAgICAgICAuRW5kKCkKKworICAgICAgLkVuZCgpOworCitjb25zdCBiaW4gPSBi dWlsZGVyLldlYkFzc2VtYmx5KCkuZ2V0KCk7Cithc3NlcnQudGhyb3dzKCgpID0+IG5ldyBXZWJB c3NlbWJseS5Nb2R1bGUoYmluKSwgV2ViQXNzZW1ibHkuQ29tcGlsZUVycm9yLCAiV2ViQXNzZW1i bHkuTW9kdWxlIGRvZXNuJ3QgdmFsaWRhdGU6IElmLWJsb2NrIGhhZCBhIG5vbi12b2lkIHJlc3Vs dCB0eXBlOiBJMzIgYnV0IGhhZCBubyBlbHNlLWJsb2NrIChldmFsdWF0aW5nICduZXcgV2ViQXNz ZW1ibHkuTW9kdWxlKGJpbiknKSIpOwo=