165933 2016-12-15 16:45:12 -0800 Wasm should not create empty unlinked callsites 2016-12-15 17:06:46 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 keith_miller keith_miller commit-queue mark.lam msaboff saam oldest_to_newest 1260370 0 keith_miller 2016-12-15 16:45:12 -0800 Wasm should not create empty unlinked callsites 1260372 1 297254 keith_miller 2016-12-15 16:47:17 -0800 Created attachment 297254 Patch 1260385 2 297254 mark.lam 2016-12-15 17:00:18 -0800 Comment on attachment 297254 Patch LGTM 1260393 3 keith_miller 2016-12-15 17:06:46 -0800 Committed r209891: <http://trac.webkit.org/changeset/209891> 297254 2016-12-15 16:47:17 -0800 2016-12-15 17:00:18 -0800 Patch bug-165933-20161215164624.patch text/plain 3742 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjA5ODcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl NTRiMDIwMzFhZjk3ZmIwMjY0MTA4YWFmMDg0MDhiN2NlODg0N2VjLi5hZGNmMTVmOWQ2NTU0OGYy ODUxYzdlN2ZjN2YzNTVkM2MzMDhhZDA2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxOCBAQAogMjAxNi0xMi0xNSAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KIAorICAgICAgICBXYXNtIHNob3VsZCBub3QgY3JlYXRlIGVtcHR5IHVubGlua2VkIGNh bGxzaXRlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTY1OTMzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg V2FzbSB3b3VsZCBjcmVhdGUgaG9sZXMgaW4gdGhlIHVubGlua2VkIGNhbGxzaXRlIHZlY3RvciBp ZiBCMyB3YXMgYWJsZSB0bworICAgICAgICBlbGltaW5hdGUgdGhlIGNhbGxzaXRlLgorCisgICAg ICAgICogd2FzbS9XYXNtQjNJUkdlbmVyYXRvci5jcHA6CisgICAgICAgIChKU0M6Oldhc206OkIz SVJHZW5lcmF0b3I6OmFkZENhbGwpOgorCisyMDE2LTEyLTE1ICBLZWl0aCBNaWxsZXIgIDxrZWl0 aF9taWxsZXJAYXBwbGUuY29tPgorCiAgICAgICAgIFR1cm4gb24gV2ViQXNzZW1ibHkgYnkgZGVm YXVsdAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY1 OTE4CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dhc21CM0lSR2Vu ZXJhdG9yLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dhc21CM0lSR2VuZXJhdG9y LmNwcAppbmRleCA2OTQ4ZjEyMDg2ODI1NDBlOWM2Mzk2ZWZlZmY4NjQxYzYzMjZiOGIyLi42NjUz ODJjYWIxY2UxN2NkOTgyNjgwZDljNzE5OTkxNDAzYTY1MWJmIDEwMDY0NAotLS0gYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvd2FzbS9XYXNtQjNJUkdlbmVyYXRvci5jcHAKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL3dhc20vV2FzbUIzSVJHZW5lcmF0b3IuY3BwCkBAIC02ODgsOCArNjg4LDYg QEAgYm9vbCBCM0lSR2VuZXJhdG9yOjphZGRDYWxsKHVpbnQzMl90IGZ1bmN0aW9uSW5kZXgsIGNv bnN0IFNpZ25hdHVyZSogc2lnbmF0dXJlLAogCiAgICAgVHlwZSByZXR1cm5UeXBlID0gc2lnbmF0 dXJlLT5yZXR1cm5UeXBlOwogCi0gICAgc2l6ZV90IGNhbGxJbmRleCA9IG1fdW5saW5rZWRXYXNt VG9XYXNtQ2FsbHMuc2l6ZSgpOwotICAgIG1fdW5saW5rZWRXYXNtVG9XYXNtQ2FsbHMuZ3Jvdyhj YWxsSW5kZXggKyAxKTsKICAgICByZXN1bHQgPSB3YXNtQ2FsbGluZ0NvbnZlbnRpb24oKS5zZXR1 cENhbGwobV9wcm9jLCBtX2N1cnJlbnRCbG9jaywgT3JpZ2luKCksIGFyZ3MsIHRvQjNUeXBlKHJl dHVyblR5cGUpLAogICAgICAgICBbJl0gKFBhdGNocG9pbnRWYWx1ZSogcGF0Y2hwb2ludCkgewog ICAgICAgICAgICAgcGF0Y2hwb2ludC0+ZWZmZWN0cy53cml0ZXNQaW5uZWQgPSB0cnVlOwpAQCAt NzAxLDcgKzY5OSw3IEBAIGJvb2wgQjNJUkdlbmVyYXRvcjo6YWRkQ2FsbCh1aW50MzJfdCBmdW5j dGlvbkluZGV4LCBjb25zdCBTaWduYXR1cmUqIHNpZ25hdHVyZSwKICAgICAgICAgICAgICAgICBD Q2FsbEhlbHBlcnM6OkNhbGwgY2FsbCA9IGppdC5jYWxsKCk7CiAKICAgICAgICAgICAgICAgICBq aXQuYWRkTGlua1Rhc2soWz1dIChMaW5rQnVmZmVyJiBsaW5rQnVmZmVyKSB7Ci0gICAgICAgICAg ICAgICAgICAgIG1fdW5saW5rZWRXYXNtVG9XYXNtQ2FsbHNbY2FsbEluZGV4XSA9IHsgbGlua0J1 ZmZlci5sb2NhdGlvbk9mKGNhbGwpLCBmdW5jdGlvbkluZGV4IH07CisgICAgICAgICAgICAgICAg ICAgIG1fdW5saW5rZWRXYXNtVG9XYXNtQ2FsbHMuYXBwZW5kKHsgbGlua0J1ZmZlci5sb2NhdGlv bk9mKGNhbGwpLCBmdW5jdGlvbkluZGV4IH0pOwogICAgICAgICAgICAgICAgIH0pOwogICAgICAg ICAgICAgfSk7CiAgICAgICAgIH0pOwpkaWZmIC0tZ2l0IGEvSlNUZXN0cy9DaGFuZ2VMb2cgYi9K U1Rlc3RzL0NoYW5nZUxvZwppbmRleCA0N2ZkYmM4MjJkYjFmZWQ0NTgxYjBkZGM2MDIxNDdiYTcz NWU1OTJhLi45OGQzOWM0ZGQyNDExYmFhZGZjMzY3YjZmNTk1MTFiYzNlMjA1MWIyIDEwMDY0NAot LS0gYS9KU1Rlc3RzL0NoYW5nZUxvZworKysgYi9KU1Rlc3RzL0NoYW5nZUxvZwpAQCAtMSw1ICsx LDE0IEBACiAyMDE2LTEyLTE1ICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29t PgogCisgICAgICAgIFdhc20gc2hvdWxkIG5vdCBjcmVhdGUgZW1wdHkgdW5saW5rZWQgY2FsbHNp dGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjU5 MzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHdh c20vZnVuY3Rpb24tdGVzdHMvZGVhZC1jYWxsLmpzOiBBZGRlZC4KKworMjAxNi0xMi0xNSAgS2Vp dGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxlLmNvbT4KKwogICAgICAgICBGaXggNjQtYml0 IHNoaWZ0IGZhbWlseSBXYXNtIG9wY29kZXMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE2NTkwMgogCmRpZmYgLS1naXQgYS9KU1Rlc3RzL3dhc20vZnVu Y3Rpb24tdGVzdHMvZGVhZC1jYWxsLmpzIGIvSlNUZXN0cy93YXNtL2Z1bmN0aW9uLXRlc3RzL2Rl YWQtY2FsbC5qcwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4zZmMyYjQ0OWE3NmVkMWU0ODZlOTg1ODdhNjI4OWViZGE4 NTk1MTA3Ci0tLSAvZGV2L251bGwKKysrIGIvSlNUZXN0cy93YXNtL2Z1bmN0aW9uLXRlc3RzL2Rl YWQtY2FsbC5qcwpAQCAtMCwwICsxLDI1IEBACitpbXBvcnQgKiBhcyBhc3NlcnQgZnJvbSAnLi4v YXNzZXJ0LmpzJzsKK2ltcG9ydCBCdWlsZGVyIGZyb20gJy4uL0J1aWxkZXIuanMnOworCitjb25z dCBidWlsZGVyID0gKG5ldyBCdWlsZGVyKCkpCisgICAgICAuVHlwZSgpLkVuZCgpCisgICAgICAu RnVuY3Rpb24oKS5FbmQoKQorICAgICAgLkV4cG9ydCgpCisgICAgICAgICAgLkZ1bmN0aW9uKCJk ZWFkLWNhbGwiKQorICAgICAgLkVuZCgpCisgICAgICAuQ29kZSgpCisgICAgICAgICAgLkZ1bmN0 aW9uKCJjcmFzaCIsIHsgcGFyYW1zOiBbXSwgcmV0OiAiaTMyIiB9KQorICAgICAgICAgICAgICAu VW5yZWFjaGFibGUoKQorICAgICAgICAgIC5FbmQoKQorCisgICAgICAgICAgLkZ1bmN0aW9uKCJk ZWFkLWNhbGwiLCB7IHBhcmFtczogW10sIHJldDogImkzMiIgfSkKKyAgICAgICAgICAgICAgLkkz MkNvbnN0KDApCisgICAgICAgICAgICAgIC5JZigiaTMyIiwgYiA9PiBiLkNhbGwoMCkuUmV0dXJu KCkpCisgICAgICAgICAgICAgIC5JMzJDb25zdCgxKQorICAgICAgICAgIC5FbmQoKQorCisgICAg ICAuRW5kKCk7CisKK2NvbnN0IGJpbiA9IGJ1aWxkZXIuV2ViQXNzZW1ibHkoKS5nZXQoKTsKK2Nv bnN0IG1vZHVsZSA9IG5ldyBXZWJBc3NlbWJseS5Nb2R1bGUoYmluKTsKK2NvbnN0IGluc3RhbmNl ID0gbmV3IFdlYkFzc2VtYmx5Lkluc3RhbmNlKG1vZHVsZSk7Cg==