165923 2016-12-15 14:56:36 -0800 Arguments called in wrong order 2017-03-08 06:48:21 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 104114 1 bfulgham bfulgham bfulgham ddkilzer eric.carlson jer.noble koivisto mcatanzaro mmaxfield simon.fraser oldest_to_newest 1260279 0 bfulgham 2016-12-15 14:56:36 -0800 Static analysis has identified several places where the order of arguments to functions does not match the expected signature. 1260381 1 bfulgham 2016-12-15 16:57:05 -0800 I corrected a few other small bugs at the same time. 1260382 2 297257 bfulgham 2016-12-15 16:57:22 -0800 Created attachment 297257 Patch 1260396 3 297257 simon.fraser 2016-12-15 17:12:17 -0800 Comment on attachment 297257 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297257&action=review > Source/WebCore/ChangeLog:3 > + Arguments called in wrong order That doesn't really cover all the problems. > Source/WebCore/platform/graphics/GraphicsContext3D.cpp:332 > - if (!computeFormatAndTypeParameters(format, type, &bytesPerComponent, &componentsPerPixel)) > + if (!computeFormatAndTypeParameters(format, type, &componentsPerPixel, &bytesPerComponent)) It seems like this should be testable. 1260406 4 297257 thorton 2016-12-15 17:24:36 -0800 Comment on attachment 297257 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297257&action=review > Tools/TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:54 > - WKUserMediaPermissionRequestAllow(permissionRequest, videoDeviceUID.get(), audioDeviceUID.get()); > + WKUserMediaPermissionRequestAllow(permissionRequest, audioDeviceUID.get(), videoDeviceUID.get()); Seems bad that the test didn't catch this? 1260621 5 297257 bfulgham 2016-12-16 10:31:20 -0800 Comment on attachment 297257 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297257&action=review >> Source/WebCore/platform/graphics/GraphicsContext3D.cpp:332 >> + if (!computeFormatAndTypeParameters(format, type, &componentsPerPixel, &bytesPerComponent)) > > It seems like this should be testable. It's actually not, because the only use of 'bytesPerComponent' and 'componentsPerPixel' is to multiply by each-other and use that result. So this change is more about correctness than any actual behavior problem. I kind of wonder why we bother returning both values, since they are only ever used to do this one calculation. >> Tools/TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:54 >> + WKUserMediaPermissionRequestAllow(permissionRequest, audioDeviceUID.get(), videoDeviceUID.get()); > > Seems bad that the test didn't catch this? Agreed! 1260622 6 bfulgham 2016-12-16 10:33:03 -0800 Committed r209924: <http://trac.webkit.org/changeset/209924> 1261260 7 ddkilzer 2016-12-19 16:19:04 -0800 Antti: FYI, note the cache validation fix in Source/WebCore/platform/network/CacheValidation.cpp. 297257 2016-12-15 16:57:22 -0800 2016-12-15 17:12:17 -0800 Patch bug-165923-20161215165630.patch text/plain 8273 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwOTgxNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI4IEBACisyMDE2LTEyLTE1ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIEFyZ3VtZW50cyBjYWxsZWQg aW4gd3Jvbmcgb3JkZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE2NTkyMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIENvcnJlY3QgdGhlIG9yZGVyaW5nIG9mIHNldmVyYWwgZnVuY3Rpb24gY2FsbHMuCisK KyAgICAgICAgKiBNb2R1bGVzL21lZGlhc291cmNlL1NvdXJjZUJ1ZmZlci5jcHA6CisgICAgICAg IChXZWJDb3JlOjpTb3VyY2VCdWZmZXI6OnNvdXJjZUJ1ZmZlclByaXZhdGVEaWRSZWNlaXZlU2Ft cGxlKTogVGhlICduZWFyZXN0VG9QcmVzZW50YXRpb25TdGFydFRpbWUnCisgICAgICAgIGFyZ3Vt ZW50IGlzIGJlaW5nIGNoZWNrZWQgZm9yIHZhbGlkaXR5LCBidXQgJ25lYXJlc3RUb1ByZXNlbnRh dGlvbkVuZFRpbWUnIGlzIGJlaW5nIHVzZWQgaW4gdGhlCisgICAgICAgIGNhbGN1bGF0aW9uLiBU aGlzIHNlZW1zIGxpa2UgYSBjb3B5L3Bhc3RlIGVycm9yLgorICAgICAgICAqIHBhZ2UvUHJpbnRD b250ZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlByaW50Q29udGV4dDo6b3V0cHV0TGlua2Vk RGVzdGluYXRpb25zKTogRmxvYXRQb2ludDo6ZXhwYW5kZWRUbyByZXR1cm5zIGEgbmV3IG9iamVj dCB0aGF0CisgICAgICAgIGhhcyBiZWVuIGV4cGFuZGVkLiBUaGlzIGNvZGUgY29udGludWVkIHVz aW5nIHRoZSAndW5leHBhbmRlZCcgcG9pbnQuCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv R3JhcGhpY3NDb250ZXh0M0QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0 M0Q6OmNvbXB1dGVJbWFnZVNpemVJbkJ5dGVzKTogVGhlICdieXRlc1BlckNvbXBvbmVudCcgYW5k ICdjb21wb25lbnRzUGVyUGl4ZWwnCisgICAgICAgIHZhcmlhYmxlcyB3ZXJlIGJlaW5nIHBhc3Nl ZCBpbiB0aGUgd3Jvbmcgb3JkZXIuCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9DYWNoZVZh bGlkYXRpb24uY3BwOiBUaGUgJ2xhc3QtbW9kaWZpZWQnIGhlYWRlciBzdHJpbmcgd2FzIGJlaW5n IGNvbmNhdGVuYXRlZCB3aXRoCisgICAgICAgIHRoZSBmb2xsb3dpbmcgc3RyaW5nLCByZXN1bHRp bmcgaW4gYW4gaW5jb3JyZWN0ICdsYXN0LW1vZGlmaWVkcHJveHktYXV0aGVudGljYXRlJyBzdHJp bmcgdmFsdWUuCisgICAgICAgICogc3ZnL1NWR1RvT1RGRm9udENvbnZlcnNpb24uY3BwOgorICAg ICAgICAoV2ViQ29yZTo6U1ZHVG9PVEZGb250Q29udmVydGVyOjpmaXJzdEdseXBoKTogVGhlIEFT U0VSVCB3YXMgYXNzaWduaW5nIHRvIHRoZSAoYnktdmFsdWUpIGlucHV0CisgICAgICAgIHBhcmFt ZXRlciAnY29kZVBvaW50JywgcmF0aGVyIHRoYW4gY29tcGFyaW5nIGl0IHRvIHRoZSBmaXJzdEds eXBoIHZhbHVlJ3MgY29kZVBvaW50LgorCiAyMDE2LTEyLTE0ICBBbnR0aSBLb2l2aXN0byAgPGFu dHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWJDb250ZW50IGNyYXNoIHVuZGVyIFdlYkNvcmU6 OkNhY2hlZFJlc291cmNlOjpsb2FkIGluIFdlYkNvcmU6OkZyYW1lTG9hZGVyOjpvdXRnb2luZ1Jl ZmVycmVyIGNvbnN0CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc291cmNlL1Nv dXJjZUJ1ZmZlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRp YXNvdXJjZS9Tb3VyY2VCdWZmZXIuY3BwCShyZXZpc2lvbiAyMDk4MTcpCisrKyBTb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL21lZGlhc291cmNlL1NvdXJjZUJ1ZmZlci5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTEsNiArMSw2IEBACiAvKgogICogQ29weXJpZ2h0IChDKSAyMDEzIEdvb2dsZSBJbmMuIEFs bCByaWdodHMgcmVzZXJ2ZWQuCi0gKiBDb3B5cmlnaHQgKEMpIDIwMTMtMjAxNCBBcHBsZSBJbmMu IEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMpIDIwMTMtMjAxNiBBcHBsZSBJ bmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBp biBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmljYXRp b24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMg YXJlCkBAIC0xNjM4LDcgKzE2MzgsNyBAQCB2b2lkIFNvdXJjZUJ1ZmZlcjo6c291cmNlQnVmZmVy UHJpdmF0ZURpCiAgICAgICAgICAgICBwcmVzZW50YXRpb25UaW1lc3RhbXAgPSBuZWFyZXN0VG9Q cmVzZW50YXRpb25TdGFydFRpbWU7CiAKICAgICAgICAgYXV0byBuZWFyZXN0VG9QcmVzZW50YXRp b25FbmRUaW1lID0gdHJhY2tCdWZmZXIuYnVmZmVyZWQubmVhcmVzdChwcmVzZW50YXRpb25FbmRU aW1lKTsKLSAgICAgICAgaWYgKG5lYXJlc3RUb1ByZXNlbnRhdGlvblN0YXJ0VGltZS5pc1ZhbGlk KCkgJiYgKG5lYXJlc3RUb1ByZXNlbnRhdGlvbkVuZFRpbWUgLSBwcmVzZW50YXRpb25FbmRUaW1l KS5pc0JldHdlZW4oTWVkaWFUaW1lOjp6ZXJvVGltZSgpLCBNZWRpYVNvdXJjZTo6Y3VycmVudFRp bWVGdWRnZUZhY3RvcigpKSkKKyAgICAgICAgaWYgKG5lYXJlc3RUb1ByZXNlbnRhdGlvbkVuZFRp bWUuaXNWYWxpZCgpICYmIChuZWFyZXN0VG9QcmVzZW50YXRpb25FbmRUaW1lIC0gcHJlc2VudGF0 aW9uRW5kVGltZSkuaXNCZXR3ZWVuKE1lZGlhVGltZTo6emVyb1RpbWUoKSwgTWVkaWFTb3VyY2U6 OmN1cnJlbnRUaW1lRnVkZ2VGYWN0b3IoKSkpCiAgICAgICAgICAgICBwcmVzZW50YXRpb25FbmRU aW1lID0gbmVhcmVzdFRvUHJlc2VudGF0aW9uRW5kVGltZTsKIAogICAgICAgICB0cmFja0J1ZmZl ci5idWZmZXJlZC5hZGQocHJlc2VudGF0aW9uVGltZXN0YW1wLCBwcmVzZW50YXRpb25FbmRUaW1l KTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2UvUHJpbnRDb250ZXh0LmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9wYWdlL1ByaW50Q29udGV4dC5jcHAJKHJldmlzaW9uIDIwOTgx NykKKysrIFNvdXJjZS9XZWJDb3JlL3BhZ2UvUHJpbnRDb250ZXh0LmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMSw2ICsxLDYgQEAKIC8qCiAgKiBDb3B5cmlnaHQgKEMpIDIwMDcgQWxwIFRva2VyIDxh bHBAYXRva2VyLmNvbT4KLSAqIENvcHlyaWdodCAoQykgMjAwNyBBcHBsZSBJbmMuCisgKiBDb3B5 cmlnaHQgKEMpIDIwMDcsIDIwMTYgQXBwbGUgSW5jLgogICoKICAqIFRoaXMgbGlicmFyeSBpcyBm cmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IKICAqIG1vZGlmeSBp dCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBMaWJyYXJ5IEdlbmVyYWwgUHVibGljCkBAIC0y NzUsNyArMjc1LDcgQEAgdm9pZCBQcmludENvbnRleHQ6Om91dHB1dExpbmtlZERlc3RpbmF0aQog ICAgICAgICAgICAgY29udGludWU7CiAKICAgICAgICAgRmxvYXRQb2ludCBwb2ludCA9IHJlbmRl cmVyLT5hYnNvbHV0ZUFuY2hvclJlY3QoKS5taW5YTWluWUNvcm5lcigpOwotICAgICAgICBwb2lu dC5leHBhbmRlZFRvKEZsb2F0UG9pbnQoKSk7CisgICAgICAgIHBvaW50ID0gcG9pbnQuZXhwYW5k ZWRUbyhGbG9hdFBvaW50KCkpOwogCiAgICAgICAgIGlmICghcGFnZVJlY3QuY29udGFpbnMocm91 bmRlZEludFBvaW50KHBvaW50KSkpCiAgICAgICAgICAgICBjb250aW51ZTsKSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dDNELmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQz RC5jcHAJKHJldmlzaW9uIDIwOTgxNykKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL0dyYXBoaWNzQ29udGV4dDNELmNwcAkod29ya2luZyBjb3B5KQpAQCAtMSw1ICsxLDUgQEAK IC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMTAgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVk LgorICogQ29weXJpZ2h0IChDKSAyMDEwLCAyMDE2IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNl cnZlZC4KICAqIENvcHlyaWdodCAoQykgMjAxMCBHb29nbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2Vy dmVkLgogICogQ29weXJpZ2h0IChDKSAyMDEwIE1vemlsbGEgQ29ycG9yYXRpb24uIEFsbCByaWdo dHMgcmVzZXJ2ZWQuCiAgKgpAQCAtMzI5LDcgKzMyOSw3IEBAIEdDM0RlbnVtIEdyYXBoaWNzQ29u dGV4dDNEOjpjb21wdXRlSW1hZ2UKICAgICBpZiAod2lkdGggPCAwIHx8IGhlaWdodCA8IDApCiAg ICAgICAgIHJldHVybiBHcmFwaGljc0NvbnRleHQzRDo6SU5WQUxJRF9WQUxVRTsKICAgICB1bnNp Z25lZCBpbnQgYnl0ZXNQZXJDb21wb25lbnQsIGNvbXBvbmVudHNQZXJQaXhlbDsKLSAgICBpZiAo IWNvbXB1dGVGb3JtYXRBbmRUeXBlUGFyYW1ldGVycyhmb3JtYXQsIHR5cGUsICZieXRlc1BlckNv bXBvbmVudCwgJmNvbXBvbmVudHNQZXJQaXhlbCkpCisgICAgaWYgKCFjb21wdXRlRm9ybWF0QW5k VHlwZVBhcmFtZXRlcnMoZm9ybWF0LCB0eXBlLCAmY29tcG9uZW50c1BlclBpeGVsLCAmYnl0ZXNQ ZXJDb21wb25lbnQpKQogICAgICAgICByZXR1cm4gR3JhcGhpY3NDb250ZXh0M0Q6OklOVkFMSURf RU5VTTsKICAgICBpZiAoIXdpZHRoIHx8ICFoZWlnaHQpIHsKICAgICAgICAgKmltYWdlU2l6ZUlu Qnl0ZXMgPSAwOwpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9DYWNoZVZh bGlkYXRpb24uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvQ2FjaGVWYWxpZGF0aW9uLmNwcAkocmV2aXNpb24gMjA5ODE3KQorKysgU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbmV0d29yay9DYWNoZVZhbGlkYXRpb24uY3BwCSh3b3JraW5nIGNvcHkpCkBA IC00Niw3ICs0Niw3IEBAIGNvbnN0IGNoYXIqIGNvbnN0IGhlYWRlcnNUb0lnbm9yZUFmdGVyUmUK ICAgICAiY29ubmVjdGlvbiIsCiAgICAgImV0YWciLAogICAgICJrZWVwLWFsaXZlIiwKLSAgICAi bGFzdC1tb2RpZmllZCIKKyAgICAibGFzdC1tb2RpZmllZCIsCiAgICAgInByb3h5LWF1dGhlbnRp Y2F0ZSIsCiAgICAgInByb3h5LWNvbm5lY3Rpb24iLAogICAgICJ0cmFpbGVyIiwKSW5kZXg6IFNv dXJjZS9XZWJDb3JlL3N2Zy9TVkdUb09URkZvbnRDb252ZXJzaW9uLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViQ29yZS9zdmcvU1ZHVG9PVEZGb250Q29udmVyc2lvbi5jcHAJKHJldmlzaW9u IDIwOTgxNykKKysrIFNvdXJjZS9XZWJDb3JlL3N2Zy9TVkdUb09URkZvbnRDb252ZXJzaW9uLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMSw1ICsxLDUgQEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIw MTQtMjAxNSBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMp IDIwMTQtMjAxNiBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgogICogUmVkaXN0 cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRo b3V0CiAgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9s bG93aW5nIGNvbmRpdGlvbnMKQEAgLTczMyw3ICs3MzMsNyBAQCBHbHlwaCBTVkdUb09URkZvbnRD b252ZXJ0ZXI6OmZpcnN0R2x5cGgoCiAgICAgYXV0byBjb2RlUG9pbnRzID0gU3RyaW5nVmlldyht X2dseXBoc1t2WzBdXS5jb2RlcG9pbnRzKS5jb2RlUG9pbnRzKCk7CiAgICAgYXV0byBjb2RlUG9p bnRzSXRlcmF0b3IgPSBjb2RlUG9pbnRzLmJlZ2luKCk7CiAgICAgQVNTRVJUKGNvZGVQb2ludHNJ dGVyYXRvciAhPSBjb2RlUG9pbnRzLmVuZCgpKTsKLSAgICBBU1NFUlQoY29kZXBvaW50ID0gKmNv ZGVQb2ludHNJdGVyYXRvcik7CisgICAgQVNTRVJUKGNvZGVwb2ludCA9PSAqY29kZVBvaW50c0l0 ZXJhdG9yKTsKICNlbmRpZgogICAgIHJldHVybiB2WzBdOwogfQpJbmRleDogVG9vbHMvQ2hhbmdl TG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0NoYW5nZUxvZwkocmV2aXNpb24gMjA5ODg2KQorKysg VG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTYtMTIt MTUgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgQXJndW1l bnRzIGNhbGxlZCBpbiB3cm9uZyBvcmRlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTY1OTIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGhlICdhdWRpb0RldmljZVVJRHMnIGFycmF5IGlzIGJlaW5nIHBh c3NlZCB0byB0aGUgYXJndW1lbnQgdGhhdCBleHBlY3RzIHZpZGVvIGRldmljZXMsCisgICAgICAg IGFuZCB0aGUgJ3ZpZGVvRGV2aWNlVUlEcycgYXJyYXkgaXMgYmVpbmcgcGFzc2VkIHRvIHRoZSBh dWRvIGRldmljZSBhcmd1bWVudC4gRml4IHRoaXMuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJ L1Rlc3RzL1dlYktpdDIvVXNlck1lZGlhLmNwcDoKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OmRl Y2lkZVBvbGljeUZvclVzZXJNZWRpYVBlcm1pc3Npb25SZXF1ZXN0Q2FsbEJhY2spOiBUaGUKKyAg ICAgICAgb3JkZXIgb2YgYXJndW1lbnRzIHRvIFdLVXNlck1lZGlhUGVybWlzc2lvblJlcXVlc3RB bGxvdyBhcmUgZmxpcHBlZC4KKwogMjAxNi0xMi0xNSAgQ2xhdWRpbyBTYWF2ZWRyYSAgPGNzYWF2 ZWRyYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIEVuc3VyZSBnc3QqIGRvY3MgYXJlIG5v dCBidWlsdCB3aXRoIHVwZGF0ZS13ZWJraXRndGstbGlicwpJbmRleDogVG9vbHMvVGVzdFdlYktp dEFQSS9UZXN0cy9XZWJLaXQyL1VzZXJNZWRpYS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvVGVz dFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyL1VzZXJNZWRpYS5jcHAJKHJldmlzaW9uIDIwOTgxNykK KysrIFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Mi9Vc2VyTWVkaWEuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDUgKzEsNiBAQAogLyoKICAqIENvcHlyaWdodCAoQykgMjAxNCBJZ2Fs aWEgUy5MCisgKiBDb3B5cmlnaHQgKEMpIDIwMTYgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2Vy dmVkLgogICoKICAqICBUaGlzIGxpYnJhcnkgaXMgZnJlZSBzb2Z0d2FyZTsgeW91IGNhbiByZWRp c3RyaWJ1dGUgaXQgYW5kL29yCiAgKiAgbW9kaWZ5IGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUg R05VIExlc3NlciBHZW5lcmFsIFB1YmxpYwpAQCAtNTAsNyArNTEsNyBAQCB2b2lkIGRlY2lkZVBv bGljeUZvclVzZXJNZWRpYVBlcm1pc3Npb25SCiAgICAgICAgIGVsc2UKICAgICAgICAgICAgIGF1 ZGlvRGV2aWNlVUlEID0gV0tTdHJpbmdDcmVhdGVXaXRoVVRGOENTdHJpbmcoIiIpOwogCi0gICAg ICAgIFdLVXNlck1lZGlhUGVybWlzc2lvblJlcXVlc3RBbGxvdyhwZXJtaXNzaW9uUmVxdWVzdCwg dmlkZW9EZXZpY2VVSUQuZ2V0KCksIGF1ZGlvRGV2aWNlVUlELmdldCgpKTsKKyAgICAgICAgV0tV c2VyTWVkaWFQZXJtaXNzaW9uUmVxdWVzdEFsbG93KHBlcm1pc3Npb25SZXF1ZXN0LCBhdWRpb0Rl dmljZVVJRC5nZXQoKSwgdmlkZW9EZXZpY2VVSUQuZ2V0KCkpOwogICAgIH0KIAogICAgIGRvbmUg PSB0cnVlOwo=