165914 2016-12-15 12:43:46 -0800 Add more mach_msg logging instrumentation 2016-12-15 14:48:50 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 1260215 0 andersca 2016-12-15 12:43:46 -0800 Add more mach_msg logging instrumentation 1260218 1 297212 andersca 2016-12-15 12:46:18 -0800 Created attachment 297212 Patch 1260220 2 297212 darin 2016-12-15 12:50:21 -0800 Comment on attachment 297212 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297212&action=review > Source/WebKit2/Platform/IPC/mac/ConnectionMac.mm:286 > + WKSetCrashReportApplicationSpecificInformation((CFStringRef)[NSString stringWithFormat:@"Unhandled error code %x, message '%@'", kr, message->messageName()]); Wish we had bridging_cast to use in places like this. > Source/WebKit2/Platform/IPC/mac/ConnectionMac.mm:321 > + message->setMessageName((__bridge CFStringRef)[NSString stringWithFormat:@"%s:%s:", encoder->messageReceiverName().toString().data(), encoder->messageName().toString().data()]); Ditto. 1260274 3 andersca 2016-12-15 14:48:50 -0800 Committed r209876: <http://trac.webkit.org/changeset/209876> 297212 2016-12-15 12:46:18 -0800 2016-12-15 12:50:21 -0800 Patch bug-165914-20161215124527.patch text/plain 2817 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMjA5ODQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZmY3NzQ3M2I0MjdhYTcw ZTgzNjQ5ODRhYWY5ZDc2ODZiNzQ2MTUxMy4uN2M0MDNkZjY4ZDIyNTViNzVkMjYwY2ExODdiNGZi YWU3NjIyOWEyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE2LTEyLTE1ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIG1vcmUgbWFj aF9tc2cgbG9nZ2luZyBpbnN0cnVtZW50YXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NTkxNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogUGxhdGZvcm0vSVBDL21hYy9Db25uZWN0aW9uTWFjLm1t OgorICAgICAgICAoSVBDOjpDb25uZWN0aW9uOjpzZW5kTWVzc2FnZSk6CisgICAgICAgIChJUEM6 OkNvbm5lY3Rpb246OnNlbmRPdXRnb2luZ01lc3NhZ2UpOgorICAgICAgICAqIFBsYXRmb3JtL0lQ Qy9tYWMvTWFjaE1lc3NhZ2UuaDoKKyAgICAgICAgKElQQzo6TWFjaE1lc3NhZ2U6Om1lc3NhZ2VO YW1lKToKKyAgICAgICAgKElQQzo6TWFjaE1lc3NhZ2U6OnNldE1lc3NhZ2VOYW1lKToKKwogMjAx Ni0xMi0xNCAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAg IEFkZCBXS0NvbnRleHRSZWZyZXNoUGx1Z0lucwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv UGxhdGZvcm0vSVBDL21hYy9Db25uZWN0aW9uTWFjLm1tIGIvU291cmNlL1dlYktpdDIvUGxhdGZv cm0vSVBDL21hYy9Db25uZWN0aW9uTWFjLm1tCmluZGV4IGJjZWFlMmQxMzg0MzRiMTk4MmM2Yjlm OTIwN2UyODdmNGNkOTM3NzcuLjdmZTAwOWIwZTNhZTU5NWY2OTM0Zjg3OWYzYzZiYTE4ZTBmOTIz YjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0lQQy9tYWMvQ29ubmVjdGlv bk1hYy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9JUEMvbWFjL0Nvbm5lY3Rpb25N YWMubW0KQEAgLTI4Myw3ICsyODMsNyBAQCBib29sIENvbm5lY3Rpb246OnNlbmRNZXNzYWdlKHN0 ZDo6dW5pcXVlX3B0cjxNYWNoTWVzc2FnZT4gbWVzc2FnZSkKICAgICAgICAgcmV0dXJuIGZhbHNl OwogCiAgICAgZGVmYXVsdDoKLSAgICAgICAgV0tTZXRDcmFzaFJlcG9ydEFwcGxpY2F0aW9uU3Bl Y2lmaWNJbmZvcm1hdGlvbigoQ0ZTdHJpbmdSZWYpW05TU3RyaW5nIHN0cmluZ1dpdGhGb3JtYXQ6 QCJVbmhhbmRsZWQgZXJyb3IgY29kZSAleCIsIGtyXSk7CisgICAgICAgIFdLU2V0Q3Jhc2hSZXBv cnRBcHBsaWNhdGlvblNwZWNpZmljSW5mb3JtYXRpb24oKENGU3RyaW5nUmVmKVtOU1N0cmluZyBz dHJpbmdXaXRoRm9ybWF0OkAiVW5oYW5kbGVkIGVycm9yIGNvZGUgJXgsIG1lc3NhZ2UgJyVAJyIs IGtyLCBtZXNzYWdlLT5tZXNzYWdlTmFtZSgpXSk7CiAgICAgICAgIENSQVNIKCk7CiAgICAgfQog fQpAQCAtMzE4LDYgKzMxOCw3IEBAIGJvb2wgQ29ubmVjdGlvbjo6c2VuZE91dGdvaW5nTWVzc2Fn ZShzdGQ6OnVuaXF1ZV9wdHI8RW5jb2Rlcj4gZW5jb2RlcikKICAgICB9CiAKICAgICBhdXRvIG1l c3NhZ2UgPSBNYWNoTWVzc2FnZTo6Y3JlYXRlKG1lc3NhZ2VTaXplKTsKKyAgICBtZXNzYWdlLT5z ZXRNZXNzYWdlTmFtZSgoX19icmlkZ2UgQ0ZTdHJpbmdSZWYpW05TU3RyaW5nIHN0cmluZ1dpdGhG b3JtYXQ6QCIlczolczoiLCBlbmNvZGVyLT5tZXNzYWdlUmVjZWl2ZXJOYW1lKCkudG9TdHJpbmco KS5kYXRhKCksIGVuY29kZXItPm1lc3NhZ2VOYW1lKCkudG9TdHJpbmcoKS5kYXRhKCldKTsKIAog ICAgIGJvb2wgaXNDb21wbGV4ID0gKG51bWJlck9mUG9ydERlc2NyaXB0b3JzICsgbnVtYmVyT2ZP T0xNZW1vcnlEZXNjcmlwdG9ycykgPiAwOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9Q bGF0Zm9ybS9JUEMvbWFjL01hY2hNZXNzYWdlLmggYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9J UEMvbWFjL01hY2hNZXNzYWdlLmgKaW5kZXggNGMzODRmYzNiMGNhNWZkMTVmZWU1MWRlZDY2NGFh MjYxY2M5MmQ0ZS4uMWRlNjZmNjYwMzk1NGIzMTBjZTFmZWRhNDQ1ZGY4NjYzOWUwOTI1YSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vSVBDL21hYy9NYWNoTWVzc2FnZS5oCisr KyBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0lQQy9tYWMvTWFjaE1lc3NhZ2UuaApAQCAtMjYs NiArMjYsNyBAQAogI3ByYWdtYSBvbmNlCiAKICNpbmNsdWRlIDxtZW1vcnk+CisjaW5jbHVkZSA8 d3RmL1JldGFpblB0ci5oPgogCiBuYW1lc3BhY2UgSVBDIHsKIApAQCAtNDIsOSArNDMsMTMgQEAg cHVibGljOgogCiAgICAgdm9pZCBsZWFrRGVzY3JpcHRvcnMoKTsKIAorICAgIENGU3RyaW5nUmVm IG1lc3NhZ2VOYW1lKCkgY29uc3QgeyByZXR1cm4gbV9tZXNzYWdlTmFtZS5nZXQoKTsgfQorICAg IHZvaWQgc2V0TWVzc2FnZU5hbWUoQ0ZTdHJpbmdSZWYgbWVzc2FnZU5hbWUpIHsgbV9tZXNzYWdl TmFtZSA9IG1lc3NhZ2VOYW1lOyB9CisKIHByaXZhdGU6CiAgICAgZXhwbGljaXQgTWFjaE1lc3Nh Z2Uoc2l6ZV90KTsKIAorICAgIFJldGFpblB0cjxDRlN0cmluZ1JlZj4gbV9tZXNzYWdlTmFtZTsK ICAgICBzaXplX3QgbV9zaXplOwogICAgIGJvb2wgbV9zaG91bGRGcmVlRGVzY3JpcHRvcnM7CiAg ICAgdWludDhfdCBtX2J1ZmZlclswXTsK