165896 2016-12-15 01:55:02 -0800 [EFL] Disable non-srcdir builds for failing libraries 2016-12-16 05:37:30 -0800 1 1 1 Unclassified WebKit WebKit EFL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hs85.jeong hs85.jeong commit-queue gyuyoung.kim lucas.de.marchi oldest_to_newest 1260104 0 hs85.jeong 2016-12-15 01:55:02 -0800 After update the jhbuild, Some libraries fail to build the library. 1260110 1 297187 hs85.jeong 2016-12-15 02:35:06 -0800 Created attachment 297187 Patch 1260111 2 hs85.jeong 2016-12-15 02:36:16 -0800 [GTK][EFL] Update the JHBuild version. http://trac.webkit.org/changeset/209804 1260429 3 297187 gyuyoung.kim 2016-12-15 17:54:48 -0800 Comment on attachment 297187 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297187&action=review > Tools/ChangeLog:8 > + * efl/jhbuild.modules: Set non srcdir builds to no Is it fine to skip the build of non-src directory modules ? Shouldn't we find proper directory ? 1260444 4 hs85.jeong 2016-12-15 18:14:32 -0800 (In reply to comment #3) > Comment on attachment 297187 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=297187&action=review > > > Tools/ChangeLog:8 > > + * efl/jhbuild.modules: Set non srcdir builds to no > > Is it fine to skip the build of non-src directory modules ? Shouldn't we > find proper directory ? I tested it and it worked fine. If we didn't set the non-src builds to no, 'update-webkitefl-libs' failed to build the libraies. Anyway I will check one more to find the proper directory. 1260456 5 297187 gyuyoung.kim 2016-12-15 18:28:27 -0800 Comment on attachment 297187 Patch Ok, please land it after checking it one more time. 1260571 6 297187 commit-queue 2016-12-16 05:37:26 -0800 Comment on attachment 297187 Patch Clearing flags on attachment: 297187 Committed r209918: <http://trac.webkit.org/changeset/209918> 1260572 7 commit-queue 2016-12-16 05:37:30 -0800 All reviewed patches have been landed. Closing bug. 297187 2016-12-15 02:35:06 -0800 2016-12-16 05:37:26 -0800 Patch bug-165896-20161215193413.patch text/plain 2579 hs85.jeong SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIwOTg1NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDE2LTEyLTE1ICBIdW5zZW9wIEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5n LmNvbT4KKworICAgICAgICBbRUZMXSBEaXNhYmxlIG5vbi1zcmNkaXIgYnVpbGRzIGZvciBmYWls aW5nIGxpYnJhcmllcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTY1ODk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBlZmwvamhidWlsZC5tb2R1bGVzOiBTZXQgbm9uIHNyY2RpciBidWlsZHMgdG8gbm8K KwogMjAxNi0xMi0xNSAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3Jn PgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIyMDg5MDIpIE51bGwgcG9pbnRlciBkZXJlZmVyZW5j ZSBpbiB3a0lzUHVibGljU3VmZml4CkluZGV4OiBUb29scy9lZmwvamhidWlsZC5tb2R1bGVzCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFRvb2xzL2VmbC9qaGJ1aWxkLm1vZHVsZXMJKHJldmlzaW9uIDIwOTg1MSkK KysrIFRvb2xzL2VmbC9qaGJ1aWxkLm1vZHVsZXMJKHdvcmtpbmcgY29weSkKQEAgLTc3LDcgKzc3 LDcgQEAKICAgICA8L2JyYW5jaD4KICAgPC9hdXRvdG9vbHM+CiAKLSAgPGF1dG90b29scyBpZD0i Zm9udHMiCisgIDxhdXRvdG9vbHMgaWQ9ImZvbnRzIiBzdXBwb3J0cy1ub24tc3JjZGlyLWJ1aWxk cz0ibm8iCiAgICAgICAgICAgICAgc2tpcC1hdXRvZ2VuPSJ0cnVlIj4KICAgICA8YnJhbmNoIG1v ZHVsZT0ibXJvYmluc29uL3dlYmtpdGd0ay10ZXN0LWZvbnRzL2FyY2hpdmUvMC4wLjUudGFyLmd6 IiB2ZXJzaW9uPSIwLjAuNSIKICAgICAgICAgICAgIGNoZWNrb3V0ZGlyPSJ3ZWJraXRndGstdGVz dC1mb250cyIKQEAgLTg3LDcgKzg3LDcgQEAKICAgICA8L2JyYW5jaD4KICAgPC9hdXRvdG9vbHM+ CiAKLSAgPGF1dG90b29scyBpZD0iZGljdHMiCisgIDxhdXRvdG9vbHMgaWQ9ImRpY3RzIiBzdXBw b3J0cy1ub24tc3JjZGlyLWJ1aWxkcz0ibm8iCiAgICAgICAgICAgICAgc2tpcC1hdXRvZ2VuPSJ0 cnVlIj4KICAgICA8YnJhbmNoIG1vZHVsZT0ibXJvYmluc29uL3dlYmtpdGd0ay10ZXN0LWRpY3Rz L2FyY2hpdmUvMC4wLjEuemlwIiB2ZXJzaW9uPSIwLjAuMSIKICAgICAgICAgICAgIGNoZWNrb3V0 ZGlyPSJ3ZWJraXRndGstdGVzdC1kaWN0cyIKQEAgLTI3NSwxMyArMjc1LDEzIEBACiAgICAgPC9k ZXBlbmRlbmNpZXM+CiAgIDwvYXV0b3Rvb2xzPgogCi0gIDxhdXRvdG9vbHMgaWQ9ImxpYnVzcnNj dHAiIGF1dG9nZW4tc2g9Ii4vYm9vdHN0cmFwOyAuL2NvbmZpZ3VyZSAtLWRpc2FibGUtd2Fybmlu Z3MtYXMtZXJyb3JzIj4KKyAgPGF1dG90b29scyBpZD0ibGlidXNyc2N0cCIgc3VwcG9ydHMtbm9u LXNyY2Rpci1idWlsZHM9Im5vIiBhdXRvZ2VuLXNoPSIuL2Jvb3RzdHJhcDsgLi9jb25maWd1cmUg LS1kaXNhYmxlLXdhcm5pbmdzLWFzLWVycm9ycyI+CiAgICAgPGJyYW5jaCByZXBvPSJnaXRodWIu Y29tIiBtb2R1bGU9InNjdHBsYWIvdXNyc2N0cC9hcmNoaXZlLzA3OGZmMzI1MmY3MzMyN2UwYWMx MWQ2ZmQ1ZWZmNjIwMTFmNjY0NmUudGFyLmd6IiB2ZXJzaW9uPSIwNzhmZjMyNTJmNzMzMjdlMGFj MTFkNmZkNWVmZjYyMDExZjY2NDZlIiBjaGVja291dGRpcj0ibGlidXNyc2N0cCIKICAgICAgICAg ICAgIGhhc2g9InNoYTI1NjoxNzU5Mzg4ODdkYzc1NTRlMDAwMTUyMDU1YzgxOGJkZDE1ZGQwZTRj Y2M5NGVmOTNlMzhlOWY5NTJlYTgyZWRjIiBzaXplPSI2NDg5MjUiPgogICAgIDwvYnJhbmNoPgog ICA8L2F1dG90b29scz4KIAotICA8YXV0b3Rvb2xzIGlkPSJnc3QtcGx1Z2lucy1vcGVud2VicnRj IiBzdXBwb3J0cy1wYXJhbGxlbC1idWlsZHM9Im5vIiBhdXRvZ2VuLXNoPSIuL2F1dG9nZW4uc2g7 IC4vY29uZmlndXJlIj4KKyAgPGF1dG90b29scyBpZD0iZ3N0LXBsdWdpbnMtb3BlbndlYnJ0YyIg c3VwcG9ydHMtcGFyYWxsZWwtYnVpbGRzPSJubyIgc3VwcG9ydHMtbm9uLXNyY2Rpci1idWlsZHM9 Im5vIiBhdXRvZ2VuLXNoPSIuL2F1dG9nZW4uc2g7IC4vY29uZmlndXJlIj4KICAgICA8ZGVwZW5k ZW5jaWVzPgogICAgICAgPGRlcCBwYWNrYWdlPSJnc3QtcGx1Z2lucy1iYXNlIi8+CiAgICAgICA8 ZGVwIHBhY2thZ2U9ImxpYnVzcnNjdHAiLz4KQEAgLTI5Myw3ICsyOTMsNyBAQAogICAgPC9icmFu Y2g+CiAgIDwvYXV0b3Rvb2xzPgogCi0gIDxhdXRvdG9vbHMgaWQ9ImxpYm5pY2UiPgorICA8YXV0 b3Rvb2xzIGlkPSJsaWJuaWNlIiBzdXBwb3J0cy1ub24tc3JjZGlyLWJ1aWxkcz0ibm8iPgogICAg IDxkZXBlbmRlbmNpZXM+CiAgICAgICA8ZGVwIHBhY2thZ2U9ImdzdHJlYW1lciIvPgogICAgIDwv ZGVwZW5kZW5jaWVzPgo=