165893 2016-12-14 22:09:02 -0800 WebAssembly: test_BuilderJSON.js is broken 2022-02-27 23:31:27 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 165886 163919 1 jfbastien keith_miller jfbastien keith_miller ryanhaddad saam oldest_to_newest 1260054 0 jfbastien 2016-12-14 22:09:02 -0800 Bug #165886 broke it. I started looking into it, but should do this in a separate patch. 1260055 1 297167 jfbastien 2016-12-14 22:09:34 -0800 Created attachment 297167 Partial fix 1260064 2 297170 keith_miller 2016-12-14 22:47:52 -0800 Created attachment 297170 Patch 1260068 3 297170 mark.lam 2016-12-14 22:56:09 -0800 Comment on attachment 297170 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297170&action=review > JSTests/wasm/Builder.js:40 > + case "i32": return Math.round(value) === value && LLB.varint32Min <= value && value <= LLB.varuint32Max; Is the use of LLB.varuint32Max correct for i32? Should it be LLB.varint32Max? 1260141 4 297170 jfbastien 2016-12-15 08:45:33 -0800 Comment on attachment 297170 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297170&action=review Thanks! Looks good. >> JSTests/wasm/Builder.js:40 >> + case "i32": return Math.round(value) === value && LLB.varint32Min <= value && value <= LLB.varuint32Max; > > Is the use of LLB.varuint32Max correct for i32? Should it be LLB.varint32Max? Here we want everything that can be encoded as a 32-bit integer because that's what wasm supports: i32 is sign-agnostic, the operations on some i32 values are sign-aware. We however want to expose this in a convenient manner to JS, so we allow [INT_MIN, UINT_MAX] as the input range. The code below then further restricts inputs which should be positive as needed: the JSON file identifies each opcode's immediate and for e.g. function_index we say "it has to be a positive i32". So this is correct. 1260143 5 297170 msaboff 2016-12-15 08:48:05 -0800 Comment on attachment 297170 Patch r=me 1260145 6 keith_miller 2016-12-15 08:54:16 -0800 Committed r209863: <http://trac.webkit.org/changeset/209863> 1260195 7 ryanhaddad 2016-12-15 12:00:18 -0800 *** Bug 165907 has been marked as a duplicate of this bug. *** 297167 2016-12-14 22:09:34 -0800 2016-12-14 22:47:47 -0800 Partial fix i32.diff text/plain 2330 jfbastien ZGlmZiAtLWdpdCBhL0pTVGVzdHMvd2FzbS9CdWlsZGVyLmpzIGIvSlNUZXN0cy93YXNtL0J1aWxk ZXIuanMKaW5kZXggNzk3YzgyYi4uMWE1M2M2ZCAxMDA2NDQKLS0tIGEvSlNUZXN0cy93YXNtL0J1 aWxkZXIuanMKKysrIGIvSlNUZXN0cy93YXNtL0J1aWxkZXIuanMKQEAgLTI1LDYgKzI1LDcgQEAK IAogaW1wb3J0ICogYXMgYXNzZXJ0IGZyb20gJ2Fzc2VydC5qcyc7CiBpbXBvcnQgKiBhcyBCdWls ZFdlYkFzc2VtYmx5IGZyb20gJ0J1aWxkZXJfV2ViQXNzZW1ibHlCaW5hcnkuanMnOworaW1wb3J0 ICogYXMgTExCIGZyb20gJ0xvd0xldmVsQmluYXJ5LmpzJzsKIGltcG9ydCAqIGFzIFdBU00gZnJv bSAnV0FTTS5qcyc7CiAKIGNvbnN0IF90b0phdmFTY3JpcHROYW1lID0gbmFtZSA9PiB7CkBAIC0z Niw3ICszNyw3IEBAIGNvbnN0IF90b0phdmFTY3JpcHROYW1lID0gbmFtZSA9PiB7CiBjb25zdCBf aXNWYWxpZFZhbHVlID0gKHZhbHVlLCB0eXBlKSA9PiB7CiAgICAgc3dpdGNoICh0eXBlKSB7CiAg ICAgLy8gV2UgYWxsb3cgYm90aCBzaWduZWQgYW5kIHVuc2lnbmVkIG51bWJlcnMuCi0gICAgY2Fz ZSAiaTMyIjogcmV0dXJuIC0oMiAqKiAzMSkgPD0gdmFsdWUgJiYgdmFsdWUgPCAyICoqIDMyOwor ICAgIGNhc2UgImkzMiI6IHJldHVybiB0eXBlb2YodmFsdWUpID09PSAibnVtYmVyIiAmJiBMTEIu dmFyaW50MzJNaW4gPD0gdmFsdWUgJiYgdmFsdWUgPCBMTEIudmFydWludDMyTWF4OwogICAgIGNh c2UgImk2NCI6IHRocm93IG5ldyBFcnJvcihgVW5pbXBsZW1lbnRlZDogdmFsdWUgY2hlY2sgZm9y ICR7dHlwZX1gKTsgLy8gRklYTUUgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE2MzQyMCA2NC1iaXQgdmFsdWVzCiAgICAgY2FzZSAiZjMyIjogcmV0dXJuIHR5cGVvZih2 YWx1ZSkgPT09ICJudW1iZXIiICYmIGlzRmluaXRlKHZhbHVlKTsKICAgICBjYXNlICJmNjQiOiBy ZXR1cm4gdHlwZW9mKHZhbHVlKSA9PT0gIm51bWJlciIgJiYgaXNGaW5pdGUodmFsdWUpOwpAQCAt Mjc5LDcgKzI4MCw3IEBAIGNvbnN0IF9jaGVja0ltbXMgPSAob3AsIGltbXMsIGV4cGVjdGVkSW1t cywgcmV0KSA9PiB7CiAgICAgICAgIGNvbnN0IGV4cGVjdCA9IGV4cGVjdGVkSW1tc1tpZHhdOwog ICAgICAgICBzd2l0Y2ggKGV4cGVjdC5uYW1lKSB7CiAgICAgICAgIGNhc2UgImZ1bmN0aW9uX2lu ZGV4IjoKLSAgICAgICAgICAgIGFzc2VydC50cnV0aHkoX2lzVmFsaWRWYWx1ZShnb3QsICJpMzIi KSwgYEludmFsaWQgdmFsdWUgb24gJHtvcH06IGdvdCAiJHtnb3R9IiwgZXhwZWN0ZWQgaTMyYCk7 CisgICAgICAgICAgICBhc3NlcnQudHJ1dGh5KF9pc1ZhbGlkVmFsdWUoZ290LCAiaTMyIikgJiYg Z290ID49IDAsIGBJbnZhbGlkIHZhbHVlIG9uICR7b3B9OiBnb3QgIiR7Z290fSIsIGV4cGVjdGVk IHBvc2l0aXZlIGkzMmApOwogICAgICAgICAgICAgLy8gRklYTUUgY2hlY2sgZnVuY3Rpb24gaW5k aWNlcy4gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MzQyMQogICAg ICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNhc2UgImxvY2FsX2luZGV4IjogYnJlYWs7IC8vIGlt cHJvdmUgY2hlY2tpbmcgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2 MzQyMQpkaWZmIC0tZ2l0IGEvSlNUZXN0cy93YXNtL3NlbGYtdGVzdC90ZXN0X0J1aWxkZXJKU09O LmpzIGIvSlNUZXN0cy93YXNtL3NlbGYtdGVzdC90ZXN0X0J1aWxkZXJKU09OLmpzCmluZGV4IGQx YzBjYTYuLjM2Mjc3NjMgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvd2FzbS9zZWxmLXRlc3QvdGVzdF9C dWlsZGVySlNPTi5qcworKysgYi9KU1Rlc3RzL3dhc20vc2VsZi10ZXN0L3Rlc3RfQnVpbGRlckpT T04uanMKQEAgLTQ4Miw3ICs0ODIsNyBAQCBjb25zdCBhc3NlcnRPcFRocm93cyA9IChvcEZuLCBt ZXNzYWdlKSA9PiB7CiAKIChmdW5jdGlvbiBDYWxsSW52YWxpZCgpIHsKICAgICBmb3IgKGxldCBj IG9mIFstMSwgMHgxMDAwMDAwMDAsICIwIiwge30sIEluZmluaXR5LCAtSW5maW5pdHksIE5hTiwg LU5hTiwgbnVsbF0pCi0gICAgICAgIGFzc2VydE9wVGhyb3dzKGYgPT4gZi5DYWxsKGMpLCBgRXhw ZWN0ZWQgdHJ1dGh5OiBJbnZhbGlkIHZhbHVlIG9uIGNhbGw6IGdvdCAiJHtjfSIsIGV4cGVjdGVk IGkzMmApOworICAgICAgICBhc3NlcnRPcFRocm93cyhmID0+IGYuQ2FsbChjKSwgYEV4cGVjdGVk IHRydXRoeTogSW52YWxpZCB2YWx1ZSBvbiBjYWxsOiBnb3QgIiR7Y30iLCBleHBlY3RlZCBwb3Np dGl2ZSBpMzJgKTsKIH0pKCk7CiAKIChmdW5jdGlvbiBJMzJDb25zdFZhbGlkKCkgewo= 297170 2016-12-14 22:47:52 -0800 2022-02-27 23:31:27 -0800 Patch bug-165893-20161214224701.patch text/plain 3936 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjA5ODUzCmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxv ZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDk3NTQ2YTNmZTFmMmFiNWFmNjA5MGM2OTcxMDY5 NTY1YzUyNDdkNGEuLjY0Mjc3NTE1YjQzYTI4OGRmNmU5NzYyY2NjOTZlYzQ1YzVlOTNkM2IgMTAw NjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDUgKzEsMTYgQEAKIDIwMTYtMTItMTQgIEtlaXRoIE1pbGxlciAgPGtlaXRoX21pbGxlckBhcHBs ZS5jb20+CiAKKyAgICAgICAgV2ViQXNzZW1ibHk6IHRlc3RfQnVpbGRlckpTT04uanMgaXMgYnJv a2VuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjU4 OTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHdh c20vQnVpbGRlci5qczoKKyAgICAgICAgKGNvbnN0Ll9pc1ZhbGlkVmFsdWUpOgorICAgICAgICAq IHdhc20vc2VsZi10ZXN0L3Rlc3RfQnVpbGRlckpTT04uanM6CisKKzIwMTYtMTItMTQgIEtlaXRo IE1pbGxlciAgPGtlaXRoX21pbGxlckBhcHBsZS5jb20+CisKICAgICAgICAgVW5yZXZpZXdlZCwg Zml4IHRlc3QuCiAKICAgICAgICAgKiB3YXNtL2Z1bmN0aW9uLXRlc3RzL2kzMi1jb25zdC5qczoK ZGlmZiAtLWdpdCBhL0pTVGVzdHMvd2FzbS9CdWlsZGVyLmpzIGIvSlNUZXN0cy93YXNtL0J1aWxk ZXIuanMKaW5kZXggNzk3YzgyYjNiNjNmNTQ1NzZjNjAxMTA1MmJhNzdhYzI3YzBlOWY5YS4uZGE1 ODRjNDMyYWFjZTM2YmRjZmRhNDIxMjMyMTI1ZmMwNDljMWM1ZiAxMDA2NDQKLS0tIGEvSlNUZXN0 cy93YXNtL0J1aWxkZXIuanMKKysrIGIvSlNUZXN0cy93YXNtL0J1aWxkZXIuanMKQEAgLTI1LDYg KzI1LDcgQEAKIAogaW1wb3J0ICogYXMgYXNzZXJ0IGZyb20gJ2Fzc2VydC5qcyc7CiBpbXBvcnQg KiBhcyBCdWlsZFdlYkFzc2VtYmx5IGZyb20gJ0J1aWxkZXJfV2ViQXNzZW1ibHlCaW5hcnkuanMn OworaW1wb3J0ICogYXMgTExCIGZyb20gJ0xvd0xldmVsQmluYXJ5LmpzJzsKIGltcG9ydCAqIGFz IFdBU00gZnJvbSAnV0FTTS5qcyc7CiAKIGNvbnN0IF90b0phdmFTY3JpcHROYW1lID0gbmFtZSA9 PiB7CkBAIC0zNiw3ICszNyw3IEBAIGNvbnN0IF90b0phdmFTY3JpcHROYW1lID0gbmFtZSA9PiB7 CiBjb25zdCBfaXNWYWxpZFZhbHVlID0gKHZhbHVlLCB0eXBlKSA9PiB7CiAgICAgc3dpdGNoICh0 eXBlKSB7CiAgICAgLy8gV2UgYWxsb3cgYm90aCBzaWduZWQgYW5kIHVuc2lnbmVkIG51bWJlcnMu Ci0gICAgY2FzZSAiaTMyIjogcmV0dXJuIC0oMiAqKiAzMSkgPD0gdmFsdWUgJiYgdmFsdWUgPCAy ICoqIDMyOworICAgIGNhc2UgImkzMiI6IHJldHVybiBNYXRoLnJvdW5kKHZhbHVlKSA9PT0gdmFs dWUgJiYgTExCLnZhcmludDMyTWluIDw9IHZhbHVlICYmIHZhbHVlIDw9IExMQi52YXJ1aW50MzJN YXg7CiAgICAgY2FzZSAiaTY0IjogdGhyb3cgbmV3IEVycm9yKGBVbmltcGxlbWVudGVkOiB2YWx1 ZSBjaGVjayBmb3IgJHt0eXBlfWApOyAvLyBGSVhNRSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTYzNDIwIDY0LWJpdCB2YWx1ZXMKICAgICBjYXNlICJmMzIiOiByZXR1 cm4gdHlwZW9mKHZhbHVlKSA9PT0gIm51bWJlciIgJiYgaXNGaW5pdGUodmFsdWUpOwogICAgIGNh c2UgImY2NCI6IHJldHVybiB0eXBlb2YodmFsdWUpID09PSAibnVtYmVyIiAmJiBpc0Zpbml0ZSh2 YWx1ZSk7CkBAIC0yNzksNyArMjgwLDcgQEAgY29uc3QgX2NoZWNrSW1tcyA9IChvcCwgaW1tcywg ZXhwZWN0ZWRJbW1zLCByZXQpID0+IHsKICAgICAgICAgY29uc3QgZXhwZWN0ID0gZXhwZWN0ZWRJ bW1zW2lkeF07CiAgICAgICAgIHN3aXRjaCAoZXhwZWN0Lm5hbWUpIHsKICAgICAgICAgY2FzZSAi ZnVuY3Rpb25faW5kZXgiOgotICAgICAgICAgICAgYXNzZXJ0LnRydXRoeShfaXNWYWxpZFZhbHVl KGdvdCwgImkzMiIpLCBgSW52YWxpZCB2YWx1ZSBvbiAke29wfTogZ290ICIke2dvdH0iLCBleHBl Y3RlZCBpMzJgKTsKKyAgICAgICAgICAgIGFzc2VydC50cnV0aHkoX2lzVmFsaWRWYWx1ZShnb3Qs ICJpMzIiKSAmJiBnb3QgPj0gMCwgYEludmFsaWQgdmFsdWUgb24gJHtvcH06IGdvdCAiJHtnb3R9 IiwgZXhwZWN0ZWQgbm9uLW5lZ2F0aXZlIGkzMmApOwogICAgICAgICAgICAgLy8gRklYTUUgY2hl Y2sgZnVuY3Rpb24gaW5kaWNlcy4gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE2MzQyMQogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNhc2UgImxvY2FsX2luZGV4 IjogYnJlYWs7IC8vIGltcHJvdmUgY2hlY2tpbmcgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE2MzQyMQpkaWZmIC0tZ2l0IGEvSlNUZXN0cy93YXNtL3NlbGYtdGVzdC90 ZXN0X0J1aWxkZXJKU09OLmpzIGIvSlNUZXN0cy93YXNtL3NlbGYtdGVzdC90ZXN0X0J1aWxkZXJK U09OLmpzCmluZGV4IGQxYzBjYTZmMDMwY2VhZDQ2MTgzYzAwYzg5MmNlYWU4YTRjN2IxZmMuLjE3 ZGIyNjNiNTZhY2JmMDBkYmYzNjI3ODU4Nzc5MDViNDBjZWNlOTUgMTAwNjQ0Ci0tLSBhL0pTVGVz dHMvd2FzbS9zZWxmLXRlc3QvdGVzdF9CdWlsZGVySlNPTi5qcworKysgYi9KU1Rlc3RzL3dhc20v c2VsZi10ZXN0L3Rlc3RfQnVpbGRlckpTT04uanMKQEAgLTQ4MiwxMSArNDgyLDExIEBAIGNvbnN0 IGFzc2VydE9wVGhyb3dzID0gKG9wRm4sIG1lc3NhZ2UpID0+IHsKIAogKGZ1bmN0aW9uIENhbGxJ bnZhbGlkKCkgewogICAgIGZvciAobGV0IGMgb2YgWy0xLCAweDEwMDAwMDAwMCwgIjAiLCB7fSwg SW5maW5pdHksIC1JbmZpbml0eSwgTmFOLCAtTmFOLCBudWxsXSkKLSAgICAgICAgYXNzZXJ0T3BU aHJvd3MoZiA9PiBmLkNhbGwoYyksIGBFeHBlY3RlZCB0cnV0aHk6IEludmFsaWQgdmFsdWUgb24g Y2FsbDogZ290ICIke2N9IiwgZXhwZWN0ZWQgaTMyYCk7CisgICAgICAgIGFzc2VydE9wVGhyb3dz KGYgPT4gZi5DYWxsKGMpLCBgRXhwZWN0ZWQgdHJ1dGh5OiBJbnZhbGlkIHZhbHVlIG9uIGNhbGw6 IGdvdCAiJHtjfSIsIGV4cGVjdGVkIG5vbi1uZWdhdGl2ZSBpMzJgKTsKIH0pKCk7CiAKIChmdW5j dGlvbiBJMzJDb25zdFZhbGlkKCkgewotICAgIGZvciAobGV0IGMgb2YgWzAsIDEsIDIsIDQyLCAx MzM3LCAweEZGLCAweEZGRkYsIDB4N0ZGRkZGRkYsIDB4RkZGRkZGRkUsIDB4RkZGRkZGRkZdKSB7 CisgICAgZm9yIChsZXQgYyBvZiBbLTEwMCwgLTEsIDAsIDEsIDIsIDQyLCAxMzM3LCAweEZGLCAw eEZGRkYsIDB4N0ZGRkZGRkYsIDB4RkZGRkZGRkUsIDB4RkZGRkZGRkZdKSB7CiAgICAgICAgIGNv bnN0IGIgPSAobmV3IEJ1aWxkZXIoKSkuVHlwZSgpLkVuZCgpLkNvZGUoKS5GdW5jdGlvbigpLkkz MkNvbnN0KGMpLlJldHVybigpLkVuZCgpLkVuZCgpOwogICAgICAgICBjb25zdCBqID0gSlNPTi5w YXJzZShiLmpzb24oKSk7CiAgICAgICAgIGFzc2VydC5lcShqLnNlY3Rpb25bMV0uZGF0YVswXS5j b2RlWzBdLm5hbWUsICJpMzIuY29uc3QiKTsKQEAgLTQ5Nyw3ICs0OTcsNyBAQCBjb25zdCBhc3Nl cnRPcFRocm93cyA9IChvcEZuLCBtZXNzYWdlKSA9PiB7CiB9KSgpOwogCiAoZnVuY3Rpb24gSTMy Q29uc3RJbnZhbGlkKCkgewotICAgIGZvciAobGV0IGMgb2YgWy0xLCAweDEwMDAwMDAwMCwgMC4x LCAtMC4xLCAiMCIsIHt9LCBJbmZpbml0eSwgbnVsbF0pCisgICAgZm9yIChsZXQgYyBvZiBbMHgx MDAwMDAwMDAsIDAuMSwgLTAuMSwgIjAiLCB7fSwgSW5maW5pdHksIG51bGxdKQogICAgICAgICBh c3NlcnRPcFRocm93cyhmID0+IGYuSTMyQ29uc3QoYyksIGBFeHBlY3RlZCB0cnV0aHk6IEludmFs aWQgdmFsdWUgb24gaTMyLmNvbnN0OiBnb3QgIiR7Y30iLCBleHBlY3RlZCBpMzJgKTsKIH0pKCk7 CiAK