165872 2016-12-14 14:42:53 -0800 REGRESSION (204679): Google notifications never load (expecting DOMStringList rather than JS array for Location.ancestorOrigins) 2016-12-14 16:04:36 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sam sam cdumez commit-queue esprehn+autocc kondapallykalyan oldest_to_newest 1259911 0 sam 2016-12-14 14:42:53 -0800 REGRESSION (204679): Google notifications never load (expecting DOMStringList rather than JS array for Location.ancestorOrigins) 1259912 1 sam 2016-12-14 14:44:29 -0800 Chris file https://github.com/whatwg/html/issues/2179 to track this on the spec side. Since Chrome is still returning a DOMStringList, and this is breaking the front page of Google, we should revert the Location.ancestorOrigins change from r204679. 1259913 2 sam 2016-12-14 14:44:44 -0800 <rdar://problem/29573563> 1259914 3 297128 sam 2016-12-14 14:48:21 -0800 Created attachment 297128 Patch 1259924 4 297128 cdumez 2016-12-14 15:07:21 -0800 Comment on attachment 297128 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297128&action=review r=me > Source/WebCore/page/Location.idl:61 > + // FIXME: This should return a FixedArray<DOMString> and should use SameObject. FixedArray? Did you mean FrozenArray? I believe the spec will be reverted to DOMStringList as per comment on the spec bug so we may not need to update this comment at all. 1259952 5 sam 2016-12-14 16:04:36 -0800 Committed r209841: <http://trac.webkit.org/changeset/209841> 297128 2016-12-14 14:48:21 -0800 2016-12-14 15:07:21 -0800 Patch bug-165872-20161214144730.patch text/plain 6931 sam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwOTgzNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDE2LTEyLTE0ICBTYW0gV2Vp bmlnICA8c2FtQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTiAoMjA0Njc5KTogR29v Z2xlIG5vdGlmaWNhdGlvbnMgbmV2ZXIgbG9hZCAoZXhwZWN0aW5nIERPTVN0cmluZ0xpc3QgcmF0 aGVyIHRoYW4gSlMgYXJyYXkgZm9yIExvY2F0aW9uLmFuY2VzdG9yT3JpZ2lucykKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzI5NTczNTYzPgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTY1ODcyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgUmV2ZXJ0IHRoZSBMb2NhdGlvbi5hbmNlc3Rvck9yaWdpbnMgcGFy dCBvZiByMjA0Njc5IGJlY2F1c2UgZ29vZ2xlLmNvbSBpcyByZWx5aW5nIG9uCisgICAgICAgIGl0 IHJldHVybmluZyBhIERPTVN0cmluZ0xpc3QgKG9yIGF0IGxlYXN0IHNvbWV0aGluZyB3aXRoIGEg Lml0ZW0oKSBmdW5jdGlvbiksIHJhdGhlcgorICAgICAgICB0aGFuIGEgZnJvemVuIGphdmFzY3Jp cHQgYXJyYXkuCisgICAgICAgIAorICAgICAgICBTcGVjIGNoYW5nZXMgYXJlIHRyYWNrZWQgd2l0 aCBodHRwczovL2dpdGh1Yi5jb20vd2hhdHdnL2h0bWwvaXNzdWVzLzIxNzkuCisKKyAgICAgICAg KiBwYWdlL0xvY2F0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxvY2F0aW9uOjphbmNlc3Rv ck9yaWdpbnMpOgorICAgICAgICAqIHBhZ2UvTG9jYXRpb24uaDoKKyAgICAgICAgKiBwYWdlL0xv Y2F0aW9uLmlkbDoKKyAgICAgICAgQ2hhbmdlIExvY2F0aW9uLmFuY2VzdG9yT3JpZ2lucyBiYWNr IHRvIHJldHVybmluZyBhIERPTVN0cmluZ0xpc3QuCisKIDIwMTYtMTItMTQgIERhdmUgSHlhdHQg IDxoeWF0dEBhcHBsZS5jb20+CiAKICAgICAgICAgW0NTUyBQYXJzZXJdIE1ha2UgZGVmZXJyZWQg cGFyc2luZyByZXRhaW4gdGhlIHNoZWV0IHRleHQuIEZpeCBpbnZhbGlkYXRpb24gdG8gYXZvaWQg ZGVmZXJyZWQgcGFyc2luZy4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2UvTG9jYXRpb24uY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2UvTG9jYXRpb24uY3BwCShyZXZpc2lv biAyMDk4MzApCisrKyBTb3VyY2UvV2ViQ29yZS9wYWdlL0xvY2F0aW9uLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMTMxLDEzICsxMzEsMTMgQEAgU3RyaW5nIExvY2F0aW9uOjpvcmlnaW4oKSBjb25z dAogICAgIHJldHVybiBTZWN1cml0eU9yaWdpbjo6Y3JlYXRlKHVybCgpKS0+dG9TdHJpbmcoKTsK IH0KIAotVmVjdG9yPFN0cmluZz4gTG9jYXRpb246OmFuY2VzdG9yT3JpZ2lucygpIGNvbnN0CitS ZWY8RE9NU3RyaW5nTGlzdD4gTG9jYXRpb246OmFuY2VzdG9yT3JpZ2lucygpIGNvbnN0CiB7Ci0g ICAgVmVjdG9yPFN0cmluZz4gb3JpZ2luczsKKyAgICBhdXRvIG9yaWdpbnMgPSBET01TdHJpbmdM aXN0OjpjcmVhdGUoKTsKICAgICBpZiAoIW1fZnJhbWUpCiAgICAgICAgIHJldHVybiBvcmlnaW5z OwogICAgIGZvciAoRnJhbWUqIGZyYW1lID0gbV9mcmFtZS0+dHJlZSgpLnBhcmVudCgpOyBmcmFt ZTsgZnJhbWUgPSBmcmFtZS0+dHJlZSgpLnBhcmVudCgpKQotICAgICAgICBvcmlnaW5zLmFwcGVu ZChmcmFtZS0+ZG9jdW1lbnQoKS0+c2VjdXJpdHlPcmlnaW4oKS0+dG9TdHJpbmcoKSk7CisgICAg ICAgIG9yaWdpbnMtPmFwcGVuZChmcmFtZS0+ZG9jdW1lbnQoKS0+c2VjdXJpdHlPcmlnaW4oKS0+ dG9TdHJpbmcoKSk7CiAgICAgcmV0dXJuIG9yaWdpbnM7CiB9CiAKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL3BhZ2UvTG9jYXRpb24uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wYWdlL0xv Y2F0aW9uLmgJKHJldmlzaW9uIDIwOTgzMCkKKysrIFNvdXJjZS9XZWJDb3JlL3BhZ2UvTG9jYXRp b24uaAkod29ya2luZyBjb3B5KQpAQCAtNjgsNyArNjgsNyBAQCBwdWJsaWM6CiAKICAgICBTdHJp bmcgdG9TdHJpbmcoKSBjb25zdCB7IHJldHVybiBocmVmKCk7IH0KIAotICAgIFZlY3RvcjxTdHJp bmc+IGFuY2VzdG9yT3JpZ2lucygpIGNvbnN0OworICAgIFJlZjxET01TdHJpbmdMaXN0PiBhbmNl c3Rvck9yaWdpbnMoKSBjb25zdDsKIAogcHJpdmF0ZToKICAgICBleHBsaWNpdCBMb2NhdGlvbihG cmFtZSopOwpJbmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9Mb2NhdGlvbi5pZGwKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvcGFnZS9Mb2NhdGlvbi5pZGwJKHJldmlzaW9uIDIwOTgzMCkK KysrIFNvdXJjZS9XZWJDb3JlL3BhZ2UvTG9jYXRpb24uaWRsCSh3b3JraW5nIGNvcHkpCkBAIC01 OCw2ICs1OCw2IEBACiAKICAgICByZWFkb25seSBhdHRyaWJ1dGUgVVNWU3RyaW5nIG9yaWdpbjsK IAotICAgIC8vIEZJWE1FOiBBZGQgc3VwcG9ydCBmb3IgU2FtZU9iamVjdAotICAgIFtVbmZvcmdl YWJsZSwgQ2FjaGVkQXR0cmlidXRlXSByZWFkb25seSBhdHRyaWJ1dGUgRnJvemVuQXJyYXk8VVNW U3RyaW5nPiBhbmNlc3Rvck9yaWdpbnM7CisgICAgLy8gRklYTUU6IFRoaXMgc2hvdWxkIHJldHVy biBhIEZpeGVkQXJyYXk8RE9NU3RyaW5nPiBhbmQgc2hvdWxkIHVzZSBTYW1lT2JqZWN0LgorICAg IFtVbmZvcmdlYWJsZSwgQ2FjaGVkQXR0cmlidXRlXSByZWFkb25seSBhdHRyaWJ1dGUgRE9NU3Ry aW5nTGlzdCBhbmNlc3Rvck9yaWdpbnM7CiB9OwpJbmRleDogU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwkocmV2aXNpb24gMjA5 ODMwKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTMgQEAKKzIwMTYtMTItMDQgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KKworICAg ICAgICBbV2ViSURMXSBBZGQgc3VwcG9ydCBmb3IgY29udmVydGluZyBkaWN0aW9uYXJpZXMgdG8g SlMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NTM2 NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQ01h a2VMaXN0cy50eHQ6CisgICAgICAgIEFkZCBtaXNzaW5nIGRpcmVjdG9yaWVzIHRvIGxvb2sgaW4g Zm9yIGhlYWRlcnMuCisKIDIwMTYtMTItMTQgIERhdmUgSHlhdHQgIDxoeWF0dEBhcHBsZS5jb20+ CiAKICAgICAgICAgW0NTUyBQYXJzZXJdIEltcGxlbWVudCBkZWZlcnJlZCBwYXJzaW5nIG9mIHBy b3BlcnRpZXMsIEBtZWRpYSwgQHN1cHBvcnRzIGFuZCBAa2V5ZnJhbWVzCkluZGV4OiBMYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZp c2lvbiAyMDk4MzUpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAg LTEsMyArMSwxNSBAQAorMjAxNi0xMi0xNCAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgor CisgICAgICAgIFJFR1JFU1NJT04gKDIwNDY3OSk6IEdvb2dsZSBub3RpZmljYXRpb25zIG5ldmVy IGxvYWQgKGV4cGVjdGluZyBET01TdHJpbmdMaXN0IHJhdGhlciB0aGFuIEpTIGFycmF5IGZvciBM b2NhdGlvbi5hbmNlc3Rvck9yaWdpbnMpCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yOTU3MzU2 Mz4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NTg3 MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFz dC9kb20vV2luZG93L0xvY2F0aW9uL2FuY2VzdG9yLW9yaWdpbnMtZXhwZWN0ZWQudHh0OgorICAg ICAgICAqIGZhc3QvZG9tL1dpbmRvdy9Mb2NhdGlvbi9hbmNlc3Rvci1vcmlnaW5zLmh0bWw6Cisg ICAgICAgIENoYW5nZSBiYWNrIHRvIHRlc3QgdGhhdCBMb2NhdGlvbi5hbmNlc3Rvck9yaWdpbnMg cmV0dXJucyBhIERPTVN0cmluZ0xpc3QuCisKIDIwMTYtMTItMTQgIFJ5b3N1a2UgTml3YSAgPHJu aXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgaU9TOiBBbiBlbGVtZW50IHdpdGggdGFiaW5kZXgg aXMgbm90IGZvY3VzYWJsZSB1bmxlc3MgdGhlcmUgaXMgbm8gbW91c2UgZXZlbnQgaGFuZGxlcgpJ bmRleDogTGF5b3V0VGVzdHMvZmFzdC9kb20vV2luZG93L0xvY2F0aW9uL2FuY2VzdG9yLW9yaWdp bnMtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL1dpbmRv dy9Mb2NhdGlvbi9hbmNlc3Rvci1vcmlnaW5zLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMjA5ODMw KQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vV2luZG93L0xvY2F0aW9uL2FuY2VzdG9yLW9yaWdp bnMtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0zLDExICszLDkgQEAgVGVzdCB0aGUg TG9jYXRpb24gb2JqZWN0J3MgYW5jZXN0b3JPcmlnaQogT24gc3VjY2VzcywgeW91IHdpbGwgc2Vl IGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUi LgogCiAKLVBBU1Mgd2luZG93LmxvY2F0aW9uLmFuY2VzdG9yT3JpZ2lucyBpcyBhbiBpbnN0YW5j ZSBvZiBBcnJheQorUEFTUyB3aW5kb3cubG9jYXRpb24uYW5jZXN0b3JPcmlnaW5zIGlzIGFuIGlu c3RhbmNlIG9mIERPTVN0cmluZ0xpc3QKIFBBU1Mgd2luZG93LmxvY2F0aW9uLmFuY2VzdG9yT3Jp Z2lucy5sZW5ndGggaXMgMAotUEFTUyBPYmplY3QuaXNGcm96ZW4od2luZG93LmxvY2F0aW9uLmFu Y2VzdG9yT3JpZ2lucykgaXMgdHJ1ZQogUEFTUyB3aW5kb3cubG9jYXRpb24uYW5jZXN0b3JPcmln aW5zID09PSB3aW5kb3cubG9jYXRpb24uYW5jZXN0b3JPcmlnaW5zIGlzIHRydWUKLVBBU1Mgc3Vi ZnJhbWVPcmlnaW5zIGlzIGFuIGluc3RhbmNlIG9mIEFycmF5CiBQQVNTIHN1YmZyYW1lT3JpZ2lu cy5sZW5ndGggaXMgMQogUEFTUyBzdWJmcmFtZU9yaWdpbnNbMF0gaXMgJ2ZpbGU6Ly8nCiBQQVNT IHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9X aW5kb3cvTG9jYXRpb24vYW5jZXN0b3Itb3JpZ2lucy5odG1sCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91 dFRlc3RzL2Zhc3QvZG9tL1dpbmRvdy9Mb2NhdGlvbi9hbmNlc3Rvci1vcmlnaW5zLmh0bWwJKHJl dmlzaW9uIDIwOTgzMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZG9tL1dpbmRvdy9Mb2NhdGlvbi9h bmNlc3Rvci1vcmlnaW5zLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTksOSArOSw4IEBAIHNlbGYu anNUZXN0SXNBc3luYyA9IHRydWU7CiAKIGRlc2NyaXB0aW9uKCJUZXN0IHRoZSBMb2NhdGlvbiBv YmplY3QncyBhbmNlc3Rvck9yaWdpbnMgcHJvcGVydHkuIikKIAotc2hvdWxkQmVUeXBlKCJ3aW5k b3cubG9jYXRpb24uYW5jZXN0b3JPcmlnaW5zIiwgIkFycmF5Iik7CitzaG91bGRCZVR5cGUoIndp bmRvdy5sb2NhdGlvbi5hbmNlc3Rvck9yaWdpbnMiLCAiRE9NU3RyaW5nTGlzdCIpOwogc2hvdWxk QmUoIndpbmRvdy5sb2NhdGlvbi5hbmNlc3Rvck9yaWdpbnMubGVuZ3RoIiwgIjAiKTsKLXNob3Vs ZEJlVHJ1ZSgiT2JqZWN0LmlzRnJvemVuKHdpbmRvdy5sb2NhdGlvbi5hbmNlc3Rvck9yaWdpbnMp Iik7CiBzaG91bGRCZVRydWUoIndpbmRvdy5sb2NhdGlvbi5hbmNlc3Rvck9yaWdpbnMgPT09IHdp bmRvdy5sb2NhdGlvbi5hbmNlc3Rvck9yaWdpbnMiKTsKIAogdmFyIHN1YmZyYW1lT3JpZ2luczsK QEAgLTIwLDcgKzE5LDYgQEAgd2luZG93Lm9ubWVzc2FnZSA9IGZ1bmN0aW9uKGV2ZW50KQogewog ICAgIHN1YmZyYW1lT3JpZ2lucyA9IGV2ZW50LmRhdGE7CiAKLSAgICBzaG91bGRCZVR5cGUoInN1 YmZyYW1lT3JpZ2lucyIsICJBcnJheSIpOwogICAgIHNob3VsZEJlKCJzdWJmcmFtZU9yaWdpbnMu bGVuZ3RoIiwgIjEiKTsKICAgICBzaG91bGRCZSgic3ViZnJhbWVPcmlnaW5zWzBdIiwgIidmaWxl Oi8vJyIpOwogCkBAIC0zMCw3ICsyOCwxMSBAQCB3aW5kb3cub25tZXNzYWdlID0gZnVuY3Rpb24o ZXZlbnQpCiA8L3NjcmlwdD4KIDxpZnJhbWUgc3JjZG9jPSIKICAgPHNjcmlwdD4KLSAgICB0b3Au cG9zdE1lc3NhZ2UobG9jYXRpb24uYW5jZXN0b3JPcmlnaW5zLCAnKicpCisgICAgdmFyIG9yaWdp bnMgPSBbXTsKKyAgICBmb3IgKHZhciBpID0gMDsgaSA8IGxvY2F0aW9uLmFuY2VzdG9yT3JpZ2lu cy5sZW5ndGg7ICsraSkgeworICAgICAgICBvcmlnaW5zLnB1c2gobG9jYXRpb24uYW5jZXN0b3JP cmlnaW5zLml0ZW0oaSkpOworICAgIH0KKyAgICB0b3AucG9zdE1lc3NhZ2Uob3JpZ2lucywgJyon KQogICA8L3NjcmlwdD4KICI+PC9pZnJhbWU+CiA8c2NyaXB0IHNyYz0iLi4vLi4vLi4vLi4vcmVz b3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cg==