165869 2016-12-14 14:21:35 -0800 [CSS Parser] Enable CSS Deferred Parsing 2016-12-19 16:06:50 -0800 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified REOPENED P2 Normal --- 1 hyatt hyatt barraclough commit-queue oldest_to_newest 1259903 0 hyatt 2016-12-14 14:21:35 -0800 This bug is tracking turning on CSS deferred parsing by default. I'm going to post some performance numbers to make it clear what a win it is. 1259918 1 hyatt 2016-12-14 14:53:27 -0800 Some #s. All are done on reloads of the page to ensure all stylesheets reparse. 10 loads done of each site with deferred parsing on and off and average taken. 40% reduction on apple.com 25% reduction on twitter.com (logged in with a feed) 25% reduction on facebook.com (logged in, my account) 30% reduction on cnn.com The gain is anywhere from 5-15ms for each page in the examples above. Parsing doesn't take all that long on most pages, but even so, this is a huge improvement. 1259935 2 297136 hyatt 2016-12-14 15:25:18 -0800 Created attachment 297136 Patch 1259956 3 297136 sam 2016-12-14 16:11:26 -0800 Comment on attachment 297136 Patch Nice nice! 1260135 4 297136 commit-queue 2016-12-15 07:46:49 -0800 Comment on attachment 297136 Patch Clearing flags on attachment: 297136 Committed r209862: <http://trac.webkit.org/changeset/209862> 1260136 5 commit-queue 2016-12-15 07:46:53 -0800 All reviewed patches have been landed. Closing bug. 1261255 6 barraclough 2016-12-19 16:06:50 -0800 Reverted in r209997 due to performance regressions. 297136 2016-12-14 15:25:18 -0800 2016-12-15 07:46:49 -0800 Patch bug-165869-20161214172426.patch text/plain 4327 hyatt SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwOTgzOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMzIEBACisyMDE2LTEyLTE0ICBEYXZlIEh5 YXR0ICA8aHlhdHRAYXBwbGUuY29tPgorCisgICAgICAgIFtDU1MgUGFyc2VyXSBFbmFibGUgQ1NT IERlZmVycmVkIFBhcnNpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE2NTg2OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEVuYWJsZSBDU1MgZGVmZXJyZWQgcGFyc2luZyBvbmNlIGFnYWluLiBJdCdzIG5v dyBiZWhpbmQgYSBwcmVmLAorICAgICAgICBzbyBpdCdzIGVhc3kgdG8gZmxpcCBvZmYgYW5kIG9u LgorCisgICAgICAgIFRvIGFkZHJlc3MgdGhlIG1lbW9yeSByZWdyZXNzaW9uIHRoYXQgY2F1c2Vk IHRoZSBwcmV2aW91cyByb2xsb3V0LAorICAgICAgICB0aGUgdG9rZW5pemVyIGlzIG5vIGxvbmdl ciByZXRhaW5lZC4gSW5zdGVhZCB0aGUgc2hlZXQgdGV4dCBhbmQgZXNjYXBlZAorICAgICAgICBz dHJpbmdzIGFyZSByZXRhaW5lZCBieSBDU1NEZWZlcnJlZFBhcnNlciwgYW5kIHRoZW4gRGVmZXJy ZWRTdHlsZVByb3BlcnRpZXMKKyAgICAgICAgYW5kIERlZmVycmVkU3R5bGVHcm91cFJ1bGVMaXN0 IG1ha2UgY29waWVzIG9mIHRoZSB0b2tlbnMgZnJvbSB0aGUgb3JpZ2luYWwKKyAgICAgICAgdG9r ZW5pemF0aW9uIHByb2Nlc3MuIEFzIHRoZSBydWxlcyBnZXQgcGFyc2VkLCB0aGVzZSB0b2tlbnMg Z2V0IHRocm93bgorICAgICAgICBhd2F5LgorCisgICAgICAgIFRoaXMgbWVhbnMgdGhhdCBpbnN0 ZWFkIG9mIHRoZSBlbnRpcmUgc2V0IG9mIHRva2VucyBzdGF5aW5nIGluIG1lbW9yeQorICAgICAg ICBhcyBsb25nIGFzIGV2ZW4gb25lIHVucGFyc2VkIHJ1bGUgcmVtYWluZWQsIG5vdyBvbmx5IHRo ZSB0b2tlbnMgdGhhdAorICAgICAgICBzdGlsbCBuZWVkIHBhcnNpbmcgd2lsbCByZW1haW4gYWxp dmUuCisKKyAgICAgICAgVW5wYXJzZWQgcnVsZXMgd2lsbCBjb25zdW1lIHNsaWdodGx5IG1vcmUg bWVtb3J5IHRoYW4gcGFyc2VkIHJ1bGVzLCBidXQKKyAgICAgICAgdGhlIG1vcmUgdW5wYXJzZWQg cnVsZXMgeW91IGhhdmUsIHRoZSBiaWdnZXIgdGhlIHBlcmZvcm1hbmNlIHdpbiBhcworICAgICAg ICB3ZWxsLCBzbyB0aGlzIGlzIGEgdHJhZGVvZmYuIEdpdmVuIHRoYXQgdGhlIHBhcnNpbmcgc3Bl ZWQgaXMgZ29pbmcgdXAKKyAgICAgICAgYnkgYW55d2hlcmUgZnJvbSAyNS00MCUgb24gY29sZCBs b2FkcyBvZiBwYWdlcyAod2hlcmUgYWxsIHN0eWxlc2hlZXRzCisgICAgICAgIGhhdmUgdG8gcGFy c2UpLCB0aGlzIHNlZW1zIHdvcnRoIGl0IHRvIG1lLgorCisgICAgICAgICogY3NzL3BhcnNlci9D U1NQYXJzZXJNb2RlLmg6CisgICAgICAgICogcGFnZS9TZXR0aW5ncy5pbjoKKwogMjAxNi0xMi0x NCAgRGF2ZSBIeWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KIAogICAgICAgICBbQ1NTIFBhcnNlcl0g UmVuYW1lIFN0eWxlS2V5ZnJhbWUgdG8gU3R5bGVSdWxlS2V5ZnJhbWUKSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL2Nzcy9wYXJzZXIvQ1NTUGFyc2VyTW9kZS5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL2Nzcy9wYXJzZXIvQ1NTUGFyc2VyTW9kZS5oCShyZXZpc2lvbiAyMDk4MjYpCisrKyBT b3VyY2UvV2ViQ29yZS9jc3MvcGFyc2VyL0NTU1BhcnNlck1vZGUuaAkod29ya2luZyBjb3B5KQpA QCAtMTA3LDcgKzEwNyw3IEBAIHB1YmxpYzoKICAgICBib29sIHVzZUxlZ2FjeUJhY2tncm91bmRT aXplU2hvcnRoYW5kQmVoYXZpb3IgeyBmYWxzZSB9OwogICAgIGJvb2wgc3ByaW5nVGltaW5nRnVu Y3Rpb25FbmFibGVkIHsgZmFsc2UgfTsKICAgICAKLSAgICBib29sIGRlZmVycmVkQ1NTUGFyc2Vy RW5hYmxlZCB7IGZhbHNlIH07CisgICAgYm9vbCBkZWZlcnJlZENTU1BhcnNlckVuYWJsZWQgeyB0 cnVlIH07CiAKICAgICBVUkwgY29tcGxldGVVUkwoY29uc3QgU3RyaW5nJiB1cmwpIGNvbnN0CiAg ICAgewpJbmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9TZXR0aW5ncy5pbgo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViQ29yZS9wYWdlL1NldHRpbmdzLmluCShyZXZpc2lvbiAyMDk4MjYpCisrKyBT b3VyY2UvV2ViQ29yZS9wYWdlL1NldHRpbmdzLmluCSh3b3JraW5nIGNvcHkpCkBAIC0yNDksNyAr MjQ5LDcgQEAgYXR0YWNobWVudEVsZW1lbnRFbmFibGVkIGluaXRpYWw9dHJ1ZSwgYwogCiBuZXdC bG9ja0luc2lkZUlubGluZU1vZGVsRW5hYmxlZCBpbml0aWFsPWZhbHNlLCBzZXROZWVkc1N0eWxl UmVjYWxjSW5BbGxGcmFtZXM9MQogCi1kZWZlcnJlZENTU1BhcnNlckVuYWJsZWQgaW5pdGlhbD1m YWxzZQorZGVmZXJyZWRDU1NQYXJzZXJFbmFibGVkIGluaXRpYWw9dHJ1ZQogCiBodHRwRXF1aXZF bmFibGVkIGluaXRpYWw9dHJ1ZQogCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMDk4MzgpCisr KyBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMiBA QAorMjAxNi0xMi0xNCAgRGF2ZSBIeWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KKworICAgICAgICBb Q1NTIFBhcnNlcl0gRW5hYmxlIENTUyBEZWZlcnJlZCBQYXJzaW5nCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjU4NjkKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNoYXJlZC9XZWJQcmVmZXJlbmNlc0Rl ZmluaXRpb25zLmg6CisKIDIwMTYtMTItMTQgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFw cGxlLmNvbT4KIAogICAgICAgICBBZGQgc29tZSBpbnN0cnVtZW50YXRpb24gdG8gdHJ5IHRvIGRl dGVjdCBhIGNyYXNoIG9uIHRoZSBib3RzCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2Vi UHJlZmVyZW5jZXNEZWZpbml0aW9ucy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1No YXJlZC9XZWJQcmVmZXJlbmNlc0RlZmluaXRpb25zLmgJKHJldmlzaW9uIDIwOTgyNikKKysrIFNv dXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJQcmVmZXJlbmNlc0RlZmluaXRpb25zLmgJKHdvcmtpbmcg Y29weSkKQEAgLTIyOSw3ICsyMjksNyBAQAogICAgIG1hY3JvKEVuYWJsZUluaGVyaXRVUklRdWVy eUNvbXBvbmVudCwgZW5hYmxlSW5oZXJpdFVSSVF1ZXJ5Q29tcG9uZW50LCBCb29sLCBib29sLCBm YWxzZSwgIiIsICIiKSBcCiAgICAgbWFjcm8oU2VydmljZUNvbnRyb2xzRW5hYmxlZCwgc2Vydmlj ZUNvbnRyb2xzRW5hYmxlZCwgQm9vbCwgYm9vbCwgZmFsc2UsICIiLCAiIikgXAogICAgIG1hY3Jv KE5ld0Jsb2NrSW5zaWRlSW5saW5lTW9kZWxFbmFibGVkLCBuZXdCbG9ja0luc2lkZUlubGluZU1v ZGVsRW5hYmxlZCwgQm9vbCwgYm9vbCwgZmFsc2UsICIiLCAiIikgXAotICAgIG1hY3JvKERlZmVy cmVkQ1NTUGFyc2VyRW5hYmxlZCwgZGVmZXJyZWRDU1NQYXJzZXJFbmFibGVkLCBCb29sLCBib29s LCBmYWxzZSwgIiIsICIiKSBcCisgICAgbWFjcm8oRGVmZXJyZWRDU1NQYXJzZXJFbmFibGVkLCBk ZWZlcnJlZENTU1BhcnNlckVuYWJsZWQsIEJvb2wsIGJvb2wsIHRydWUsICIiLCAiIikgXAogICAg IG1hY3JvKEhUVFBFcXVpdkVuYWJsZWQsIGh0dHBFcXVpdkVuYWJsZWQsIEJvb2wsIGJvb2wsIHRy dWUsICIiLCAiIikgXAogICAgIG1hY3JvKE1vY2tDYXB0dXJlRGV2aWNlc0VuYWJsZWQsIG1vY2tD YXB0dXJlRGV2aWNlc0VuYWJsZWQsIEJvb2wsIGJvb2wsIGZhbHNlLCAiIiwgIiIpIFwKICAgICBt YWNybyhNZWRpYUNhcHR1cmVSZXF1aXJlc1NlY3VyZUNvbm5lY3Rpb24sIG1lZGlhQ2FwdHVyZVJl cXVpcmVzU2VjdXJlQ29ubmVjdGlvbiwgQm9vbCwgYm9vbCwgdHJ1ZSwgIiIsICIiKSBcCg==