165859 2016-12-14 12:46:38 -0800 Devices with fewer cores should use a more aggressive GC schedule by default 2016-12-14 12:58:17 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1259847 0 fpizlo 2016-12-14 12:46:38 -0800 Patch forthcoming. 1259848 1 297111 fpizlo 2016-12-14 12:48:29 -0800 Created attachment 297111 the patch 1259849 2 commit-queue 2016-12-14 12:51:09 -0800 Attachment 297111 did not pass style-queue: ERROR: Source/JavaScriptCore/heap/Heap.cpp:664: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1259854 3 297111 mark.lam 2016-12-14 12:56:07 -0800 Comment on attachment 297111 the patch r=me 1259859 4 fpizlo 2016-12-14 12:58:17 -0800 Landed in https://trac.webkit.org/changeset/209825 297111 2016-12-14 12:48:29 -0800 2016-12-14 12:56:07 -0800 the patch blah.patch text/plain 5925 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjA5ODIzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDE2LTEyLTE0ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg RGV2aWNlcyB3aXRoIGZld2VyIGNvcmVzIHNob3VsZCB1c2UgYSBtb3JlIGFnZ3Jlc3NpdmUgR0Mg c2NoZWR1bGUgYnkgZGVmYXVsdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTY1ODU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBoZWFwL0hlYXAuY3BwOgorICAgICAgICAoSlNDOjpIZWFwOjptYXJrVG9G aXhwb2ludCk6IExvZyB3aGVuIHdlIGhhdmUgYW4gdW5leHBlY3RlZCBkZWxheSBpbiB3YWtlLXVw LgorICAgICAgICAqIGhlYXAvU2xvdFZpc2l0b3IuY3BwOgorICAgICAgICAoSlNDOjpTbG90Vmlz aXRvcjo6ZHJhaW5JblBhcmFsbGVsUGFzc2l2ZWx5KTogRG9uJ3QgZHJhaW4gcGFzc2l2ZWx5IGlm IHRoZXJlIGFyZW4ndCBtYW55IGNvcmVzLgorICAgICAgICAqIHJ1bnRpbWUvT3B0aW9ucy5jcHA6 CisgICAgICAgIChKU0M6Om92ZXJyaWRlRGVmYXVsdHMpOiBDaGFuZ2UgdGhlIGhldXJpc3RpY3Mg aWYgd2UgaGF2ZSBmZXdlciBjb3Jlcy4KKyAgICAgICAgKEpTQzo6T3B0aW9uczo6aW5pdGlhbGl6 ZSk6CisgICAgICAgICogcnVudGltZS9PcHRpb25zLmg6CisKIDIwMTYtMTItMTQgIE1hcmsgTGFt ICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIEJ5dGVjb2RlQmFzaWNCbG9jazo6Y29t cHV0ZUltcGwoKSBzaG91bGQgbm90IGtlZXAgaXRlcmF0aW5nIGJsb2NrcyBpZiBhbGwganVtcCB0 YXJnZXRzIGhhdmUgYWxyZWFkeSBiZWVuIGZvdW5kLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRD b3JlL2hlYXAvSGVhcC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2hl YXAvSGVhcC5jcHAJKHJldmlzaW9uIDIwOTgxMykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9o ZWFwL0hlYXAuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02NjEsMTYgKzY2MSwyMyBAQCB2b2lkIEhl YXA6Om1hcmtUb0ZpeHBvaW50KGRvdWJsZSBnY1N0YXJ0CiAgICAgICAgICAgICAgICAgZG8gewog ICAgICAgICAgICAgICAgICAgICBhdXRvIGRlY2lzaW9uID0gc2NoZWR1bGVyLmN1cnJlbnREZWNp c2lvbigpOwogICAgICAgICAgICAgICAgICAgICBpZiAoZGVjaXNpb24uc2hvdWxkQmVSZXN1bWVk KCkpIHsKLSAgICAgICAgICAgICAgICAgICAgICAgIFJlc3VtZVRoZVdvcmxkU2NvcGUgcmVzdW1l VGhlV29ybGRTY29wZSgqdGhpcyk7Ci0gICAgICAgICAgICAgICAgICAgICAgICBkcmFpblJlc3Vs dCA9IG1fY29sbGVjdG9yU2xvdFZpc2l0b3ItPmRyYWluSW5QYXJhbGxlbFBhc3NpdmVseShkZWNp c2lvbi50aW1lVG9TdG9wKCkpOwotICAgICAgICAgICAgICAgICAgICAgICAgaWYgKGRyYWluUmVz dWx0ID09IFNsb3RWaXNpdG9yOjpTaGFyZWREcmFpblJlc3VsdDo6RG9uZSkgewotICAgICAgICAg ICAgICAgICAgICAgICAgICAgIC8vIEF0IHRoaXMgcG9pbnQgd2Ugd2lsbCBzdG9wLiBCdXQgbWF5 YmUgdGhlIHNjaGVkdWxlciBkb2VzIG5vdCB3YW50Ci0gICAgICAgICAgICAgICAgICAgICAgICAg ICAgLy8gdGhhdC4KLSAgICAgICAgICAgICAgICAgICAgICAgICAgICBTZWNvbmRzIHNjaGVkdWxl ZElkbGUgPSBkZWNpc2lvbi50aW1lVG9TdG9wKCkgLSBNb25vdG9uaWNUaW1lOjpub3coKTsKLSAg ICAgICAgICAgICAgICAgICAgICAgICAgICAvLyBJdCdzIHRvdGFsbHkgdW5jbGVhciB3aGF0IHRo ZSB2YWx1ZSBvZiBjb2xsZWN0UGVybWl0dGVkSWRsZVJhdGlvCi0gICAgICAgICAgICAgICAgICAg ICAgICAgICAgLy8gc2hvdWxkIGJlLCBvdGhlciB0aGFuIGl0IHNob3VsZCBiZSBncmVhdGVyIHRo YW4gMC4gWW91IGNvdWxkIGV2ZW4KLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAvLyBhcmd1 ZSBmb3IgaXQgYmVpbmcgZ3JlYXRlciB0aGFuIDEuIFdlIHNob3VsZCB0dW5lIGl0LgotICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHNsZWVwKHNjaGVkdWxlZElkbGUgKiBPcHRpb25zOjpjb2xs ZWN0b3JQZXJtaXR0ZWRJZGxlUmF0aW8oKSk7CisgICAgICAgICAgICAgICAgICAgICAgICB7Cisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgUmVzdW1lVGhlV29ybGRTY29wZSByZXN1bWVUaGVX b3JsZFNjb3BlKCp0aGlzKTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICBkcmFpblJlc3Vs dCA9IG1fY29sbGVjdG9yU2xvdFZpc2l0b3ItPmRyYWluSW5QYXJhbGxlbFBhc3NpdmVseShkZWNp c2lvbi50aW1lVG9TdG9wKCkpOworICAgICAgICAgICAgICAgICAgICAgICAgICAgIGlmIChkcmFp blJlc3VsdCA9PSBTbG90VmlzaXRvcjo6U2hhcmVkRHJhaW5SZXN1bHQ6OkRvbmUpIHsKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgLy8gQXQgdGhpcyBwb2ludCB3ZSB3aWxsIHN0b3Au IEJ1dCBtYXliZSB0aGUgc2NoZWR1bGVyIGRvZXMgbm90IHdhbnQKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgLy8gdGhhdC4KKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg U2Vjb25kcyBzY2hlZHVsZWRJZGxlID0gZGVjaXNpb24udGltZVRvU3RvcCgpIC0gTW9ub3Rvbmlj VGltZTo6bm93KCk7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIC8vIEl0J3MgdG90 YWxseSB1bmNsZWFyIHdoYXQgdGhlIHZhbHVlIG9mIGNvbGxlY3RQZXJtaXR0ZWRJZGxlUmF0aW8K KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLy8gc2hvdWxkIGJlLCBvdGhlciB0aGFu IGl0IHNob3VsZCBiZSBncmVhdGVyIHRoYW4gMC4gWW91IGNvdWxkIGV2ZW4KKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgLy8gYXJndWUgZm9yIGl0IGJlaW5nIGdyZWF0ZXIgdGhhbiAx LiBXZSBzaG91bGQgdHVuZSBpdC4KKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc2xl ZXAoc2NoZWR1bGVkSWRsZSAqIE9wdGlvbnM6OmNvbGxlY3RvclBlcm1pdHRlZElkbGVSYXRpbygp KTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICAgICAgICAgICAg ICB9CisgICAgICAgICAgICAgICAgICAgICAgICBpZiAoT3B0aW9uczo6bG9nR0MoKSkgeworICAg ICAgICAgICAgICAgICAgICAgICAgICAgIFNlY29uZHMgd2FrZVVwTGF0ZW5jeSA9IE1vbm90b25p Y1RpbWU6Om5vdygpIC0gZGVjaXNpb24udGltZVRvU3RvcCgpOworICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGlmICh3YWtlVXBMYXRlbmN5ID49IDFfbXMpCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGRhdGFMb2coInd1bCE9Iiwgd2FrZVVwTGF0ZW5jeS5taWxsaXNlY29uZHMo KSwgIiBtcyAiKTsKICAgICAgICAgICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICAg ICAgfSBlbHNlCiAgICAgICAgICAgICAgICAgICAgICAgICBkcmFpblJlc3VsdCA9IG1fY29sbGVj dG9yU2xvdFZpc2l0b3ItPmRyYWluSW5QYXJhbGxlbChkZWNpc2lvbi50aW1lVG9SZXN1bWUoKSk7 CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9TbG90VmlzaXRvci5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvU2xvdFZpc2l0b3IuY3BwCShyZXZp c2lvbiAyMDk4MTMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9TbG90VmlzaXRvci5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTU3MiwxMyArNTcyLDE5IEBAIFNsb3RWaXNpdG9yOjpTaGFy ZWREcmFpblJlc3VsdCBTbG90VmlzaXQKICAgICAKICAgICBBU1NFUlQoT3B0aW9uczo6bnVtYmVy T2ZHQ01hcmtlcnMoKSk7CiAgICAgCi0gICAgaWYgKCFtX2hlYXAuaGFzSGVhcEFjY2VzcygpIHx8 IG1faGVhcC5jb2xsZWN0b3JCZWxpZXZlc1RoYXRUaGVXb3JsZElzU3RvcHBlZCgpKSB7CisgICAg aWYgKE9wdGlvbnM6Om51bWJlck9mR0NNYXJrZXJzKCkgPCA0CisgICAgICAgIHx8ICFtX2hlYXAu aGFzSGVhcEFjY2VzcygpCisgICAgICAgIHx8IG1faGVhcC5jb2xsZWN0b3JCZWxpZXZlc1RoYXRU aGVXb3JsZElzU3RvcHBlZCgpKSB7CiAgICAgICAgIC8vIFRoaXMgaXMgYW4gb3B0aW1pemF0aW9u IG92ZXIgZHJhaW5JblBhcmFsbGVsKCkgd2hlbiB3ZSBoYXZlIGEgY29uY3VycmVudCBtdXRhdG9y IGJ1dAogICAgICAgICAvLyBvdGhlcndpc2UgaXQgaXMgbm90IHByb2ZpdGFibGUuCiAgICAgICAg IHJldHVybiBkcmFpbkluUGFyYWxsZWwodGltZW91dCk7CiAgICAgfQotICAgIAorCiAgICAgTG9j a0hvbGRlciBsb2NrZXIobV9oZWFwLm1fbWFya2luZ011dGV4KTsKKyAgICBtX2NvbGxlY3RvclN0 YWNrLnRyYW5zZmVyVG8oKm1faGVhcC5tX3NoYXJlZENvbGxlY3Rvck1hcmtTdGFjayk7CisgICAg bV9tdXRhdG9yU3RhY2sudHJhbnNmZXJUbygqbV9oZWFwLm1fc2hhcmVkTXV0YXRvck1hcmtTdGFj ayk7CisgICAgbV9oZWFwLm1fbWFya2luZ0NvbmRpdGlvblZhcmlhYmxlLm5vdGlmeUFsbCgpOwor ICAgIAogICAgIGZvciAoOzspIHsKICAgICAgICAgaWYgKGhhc0VsYXBzZWQodGltZW91dCkpCiAg ICAgICAgICAgICByZXR1cm4gU2hhcmVkRHJhaW5SZXN1bHQ6OlRpbWVkT3V0OwpJbmRleDogU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT3B0aW9ucy5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT3B0aW9ucy5jcHAJKHJldmlzaW9uIDIwOTgxMykK KysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL09wdGlvbnMuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0zMDYsNiArMzA2LDE1IEBAIHN0YXRpYyB2b2lkIHNjYWxlSklUUG9saWN5KCkKICAg ICB9CiB9CiAKK3N0YXRpYyB2b2lkIG92ZXJyaWRlRGVmYXVsdHMoKQoreworICAgIGlmIChXVEY6 Om51bWJlck9mUHJvY2Vzc29yQ29yZXMoKSA8IDQpIHsKKyAgICAgICAgT3B0aW9uczo6bWF4aW11 bU11dGF0b3JVdGlsaXphdGlvbigpID0gMC42OworICAgICAgICBPcHRpb25zOjpjb25jdXJyZW50 R0NNYXhIZWFkcm9vbSgpID0gMS40OworICAgICAgICBPcHRpb25zOjpjb25jdXJyZW50R0NQZXJp b2RNUygpID0gMTA7CisgICAgfQorfQorCiBzdGF0aWMgdm9pZCByZWNvbXB1dGVEZXBlbmRlbnRP cHRpb25zKCkKIHsKICNpZiAhZGVmaW5lZChOREVCVUcpCkBAIC00MzUsNiArNDQ0LDggQEAgdm9p ZCBPcHRpb25zOjppbml0aWFsaXplKCkKICAgICAgICAgICAgIG5hbWVfIyNEZWZhdWx0KCkgPSBk ZWZhdWx0VmFsdWVfOwogICAgICAgICAgICAgSlNDX09QVElPTlMoRk9SX0VBQ0hfT1BUSU9OKQog I3VuZGVmIEZPUl9FQUNIX09QVElPTgorCisgICAgICAgICAgICBvdmVycmlkZURlZmF1bHRzKCk7 CiAgICAgICAgICAgICAgICAgCiAgICAgICAgICAgICAvLyBBbGxvdyBlbnZpcm9ubWVudCB2YXJz IHRvIG92ZXJyaWRlIG9wdGlvbnMgaWYgYXBwbGljYWJsZS4KICAgICAgICAgICAgIC8vIFRoZSBl dm4gdmFyIHNob3VsZCBiZSB0aGUgbmFtZSBvZiB0aGUgb3B0aW9uIHByZWZpeGVkIHdpdGgK