165851 2016-12-14 08:38:35 -0800 Update ModuleLoader code by using the latest builtin primitives 2016-12-14 18:24:35 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ysuzuki ysuzuki commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1259739 0 ysuzuki 2016-12-14 08:38:35 -0800 Update ModuleLoader code by using the latest builtin primitives 1259742 1 297092 ysuzuki 2016-12-14 08:41:10 -0800 Created attachment 297092 Patch 1259991 2 297092 ysuzuki 2016-12-14 17:59:38 -0800 Comment on attachment 297092 Patch Thanks! 1260001 3 297092 commit-queue 2016-12-14 18:24:31 -0800 Comment on attachment 297092 Patch Clearing flags on attachment: 297092 Committed r209848: <http://trac.webkit.org/changeset/209848> 1260002 4 commit-queue 2016-12-14 18:24:35 -0800 All reviewed patches have been landed. Closing bug. 297092 2016-12-14 08:41:10 -0800 2016-12-14 18:24:31 -0800 Patch bug-165851-20161215014019.patch text/plain 5512 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjA5ODAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy ZTY3MzBmY2E1OWEwZDIyMmZlMmM3MjczMGU3ZjczOTVjYzE3N2E5Li45NWYyNzZmYTZkZGNlOWUw OGU5MjI1YWY4NjRjMjEzOWEwN2E2MjczIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNiBAQAorMjAxNi0xMi0xNCAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBVcGRhdGUgTW9kdWxlTG9hZGVyIGNvZGUgYnkgdXNpbmcgdGhlIGxh dGVzdCBidWlsdGluIHByaW1pdGl2ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE2NTg1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFVwZGF0ZSB0aGUgbW9kdWxlIGxvYWRlciBjb2RlLAorCisgICAgICAg IDEuIFVzZSBAZ2xvYmFsUHJpdmF0ZSBmb3IgdGhlIHV0aWxpdGllcywgaW5zdGVhZCBvZiBzZXR0 aW5nIHRoZW0gYXMgdGhlIG1lbWJlciBvZiBNb2R1bGVMb2FkZXIuCisgICAgICAgIDIuIFVzZSBA cHV0QnlWYWxEaXJlY3QgaW5zdGVhZCBvZiBAcHVzaC4gQHB1c2ggaXMgdXNlci1vYnNlcnZhYmxl IHNpbmNlIGl0IHVzZXMgU2V0KCkgb3BlcmF0aW9uCisgICAgICAgICAgIGFuZCBpdCBjYW4gYmUg b2JzZXJ2ZWQgYnkgZGVmaW5pbmcgaW5kZXhlZCBzZXR0ZXJzIGluIEFycmF5LnByb3RvdHlwZS4K KworICAgICAgICAqIGJ1aWx0aW5zL01vZHVsZUxvYWRlclByb3RvdHlwZS5qczoKKyAgICAgICAg KGVuc3VyZVJlZ2lzdGVyZWQpOgorICAgICAgICAoZnVsZmlsbEZldGNoKToKKyAgICAgICAgKGNv bW1pdEluc3RhbnRpYXRlZCk6CisgICAgICAgIChyZXF1ZXN0RmV0Y2gpOgorICAgICAgICAocmVx dWVzdFNhdGlzZnkpOgorICAgICAgICAoc2V0U3RhdGVUb01heCk6IERlbGV0ZWQuCisgICAgICAg IChuZXdSZWdpc3RyeUVudHJ5KTogRGVsZXRlZC4KKyAgICAgICAgKiBydW50aW1lL01vZHVsZUxv YWRlclByb3RvdHlwZS5jcHA6CisKIDIwMTYtMTItMTMgIFl1c3VrZSBTdXp1a2kgIDx1dGF0YW5l LnRlYUBnbWFpbC5jb20+CiAKICAgICAgICAgVXNlIEpTVmFsdWU6OnRvV1RGU3RyaW5nIGluc3Rl YWQgb2YgY2FsbGluZyB0b1N0cmluZyhleGVjKSBhbmQgdmFsdWUoZXhlYykKZGlmZiAtLWdpdCBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9idWlsdGlucy9Nb2R1bGVMb2FkZXJQcm90b3R5cGUuanMg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnVpbHRpbnMvTW9kdWxlTG9hZGVyUHJvdG90eXBlLmpz CmluZGV4IDZkZjQyNmY5NjM1NmMwZjUzZjMyODE5ZTJjZWNmN2NjNzQzNjVhODkuLjAxYzJiMjEx ZTc3NDQwN2RjYWZmMmQxN2ZmMzNjNGE0NWY0N2EyNGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9idWlsdGlucy9Nb2R1bGVMb2FkZXJQcm90b3R5cGUuanMKKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2J1aWx0aW5zL01vZHVsZUxvYWRlclByb3RvdHlwZS5qcwpAQCAtMzIs NiArMzIsNyBAQAogLy8gICAgMi4gTG9hZGVyLmZldGNoCiAvLyAgICAzLiBMb2FkZXIuaW5zdGFu dGlhdGUKIAorQGdsb2JhbFByaXZhdGUKIGZ1bmN0aW9uIHNldFN0YXRlVG9NYXgoZW50cnksIG5l d1N0YXRlKQogewogICAgIC8vIGh0dHBzOi8vd2hhdHdnLmdpdGh1Yi5pby9sb2FkZXIvI3NldC1z dGF0ZS10by1tYXgKQEAgLTQyLDYgKzQzLDcgQEAgZnVuY3Rpb24gc2V0U3RhdGVUb01heChlbnRy eSwgbmV3U3RhdGUpCiAgICAgICAgIGVudHJ5LnN0YXRlID0gbmV3U3RhdGU7CiB9CiAKK0BnbG9i YWxQcml2YXRlCiBmdW5jdGlvbiBuZXdSZWdpc3RyeUVudHJ5KGtleSkKIHsKICAgICAvLyBodHRw czovL3doYXR3Zy5naXRodWIuaW8vbG9hZGVyLyNyZWdpc3RyeQpAQCAtMTExLDcgKzExMyw3IEBA IGZ1bmN0aW9uIGVuc3VyZVJlZ2lzdGVyZWQoa2V5KQogICAgIGlmIChlbnRyeSkKICAgICAgICAg cmV0dXJuIGVudHJ5OwogCi0gICAgZW50cnkgPSB0aGlzLm5ld1JlZ2lzdHJ5RW50cnkoa2V5KTsK KyAgICBlbnRyeSA9IEBuZXdSZWdpc3RyeUVudHJ5KGtleSk7CiAgICAgdGhpcy5yZWdpc3RyeS5A c2V0KGtleSwgZW50cnkpOwogCiAgICAgcmV0dXJuIGVudHJ5OwpAQCAtMTM0LDcgKzEzNiw3IEBA IGZ1bmN0aW9uIGZ1bGZpbGxGZXRjaChlbnRyeSwgcGF5bG9hZCkKICAgICBpZiAoIWVudHJ5LmZl dGNoKQogICAgICAgICBlbnRyeS5mZXRjaCA9IEBuZXdQcm9taXNlQ2FwYWJpbGl0eShASW50ZXJu YWxQcm9taXNlKS5AcHJvbWlzZTsKICAgICB0aGlzLmZvcmNlRnVsZmlsbFByb21pc2UoZW50cnku ZmV0Y2gsIHBheWxvYWQpOwotICAgIHRoaXMuc2V0U3RhdGVUb01heChlbnRyeSwgQE1vZHVsZUlu c3RhbnRpYXRlKTsKKyAgICBAc2V0U3RhdGVUb01heChlbnRyeSwgQE1vZHVsZUluc3RhbnRpYXRl KTsKIH0KIAogZnVuY3Rpb24gZnVsZmlsbEluc3RhbnRpYXRlKGVudHJ5LCBvcHRpb25hbEluc3Rh bmNlLCBzb3VyY2UpCkBAIC0xODAsMTMgKzE4MiwxMyBAQCBmdW5jdGlvbiBjb21taXRJbnN0YW50 aWF0ZWQoZW50cnksIG9wdGlvbmFsSW5zdGFuY2UsIHNvdXJjZSkKICAgICAgICAgICAgIGtleTog ZGVwS2V5LAogICAgICAgICAgICAgdmFsdWU6IEB1bmRlZmluZWQKICAgICAgICAgfTsKLSAgICAg ICAgZGVwZW5kZW5jaWVzLkBwdXNoKHBhaXIpOworICAgICAgICBAcHV0QnlWYWxEaXJlY3QoZGVw ZW5kZW5jaWVzLCBkZXBlbmRlbmNpZXMubGVuZ3RoLCBwYWlyKTsKICAgICAgICAgZGVwZW5kZW5j aWVzTWFwLkBzZXQoZGVwS2V5LCBwYWlyKTsKICAgICB9CiAgICAgZW50cnkuZGVwZW5kZW5jaWVz ID0gZGVwZW5kZW5jaWVzOwogICAgIGVudHJ5LmRlcGVuZGVuY2llc01hcCA9IGRlcGVuZGVuY2ll c01hcDsKICAgICBlbnRyeS5tb2R1bGUgPSBtb2R1bGVSZWNvcmQ7Ci0gICAgdGhpcy5zZXRTdGF0 ZVRvTWF4KGVudHJ5LCBATW9kdWxlU2F0aXNmeSk7CisgICAgQHNldFN0YXRlVG9NYXgoZW50cnks IEBNb2R1bGVTYXRpc2Z5KTsKIH0KIAogZnVuY3Rpb24gaW5zdGFudGlhdGlvbihyZXN1bHQsIHNv dXJjZSwgZW50cnkpCkBAIC0yMTksNyArMjIxLDcgQEAgZnVuY3Rpb24gcmVxdWVzdEZldGNoKGtl eSwgaW5pdGlhdG9yKQogICAgIC8vICAgICBGb3IgZXhhbXBsZSwgSmF2YVNjcmlwdENvcmUgc2hl bGwgY2FuIHByb3ZpZGUgdGhlIGhvb2sgZmV0Y2hpbmcgdGhlIHJlc291cmNlCiAgICAgLy8gICAg IGZyb20gdGhlIGxvY2FsIGZpbGUgc3lzdGVtLgogICAgIHZhciBmZXRjaFByb21pc2UgPSB0aGlz LmZldGNoKGtleSwgaW5pdGlhdG9yKS50aGVuKChwYXlsb2FkKSA9PiB7Ci0gICAgICAgIHRoaXMu c2V0U3RhdGVUb01heChlbnRyeSwgQE1vZHVsZUluc3RhbnRpYXRlKTsKKyAgICAgICAgQHNldFN0 YXRlVG9NYXgoZW50cnksIEBNb2R1bGVJbnN0YW50aWF0ZSk7CiAgICAgICAgIHJldHVybiBwYXls b2FkOwogICAgIH0pOwogICAgIGVudHJ5LmZldGNoID0gZmV0Y2hQcm9taXNlOwpAQCAtMjk3LDEx ICsyOTksMTEgQEAgZnVuY3Rpb24gcmVxdWVzdFNhdGlzZnkoa2V5LCBpbml0aWF0b3IpCiAgICAg ICAgICAgICAgICAgICAgIHJldHVybiBlbnRyeTsKICAgICAgICAgICAgICAgICB9KTsKICAgICAg ICAgICAgIH0pOwotICAgICAgICAgICAgZGVwTG9hZHMuQHB1c2gocHJvbWlzZSk7CisgICAgICAg ICAgICBAcHV0QnlWYWxEaXJlY3QoZGVwTG9hZHMsIGRlcExvYWRzLmxlbmd0aCwgcHJvbWlzZSk7 CiAgICAgICAgIH0KIAogICAgICAgICByZXR1cm4gQEludGVybmFsUHJvbWlzZS5pbnRlcm5hbEFs bChkZXBMb2FkcykudGhlbigobW9kdWxlcykgPT4gewotICAgICAgICAgICAgdGhpcy5zZXRTdGF0 ZVRvTWF4KGVudHJ5LCBATW9kdWxlTGluayk7CisgICAgICAgICAgICBAc2V0U3RhdGVUb01heChl bnRyeSwgQE1vZHVsZUxpbmspOwogICAgICAgICAgICAgcmV0dXJuIGVudHJ5OwogICAgICAgICB9 KTsKICAgICB9KTsKQEAgLTM2Myw3ICszNjUsNyBAQCBmdW5jdGlvbiBsaW5rKGVudHJ5LCBpbml0 aWF0b3IpCiAKICAgICBpZiAoZW50cnkuc3RhdGUgPT09IEBNb2R1bGVSZWFkeSkKICAgICAgICAg cmV0dXJuOwotICAgIHRoaXMuc2V0U3RhdGVUb01heChlbnRyeSwgQE1vZHVsZVJlYWR5KTsKKyAg ICBAc2V0U3RhdGVUb01heChlbnRyeSwgQE1vZHVsZVJlYWR5KTsKIAogICAgIC8vIFNpbmNlIHdl IGFscmVhZHkgaGF2ZSB0aGUgImRlcGVuZGVuY2llcyIgZmllbGQsCiAgICAgLy8gd2UgY2FuIGNh bGwgbW9kdWxlRGVjbGFyYXRpb25JbnN0YW50aWF0aW9uIHdpdGggdGhlIGNvcnJlY3Qgb3JkZXIK ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL01vZHVsZUxvYWRlclBy b3RvdHlwZS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Nb2R1bGVMb2FkZXJQ cm90b3R5cGUuY3BwCmluZGV4IDNmY2NkYTc2NmFmYjU2ZGJhMDZkOWEyYjM0OGUzN2U0YzVkYzAy N2MuLmYzNmZkNDgyMTNhNDAxNmVmYzlmNjc1Yzk5ZWU4YWI1ZjllNDEzZWIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL01vZHVsZUxvYWRlclByb3RvdHlwZS5jcHAK KysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvTW9kdWxlTG9hZGVyUHJvdG90eXBl LmNwcApAQCAtNjUsOCArNjUsNiBAQCBjb25zdCBDbGFzc0luZm8gTW9kdWxlTG9hZGVyUHJvdG90 eXBlOjpzX2luZm8gPSB7ICJNb2R1bGVMb2FkZXIiLCAmQmFzZTo6c19pbmZvLAogCiAvKiBTb3Vy Y2UgZm9yIE1vZHVsZUxvYWRlclByb3RvdHlwZS5sdXQuaAogQGJlZ2luIG1vZHVsZUxvYWRlclBy b3RvdHlwZVRhYmxlCi0gICAgc2V0U3RhdGVUb01heCAgICAgICAgICAgICAgICAgIEpTQnVpbHRp biAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBEb250RW51bXxGdW5j dGlvbiAyCi0gICAgbmV3UmVnaXN0cnlFbnRyeSAgICAgICAgICAgICAgIEpTQnVpbHRpbiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBEb250RW51bXxGdW5jdGlvbiAx CiAgICAgZW5zdXJlUmVnaXN0ZXJlZCAgICAgICAgICAgICAgIEpTQnVpbHRpbiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBEb250RW51bXxGdW5jdGlvbiAxCiAgICAg Zm9yY2VGdWxmaWxsUHJvbWlzZSAgICAgICAgICAgIEpTQnVpbHRpbiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBEb250RW51bXxGdW5jdGlvbiAyCiAgICAgZnVsZmls bEZldGNoICAgICAgICAgICAgICAgICAgIEpTQnVpbHRpbiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBEb250RW51bXxGdW5jdGlvbiAyCg==