165845 2016-12-14 04:47:18 -0800 Make Style::Update const in RenderTreeUpdater 2016-12-14 08:47:41 -0800 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned commit-queue oldest_to_newest 1259701 0 koivisto 2016-12-14 04:47:18 -0800 Don't mutate it. 1259703 1 297083 koivisto 2016-12-14 04:58:52 -0800 Created attachment 297083 patch 1259721 2 297083 commit-queue 2016-12-14 08:07:25 -0800 Comment on attachment 297083 patch Clearing flags on attachment: 297083 Committed r209802: <http://trac.webkit.org/changeset/209802> 1259723 3 commit-queue 2016-12-14 08:07:29 -0800 All reviewed patches have been landed. Closing bug. 1259743 4 koivisto 2016-12-14 08:47:41 -0800 rdar://problem/27738108 297083 2016-12-14 04:58:52 -0800 2016-12-14 08:07:25 -0800 patch const-styleupdate.patch text/plain 5733 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwOTc5OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE2LTEyLTE0ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBNYWtlIFN0eWxlOjpVcGRhdGUg Y29uc3QgaW4gUmVuZGVyVHJlZVVwZGF0ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE2NTg0NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIE1vdmluZyBzdHlsZSBhd2F5IGZyb20gdW5pcXVlX3B0cnMgbGVh dmVzIHRoZW0gaW4gd2VpcmQgc3RhdGUuCisKKyAgICAgICAgKiBzdHlsZS9SZW5kZXJUcmVlVXBk YXRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpmaW5kUmVuZGVyaW5nUm9vdHMpOgorICAgICAg ICAoV2ViQ29yZTo6UmVuZGVyVHJlZVVwZGF0ZXI6OmNvbW1pdCk6CisgICAgICAgIChXZWJDb3Jl OjpSZW5kZXJUcmVlVXBkYXRlcjo6dXBkYXRlRWxlbWVudFJlbmRlcmVyKToKKworICAgICAgICAg ICAgQ2xvbmUgdGhlIHN0eWxlIGluc3RlYWQgb2YgbW92aW5nIGl0LiBUaGlzIGlzIG5vdCBtZWFu aW5nZnVsbHkgbW9yZSBleHBlbnNpdmUuCisgICAgICAgICAgICBSZW1vdmUgbnVsbCBjaGVja3Ms IHN0eWxlIGlzIG5ldmVyIG51bGwuCisKKyAgICAgICAgKiBzdHlsZS9SZW5kZXJUcmVlVXBkYXRl ci5oOgorCiAyMDE2LTEyLTE0ICBFbnJpcXVlIE9jYcOxYSBHb256w6FsZXogIDxlb2NhbmhhQGln YWxpYS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMjA3ODc5LTIwNzg5MSk6IFtHU3RyZWFt ZXJdIEludHJvZHVjZWQgbWFueSBsYXlvdXQgdGVzdCBmYWlsdXJlcyBhbmQgY3Jhc2hlcywgYm90 cyBleGl0aW5nIGVhcmx5CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9zdHlsZS9SZW5kZXJUcmVlVXBk YXRlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvc3R5bGUvUmVuZGVyVHJlZVVw ZGF0ZXIuY3BwCShyZXZpc2lvbiAyMDk3NTcpCisrKyBTb3VyY2UvV2ViQ29yZS9zdHlsZS9SZW5k ZXJUcmVlVXBkYXRlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTkzLDcgKzkzLDcgQEAgc3RhdGlj IENvbnRhaW5lck5vZGUqIGZpbmRSZW5kZXJpbmdSb290KAogICAgIHJldHVybiAmbm9kZS5kb2N1 bWVudCgpOwogfQogCi1zdGF0aWMgTGlzdEhhc2hTZXQ8Q29udGFpbmVyTm9kZSo+IGZpbmRSZW5k ZXJpbmdSb290cyhTdHlsZTo6VXBkYXRlJiB1cGRhdGUpCitzdGF0aWMgTGlzdEhhc2hTZXQ8Q29u dGFpbmVyTm9kZSo+IGZpbmRSZW5kZXJpbmdSb290cyhjb25zdCBTdHlsZTo6VXBkYXRlJiB1cGRh dGUpCiB7CiAgICAgTGlzdEhhc2hTZXQ8Q29udGFpbmVyTm9kZSo+IHJlbmRlcmluZ1Jvb3RzOwog ICAgIGZvciAoYXV0byogcm9vdCA6IHVwZGF0ZS5yb290cygpKSB7CkBAIC0xMDUsNyArMTA1LDcg QEAgc3RhdGljIExpc3RIYXNoU2V0PENvbnRhaW5lck5vZGUqPiBmaW5kUgogICAgIHJldHVybiBy ZW5kZXJpbmdSb290czsKIH0KIAotdm9pZCBSZW5kZXJUcmVlVXBkYXRlcjo6Y29tbWl0KHN0ZDo6 dW5pcXVlX3B0cjxTdHlsZTo6VXBkYXRlPiBzdHlsZVVwZGF0ZSkKK3ZvaWQgUmVuZGVyVHJlZVVw ZGF0ZXI6OmNvbW1pdChzdGQ6OnVuaXF1ZV9wdHI8Y29uc3QgU3R5bGU6OlVwZGF0ZT4gc3R5bGVV cGRhdGUpCiB7CiAgICAgQVNTRVJUKCZtX2RvY3VtZW50ID09ICZzdHlsZVVwZGF0ZS0+ZG9jdW1l bnQoKSk7CiAKQEAgLTI0Nyw3ICsyNDcsNyBAQCBzdGF0aWMgYm9vbCBwc2V1ZG9TdHlsZUNhY2hl SXNJbnZhbGlkKFJlCiAgICAgcmV0dXJuIGZhbHNlOwogfQogCi12b2lkIFJlbmRlclRyZWVVcGRh dGVyOjp1cGRhdGVFbGVtZW50UmVuZGVyZXIoRWxlbWVudCYgZWxlbWVudCwgU3R5bGU6OkVsZW1l bnRVcGRhdGUmIHVwZGF0ZSkKK3ZvaWQgUmVuZGVyVHJlZVVwZGF0ZXI6OnVwZGF0ZUVsZW1lbnRS ZW5kZXJlcihFbGVtZW50JiBlbGVtZW50LCBjb25zdCBTdHlsZTo6RWxlbWVudFVwZGF0ZSYgdXBk YXRlKQogewogI2lmIFBMQVRGT1JNKElPUykKICAgICBDaGVja0ZvclZpc2liaWxpdHlDaGFuZ2Ug Y2hlY2tGb3JWaXNpYmlsaXR5Q2hhbmdlKGVsZW1lbnQpOwpAQCAtMjU3LDE4ICsyNTcsMTggQEAg dm9pZCBSZW5kZXJUcmVlVXBkYXRlcjo6dXBkYXRlRWxlbWVudFJlbgogICAgIGlmIChzaG91bGRU ZWFyRG93blJlbmRlcmVycykKICAgICAgICAgdGVhckRvd25SZW5kZXJlcnMoZWxlbWVudCwgVGVh cmRvd25UeXBlOjpLZWVwSG92ZXJBbmRBY3RpdmUpOwogCi0gICAgYm9vbCBoYXNEaXNwbGF5Q29u dGVudHMgPSB1cGRhdGUuc3R5bGUgJiYgdXBkYXRlLnN0eWxlLT5kaXNwbGF5KCkgPT0gQ09OVEVO VFM7CisgICAgYm9vbCBoYXNEaXNwbGF5Q29udGVudHMgPSB1cGRhdGUuc3R5bGUtPmRpc3BsYXko KSA9PSBDT05URU5UUzsKICAgICBpZiAoaGFzRGlzcGxheUNvbnRlbnRzICE9IGVsZW1lbnQuaGFz RGlzcGxheUNvbnRlbnRzKCkpIHsKICAgICAgICAgZWxlbWVudC5zZXRIYXNEaXNwbGF5Q29udGVu dHMoaGFzRGlzcGxheUNvbnRlbnRzKTsKICAgICAgICAgLy8gUmVuZGVyIHRyZWUgcG9zaXRpb24g bmVlZHMgdG8gYmUgcmVjb21wdXRlZCBhcyByZW5kZXJpbmcgc2libGluZ3MgbWF5IGJlIGZvdW5k IGZyb20gdGhlIGRpc3BsYXk6Y29udGVudHMgc3VidHJlZS4KICAgICAgICAgcmVuZGVyVHJlZVBv c2l0aW9uKCkuaW52YWxpZGF0ZU5leHRTaWJsaW5nKCk7CiAgICAgfQogCi0gICAgYm9vbCBzaG91 bGRDcmVhdGVOZXdSZW5kZXJlciA9ICFlbGVtZW50LnJlbmRlcmVyKCkgJiYgdXBkYXRlLnN0eWxl ICYmICFoYXNEaXNwbGF5Q29udGVudHM7CisgICAgYm9vbCBzaG91bGRDcmVhdGVOZXdSZW5kZXJl ciA9ICFlbGVtZW50LnJlbmRlcmVyKCkgJiYgIWhhc0Rpc3BsYXlDb250ZW50czsKICAgICBpZiAo c2hvdWxkQ3JlYXRlTmV3UmVuZGVyZXIpIHsKICAgICAgICAgaWYgKGVsZW1lbnQuaGFzQ3VzdG9t U3R5bGVSZXNvbHZlQ2FsbGJhY2tzKCkpCiAgICAgICAgICAgICBlbGVtZW50LndpbGxBdHRhY2hS ZW5kZXJlcnMoKTsKLSAgICAgICAgY3JlYXRlUmVuZGVyZXIoZWxlbWVudCwgV1RGTW92ZSgqdXBk YXRlLnN0eWxlKSk7CisgICAgICAgIGNyZWF0ZVJlbmRlcmVyKGVsZW1lbnQsIFJlbmRlclN0eWxl OjpjbG9uZSgqdXBkYXRlLnN0eWxlKSk7CiAgICAgICAgIGludmFsaWRhdGVXaGl0ZXNwYWNlT25s eVRleHRTaWJsaW5nc0FmdGVyQXR0YWNoSWZOZWVkZWQoZWxlbWVudCk7CiAgICAgICAgIHJldHVy bjsKICAgICB9CkBAIC0yNzgsMTkgKzI3OCwxOSBAQCB2b2lkIFJlbmRlclRyZWVVcGRhdGVyOjp1 cGRhdGVFbGVtZW50UmVuCiAgICAgYXV0byYgcmVuZGVyZXIgPSAqZWxlbWVudC5yZW5kZXJlcigp OwogCiAgICAgaWYgKHVwZGF0ZS5yZWNvbXBvc2l0ZUxheWVyKSB7Ci0gICAgICAgIHJlbmRlcmVy LnNldFN0eWxlKFdURk1vdmUoKnVwZGF0ZS5zdHlsZSksIFN0eWxlRGlmZmVyZW5jZVJlY29tcG9z aXRlTGF5ZXIpOworICAgICAgICByZW5kZXJlci5zZXRTdHlsZShSZW5kZXJTdHlsZTo6Y2xvbmUo KnVwZGF0ZS5zdHlsZSksIFN0eWxlRGlmZmVyZW5jZVJlY29tcG9zaXRlTGF5ZXIpOwogICAgICAg ICByZXR1cm47CiAgICAgfQogCiAgICAgaWYgKHVwZGF0ZS5jaGFuZ2UgPT0gU3R5bGU6Ok5vQ2hh bmdlKSB7CiAgICAgICAgIGlmIChwc2V1ZG9TdHlsZUNhY2hlSXNJbnZhbGlkKCZyZW5kZXJlciwg dXBkYXRlLnN0eWxlLmdldCgpKSB8fCAocGFyZW50KCkuc3R5bGVDaGFuZ2UgPT0gU3R5bGU6OkZv cmNlICYmIHJlbmRlcmVyLnJlcXVpcmVzRm9yY2VkU3R5bGVSZWNhbGNQcm9wYWdhdGlvbigpKSkg ewotICAgICAgICAgICAgcmVuZGVyZXIuc2V0U3R5bGUoV1RGTW92ZSgqdXBkYXRlLnN0eWxlKSwg U3R5bGVEaWZmZXJlbmNlRXF1YWwpOworICAgICAgICAgICAgcmVuZGVyZXIuc2V0U3R5bGUoUmVu ZGVyU3R5bGU6OmNsb25lKCp1cGRhdGUuc3R5bGUpLCBTdHlsZURpZmZlcmVuY2VFcXVhbCk7CiAg ICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KICAgICAgICAgcmV0dXJuOwogICAgIH0KIAot ICAgIHJlbmRlcmVyLnNldFN0eWxlKFdURk1vdmUoKnVwZGF0ZS5zdHlsZSksIFN0eWxlRGlmZmVy ZW5jZUVxdWFsKTsKKyAgICByZW5kZXJlci5zZXRTdHlsZShSZW5kZXJTdHlsZTo6Y2xvbmUoKnVw ZGF0ZS5zdHlsZSksIFN0eWxlRGlmZmVyZW5jZUVxdWFsKTsKIH0KIAogI2lmIEVOQUJMRShDU1Nf UkVHSU9OUykKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3N0eWxlL1JlbmRlclRyZWVVcGRhdGVyLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvc3R5bGUvUmVuZGVyVHJlZVVwZGF0ZXIuaAko cmV2aXNpb24gMjA5NzU3KQorKysgU291cmNlL1dlYkNvcmUvc3R5bGUvUmVuZGVyVHJlZVVwZGF0 ZXIuaAkod29ya2luZyBjb3B5KQpAQCAtNDYsNyArNDYsNyBAQCBjbGFzcyBSZW5kZXJUcmVlVXBk YXRlciB7CiBwdWJsaWM6CiAgICAgUmVuZGVyVHJlZVVwZGF0ZXIoRG9jdW1lbnQmKTsKIAotICAg IHZvaWQgY29tbWl0KHN0ZDo6dW5pcXVlX3B0cjxTdHlsZTo6VXBkYXRlPik7CisgICAgdm9pZCBj b21taXQoc3RkOjp1bmlxdWVfcHRyPGNvbnN0IFN0eWxlOjpVcGRhdGU+KTsKIAogICAgIGVudW0g Y2xhc3MgVGVhcmRvd25UeXBlIHsgTm9ybWFsLCBLZWVwSG92ZXJBbmRBY3RpdmUgfTsKICAgICBz dGF0aWMgdm9pZCB0ZWFyRG93blJlbmRlcmVycyhFbGVtZW50JiwgVGVhcmRvd25UeXBlID0gVGVh cmRvd25UeXBlOjpOb3JtYWwpOwpAQCAtNTUsNyArNTUsNyBAQCBwdWJsaWM6CiBwcml2YXRlOgog ICAgIHZvaWQgdXBkYXRlUmVuZGVyVHJlZShDb250YWluZXJOb2RlJiByb290KTsKICAgICB2b2lk IHVwZGF0ZVRleHRSZW5kZXJlcihUZXh0Jik7Ci0gICAgdm9pZCB1cGRhdGVFbGVtZW50UmVuZGVy ZXIoRWxlbWVudCYsIFN0eWxlOjpFbGVtZW50VXBkYXRlJik7CisgICAgdm9pZCB1cGRhdGVFbGVt ZW50UmVuZGVyZXIoRWxlbWVudCYsIGNvbnN0IFN0eWxlOjpFbGVtZW50VXBkYXRlJik7CiAgICAg dm9pZCBjcmVhdGVSZW5kZXJlcihFbGVtZW50JiwgUmVuZGVyU3R5bGUmJik7CiAgICAgdm9pZCBp bnZhbGlkYXRlV2hpdGVzcGFjZU9ubHlUZXh0U2libGluZ3NBZnRlckF0dGFjaElmTmVlZGVkKE5v ZGUmKTsKICAgICB2b2lkIHVwZGF0ZUJlZm9yZU9yQWZ0ZXJQc2V1ZG9FbGVtZW50KEVsZW1lbnQm LCBQc2V1ZG9JZCk7CkBAIC03Niw3ICs3Niw3IEBAIHByaXZhdGU6CiAgICAgdm9pZCBwb3BQYXJl bnRzVG9EZXB0aCh1bnNpZ25lZCBkZXB0aCk7CiAKICAgICBEb2N1bWVudCYgbV9kb2N1bWVudDsK LSAgICBzdGQ6OnVuaXF1ZV9wdHI8U3R5bGU6OlVwZGF0ZT4gbV9zdHlsZVVwZGF0ZTsKKyAgICBz dGQ6OnVuaXF1ZV9wdHI8Y29uc3QgU3R5bGU6OlVwZGF0ZT4gbV9zdHlsZVVwZGF0ZTsKIAogICAg IFZlY3RvcjxQYXJlbnQ+IG1fcGFyZW50U3RhY2s7CiAK