165816 2016-12-13 12:21:29 -0800 Add a PerfTest targeting IDBObjectStore.get() 2016-12-13 12:51:51 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 160306 1 beidson beidson cdumez commit-queue dbates lforschler rniwa oldest_to_newest 1259491 0 beidson 2016-12-13 12:21:29 -0800 Add a PerfTest targeting IDBObjectStore.get() 1259492 1 297033 beidson 2016-12-13 12:22:14 -0800 Created attachment 297033 Patch 1259495 2 297033 dbates 2016-12-13 12:24:27 -0800 Comment on attachment 297033 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297033&action=review > PerformanceTests/IndexedDB/objectstore-get.html:41 > +function *runIteration() I'm surprised that star in front of runIterations does not cause a syntax error. 1259499 3 dbates 2016-12-13 12:27:09 -0800 (In reply to comment #2) > Comment on attachment 297033 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=297033&action=review > > > PerformanceTests/IndexedDB/objectstore-get.html:41 > > +function *runIteration() > > I'm surprised that star in front of runIterations does not cause a syntax > error. Disregard this remark. function* is the syntax to define a generator,<https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/function*> 1259507 4 297033 commit-queue 2016-12-13 12:42:16 -0800 Comment on attachment 297033 Patch Clearing flags on attachment: 297033 Committed r209772: <http://trac.webkit.org/changeset/209772> 1259508 5 commit-queue 2016-12-13 12:42:21 -0800 All reviewed patches have been landed. Closing bug. 1259512 6 beidson 2016-12-13 12:51:04 -0800 (In reply to comment #3) > (In reply to comment #2) > > Comment on attachment 297033 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=297033&action=review > > > > > PerformanceTests/IndexedDB/objectstore-get.html:41 > > > +function *runIteration() > > > > I'm surprised that star in front of runIterations does not cause a syntax > > error. > > Disregard this remark. function* is the syntax to define a > generator,<https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/ > Statements/function*> Yup - Because of how asynchronous IndexedDB is, we've fallen into the pattern of function generators to right linear tests for it. :) 1259513 7 beidson 2016-12-13 12:51:51 -0800 (In reply to comment #6) > (In reply to comment #3) > > (In reply to comment #2) > > > Comment on attachment 297033 [details] > > > Patch > > > > > > View in context: > > > https://bugs.webkit.org/attachment.cgi?id=297033&action=review > > > > > > > PerformanceTests/IndexedDB/objectstore-get.html:41 > > > > +function *runIteration() > > > > > > I'm surprised that star in front of runIterations does not cause a syntax > > > error. > > > > Disregard this remark. function* is the syntax to define a > > generator,<https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/ > > Statements/function*> > > Yup - Because of how asynchronous IndexedDB is, we've fallen into the > pattern of function generators to right linear tests for it. :) Wow. To say that again: Yup - Because of how asynchronous IndexedDB is, we've fallen into the pattern of *using* function generators to *write* linear tests for it. 297033 2016-12-13 12:22:14 -0800 2016-12-13 12:42:16 -0800 Patch bug-165816-20161213122125.patch text/plain 2909 beidson U3VidmVyc2lvbiBSZXZpc2lvbjogMjA5NzY4CmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCmluZGV4IGVlZjE4NzNjZTVi ZDI3N2QzMDA1MWY1N2FiMWViMTY0MjZhODgyNjUuLmJjYTNmZDI0ZTJlNjYxZmE5ZGFmODE2MDc4 MzhiNWYzNTJmODY2ZjUgMTAwNjQ0Ci0tLSBhL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCisr KyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQgQEAKIDIwMTYtMTIt MTMgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCisgICAgICAgIEFkZCBhIFBl cmZUZXN0IHRhcmdldGluZyBJREJPYmplY3RTdG9yZS5nZXQoKS4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NTgxNgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogSW5kZXhlZERCL29iamVjdHN0b3JlLWdl dC5odG1sOiBBZGRlZC4KKworMjAxNi0xMi0xMyAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBs ZS5jb20+CisKICAgICAgICAgQWRkIGEgUGVyZlRlc3QgdGFyZ2V0aW5nIElEQkluZGV4LmdldCgp LgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY1ODAz CiAKZGlmZiAtLWdpdCBhL1BlcmZvcm1hbmNlVGVzdHMvSW5kZXhlZERCL29iamVjdHN0b3JlLWdl dC5odG1sIGIvUGVyZm9ybWFuY2VUZXN0cy9JbmRleGVkREIvb2JqZWN0c3RvcmUtZ2V0Lmh0bWwK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMC4uNmE0YzhhYzIzMjcwMWFlMTIxNmJjN2MwYzI2ODgwZjY5NzY1NjMyMQotLS0g L2Rldi9udWxsCisrKyBiL1BlcmZvcm1hbmNlVGVzdHMvSW5kZXhlZERCL29iamVjdHN0b3JlLWdl dC5odG1sCkBAIC0wLDAgKzEsODEgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8Ym9keT4K KzxzY3JpcHQgc3JjPSIuLi9yZXNvdXJjZXMvcnVubmVyLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQ+ CisKKy8vIERlbGV0ZSBkYXRhYmFzZShzKSBmb3IgdGhlIHRlc3QgYWhlYWQgb2YgdGltZS4KK3Zh ciBkYXRhYmFzZU5hbWUgPSAib2JqZWN0c3RvcmUtZ2V0LURCIjsKK2luZGV4ZWREQi5kZWxldGVE YXRhYmFzZShkYXRhYmFzZU5hbWUpLm9uc3VjY2VzcyA9IGZ1bmN0aW9uKCkgeworICAgIHN0YXJ0 SXRlcmF0aW9uKCk7Cit9CisKK3ZhciB0ZXN0R2VuZXJhdG9yID0gbnVsbDsKK3ZhciBkYiA9IG51 bGw7Cit2YXIgdHJhbnNhY3Rpb24gPSBudWxsOworCitQZXJmVGVzdFJ1bm5lci5wcmVwYXJlVG9N ZWFzdXJlVmFsdWVzQXN5bmMoeworICAgIGN1c3RvbUl0ZXJhdGlvbkNvdW50OiAyMCwKKyAgICB1 bml0OiAnbXMnLAorICAgIGRvbmU6IGZ1bmN0aW9uICgpIHsKKyAgICAgICAgdHJhbnNhY3Rpb24g PSBudWxsOworICAgICAgICBkYiA9IG51bGw7CisgICAgICAgIHRlc3RHZW5lcmF0b3IgPSBudWxs OworICAgICAgICBQZXJmVGVzdFJ1bm5lci5nYygpOworICAgIH0KK30pOworCitmdW5jdGlvbiBz dGFydEl0ZXJhdGlvbigpCit7CisgICAgdGVzdEdlbmVyYXRvciA9IHJ1bkl0ZXJhdGlvbigpOwor ICAgIG5leHRTdGVwKCk7Cit9CisKK2Z1bmN0aW9uIG5leHRTdGVwKCkKK3sKKyAgICB0ZXN0R2Vu ZXJhdG9yLm5leHQoKTsKK30KKwordmFyIG51bWJlck9mRW50cmllcyA9IDUwMDA7CisKK2Z1bmN0 aW9uICpydW5JdGVyYXRpb24oKQoreworICAgIHZhciBvcGVuUmVxdWVzdCA9IGluZGV4ZWREQi5v cGVuKGRhdGFiYXNlTmFtZSk7CisgICAgb3BlblJlcXVlc3Qub251cGdyYWRlbmVlZGVkID0gZnVu Y3Rpb24oZXZlbnQpIHsKKyAgICAgICAgZGIgPSBldmVudC50YXJnZXQucmVzdWx0OworICAgICAg ICB2YXIgb2JqZWN0U3RvcmUgPSBkYi5jcmVhdGVPYmplY3RTdG9yZSgnc3RvcmUnKTsKKyAgICAg ICAgZm9yICh2YXIgaSA9IDA7IGkgPCBudW1iZXJPZkVudHJpZXM7ICsraSkKKyAgICAgICAgICAg b2JqZWN0U3RvcmUucHV0KCJpbmRleCIgKyBpLCBpKTsKKyAgICB9CisgICAgb3BlblJlcXVlc3Qu b25zdWNjZXNzID0gbmV4dFN0ZXA7CisKKyAgICB5aWVsZDsKKworICAgIHZhciBzdGFydFRpbWUg PSBQZXJmVGVzdFJ1bm5lci5ub3coKTsKKworICAgIHZhciBvYmplY3RTdG9yZSA9IGRiLnRyYW5z YWN0aW9uKCdzdG9yZScpLm9iamVjdFN0b3JlKCdzdG9yZScpOworICAgIHZhciBjb21wbGV0ZWRH ZXRzID0gMDsKKyAgICBmb3IgKHZhciBpID0gMDsgaSA8IG51bWJlck9mRW50cmllczsgKytpKQor ICAgIHsKKyAgICAgICAgCisgICAgICAgIG9iamVjdFN0b3JlLmdldChpKS5vbnN1Y2Nlc3MgPSAo ZnVuY3Rpb24gKGopIHsKKyAgICAgICAgICAgIHJldHVybiBmdW5jdGlvbihldmVudCkgeworICAg ICAgICAgICAgICAgIGlmIChldmVudC50YXJnZXQucmVzdWx0ICE9ICgiaW5kZXgiICsgaikpCisg ICAgICAgICAgICAgICAgICAgIGFsZXJ0KCJFeHBlY3RlZCAnaW5kZXgiICsgaiArICInLCBnb3Qg JyIgKyBldmVudC50YXJnZXQucmVzdWx0ICsgIiciKTsKKworICAgICAgICAgICAgICAgIGlmICgr K2NvbXBsZXRlZEdldHMgPT0gbnVtYmVyT2ZFbnRyaWVzKQorICAgICAgICAgICAgICAgICAgICBu ZXh0U3RlcCgpOworICAgICAgICAgICAgfQorICAgICAgICB9KShpKTsKKyAgICB9CisKKyAgICB5 aWVsZDsKKworICAgIGlmICghUGVyZlRlc3RSdW5uZXIubWVhc3VyZVZhbHVlQXN5bmMoUGVyZlRl c3RSdW5uZXIubm93KCkgLSBzdGFydFRpbWUpKQorICAgICAgICByZXR1cm47CisKKyAgICBzZXRU aW1lb3V0KHN0YXJ0SXRlcmF0aW9uLCAwKTsKK30KKzwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1s Pgo=